May 2019 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: nfs_ip_name cache: Larger hostname buffer and other fixes
by Frank Filz (GerritHub) 17 May '19

17 May '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454939 Change subject: nfs_ip_name cache: Larger hostname buffer and other fixes ...................................................................... nfs_ip_name cache: Larger hostname buffer and other fixes getnameinfo specifies using NI_MAXHOST as the size that should be used for the hostname buffer. Just use the caller's buffer to getnameinfo into to save a copy. Make the hostname dynamic sized in nfs_ip_name_t Even if there is a hash error, we still resolved the ipaddress into a hostname or didn't and are going to just use the ipaddress as the name, so no reason to fail to return what would have been cached to the caller. Make sure all the string copies are safe and report an error if the buffers are too small. Change-Id: I9f5daaf632026dce9882003260e43bd17ae5fc25 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/include/nfs_ip_stats.h M src/support/exports.c M src/support/nfs_ip_name.c 3 files changed, 66 insertions(+), 51 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/454939/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454939 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9f5daaf632026dce9882003260e43bd17ae5fc25 Gerrit-Change-Number: 454939 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: FSAL_MEM - Allow whence_is_name readdir
by Daniel Gryniewicz (GerritHub) 17 May '19

17 May '19

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454928 Change subject: FSAL_MEM - Allow whence_is_name readdir ...................................................................... FSAL_MEM - Allow whence_is_name readdir Change the index tree to use a hash of the name, rather than a sequential counter. This makes the dir order more like a real FS, and less likely to hide bugs. In addition, it allows a traversal order tied to the name. Add a global that allows setting whence_is_name for MEM. No other changes are necessary. This allows testing the MDCACHE whence_is_name code. Change-Id: Ic20fe9aa43316ecbf3eec4e1943354ac4efed21c Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/FSAL/FSAL_MEM/mem_handle.c M src/FSAL/FSAL_MEM/mem_int.h M src/FSAL/FSAL_MEM/mem_main.c 3 files changed, 97 insertions(+), 27 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/28/454928/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454928 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic20fe9aa43316ecbf3eec4e1943354ac4efed21c Gerrit-Change-Number: 454928 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

1 0

Crash in clnt_vc_destroy()
by Madhu P Punjabi 17 May '19

17 May '19

1 0

Change in ...nfs-ganesha[next]: Fix CUnit tests to build and run
by Daniel Gryniewicz (GerritHub) 16 May '19

16 May '19

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454808 Change subject: Fix CUnit tests to build and run ...................................................................... Fix CUnit tests to build and run Change-Id: I731a483dca47a8b1002734ea0127f5338b150c0c Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/CMakeLists.txt A src/cmake/modules/FindCUnit.cmake M src/test/CMakeLists.txt M src/test/test_avl.c M src/test/test_mh_avl.c 5 files changed, 103 insertions(+), 76 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/08/454808/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454808 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I731a483dca47a8b1002734ea0127f5338b150c0c Gerrit-Change-Number: 454808 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: ganeshactl: update maintainer address and add new maintainer
by Kaleb KEITHLEY (GerritHub) 16 May '19

16 May '19

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454790 Change subject: ganeshactl: update maintainer address and add new maintainer ...................................................................... ganeshactl: update maintainer address and add new maintainer Retain Jim Lieb as author (emeritus). Not that anyone ever looks at this stuff. Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> Change-Id: I0d8f587ccec2e77c0915d4f2f8a3c5434e3072b4 --- M src/scripts/ganeshactl/setup.py.in 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/90/454790/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454790 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0d8f587ccec2e77c0915d4f2f8a3c5434e3072b4 Gerrit-Change-Number: 454790 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: MDCACHE - Update chunk pointers when splitting a chunk
by Daniel Gryniewicz (GerritHub) 16 May '19

16 May '19

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454777 Change subject: MDCACHE - Update chunk pointers when splitting a chunk ...................................................................... MDCACHE - Update chunk pointers when splitting a chunk Change-Id: I5a17e2bb28105074dd07f3475e890a2b15fdfbb6 Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/77/454777/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454777 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5a17e2bb28105074dd07f3475e890a2b15fdfbb6 Gerrit-Change-Number: 454777 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

1 0

Crash in svc_release_it()
by Madhu P Punjabi 16 May '19

16 May '19

4 7

Change in ...nfs-ganesha[next]: fsal_open2 - check for non-regular file when open by name
by Frank Filz (GerritHub) 15 May '19

15 May '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454683 Change subject: fsal_open2 - check for non-regular file when open by name ...................................................................... fsal_open2 - check for non-regular file when open by name We need to make sure we don't accidentally open a non-regular file. This is an expansion of patch 8b8ffa7dd6fdbf88c190add24097fb2ca01274f6 to cover all FSALs and not just SYMLINK. Change-Id: I1a42a78951248086d8df06fbd31d42280a5e194f Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_GLUSTER/handle.c M src/FSAL/FSAL_GPFS/file.c M src/FSAL/FSAL_RGW/handle.c M src/FSAL/FSAL_VFS/file.c 5 files changed, 134 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/83/454683/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454683 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1a42a78951248086d8df06fbd31d42280a5e194f Gerrit-Change-Number: 454683 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

About 9P protocol and wait queue
by Sachin Punadikar 15 May '19

15 May '19

Hello All, With Ganesha 2.7 and later we have moved away from RPC wait queues. Wondering whether 9P protocol has any such queuing mechanism in Ganesha 2.7 and later? -- with regards, Sachin Punadikar

2 1

Change in ...nfs-ganesha[next]: Build: cleanup now-unused GANESHA_CORE variables and link mooshika
by Dominique Martinet (GerritHub) 15 May '19

15 May '19

Dominique Martinet has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454626 Change subject: Build: cleanup now-unused GANESHA_CORE variables and link mooshika ...................................................................... Build: cleanup now-unused GANESHA_CORE variables and link mooshika libmooshika was incorrectly added to the GANESHA_CORE variable, add it where it belongs and clean up the old code a bit. The "MOOSHIKA_LIBS_WITHOUT_RDMA" intermediate variable was required for specific setups where the rdma libs were installed in a non-standard directory that is different from mooshika's on older mooshika versions - these people can just upgrade even if ganesha itself does not required a newer mooshika. Change-Id: Ibd23bd1d53ef8ec46036398081fb44e14bf2c1e5 Signed-off-by: Dominique Martinet <dominique.martinet(a)cea.fr> --- M src/CMakeLists.txt M src/MainNFSD/CMakeLists.txt 2 files changed, 4 insertions(+), 55 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/26/454626/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454626 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ibd23bd1d53ef8ec46036398081fb44e14bf2c1e5 Gerrit-Change-Number: 454626 Gerrit-PatchSet: 1 Gerrit-Owner: Dominique Martinet <asmadeus(a)codewreck.org> Gerrit-MessageType: newchange

1 0