May 2019 - Devel - Nfs Ganesha List Archives

Change in ...nfs-ganesha[next]: Rework client_mgr to use rpc_tools.c/gsh_rpc.h and related cleanup

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/455458 Change subject: Rework client_mgr to use rpc_tools.c/gsh_rpc.h and related cleanup ...................................................................... Rework client_mgr to use rpc_tools.c/gsh_rpc.h and related cleanup Keep the full sockaddr_t in the gsh_client. Instead of dynamic separate hostaddr_str buffer, since it's only 128 bytes (and maybe could be shrunk to 64) just make it part of the structure. Change-Id: I7e0f2dfe50d2379b8b13c784c3aee85355fe5fe9 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_GPFS/fsal_internal.c M src/include/client_mgr.h M src/support/client_mgr.c 3 files changed, 31 insertions(+), 118 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/58/455458/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/455458 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7e0f2dfe50d2379b8b13c784c3aee85355fe5fe9 Gerrit-Change-Number: 455458 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

4 years, 11 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: Add full support of AF_VSOCK to rpc_tools.c and gsh_rpc.h

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/455457 Change subject: Add full support of AF_VSOCK to rpc_tools.c and gsh_rpc.h ...................................................................... Add full support of AF_VSOCK to rpc_tools.c and gsh_rpc.h Change-Id: I87ac8f3856a84073b9d7213f01d2c47d3eb3324e Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/RPCAL/rpc_tools.c M src/include/gsh_rpc.h 2 files changed, 65 insertions(+), 22 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/57/455457/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/455457 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I87ac8f3856a84073b9d7213f01d2c47d3eb3324e Gerrit-Change-Number: 455457 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

4 years, 11 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: Clean up rpc_tools.c including fixingup sprint_sockip etc.

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/455444 Change subject: Clean up rpc_tools.c including fixingup sprint_sockip etc. ...................................................................... Clean up rpc_tools.c including fixingup sprint_sockip etc. Eliminate sprint_sockaddr and have callers directly call display_sockaddr. sprint_sockip is ONLY called for AF_INET and AF_INET6 (and maybe VSOCK in the future) so we can be a little simpler. Make sure all callers of sprint_sockip are ok with possible failure. Call display_sockaddr instead of sprint_sockip if the use really is just for logging. Change-Id: I08278ba0230f79936094c01cd1414db13290b94b Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_GLUSTER/mds.c M src/FSAL/FSAL_PROXY/handle.c M src/MainNFSD/9p_dispatcher.c M src/MainNFSD/nfs_rpc_callback.c M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/RPCAL/nfs_dupreq.c M src/RPCAL/rpc_tools.c M src/SAL/nfs4_recovery.c M src/include/gsh_rpc.h M src/include/sal_data.h M src/support/client_mgr.c M src/support/exports.c M src/support/nfs_ip_name.c 13 files changed, 106 insertions(+), 227 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/44/455444/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/455444 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I08278ba0230f79936094c01cd1414db13290b94b Gerrit-Change-Number: 455444 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

4 years, 11 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: [FSAL_VFS] Reduce the number of opens done for referral directories

by Sriram Patil (GerritHub)

Sriram Patil has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/455431 Change subject: [FSAL_VFS] Reduce the number of opens done for referral directories ...................................................................... [FSAL_VFS] Reduce the number of opens done for referral directories In the referral code path the directory is opened multiple times. First in getattr, second while getting fs locations and third when reading the xattr. The same fd can be passed around and closed at the end, so that the directory is opened only once. Change-Id: I4f62e69e4574ad9f1d072d3ce2cb46d2d31fe3d9 Signed-off-by: Sriram Patil <sriramp(a)vmware.com> --- M src/FSAL/FSAL_VFS/subfsal_helpers.c M src/FSAL/FSAL_VFS/vfs/attrs.c M src/FSAL/FSAL_VFS/vfs_methods.h M src/FSAL/FSAL_VFS/xattrs.c 4 files changed, 94 insertions(+), 53 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/31/455431/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/455431 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4f62e69e4574ad9f1d072d3ce2cb46d2d31fe3d9 Gerrit-Change-Number: 455431 Gerrit-PatchSet: 1 Gerrit-Owner: Sriram Patil <sriramp(a)vmware.com> Gerrit-MessageType: newchange

4 years, 11 months

1
0
0 / 0

V2.7 backports Google doc

by Frank Filz

Folks, I finally got around to doing my Google Doc for backports to V2.7. https://docs.google.com/document/d/16AlBZbKyFysydq5qxnLpRhQJ4nSO8pFu56DDFfsR oM4/edit?usp=sharing Please look over the patches that haven't been backported yet and let us know what you would like backported. If you want to make comments or edits and you don't have access to do so, you can request access via Google Docs. Thanks Frank

4 years, 11 months

1
0
0 / 0

Ganesha exited after logging FATAL trace in release_openstate()

by Madhu P Punjabi

4 years, 11 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: pnfs: fix coverity use-after-free in pnfs_ds_remove()

by Kaleb KEITHLEY (GerritHub)

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/455256 Change subject: pnfs: fix coverity use-after-free in pnfs_ds_remove() ...................................................................... pnfs: fix coverity use-after-free in pnfs_ds_remove() error: https://download.nfs-ganesha.org/coverity/kaleb1/1/145ds.c.html#error before: https://download.nfs-ganesha.org/coverity/2019-05-18-86de5d67/ after: https://download.nfs-ganesha.org/coverity/kaleb2/ All calls to pnfs_ds_remove() pass final=true and `pnfs_ds_put(pds)` here will free pds. It also calls fsal_pnfs_ds_fini() already, so the drop from FSAL comment and logic seems to be erroneous. Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> Change-Id: I6e4046419ecc6737e296a267faf734ab8e8d5a8b --- M src/include/pnfs_utils.h M src/support/ds.c M src/support/export_mgr.c M src/support/exports.c 4 files changed, 6 insertions(+), 13 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/56/455256/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/455256 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6e4046419ecc6737e296a267faf734ab8e8d5a8b Gerrit-Change-Number: 455256 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com> Gerrit-MessageType: newchange

4 years, 11 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: nfs4: fix coverity use-after-free in nfs4_op_create_session()

by Kaleb KEITHLEY (GerritHub)

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/455232 Change subject: nfs4: fix coverity use-after-free in nfs4_op_create_session() ...................................................................... nfs4: fix coverity use-after-free in nfs4_op_create_session() error: http://rhs-vm-10.storage-dev.lab.eng.bos.redhat.com/nfs-ganesha-coverity/... before: http://rhs-vm-10.storage-dev.lab.eng.bos.redhat.com/nfs-ganesha-coverity/... after: http://rhs-vm-10.storage-dev.lab.eng.bos.redhat.com/nfs-ganesha-coverity/... Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> Change-Id: I96a6a3aea9ed6729ee3fe3d16c55606bbd14f06c --- M src/Protocols/NFS/nfs4_op_create_session.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/32/455232/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/455232 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I96a6a3aea9ed6729ee3fe3d16c55606bbd14f06c Gerrit-Change-Number: 455232 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com> Gerrit-MessageType: newchange

4 years, 11 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: FSAL_GLUSTER: Include "enable_upcall" option in sample gluster.conf

by Soumya (GerritHub)

Soumya has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/455079 Change subject: FSAL_GLUSTER: Include "enable_upcall" option in sample gluster.conf ...................................................................... FSAL_GLUSTER: Include "enable_upcall" option in sample gluster.conf With upcall mechanism changed from polling to async callback notification in FSAL_GLUSER, UP_poll_usec option is no more used. Replace it with 'enable_upcall' option (to enable/disable upcall notifications from libgfapi) in sample gluster.conf. Change-Id: Ic765660bac8a84420f0825f9b4c253dc2ebd573f Signed-off-by: Soumya Koduri <skoduri(a)redhat.com> --- M src/config_samples/gluster.conf M src/libntirpc 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/79/455079/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/455079 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic765660bac8a84420f0825f9b4c253dc2ebd573f Gerrit-Change-Number: 455079 Gerrit-PatchSet: 1 Gerrit-Owner: Soumya <skoduri(a)redhat.com> Gerrit-MessageType: newchange

4 years, 11 months

1
0
0 / 0

Announce Push of V2.8-dev.31

by Frank Filz

Branch next Tag:V2.8-dev.31 Release Highlights * MEM - Set the parent pointer for a directory * FSAL_MEM - Allow whence_is_name readdir * MDCACHE - Update chunk pointers when splitting a chunk * MDCACHE - Add MDCACHE {} config block * Fix CUnit tests to build and run * A couple python fixes * Some build/pagacking type fixes Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 86de5d6 Frank S. Filz V2.8-dev.31 26ce775 Kaleb S. KEITHLEY build: use a version script for libganesha_nfsd.so 2115edd Kaleb S. KEITHLEY ganeshactl: update maintainer address and add new maintainer 0e4a719 Dominique Martinet Build: cleanup now-unused GANESHA_CORE variables and link mooshika 786a09b Malahal Naineni Fix gobject for python3 e570ec4 Malahal Naineni Don't mix tabs and spaces in python code 4f4d624 Daniel Gryniewicz MDCACHE - Add MDCACHE {} config block 458a2ae Daniel Gryniewicz FSAL_MEM - Allow whence_is_name readdir c7f6997 Daniel Gryniewicz Fix CUnit tests to build and run aa95864 Daniel Gryniewicz MDCACHE - Update chunk pointers when splitting a chunk 9623853 Daniel Gryniewicz MEM - Set the parent pointer for a directory

4 years, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

Devel May 2019