Change in ...nfs-ganesha[next]: rpm: require nfs-ganesha-selinux
by Ken Dreyer (GerritHub)
Ken Dreyer has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454361
Change subject: rpm: require nfs-ganesha-selinux
......................................................................
rpm: require nfs-ganesha-selinux
This eliminates the manual step for users to "yum install
nfs-ganesha-selinux" manually.
Change-Id: Ic1bf9b27d5d608aca97b0c9a2e51efd4060bdd90
Signed-off-by: Ken Dreyer <kdreyer(a)redhat.com>
---
M src/nfs-ganesha.spec-in.cmake
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/61/454361/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454361
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ic1bf9b27d5d608aca97b0c9a2e51efd4060bdd90
Gerrit-Change-Number: 454361
Gerrit-PatchSet: 1
Gerrit-Owner: Ken Dreyer <kdreyer(a)redhat.com>
Gerrit-MessageType: newchange
5 years, 7 months
Question: NFSv3 open files after create
by katcherw@gmail.com
I'm developing a proprietary FSAL in Ganesha 2.6.3. When using NFSv3, I see that nfs3_create calls open2, which presumably is supposed to create the file and open it. My question is when does the file get closed? I have a huge amount of open files in my FSAL and not sure how to close them. Even in VFS, I see that created files stay open.
Bill
5 years, 7 months
Change in ...nfs-ganesha[next]: Fix gobject for python3
by Malahal (GerritHub)
Malahal has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454337
Change subject: Fix gobject for python3
......................................................................
Fix gobject for python3
gobject module is not available in python3 env. Use GObject from
gi.repository packge if gobject import fails.
Change-Id: I37c89686a26f82bfd609f9f3b7e6abc9420dad76
Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com>
---
M src/scripts/ganeshactl/Ganesha/ganesha_mgr_utils.py
M src/scripts/ganeshactl/Ganesha/glib_dbus_stats.py
M src/scripts/ganeshactl/client_stats_9pOps.py
M src/scripts/ganeshactl/export_stats_9pOps.py
M src/scripts/ganeshactl/fake_recall.py
M src/scripts/ganeshactl/ganesha_stats.py
M src/scripts/ganeshactl/get_clientids.py
M src/scripts/ganeshactl/grace_period.py
8 files changed, 29 insertions(+), 8 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/37/454337/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454337
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I37c89686a26f82bfd609f9f3b7e6abc9420dad76
Gerrit-Change-Number: 454337
Gerrit-PatchSet: 1
Gerrit-Owner: Malahal <malahal(a)gmail.com>
Gerrit-MessageType: newchange
5 years, 7 months
Change in ...nfs-ganesha[next]: Don't mix tabs and spaces in python code
by Malahal (GerritHub)
Malahal has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454336
Change subject: Don't mix tabs and spaces in python code
......................................................................
Don't mix tabs and spaces in python code
Some forms of mixing seems to be fatal in python3. Changed all tabs to
appropriate number of spaces.
Change-Id: I5dcfe29ccd3787cf2805cbe3ddf65baad2ac2454
Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com>
---
M src/scripts/ganeshactl/Ganesha/glib_dbus_stats.py
M src/scripts/ganeshactl/client_stats_9pOps.py
M src/scripts/ganeshactl/export_stats_9pOps.py
M src/scripts/ganeshactl/ganesha_stats.py
M src/scripts/ganeshactl/grace_period.py
5 files changed, 152 insertions(+), 152 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/36/454336/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454336
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I5dcfe29ccd3787cf2805cbe3ddf65baad2ac2454
Gerrit-Change-Number: 454336
Gerrit-PatchSet: 1
Gerrit-Owner: Malahal <malahal(a)gmail.com>
Gerrit-MessageType: newchange
5 years, 7 months
Change in ...nfs-ganesha[next]: Fix RHEL8 build failure
by Malahal (GerritHub)
Malahal has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454135
Change subject: Fix RHEL8 build failure
......................................................................
Fix RHEL8 build failure
RHEL8 doesn't ship with /usr/bin/python. Our scripts currently work with
python2, so look for python2 rather than python. All distros will have
python2. Tried symlinking /usr/bin/python to /usr/bin/python2 on RHEL8,
the build went a bit far, but it didn't work either due to shebang issues!
Change-Id: I6ca7ac8584a36b3b21db4fb5c74a48908dfca09e
Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com>
---
M src/scripts/ganeshactl/CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/35/454135/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454135
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I6ca7ac8584a36b3b21db4fb5c74a48908dfca09e
Gerrit-Change-Number: 454135
Gerrit-PatchSet: 1
Gerrit-Owner: Malahal <malahal(a)gmail.com>
Gerrit-MessageType: newchange
5 years, 7 months
Announce Push of V2.8-dev.30
by Frank Filz
Branch next
Tag:V2.8-dev.30
Release Highlights
* [9P] _9p_lock doesn't process conflicts
* FSAL_CEPH: fix length calculation in reclaim_reset
* ganesha_mgr gets a new option to show mounted POSIX filesystems
* selinux: fix install errors
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
c9bfb05 Frank S. Filz V2.8-dev.30
6ceb77d Kaleb S. KEITHLEY selinux: fix install errors
686c311 Trishali Nayar ganesha_mgr gets a new option to show mounted POSIX
filesystems
505d2d0 Jeff Layton FSAL_CEPH: fix length calculation in reclaim_reset
2624256 Malahal Naineni [9P] _9p_lock doesn't process conflicts
5 years, 7 months
Use gss_wrap_iov and friends
by Frank Filz
Ok folks, I have working code:
Here is the ntirpc code:
https://github.com/nfs-ganesha/ntirpc/commits/gss
Here is a Ganesha pullup plus some reorg and debug in principle2uid:
https://github.com/ffilz/nfs-ganesha/commits/gss
I'd like a bit of review and maybe figure out how to do some more
significant testing before I submit a pull request.
For testing I have copied a large (90k) file, reading it from the server and
then writing the copy to the server using both krb5i and krb5p. I found a
couple issues after it was working due to the debug code I have in.
I may have overdone the debug for day to day use, so I will probably remove
some of it before finalizing the patches (like we probably don't need to
show the vectors at each step).
I did hit one issue that the cityhash checksum (that is used by dupreq) used
to be over the whole request, but if a krb5i request is in multiple buffers
we will only checksum the first buffer. This is comparable to what we do for
checksum when not doing krb5i or krb5p. Since krb5p still requires the whole
request to be in a single buffer, we still checksum the whole decrypted
request.
Jeff Layton pointed out that the Linux client never sends RPC fragments
which looks like that may be when we break a request into multiple buffers,
so we may in practice never see any differences.
Given the reality of requests perhaps always being in a single buffer we
should see the following benefits:
For gss_unwrap_iov, we save 1 data copy (extraction from the xdr_ioq) and
decryption is in place (may not save memory access cycles but does save on
memory allocation). If we DID see multiple buffers, we would still benefit
from the decrypt in place.
For gss_mic_verify_iov, we save 1 data copy (extraction from the xdr_ioq)
and verify is in place (may not save memory access cycles but does save on
memory allocation). If we DID see multiple buffers, we would save most or
all of the data copy (depending on if the MIC token is broken across buffers
or not), and we still do the verify in place.
For gss_wrap_iov, we save 2 data copies (extraction of the data into a
single buffer, copying the data back into the xdr stream) and encrypt in
place (may not save memory access cycles but does save on memory
allocation).
For gss_get_mic_iov, we save 2 data copies (extraction of the data into a
single buffer, copying the data back into the xdr stream) and generate the
MIC token in place (may not save memory access cycles but does save on
memory allocation).
Frank
5 years, 7 months