June 2019 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: coverity: string is not null terminated (do not merge)
by Kaleb KEITHLEY (GerritHub) 21 Jun '19

21 Jun '19

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458987 Change subject: coverity: string is not null terminated (do not merge) ...................................................................... coverity: string is not null terminated (do not merge) Now with utf8string_dup(). But do not merge because this adds more coverity warnings than it fixes. Fixes an issue (of sorts) reported by coverity, namely not enough memory is allocated to store a terminating NULL in a utf8string. The warning is a false positive. utf8strings in ganesha are nominally strings that come off the wire and may or may not be null terminated; given that, it is not safe to call strlen(). Furthermore, they need not be NULL terminated when stored internally as the length is stored in an associated length variable. In this case the string comes from an xattr and should contain a ':' separator. The ':' separator, if there is one, is replaced with a null by strsep(). By convention it should still be considered not safe to call strlen() or (gsh_)strdup(), but gsh_strdup() is used everywhere else in ganesha for utf8strings, so we do it here as well. Foolish consistency and all that. At least we know it's safe here. And it should silence the coverity warning. Unfortunately simply adding a /* coverity[OVERRUN] */ comment here did not silence it. Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> Change-Id: I3f1b3840022686d979421d267b6fc518e01fdd02 --- M src/FSAL/FSAL_VFS/subfsal_helpers.c M src/MainNFSD/libganesha_nfsd.ver M src/Protocols/NFS/nfs4_op_readdir.c M src/Protocols/NFS/nfs_proto_tools.c M src/include/nfsv41.h 5 files changed, 33 insertions(+), 14 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/87/458987/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458987 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3f1b3840022686d979421d267b6fc518e01fdd02 Gerrit-Change-Number: 458987 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: MDCACHE - Hold lock while dropping ref on chunk
by Daniel Gryniewicz (GerritHub) 20 Jun '19

20 Jun '19

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458832 Change subject: MDCACHE - Hold lock while dropping ref on chunk ...................................................................... MDCACHE - Hold lock while dropping ref on chunk Dropping the ref on a chunk requires holding the content lock, and requires holding it for write when the last ref is dropped. This ref won't be the last, but we still have to hold the lock for at least read to ensure another thread doesn't drop a ref making it last. Change-Id: I1a268d4ec8de23d16be01b317c2118f3098bbefa Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/32/458832/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458832 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1a268d4ec8de23d16be01b317c2118f3098bbefa Gerrit-Change-Number: 458832 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Handle deleting open state before lock state
by Suhrud Patankar (GerritHub) 19 Jun '19

19 Jun '19

Suhrud Patankar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458733 Change subject: Handle deleting open state before lock state ...................................................................... Handle deleting open state before lock state The LOCK state is anchored with open state. When V4 state gets wiped out, remove the LOCK state list from the open state. Otherwise the list head in the open state gets deleted corrupting the lock state list. Change-Id: I2d7fba2c30917d23fd2fbb001ad7997ccaf24e55 Signed-off-by: Suhrud Patankar <suhrudpatankar(a)gmail.com> --- M src/SAL/nfs4_state.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/33/458733/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458733 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2d7fba2c30917d23fd2fbb001ad7997ccaf24e55 Gerrit-Change-Number: 458733 Gerrit-PatchSet: 1 Gerrit-Owner: Suhrud Patankar <suhrudpatankar(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: MDCACHE - delay invalidate of dir for whence-is-name
by Daniel Gryniewicz (GerritHub) 19 Jun '19

19 Jun '19

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458684 Change subject: MDCACHE - delay invalidate of dir for whence-is-name ...................................................................... MDCACHE - delay invalidate of dir for whence-is-name A directory invalidate on a whence-is-name FSAL is a potentially huge performance problem. It can cause the entire directory to reload to find the correct cookie, which can time out the client if the directory is large. To avoid this, put of the invalidate as long as active readdirs are in process. Note, this has no effect on upcalls, so an upcall can still invalidate the directory. Change-Id: Ice244c5cff6b7b4ba9a83c5e0750e3e27a59b2e5 Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/84/458684/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458684 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ice244c5cff6b7b4ba9a83c5e0750e3e27a59b2e5 Gerrit-Change-Number: 458684 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: MDCACHE - add a name-cookie mapping for whence-is-name
by Daniel Gryniewicz (GerritHub) 19 Jun '19

19 Jun '19

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458683 Change subject: MDCACHE - add a name-cookie mapping for whence-is-name ...................................................................... MDCACHE - add a name-cookie mapping for whence-is-name Restarting a readdir internally because the chunk containing the requested cookie has been reaped cause extreme performance problems on large directories. It can cause a hang long enough for the client to time out. To avoid this, add a name-cookie map. This map contains the last cookie we sent to a client, so that when that cookie is sent back by the client, we can look up the name even if the chunk containing that dirent has been reaped. This map is in an LRU, with a hard cap (Dirmap_HWMark), and it's cleaned up in the background if entries are older than 60 seconds. Notet that we also save the second cookie in the set, since the linux client seems to request that one approximately 1/3 of the time. Change-Id: I09d1ef6012d5feca81c7418634cba02e3ab08bc5 Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_ext.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_main.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_read_conf.c M src/doc/man/ganesha-cache-config.rst 8 files changed, 344 insertions(+), 61 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/83/458683/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458683 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I09d1ef6012d5feca81c7418634cba02e3ab08bc5 Gerrit-Change-Number: 458683 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: coverity: space for terminating null
by Kaleb KEITHLEY (GerritHub) 19 Jun '19

19 Jun '19

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458644 Change subject: coverity: space for terminating null ...................................................................... coverity: space for terminating null Nominally just a test of CI failures, but this fixes an actual coverity defect. Not sure why gsh_strdup() isn't/wasn't used here, it should be fine for a utf8 string, which by definition is also null terminated, just as an ASCII string is terminated. Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> Change-Id: I594ce69f362d2a0db9a5e9257dc6b032a6552791 --- M src/FSAL/FSAL_VFS/subfsal_helpers.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/44/458644/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458644 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I594ce69f362d2a0db9a5e9257dc6b032a6552791 Gerrit-Change-Number: 458644 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Use (void) cast on sprintf that should be safe
by Frank Filz (GerritHub) 18 Jun '19

18 Jun '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458516 Change subject: Use (void) cast on sprintf that should be safe ...................................................................... Use (void) cast on sprintf that should be safe These uses of sprintf should have a large enough buffer. Use a (void) cast to show that we have examined them and deemed them safe. Change-Id: I3ccdc327039665ba4342fd394f8e8bd2b7e97682 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_RGW/main.c M src/Protocols/NLM/nlm_async.c M src/Protocols/NLM/sm_notify.c M src/cidr/cidr_to_str.c M src/idmapper/idmapper.c 5 files changed, 25 insertions(+), 27 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/16/458516/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458516 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3ccdc327039665ba4342fd394f8e8bd2b7e97682 Gerrit-Change-Number: 458516 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Use (void) cast on snprintf that should be safe
by Frank Filz (GerritHub) 18 Jun '19

18 Jun '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458515 Change subject: Use (void) cast on snprintf that should be safe ...................................................................... Use (void) cast on snprintf that should be safe Sometimes snprintf is just used to assure that an overrun can never occur, in such cases, cast to (void) to indicate we don't care about the return because we don't expect overrun to ever happen. Also pick up one or two other string buffer safety issues. Change-Id: Ib4264ad3582e18a2f2659357f3ffad549875e95d Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_CEPH/main.c M src/FSAL/FSAL_GLUSTER/fsal_up.c M src/FSAL/FSAL_GPFS/fsal_up.c M src/FSAL/FSAL_VFS/handle.c M src/FSAL/FSAL_VFS/subfsal_helpers.c M src/FSAL/FSAL_VFS/xattrs.c M src/FSAL/access_check.c M src/FSAL/fsal_manager.c M src/config_parsing/conf_url.c M src/support/export_mgr.c 10 files changed, 63 insertions(+), 45 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/458515/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458515 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib4264ad3582e18a2f2659357f3ffad549875e95d Gerrit-Change-Number: 458515 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Use display_buffer for logging file handles, add new Log macros
by Frank Filz (GerritHub) 18 Jun '19

18 Jun '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458514 Change subject: Use display_buffer for logging file handles, add new Log macros ...................................................................... Use display_buffer for logging file handles, add new Log macros New Log macros are introduced to make it easier to log messages that include file handles. Particularly for NFS v3 operations, LogNFS3_Operation logs the entry to an operation complete with handle and any additional parameters desired. LogNFS3_Operation2 is for the operations with two handles. LogHandleNFS4 replaces sprint_fhandle4. LogCompoundFH is turned into a macro for better line number reporting. All the sprint_handle functions are removed as well as the now uneccesary sprint_mem. Change-Id: Ie76757a5115a4a541dcee72f6e62d20ed61f2577 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/MainNFSD/nfs_worker_thread.c M src/Protocols/NFS/mnt_Mnt.c M src/Protocols/NFS/nfs3_access.c M src/Protocols/NFS/nfs3_commit.c M src/Protocols/NFS/nfs3_create.c M src/Protocols/NFS/nfs3_fsinfo.c M src/Protocols/NFS/nfs3_fsstat.c M src/Protocols/NFS/nfs3_getattr.c M src/Protocols/NFS/nfs3_link.c M src/Protocols/NFS/nfs3_lookup.c M src/Protocols/NFS/nfs3_mkdir.c M src/Protocols/NFS/nfs3_mknod.c M src/Protocols/NFS/nfs3_pathconf.c M src/Protocols/NFS/nfs3_read.c M src/Protocols/NFS/nfs3_readdir.c M src/Protocols/NFS/nfs3_readdirplus.c M src/Protocols/NFS/nfs3_readlink.c M src/Protocols/NFS/nfs3_remove.c M src/Protocols/NFS/nfs3_rename.c M src/Protocols/NFS/nfs3_rmdir.c M src/Protocols/NFS/nfs3_setattr.c M src/Protocols/NFS/nfs3_symlink.c M src/Protocols/NFS/nfs3_write.c M src/Protocols/NFS/nfs4_op_restorefh.c M src/Protocols/NFS/nfs4_op_savefh.c M src/Protocols/NLM/nlm_Share.c M src/Protocols/NLM/nlm_Unshare.c M src/include/nfs_file_handle.h M src/support/nfs_filehandle_mgmt.c 29 files changed, 242 insertions(+), 519 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/14/458514/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458514 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie76757a5115a4a541dcee72f6e62d20ed61f2577 Gerrit-Change-Number: 458514 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Fix LogDebugAlt etc to only log component and log level once
by Frank Filz (GerritHub) 18 Jun '19

18 Jun '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458513 Change subject: Fix LogDebugAlt etc to only log component and log level once ...................................................................... Fix LogDebugAlt etc to only log component and log level once Oops... These macros resulted in doubling up of component and log level in the log. Change-Id: I74e8df7bfea5e7f5501b11f93b64fb9b595539a3 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/include/log.h 1 file changed, 5 insertions(+), 15 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/13/458513/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458513 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I74e8df7bfea5e7f5501b11f93b64fb9b595539a3 Gerrit-Change-Number: 458513 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0