June 2019 - Devel - Nfs Ganesha List Archives

Change in ...nfs-ganesha[next]: Change string parsing in setup_client_saddr to allow more address for...

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458502 Change subject: Change string parsing in setup_client_saddr to allow more address formats ...................................................................... Change string parsing in setup_client_saddr to allow more address formats By making a copy of the uaddr string, and truncating off the port bytes, we can pass the remaining string to inet_pton directly and it will parse more (all) of the formats allowd for uaddr strings. Along the way, we also save potentially unsafe snprintf and skip sscanf. Change-Id: I00c64c52cd03cd73a16958681aef8c7c052a9be6 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/MainNFSD/nfs_rpc_callback.c 1 file changed, 43 insertions(+), 28 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/458502/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458502 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I00c64c52cd03cd73a16958681aef8c7c052a9be6 Gerrit-Change-Number: 458502 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

4 years, 10 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: MainNFSD: safer or more efficient string manipulation

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458501 Change subject: MainNFSD: safer or more efficient string manipulation ...................................................................... MainNFSD: safer or more efficient string manipulation Use memcpy when the length of the source is known. Check result of strlcpy. Cast snprintf to (void) when we know it can't overflow to make it clear ignoring overflow is intentional. Change-Id: I29341badc9d6ec32cc4a7f74db5d60f0bbc06493 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/MainNFSD/9p_dispatcher.c M src/MainNFSD/9p_rdma_dispatcher.c M src/MainNFSD/nfs_admin_thread.c M src/MainNFSD/nfs_main.c M src/MainNFSD/nfs_rpc_callback.c M src/MainNFSD/nfs_rpc_callback_simulator.c 6 files changed, 25 insertions(+), 17 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/01/458501/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458501 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I29341badc9d6ec32cc4a7f74db5d60f0bbc06493 Gerrit-Change-Number: 458501 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

4 years, 10 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: SAL recovery - safe string manipulation

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458500 Change subject: SAL recovery - safe string manipulation ...................................................................... SAL recovery - safe string manipulation Also, unify to show strerror(errno), errno as %s (%d). Change-Id: I1825de84b31e7762cb78dcbd075b0321cea23846 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/SAL/nfs4_recovery.c M src/SAL/recovery/recovery_fs.c M src/SAL/recovery/recovery_fs_ng.c M src/SAL/recovery/recovery_rados.h M src/SAL/recovery/recovery_rados_cluster.c M src/SAL/recovery/recovery_rados_kv.c M src/SAL/recovery/recovery_rados_ng.c 7 files changed, 455 insertions(+), 282 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/00/458500/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458500 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1825de84b31e7762cb78dcbd075b0321cea23846 Gerrit-Change-Number: 458500 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

4 years, 10 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: Add gsh concat functions to safely concatenate strings

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458499 Change subject: Add gsh concat functions to safely concatenate strings ...................................................................... Add gsh concat functions to safely concatenate strings Change-Id: I1e23f72930081f49cd8c61de734c5bb87ed468c9 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_main.c M src/FSAL/fsal_manager.c M src/config_parsing/conf_lex.l M src/include/abstract_mem.h 4 files changed, 28 insertions(+), 13 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/99/458499/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458499 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1e23f72930081f49cd8c61de734c5bb87ed468c9 Gerrit-Change-Number: 458499 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

4 years, 10 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: VFS: safer string copy in xattrs.c

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458498 Change subject: VFS: safer string copy in xattrs.c ...................................................................... VFS: safer string copy in xattrs.c Change-Id: I4cd718bbda99c020169ae02176dcae107be26840 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_VFS/xattrs.c M src/include/fsal_types.h 2 files changed, 39 insertions(+), 16 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/98/458498/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458498 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4cd718bbda99c020169ae02176dcae107be26840 Gerrit-Change-Number: 458498 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

4 years, 10 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: GLUSTER: use memcpy instead of strcpy in lookup_path and use less memory

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458497 Change subject: GLUSTER: use memcpy instead of strcpy in lookup_path and use less memory ...................................................................... GLUSTER: use memcpy instead of strcpy in lookup_path and use less memory Since we do strlen on every string we copy, use memcpy. Also, we over-allocate memory by the length of mount_path. Change-Id: I441f20a21da1ff2438705ad515a17efe5507048c Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_GLUSTER/export.c 1 file changed, 16 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/458497/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458497 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I441f20a21da1ff2438705ad515a17efe5507048c Gerrit-Change-Number: 458497 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

4 years, 10 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: GLUSTER: get rid of dead code - fs_specific_has

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458496 Change subject: GLUSTER: get rid of dead code - fs_specific_has ...................................................................... GLUSTER: get rid of dead code - fs_specific_has This was legacy from old config. Change-Id: Ieb50c9493d86568d39ac038ba04b32f611600d55 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_GLUSTER/gluster_internal.c M src/FSAL/FSAL_GLUSTER/gluster_internal.h 2 files changed, 0 insertions(+), 45 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/96/458496/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458496 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ieb50c9493d86568d39ac038ba04b32f611600d55 Gerrit-Change-Number: 458496 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

4 years, 10 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: display_buffer improvements

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458495 Change subject: display_buffer improvements ...................................................................... display_buffer improvements Make some (char *) parameters (const char *) to allow more callers. Add display_opaque_bytes_flags to allow control of how opaque bytes are displayed. Options include whether it uses %02x or %02X, whether it leads the string with "0x" and how it handles various issues with the buffer passed (negative length, NULL pointer, 0 length). Add an OPAQUE_BYTES_SIZE macro to compte the buffer size necessary (note that if the "0x" lead is not used, the buffer size will be 2 bytes larger than necessary. Change-Id: Ie09ce0252140b73d4026213369cbde8b89468031 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/MainNFSD/libganesha_nfsd.ver M src/include/display.h M src/log/display.c 3 files changed, 71 insertions(+), 14 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/458495/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458495 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie09ce0252140b73d4026213369cbde8b89468031 Gerrit-Change-Number: 458495 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

4 years, 10 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: ganesha_stats gets a new option to capture authentication statistics

by Trishali Nayar (GerritHub)

Trishali Nayar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458487 Change subject: ganesha_stats gets a new option to capture authentication statistics ...................................................................... ganesha_stats gets a new option to capture authentication statistics The statistics related to winbind and group cache will be captured currently. The ganesha_stats interface will help enable/disable/extract/reset these statistics. Change-Id: Ia76c4ed21f6435fc160ddc8e25531e183fb5df47 Signed-off-by: Trishali Nayar <ntrishal(a)in.ibm.com> --- M src/idmapper/idmapper.c M src/include/gsh_config.h M src/include/idmapper.h M src/include/server_stats_private.h M src/scripts/ganeshactl/Ganesha/glib_dbus_stats.py M src/scripts/ganeshactl/ganesha_stats.py M src/support/export_mgr.c M src/support/nfs_read_conf.c M src/support/uid2grp.c 9 files changed, 319 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/87/458487/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458487 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia76c4ed21f6435fc160ddc8e25531e183fb5df47 Gerrit-Change-Number: 458487 Gerrit-PatchSet: 1 Gerrit-Owner: Trishali Nayar <ntrishal(a)in.ibm.com> Gerrit-MessageType: newchange

4 years, 10 months

1
0
0 / 0

Next week's concall will be Wednesday June 26

by Frank Filz

Next week I will be at the beach Monday and Tuesday so we will do the call same time on Wednesday (June 26) morning. Thanks Frank

4 years, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

Devel June 2019