June 2019 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Use display_opaque_bytes instead of sprint_mem for clientid4
by Frank Filz (GerritHub) 18 Jun '19

18 Jun '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458512 Change subject: Use display_opaque_bytes instead of sprint_mem for clientid4 ...................................................................... Use display_opaque_bytes instead of sprint_mem for clientid4 Change-Id: Ida6100aa3cd7d38ae81387d87c90eeca4b9a8fd3 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NFS/nfs4_op_setclientid.c M src/Protocols/NFS/nfs4_op_setclientid_confirm.c 2 files changed, 22 insertions(+), 18 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/12/458512/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458512 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ida6100aa3cd7d38ae81387d87c90eeca4b9a8fd3 Gerrit-Change-Number: 458512 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Convert hashtable to use display_buffer
by Frank Filz (GerritHub) 18 Jun '19

18 Jun '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458511 Change subject: Convert hashtable to use display_buffer ...................................................................... Convert hashtable to use display_buffer Also dranatically reduce the size of HASHTABLE_DISPLAY_STRLEN from 8192 to 512. The maximum log message is only 2048 and these are only logged, and often there is both a key and a value plus other stuff. Even 512 is probably too long to read in a log message. Change-Id: I21a1864771753fa3536f8ada322c9b87ad009b29 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PROXY/handle_mapping/handle_mapping.c M src/FSAL/FSAL_PROXY/handle_mapping/handle_mapping_internal.h M src/SAL/9p_owner.c M src/SAL/nfs41_session_id.c M src/SAL/nfs4_clientid.c M src/SAL/nfs4_owner.c M src/SAL/nfs4_state_id.c M src/SAL/nlm_owner.c M src/SAL/nlm_state.c M src/SAL/state_lock.c M src/hashtable/hashtable.c M src/include/hashtable.h M src/include/nfs_ip_stats.h M src/include/sal_functions.h M src/support/nfs_ip_name.c 15 files changed, 296 insertions(+), 543 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/11/458511/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458511 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I21a1864771753fa3536f8ada322c9b87ad009b29 Gerrit-Change-Number: 458511 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: EXPRTS: make LogClientListEntry more efficient
by Frank Filz (GerritHub) 18 Jun '19

18 Jun '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458510 Change subject: EXPRTS: make LogClientListEntry more efficient ...................................................................... EXPRTS: make LogClientListEntry more efficient And get rid of an snprintf into a separate buffer Change-Id: I9df30a88cb1b25fc075da20956f5b07a2cc7a05e Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/support/exports.c 1 file changed, 25 insertions(+), 22 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/10/458510/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458510 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9df30a88cb1b25fc075da20956f5b07a2cc7a05e Gerrit-Change-Number: 458510 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Miscellaneous safer or more efficient string copy
by Frank Filz (GerritHub) 18 Jun '19

18 Jun '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458509 Change subject: Miscellaneous safer or more efficient string copy ...................................................................... Miscellaneous safer or more efficient string copy Change-Id: Ib4f1f1722e11683bd2c8f74b04e01407e7e426ec Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_MEM/mem_handle.c M src/config_parsing/conf_url_rados.c M src/dbus/dbus_server.c M src/log/log_functions.c M src/os/freebsd/mntent_compat.c 5 files changed, 80 insertions(+), 74 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/09/458509/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458509 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib4f1f1722e11683bd2c8f74b04e01407e7e426ec Gerrit-Change-Number: 458509 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Replace strmaxcpy with checked calls to strlcpy
by Frank Filz (GerritHub) 18 Jun '19

18 Jun '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458508 Change subject: Replace strmaxcpy with checked calls to strlcpy ...................................................................... Replace strmaxcpy with checked calls to strlcpy Change-Id: I00358900e5506d19415ddf9010ebb29d9dba4062 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NFS/nfs4_op_setclientid.c M src/include/common_utils.h M src/log/log_functions.c 3 files changed, 11 insertions(+), 60 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/08/458508/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458508 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I00358900e5506d19415ddf9010ebb29d9dba4062 Gerrit-Change-Number: 458508 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: PROXY: Make safer string handling and use display_opaque_bytes_flags
by Frank Filz (GerritHub) 18 Jun '19

18 Jun '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458507 Change subject: PROXY: Make safer string handling and use display_opaque_bytes_flags ...................................................................... PROXY: Make safer string handling and use display_opaque_bytes_flags Check return of strlcpy. Use gsh_strdup where appropriate. Replace snprintmem with display_opaque_bytes_flags for code re-use. Change-Id: I49a34fdbeb3498141d4e2f46b4a1c17b74626370 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> PROXY: test return of strlcpy Change-Id: Id85e06d7c5e2b31c63807a8d2fbd714577810c61 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> handle_mapping_db: use display functions to make file handle string Use display_opaque_bytes_flags to produce the same file handle string as before, re-uses existing code and is safer. Change-Id: Iedb247a744f1744a721e08ee91735e5d43cf6c3f Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PROXY/handle.c M src/FSAL/FSAL_PROXY/handle_mapping/handle_mapping_db.c M src/FSAL/FSAL_PROXY/handle_mapping/test_handle_mapping.c 3 files changed, 64 insertions(+), 65 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/07/458507/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458507 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iedb247a744f1744a721e08ee91735e5d43cf6c3f Gerrit-Change-Number: 458507 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Add and use gsh_strdupa instead of alloca(strlen()); strcpy();
by Frank Filz (GerritHub) 18 Jun '19

18 Jun '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458506 Change subject: Add and use gsh_strdupa instead of alloca(strlen()); strcpy(); ...................................................................... Add and use gsh_strdupa instead of alloca(strlen()); strcpy(); Change-Id: Icfde0abf883b3f64bb3927ad2ac38415c6660c50 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NFS/nfs4_pseudo.c M src/config_parsing/conf_lex.l M src/config_parsing/config_parsing.c M src/include/abstract_mem.h M src/log/log_functions.c 5 files changed, 20 insertions(+), 14 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/06/458506/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458506 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Icfde0abf883b3f64bb3927ad2ac38415c6660c50 Gerrit-Change-Number: 458506 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: cleaner string handling in sm_notify
by Frank Filz (GerritHub) 18 Jun '19

18 Jun '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458505 Change subject: cleaner string handling in sm_notify ...................................................................... cleaner string handling in sm_notify Change-Id: I1b9e4f09ef497909871fee2a8a7473f2f2296651 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NLM/sm_notify.c 1 file changed, 7 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/05/458505/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458505 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1b9e4f09ef497909871fee2a8a7473f2f2296651 Gerrit-Change-Number: 458505 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: 9P: Safe string handling
by Frank Filz (GerritHub) 18 Jun '19

18 Jun '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458504 Change subject: 9P: Safe string handling ...................................................................... 9P: Safe string handling Change-Id: Ic9bc5f3e76b09307a6f86b9c3c59ef176c5fab99 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/9P/9p_attach.c M src/Protocols/9P/9p_lcreate.c M src/Protocols/9P/9p_link.c M src/Protocols/9P/9p_lock.c M src/Protocols/9P/9p_mkdir.c M src/Protocols/9P/9p_mknod.c M src/Protocols/9P/9p_rename.c M src/Protocols/9P/9p_renameat.c M src/Protocols/9P/9p_symlink.c M src/Protocols/9P/9p_unlinkat.c M src/Protocols/9P/9p_walk.c M src/Protocols/9P/9p_xattrcreate.c M src/Protocols/9P/9p_xattrwalk.c 13 files changed, 123 insertions(+), 18 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/04/458504/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458504 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic9bc5f3e76b09307a6f86b9c3c59ef176c5fab99 Gerrit-Change-Number: 458504 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: cleanup gss_credcache - safe string functions, connect logging
by Frank Filz (GerritHub) 18 Jun '19

18 Jun '19

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458503 Change subject: cleanup gss_credcache - safe string functions, connect logging ...................................................................... cleanup gss_credcache - safe string functions, connect logging Change-Id: I3b46d5307cfa3923be24998ceb44e177ab7112af Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/RPCAL/gss_credcache.c 1 file changed, 51 insertions(+), 35 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/03/458503/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/458503 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3b46d5307cfa3923be24998ceb44e177ab7112af Gerrit-Change-Number: 458503 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0