Announce Push of V4-dev.37
by Frank Filz
Branch next
Tag:V4-dev.37
Merge Highlights
* 2 GPFS patches for OPENHANDLE_GET_VERSION3
* MDCACHE: Invalidate dirents cache if mtime moves backwards.
* ProxyV3: Issue last-chance GETATTR in READDIRPLUS.
* Improve INFO logging of exports
* Fix a use of STATELOCK_lock in nfs4_op_getattr.c
* Add missing mutex initialization
* Rename struct attrlist to more specific name
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
131b669 Frank S. Filz V4-dev.37
6804425 Matthew DeVore Rename struct attrlist to more specific name
0103714 Matthew DeVore Add missing mutex initialization
9bcc240 Frank S. Filz Fix a use of STATELOCK_lock in nfs4_op_getattr.c
4038de7 Frank S. Filz Improve INFO logging of exports
2636682 Solomon Boulos ProxyV3: Issue last-chance GETATTR in READDIRPLUS.
f338051 Pradeep MDCACHE: Invalidate dirents cache if mtime moves backwards.
551ab2b Malahal Naineni [GPFS] Use OPENHANDLE_GET_VERSION3 for auditing NFS
client IP address
d62c274 Malahal Naineni [GPFS] Get interface header file with
OPENHANDLE_GET_VERSION3
3 years, 6 months
Change in ...nfs-ganesha[next]: Fix a use of STATELOCK_lock in nfs4_op_getattr.c
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/503849 )
Change subject: Fix a use of STATELOCK_lock in nfs4_op_getattr.c
......................................................................
Fix a use of STATELOCK_lock in nfs4_op_getattr.c
The lock is only valid for REGULAR_FILE which is fine since delegation
can only be on REGULAR_FILE.
Change-Id: I705def1bc38486175540596240b990e282ad9e1a
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/Protocols/NFS/nfs4_op_getattr.c
1 file changed, 31 insertions(+), 26 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/503849/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/503849
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I705def1bc38486175540596240b990e282ad9e1a
Gerrit-Change-Number: 503849
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
Gerrit-MessageType: newchange
3 years, 6 months
Change in ...nfs-ganesha[next]: Improve INFO logging of exports
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/503845 )
Change subject: Improve INFO logging of exports
......................................................................
Improve INFO logging of exports
When logging the exports on startup or reload, show the client lists also.
Also, downgrade showing the list before update to DEBUG.
Also downgrade some messages that should have been DEBUG.
Also change things so different line and function are showed.
Change-Id: Ibd9c70b2f623a45dc45f08ae2099e44d247b2e55
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/support/exports.c
1 file changed, 67 insertions(+), 59 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/45/503845/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/503845
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ibd9c70b2f623a45dc45f08ae2099e44d247b2e55
Gerrit-Change-Number: 503845
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
Gerrit-MessageType: newchange
3 years, 6 months
Change in ...nfs-ganesha[next]: Support empty sub config block, it could be empty if params have defa...
by Gaurav (GerritHub)
Gaurav has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/503728 )
Change subject: Support empty sub config block, it could be empty if params have default values. Ideally it should take default values for sub block even if sub block is not specified. With this fix we can give expmty sub block. Needed this fix to reduce config data for Ganesha for large number of shares.
......................................................................
Support empty sub config block, it could be empty if params have
default values.
Ideally it should take default values for sub block even if sub block is
not specified.
With this fix we can give expmty sub block.
Needed this fix to reduce config data for Ganesha for large number of shares.
Change-Id: Ife20718dd03a2e4b9c83ce8e93e11ab584cd6dc0
Signed-off-by: Gaurav Gangalwar <gaurav.gangalwar(a)gmail.com>
---
M src/config_parsing/config_parsing.c
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/28/503728/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/503728
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ife20718dd03a2e4b9c83ce8e93e11ab584cd6dc0
Gerrit-Change-Number: 503728
Gerrit-PatchSet: 1
Gerrit-Owner: Gaurav <gaurav.gangalwar(a)gmail.com>
Gerrit-MessageType: newchange
3 years, 6 months
Change in ...nfs-ganesha[next]: [GPFS] Use OPENHANDLE_GET_VERSION3 for auditing NFS client IP address
by Malahal (GerritHub)
Malahal has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/503687 )
Change subject: [GPFS] Use OPENHANDLE_GET_VERSION3 for auditing NFS client IP address
......................................................................
[GPFS] Use OPENHANDLE_GET_VERSION3 for auditing NFS client IP address
Fill in NFS client IP address in operations that need IP address
auditing. Ganesha will try OPENHANDLE_GET_VERSION3 first. If this
fails, we fallback to OPENHANDLE_GET_VERSION2 to work with older
GPFS versions. If both these calls fail, we do log a major error
message but don't bail out to work with even older GPFS versions.
Change-Id: I53354946abba592b7f2791f8f18fc4078812c09e
Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com>
---
M src/FSAL/FSAL_GPFS/export.c
M src/FSAL/FSAL_GPFS/file.c
M src/FSAL/FSAL_GPFS/fsal_ds.c
M src/FSAL/FSAL_GPFS/fsal_fileop.c
M src/FSAL/FSAL_GPFS/fsal_internal.c
M src/FSAL/FSAL_GPFS/handle.c
6 files changed, 46 insertions(+), 8 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/87/503687/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/503687
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I53354946abba592b7f2791f8f18fc4078812c09e
Gerrit-Change-Number: 503687
Gerrit-PatchSet: 1
Gerrit-Owner: Malahal <malahal(a)gmail.com>
Gerrit-MessageType: newchange
3 years, 6 months
Change in ...nfs-ganesha[next]: [GPFS] Get interface header file with OPENHANDLE_GET_VERSION3
by Malahal (GerritHub)
Malahal has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/503686 )
Change subject: [GPFS] Get interface header file with OPENHANDLE_GET_VERSION3
......................................................................
[GPFS] Get interface header file with OPENHANDLE_GET_VERSION3
OPENHANDLE_GET_VERSION2 added NFS client IP address for open operation
for auditing. OPENHANDLE_GET_VERSION3 adds NFS client IP address
for many other operations. Updated the interface header file to include
client IP address field.
Change-Id: Id7fa7d23e310b1668e2c5c80a9d1fa0d4624ca93
Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com>
---
M src/FSAL/FSAL_GPFS/include/gpfs_nfs.h
1 file changed, 22 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/86/503686/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/503686
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Id7fa7d23e310b1668e2c5c80a9d1fa0d4624ca93
Gerrit-Change-Number: 503686
Gerrit-PatchSet: 1
Gerrit-Owner: Malahal <malahal(a)gmail.com>
Gerrit-MessageType: newchange
3 years, 6 months
Change in ...nfs-ganesha[next]: Set root of FSAL_MEM exports to writeable by all
by Matthew DeVore (GerritHub)
Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/503682 )
Change subject: Set root of FSAL_MEM exports to writeable by all
......................................................................
Set root of FSAL_MEM exports to writeable by all
This allows clients which set the owner of the root directory of the
export to one user (including super user) to still allow writes by other
users, and potentially allow multiple users to own files on the share.
This is "insecure" but more flexible, which is fine for FSAL_MEM exports
since FSAL_MEM is not intended for production use.
Change-Id: Ifb5ac8488cc705bf0ca453ceef05a6c19996ded6
Signed-off-by: Matthew DeVore <matvore(a)google.com>
---
M src/FSAL/FSAL_MEM/mem_handle.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/82/503682/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/503682
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ifb5ac8488cc705bf0ca453ceef05a6c19996ded6
Gerrit-Change-Number: 503682
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew DeVore <matvore(a)google.com>
Gerrit-MessageType: newchange
3 years, 6 months
Change in ...nfs-ganesha[next]: FSAL_CEPH: fix segfault when shutdown with destroy fsal
by freeze (GerritHub)
freeze has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/503679 )
Change subject: FSAL_CEPH: fix segfault when shutdown with destroy fsal
......................................................................
FSAL_CEPH: fix segfault when shutdown with destroy fsal
- op_ctx would be NULL when shutdown. We could save
the first export when handle object construct.
Change-Id: I4feff0365957f2dff274fe8eb006b98bf4aa4b34
Signed-off-by: Vicente Cheng <vicente_cheng(a)bigtera.com>
---
M src/FSAL/FSAL_CEPH/handle.c
M src/FSAL/FSAL_CEPH/internal.c
M src/FSAL/FSAL_CEPH/internal.h
3 files changed, 8 insertions(+), 6 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/79/503679/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/503679
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I4feff0365957f2dff274fe8eb006b98bf4aa4b34
Gerrit-Change-Number: 503679
Gerrit-PatchSet: 1
Gerrit-Owner: freeze <freeze.bilsted(a)gmail.com>
Gerrit-MessageType: newchange
3 years, 6 months
Problem with proxy of a directory tree of exports?
by Bjorn Leffler
I discovered a problem when proxying a tree of nfs mounts. It works with
the NFSv4 proxy, but not the NFSv3 proxy. I'm wondering what the correct
behaviour is. Is it a problem with proxy_v3 or something else?
*Configuration:*
EXPORT {
Export_Id = 100;
Path = "/base";
Pseudo = "/base";
Access_Type = "RW";
Squash = "No_Root_Squash";
FSAL {
Name = "PROXY_VX";
Srv_Addr = 10.2.1.3;
}
}
EXPORT {
Export_Id = 101;
Path = "/base/dir1";
Pseudo = "/base/dir1";
Access_Type = "RW";
Squash = "No_Root_Squash";
FSAL {
Name = "PROXY_VX";
Srv_Addr = 10.2.1.3;
}
}
*With proxy_v4, client side:*
# mount -o vers=3 centosbuild:/base /base
# ls /base
hello1.txt dir1
# ls /base/dir1
hello2.txt
*(no error messages server side)*
*With proxy_v3, client side:*
# mount -o vers=3 centosbuild:/base /base
# ls /base
ls: reading directory '/base': Remote I/O error
*With proxy_v3, server side:*
proxyv3_readdir :FSAL :CRIT :READDIRPLUS didn't return a handle for 'dir1'
Thanks,
Bjorn
3 years, 6 months
Change in ...nfs-ganesha[next]: MDCACHE: Invalidate dirents cache if mtime moves backwards.
by Name of user not set (GerritHub)
pradeepthomas(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/503677 )
Change subject: MDCACHE: Invalidate dirents cache if mtime moves backwards.
......................................................................
MDCACHE: Invalidate dirents cache if mtime moves backwards.
In a multiprotocol environment (Samba & Ganesha exporting same
filesystem to Windows and Linux clients), it is possible that
directory contents get modified through the other process. If
this is triggered by backup applications doing restore, then
mtime may be set to the original timestamp (which may end up
in the past).
Signed-off-by: Pradeep <pradeepthomas(a)gmail.com>
Change-Id: Ie7a67553ba4e01a45eabd5a049eeeac414da8398
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/77/503677/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/503677
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ie7a67553ba4e01a45eabd5a049eeeac414da8398
Gerrit-Change-Number: 503677
Gerrit-PatchSet: 1
Gerrit-Owner: pradeepthomas(a)gmail.com
Gerrit-MessageType: newchange
3 years, 6 months