March 2020 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Don't update fs_info.maxfilesize based on the backend.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487472 ) Change subject: Don't update fs_info.maxfilesize based on the backend. ...................................................................... Don't update fs_info.maxfilesize based on the backend. nlm_util (incorrectly) treats offsets > fs_info.maxfilesize as an opportunity to exit early. This was introduced in c811fe9323 to try to avoid waiting for errors downstream, except the cthon locking tests generate it and get the right answer (NFSD will happily let you specify UINT64_MAX as an offset). dang(a)redhat.com worked around this for the NFSv4 lock routines in 3d069bf, and we probably should do the same. For now though, I don't think other FSALs update fs_info.maxfilesize, so I'll just warn that we're not updating it. Change-Id: Ibb494b5e7a90201df5bc0c30252ef3e495bf0f58 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/72/487472/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487472 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ibb494b5e7a90201df5bc0c30252ef3e495bf0f58 Gerrit-Change-Number: 487472 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Implement basic NLM locking methods.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487471 ) Change subject: Implement basic NLM locking methods. ...................................................................... Implement basic NLM locking methods. Ganesha routes all NLM methods through the single lock_op2 handler, so I wired that up and did a "No, I can't handle async calls" implementation. This is good enough for a basic NLM LOCK as well as UNLOCK, but I don't think there's a great way for me to test the NLM_TEST op from the command line (without running either cthon or writing some basic fcntl code). Basic locking in action: # Terminal 1: Open a lockfile. $ flock proxy-mount/lockfile -c cat (Generates lockd: LOCK called on the backend server) # Terminal 2: See that Terminal 1's flock has the lockfile open. $ lsof proxy-mount/lockfile COMMAND PID USER FD TYPE DEVICE SIZE/OFF NODE NAME flock 2149 boulos 3rW REG 0,38 0 541739 proxy-mount/lockfile cat 2151 boulos 3r REG 0,38 0 541739 proxy-mount/lockfile # Terminal 2: Try to grab the lockfile while it's held. $ flock -w 1 proxy-mount/lockfile -c echo ; echo $? 1 (Failed to acquire the lock within 1 second) # Terminal 1: Kill flock. $ Ctrl-C (Generates lockd: UNLOCK called on the backend server) I haven't written up / thought deeply yet about how reclaim and lock recovery are supposed to work. From a NFSv3 backend's (NFSD) perspective, the Ganesha proxy is its only "client". If the backend crashes, it will try to inform Ganesha, who will be fairly confused (Ganesha doesn't "know" that it's an NFS Client). If a client crashes, it will inform Ganesha's NFSD that it has crashed and try to reclaim. In theory, Ganesha's NFSD it totally prepared for that, because the state_lock code keeps track of the owners while the locks are held (they just happen to be held on the non-Ganesha backend too). Here's hoping. Change-Id: I0217e046ab694da67ee8b2a3115b7f79616817f5 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/CMakeLists.txt M src/FSAL/FSAL_PROXY_V3/main.c A src/FSAL/FSAL_PROXY_V3/nlm.c M src/FSAL/FSAL_PROXY_V3/proxyv3_fsal_methods.h M src/FSAL/FSAL_PROXY_V3/utils.c 5 files changed, 461 insertions(+), 13 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/71/487471/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487471 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0217e046ab694da67ee8b2a3115b7f79616817f5 Gerrit-Change-Number: 487471 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Ask the portmapper for the NLM port.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487470 ) Change subject: Ask the portmapper for the NLM port. ...................................................................... Ask the portmapper for the NLM port. In preparation to add some basic lock2 implementation, we need to know the port and test it on export init with a NULL procedure. For now, I put the NLM part at the end of the list of ports and made it effectively optional with a warning. Change-Id: Id22f0ec31cf09a233fde9aea79f56f5933c51efa Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V3/proxyv3_fsal_methods.h M src/FSAL/FSAL_PROXY_V3/rpc.c 3 files changed, 94 insertions(+), 29 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/70/487470/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487470 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id22f0ec31cf09a233fde9aea79f56f5933c51efa Gerrit-Change-Number: 487470 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Allow FSSTAT on any object.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487469 ) Change subject: Allow FSSTAT on any object. ...................................................................... Allow FSSTAT on any object. I misread this originally, it's not just for the root of the filesystem. (This came up in the final cthon basic test). With this in place, all the basic cthon tests pass! But the readdir test is still super slow (10 minutes vs a handful of seconds directly to an NFS server). Change-Id: I5e7d7d8ed7a6a0ab678451548d1d027a0b5793d3 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c 1 file changed, 2 insertions(+), 23 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/69/487469/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487469 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5e7d7d8ed7a6a0ab678451548d1d027a0b5793d3 Gerrit-Change-Number: 487469 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Implement RENAME3, the last obvious NFSv3 op.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487468 ) Change subject: Implement RENAME3, the last obvious NFSv3 op. ...................................................................... Implement RENAME3, the last obvious NFSv3 op. Initial state, before attempting to rename my-first-link (conflicts with my-fifo) $ ls -l proxy-mount/ total 7036 -rw-r--r-- 1 boulos boulos 3584000 Mar 5 23:11 bytes-again.txt -rw-r--r-- 1 boulos boulos 3584000 Mar 4 17:59 bytes.txt drwxr-xr-x 2 boulos boulos 4096 Mar 10 22:56 code -rw-r--r-- 2 boulos boulos 16 Feb 15 00:15 hard-link.txt -rw-r--r-- 2 boulos boulos 16 Feb 15 00:15 hello.txt prw-r--r-- 1 boulos boulos 0 Mar 11 00:40 my-fifo lrwxrwxrwx 1 boulos boulos 14 Mar 10 23:05 my-first-link.txt -> code/hello.txt drwxr-xr-x 2 boulos boulos 4096 Mar 10 17:40 newdir -rw-r--r-- 1 boulos boulos 8 Mar 4 23:39 new.txt drwxr-xr-x 2 boulos boulos 4096 Mar 10 17:30 sub drwxr-xr-x 2 boulos boulos 4096 Mar 7 00:29 subdir -rw-r--r-- 1 boulos boulos 8 Feb 26 02:35 woohoo.txt -rw-r--r-- 1 boulos boulos 11 Feb 15 00:15 yo.txt $ mv proxy-mount/my-first-link.txt proxy-mount/link.txt $ ls -l proxy-mount/ total 7036 -rw-r--r-- 1 boulos boulos 3584000 Mar 5 23:11 bytes-again.txt -rw-r--r-- 1 boulos boulos 3584000 Mar 4 17:59 bytes.txt drwxr-xr-x 2 boulos boulos 4096 Mar 10 22:56 code -rw-r--r-- 2 boulos boulos 16 Feb 15 00:15 hard-link.txt -rw-r--r-- 2 boulos boulos 16 Feb 15 00:15 hello.txt lrwxrwxrwx 1 boulos boulos 14 Mar 10 23:05 link.txt -> code/hello.txt prw-r--r-- 1 boulos boulos 0 Mar 11 00:40 my-fifo drwxr-xr-x 2 boulos boulos 4096 Mar 10 17:40 newdir -rw-r--r-- 1 boulos boulos 8 Mar 4 23:39 new.txt drwxr-xr-x 2 boulos boulos 4096 Mar 10 17:30 sub drwxr-xr-x 2 boulos boulos 4096 Mar 7 00:29 subdir -rw-r--r-- 1 boulos boulos 8 Feb 26 02:35 woohoo.txt -rw-r--r-- 1 boulos boulos 11 Feb 15 00:15 yo.txt And to make sure that subdirectory support and actual "renaming" works: $ mv proxy-mount/new.txt proxy-mount/newdir/renamed.txt $ ls -l proxy-mount/ total 7032 -rw-r--r-- 1 boulos boulos 3584000 Mar 5 23:11 bytes-again.txt -rw-r--r-- 1 boulos boulos 3584000 Mar 4 17:59 bytes.txt drwxr-xr-x 2 boulos boulos 4096 Mar 10 22:56 code -rw-r--r-- 2 boulos boulos 16 Feb 15 00:15 hard-link.txt -rw-r--r-- 2 boulos boulos 16 Feb 15 00:15 hello.txt lrwxrwxrwx 1 boulos boulos 14 Mar 10 23:05 link.txt -> code/hello.txt prw-r--r-- 1 boulos boulos 0 Mar 11 00:40 my-fifo drwxr-xr-x 2 boulos boulos 4096 Mar 11 00:59 newdir drwxr-xr-x 2 boulos boulos 4096 Mar 10 17:30 sub drwxr-xr-x 2 boulos boulos 4096 Mar 7 00:29 subdir -rw-r--r-- 1 boulos boulos 8 Feb 26 02:35 woohoo.txt -rw-r--r-- 1 boulos boulos 11 Feb 15 00:15 yo.txt $ ls -l proxy-mount/newdir/ total 4 -rw-r--r-- 1 boulos boulos 8 Mar 4 23:39 renamed.txt Change-Id: Ic6cb030021f3ec4e180926c2c5bc21dea6152f00 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c 1 file changed, 52 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/68/487468/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487468 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic6cb030021f3ec4e180926c2c5bc21dea6152f00 Gerrit-Change-Number: 487468 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Add MKNOD support.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487467 ) Change subject: Add MKNOD support. ...................................................................... Add MKNOD support. Simplest test was to just do a FIFO: $ mkfifo proxy-mount/my-fifo $ ls -l proxy-mount/ total 7036 -rw-r--r-- 1 boulos boulos 3584000 Mar 5 23:11 bytes-again.txt -rw-r--r-- 1 boulos boulos 3584000 Mar 4 17:59 bytes.txt drwxr-xr-x 2 boulos boulos 4096 Mar 10 22:56 code -rw-r--r-- 2 boulos boulos 16 Feb 15 00:15 hard-link.txt -rw-r--r-- 2 boulos boulos 16 Feb 15 00:15 hello.txt prw-r--r-- 1 boulos boulos 0 Mar 11 00:40 my-fifo lrwxrwxrwx 1 boulos boulos 14 Mar 10 23:05 my-first-link.txt -> code/hello.txt drwxr-xr-x 2 boulos boulos 4096 Mar 10 17:40 newdir -rw-r--r-- 1 boulos boulos 8 Mar 4 23:39 new.txt drwxr-xr-x 2 boulos boulos 4096 Mar 10 17:30 sub drwxr-xr-x 2 boulos boulos 4096 Mar 7 00:29 subdir -rw-r--r-- 1 boulos boulos 8 Feb 26 02:35 woohoo.txt -rw-r--r-- 1 boulos boulos 11 Feb 15 00:15 yo.txt $ echo "Who's on first?" > proxy-mount/my-fifo and then in a separate terminal: $ cat proxy-mount/my-fifo Who's on first? Change-Id: I1b9db7471a320c95370959278a8e3b5ec25dc9f0 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c 1 file changed, 85 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/67/487467/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487467 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1b9db7471a320c95370959278a8e3b5ec25dc9f0 Gerrit-Change-Number: 487467 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Implement (hard)LINK.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487466 ) Change subject: Implement (hard)LINK. ...................................................................... Implement (hard)LINK. $ ln proxy-mount/hello.txt proxy-mount/hard-link.txt $ stat proxy-mount/hard-link.txt File: proxy-mount/hard-link.txt Size: 16 Blocks: 8 IO Block: 1048576 regular file Device: 26h/38d Inode: 541601 Links: 2 Access: (0644/-rw-r--r--) Uid: ( 1000/ boulos) Gid: ( 1001/ boulos) Access: 2020-03-10 17:36:24.809289108 +0000 Modify: 2020-02-15 00:15:20.803463815 +0000 Change: 2020-03-11 00:23:02.863319971 +0000 Birth: - $ stat proxy-mount/hello.txt File: proxy-mount/hello.txt Size: 16 Blocks: 8 IO Block: 1048576 regular file Device: 26h/38d Inode: 541601 Links: 2 Access: (0644/-rw-r--r--) Uid: ( 1000/ boulos) Gid: ( 1001/ boulos) Access: 2020-03-10 17:36:24.809289108 +0000 Modify: 2020-02-15 00:15:20.803463815 +0000 Change: 2020-03-11 00:23:02.863319971 +0000 Birth: - inodes match! Woohoo. Change-Id: Iaae051574db1b4367efb1f2f2321b98aef738e45 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c 1 file changed, 67 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/66/487466/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487466 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iaae051574db1b4367efb1f2f2321b98aef738e45 Gerrit-Change-Number: 487466 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Implement READLINK.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487465 ) Change subject: Implement READLINK. ...................................................................... Implement READLINK. $ ls -l proxy-mount/ total 7032 -rw-r--r-- 1 boulos boulos 3584000 Mar 5 23:11 bytes-again.txt -rw-r--r-- 1 boulos boulos 3584000 Mar 4 17:59 bytes.txt drwxr-xr-x 2 boulos boulos 4096 Mar 10 22:56 code -rw-r--r-- 1 boulos boulos 16 Feb 15 00:15 hello.txt lrwxrwxrwx 1 boulos boulos 14 Mar 10 23:05 my-first-link.txt -> code/hello.txt drwxr-xr-x 2 boulos boulos 4096 Mar 10 17:40 newdir -rw-r--r-- 1 boulos boulos 8 Mar 4 23:39 new.txt drwxr-xr-x 2 boulos boulos 4096 Mar 10 17:30 sub drwxr-xr-x 2 boulos boulos 4096 Mar 7 00:29 subdir -rw-r--r-- 1 boulos boulos 8 Feb 26 02:35 woohoo.txt -rw-r--r-- 1 boulos boulos 11 Feb 15 00:15 yo.txt (Note: the previous listing of implementing SYMLINK worked because Ganesha knew the answer and cached it! On a re-mount, it doesn't and failed) Change-Id: Ie7633fe10e1ce0979190dc067436430bedc6241b Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c 1 file changed, 52 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/65/487465/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487465 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie7633fe10e1ce0979190dc067436430bedc6241b Gerrit-Change-Number: 487465 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Error => warning for Ganesha's FSAL_DIGEST_V4 request.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487464 ) Change subject: Error => warning for Ganesha's FSAL_DIGEST_V4 request. ...................................................................... Error => warning for Ganesha's FSAL_DIGEST_V4 request. The mdcache has a hardcoded "I want a FSAL_DIGEST_V4 from you", which I previously worked around with an innocuous ("V3 requests should be V3, V4 should be V4"). But, on "boot", there is no active operation / NFS request that drives the creation of the export, so the first one of these will fail. Not returning to Ganesha the handle to our root is sure to cause problems. So instead, since Ganesha doesn't look at it anyway, turn this into a warning. If possible, I may try to make the internal handler detect that it's being called for the root object and silently do that. Change-Id: Ibdd8ee9e2af4b1275e7a0e07b7c4684708c4e2e0 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/64/487464/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487464 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ibdd8ee9e2af4b1275e7a0e07b7c4684708c4e2e0 Gerrit-Change-Number: 487464 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Mask the mode bits in sattr3 with fsal2unix_mode.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487463 ) Change subject: Mask the mode bits in sattr3 with fsal2unix_mode. ...................................................................... Mask the mode bits in sattr3 with fsal2unix_mode. While trying to debug the close2() bug, I noticed this, and while it never came up, it seems like good hygiene (CEPH and Gluster do it). Change-Id: I9d88cfd42d384dd6fff744f1dd5228a2ddd02232 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/utils.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/63/487463/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487463 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9d88cfd42d384dd6fff744f1dd5228a2ddd02232 Gerrit-Change-Number: 487463 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0