March 2020 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: spec - Fix broken parens
by Daniel Gryniewicz (GerritHub) 24 Mar '20

24 Mar '20

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487910 ) Change subject: spec - Fix broken parens ...................................................................... spec - Fix broken parens Change-Id: Ia5d7dbea93089741b1783e947ffa9244f4ae33f9 Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/nfs-ganesha.spec-in.cmake 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/10/487910/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487910 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia5d7dbea93089741b1783e947ffa9244f4ae33f9 Gerrit-Change-Number: 487910 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: MDCACHE - Close unexport race for used entries
by Daniel Gryniewicz (GerritHub) 24 Mar '20

24 Mar '20

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487898 ) Change subject: MDCACHE - Close unexport race for used entries ...................................................................... MDCACHE - Close unexport race for used entries When we're unexporting, we need to make an entry unreachable if no exports are referencing it. However, the refcount is not a suitable method of determining this, since an OP can be outstanding on the entry, keeping a ref on it. If this was the case, we'd leave the entry dangling, and a new export could reference it, and it's contents could be bad. To avoid this, switch from using the refcount to a locked check to make sure the entry is still not exported. Change-Id: If7c21274325c23ba1a15797a3be29cf4330e1203 Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c 1 file changed, 13 insertions(+), 17 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/98/487898/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487898 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If7c21274325c23ba1a15797a3be29cf4330e1203 Gerrit-Change-Number: 487898 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: selinux: new policy to allow gluster (glusterd) to start ganesha
by Kaleb KEITHLEY (GerritHub) 24 Mar '20

24 Mar '20

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487864 ) Change subject: selinux: new policy to allow gluster (glusterd) to start ganesha ...................................................................... selinux: new policy to allow gluster (glusterd) to start ganesha selinux moving target lvrabrec at redhat dot com suggests it's correct here in ganesha rather than the gluster selinux policy. Even though all the other glusterd_t policies are in the gluster selinux policy. Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> Change-Id: Icd0a419f1569c2ec8a860ad1236e9ca08bd76ef0 --- M src/selinux/ganesha.te 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/64/487864/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487864 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Icd0a419f1569c2ec8a860ad1236e9ca08bd76ef0 Gerrit-Change-Number: 487864 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com> Gerrit-MessageType: newchange

1 0

Announce Push of V4-dev.9
by Frank Filz 20 Mar '20

20 Mar '20

Branch next Tag:V4-dev.9 Merge Highlights * scripts/systemd: .include is deprecated, use drop-in .conf file * GRACE: Handle start grace with refs taken. * Set no_cleanup=true prior to calling fsal_open2()/fsal_reopen2() * Replaced a LogMajor() with LogEvent() in nlm4_Granted_Res() Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 4abb220 Madhu Thorat Replaced a LogMajor() with LogEvent() in nlm4_Granted_Res() d3b90cf Madhu Thorat Set no_cleanup=true prior to calling fsal_open2()/fsal_reopen2() 92bf3f7 Gaurav Gangalwar GRACE: Handle start grace with refs taken. 8f58f8f Kaleb S. KEITHLEY scripts/systemd: .include is deprecated, use drop-in .conf file

1 0

Change in ...nfs-ganesha[next]: Separate out client specific stats per protocol
by Sachin Punadikar (GerritHub) 20 Mar '20

20 Mar '20

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487661 ) Change subject: Separate out client specific stats per protocol ...................................................................... Separate out client specific stats per protocol Currently client specific stats, "client_all_ops" option, provides statistics on all operations of NFSv3, NLM, and NFSv4.x protocols. While sending this data over DBUS, this exceeds the DBUS limits leading to Ganesha crash/hang situation. To limit the data flow over DBUS, this patch supports 2 options for client specific statistics - "client_all_v3_ops" and "client_all_v4_ops". "client_all_v3_ops" option provides stats of all ops of NFSv3+NLM "client_all_v4_ops" option provides stats of all ops of NFSv4.x (NFSv4.0, NFSv4.1, NFSv4.2 etc) Change-Id: I0f46dd8c042fb3a295661f410b97bf3bb5bc2d38 Signed-off-by: root <psachin(a)in.ibm.com> (cherry picked from commit 57e0f40b33a36b0cffb8b53eb2d121f8beb23636) --- M src/include/gsh_config.h M src/include/server_stats_private.h M src/scripts/ganeshactl/Ganesha/glib_dbus_stats.py M src/scripts/ganeshactl/ganesha_stats.py M src/support/client_mgr.c M src/support/export_mgr.c M src/support/nfs_read_conf.c M src/support/server_stats.c 8 files changed, 313 insertions(+), 154 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/61/487661/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487661 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0f46dd8c042fb3a295661f410b97bf3bb5bc2d38 Gerrit-Change-Number: 487661 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <psachin(a)in.ibm.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Replaced a LogMajor() with LogEvent() in nlm4_Granted_Res()
by Madhu Thorat (GerritHub) 19 Mar '20

19 Mar '20

Madhu Thorat has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487566 ) Change subject: Replaced a LogMajor() with LogEvent() in nlm4_Granted_Res() ...................................................................... Replaced a LogMajor() with LogEvent() in nlm4_Granted_Res() Replaced a LogMajor() with LogEvent() in nlm4_Granted_Res(..), in case the client returned an error or the export has gone stale. Change-Id: If042b018b3437c0bbe4e6ae25a07df6b75055b51 Signed-off-by: Madhu Thorat <madhu.punjabi(a)in.ibm.com> --- M src/Protocols/NLM/nlm_Granted_Res.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/66/487566/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487566 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If042b018b3437c0bbe4e6ae25a07df6b75055b51 Gerrit-Change-Number: 487566 Gerrit-PatchSet: 1 Gerrit-Owner: Madhu Thorat <madhu.punjabi(a)in.ibm.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Initial NFSv3 proxying FSAL.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487439 ) Change subject: Initial NFSv3 proxying FSAL. ...................................................................... Initial NFSv3 proxying FSAL. This code just builds, is able to get parsed and correctly explode as soon as the first lookup_path request. Next up, implement some ops. Change-Id: I45926761389ef61af281f7ba0f7e643fd32b4ee5 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/CMakeLists.txt M src/FSAL/CMakeLists.txt A src/FSAL/FSAL_PROXY_V3/CMakeLists.txt A src/FSAL/FSAL_PROXY_V3/main.c A src/FSAL/FSAL_PROXY_V3/proxyv3_fsal_methods.h A src/config_samples/proxy_v3.conf M src/doc/man/ganesha-config.rst A src/doc/man/ganesha-proxy-v3-config.rst 8 files changed, 325 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/487439/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487439 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I45926761389ef61af281f7ba0f7e643fd32b4ee5 Gerrit-Change-Number: 487439 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

2 1

Change in ...nfs-ganesha[next]: Avoid allocating memory on every rpc for v3 proxy.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487475 ) Change subject: Avoid allocating memory on every rpc for v3 proxy. ...................................................................... Avoid allocating memory on every rpc for v3 proxy. Like opening a socket, it's worthwhile to just malloc the bytes once and reuse them if possible. Like the V4 proxy, I shoved this into a struct alongside the socket (fd_entry). cthon still passes, but readdir is still quite slow. Change-Id: I803ee391ae15b38fda632b543c2188c524fb8a56 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/rpc.c 1 file changed, 180 insertions(+), 128 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/75/487475/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487475 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I803ee391ae15b38fda632b543c2188c524fb8a56 Gerrit-Change-Number: 487475 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Small updates to READDIR for V3 Proxy.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487474 ) Change subject: Small updates to READDIR for V3 Proxy. ...................................................................... Small updates to READDIR for V3 Proxy. In trying to debug why readdir is so slow in the cthon testsuite, I realized that (a) NFS Illustrated suggests respecting the dtpref parameter and (b) that I should probably LogDebug how many entries came back per READDIR (quite small! 24 at a time?). Change-Id: Ic3e7fa618223cab335c21ce733ab3ce0dcff8c64 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V3/proxyv3_fsal_methods.h 2 files changed, 66 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/74/487474/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487474 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic3e7fa618223cab335c21ce733ab3ce0dcff8c64 Gerrit-Change-Number: 487474 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Reply to close2 requests for NLM locks.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487473 ) Change subject: Reply to close2 requests for NLM locks. ...................................................................... Reply to close2 requests for NLM locks. The MDCACHE issues close2 requests with state, which I thought was for NFSv4 only (I missed the NLM lock state_type). Handle those "correctly" (replying with "not opened" like the file close) and warn otherwise. Change-Id: I4ffcdb478f2c5be05d48a3397715078a986da757 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/73/487473/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487473 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4ffcdb478f2c5be05d48a3397715078a986da757 Gerrit-Change-Number: 487473 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0