March 2020 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Respect config parameters for mount path and server.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487452 ) Change subject: Respect config parameters for mount path and server. ...................................................................... Respect config parameters for mount path and server. With this change, the proxy can now correctly be pointed at whatever server (including IPv6 in theory) and mount point you want. The main cleanups are in the socket parsing and creation code. No more kFilestoreHost! When pointed at my old filestore instance: $ sudo mount -vvv -t nfs -o proto=tcp,vers=3 192.168.1.2:/testy ${HOME}/proxy-mount $ ls proxy-mount/ lost+found proxyv3_ganesha.conf and now a different (expected) outcome by proxying the more built up knfsd: $ sudo mount -vvv -t nfs -o proto=tcp,vers=3 192.168.1.2:/testy ${HOME}/proxy-mount $ ls proxy-mount/ bytes-again.txt bytes-small.txt copied.txt new.txt subdir yo.txt bytes-copy.txt bytes.txt hello.txt nope.txt woohoo.txt Change-Id: I952554a190dbc82eb2d45b9b013086ed4843e60e Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V3/proxyv3_fsal_methods.h M src/FSAL/FSAL_PROXY_V3/rpc.c 3 files changed, 165 insertions(+), 45 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/52/487452/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487452 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I952554a190dbc82eb2d45b9b013086ed4843e60e Gerrit-Change-Number: 487452 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Implement commit and respect maxwrite/maxread.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487451 ) Change subject: Implement commit and respect maxwrite/maxread. ...................................................................... Implement commit and respect maxwrite/maxread. With COMMIT implemented, dd runs successfully: $ dd if=proxy-mount/bytes.txt of=proxy-mount/bytes-again.txt 7000+0 records in 7000+0 records out 3584000 bytes (3.6 MB, 3.4 MiB) copied, 0.748621 s, 4.8 MB/s but, I had to actually teach my FSAL to listen to the server about its capabilities via FSINFO. Turns out linux's knfsd seems to default to 512KB as maxread/maxwrite and will rudely close the socket rather than just doing a short write. Change-Id: I5622e29010a7ea226133f1dca0ffc0f1b4bd7f9c Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V3/rpc.c 2 files changed, 119 insertions(+), 11 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/51/487451/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487451 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5622e29010a7ea226133f1dca0ffc0f1b4bd7f9c Gerrit-Change-Number: 487451 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Implement write2!
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487450 ) Change subject: Implement write2! ...................................................................... Implement write2! $ echo "Bye bye" > proxy-mount/new.txt $ cat proxy-mount/new.txt Bye bye But, this isn't enough for a full dd, because we need COMMIT as well. Change-Id: Ie3df0cb32e402ca4535578bd1437726112ce619f Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V3/rpc.c 2 files changed, 100 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/50/487450/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487450 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie3df0cb32e402ca4535578bd1437726112ce619f Gerrit-Change-Number: 487450 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Implement CREATE3 / FSAL open2().
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487449 ) Change subject: Implement CREATE3 / FSAL open2(). ...................................................................... Implement CREATE3 / FSAL open2(). This is just enough to create a file, but not to do the follow-up write nor setattr. But I did successfully create a new empty file, and didn't segfault when trying to overwrite it. $ sudo mount -vvv -t nfs -o proto=tcp,vers=3 192.168.1.2:/testy ${HOME}/proxy-mount $ echo "Bye bye" > proxy-mount/nope.txt $ ls -l proxy-mount/ total 3516 -rw-r--r-- 1 boulos boulos 3584000 Mar 4 17:59 bytes.txt -rw-r--r-- 1 boulos boulos 16 Feb 15 00:15 hello.txt -rw-r--r-- 1 boulos boulos 0 Mar 4 22:58 nope.txt drwxr-xr-x 2 boulos boulos 4096 Feb 22 18:12 subdir -rw-r--r-- 1 boulos boulos 8 Feb 26 02:35 woohoo.txt -rw-r--r-- 1 boulos boulos 11 Feb 15 00:15 yo.txt Change-Id: If7df70d3426e7a6f5a5780b6d904dacb6748bbc6 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V3/proxyv3_fsal_methods.h M src/FSAL/FSAL_PROXY_V3/utils.c 3 files changed, 213 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/487449/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487449 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If7df70d3426e7a6f5a5780b6d904dacb6748bbc6 Gerrit-Change-Number: 487449 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Implement read!
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487448 ) Change subject: Implement read! ...................................................................... Implement read! On the server: $ dd if=/dev/urandom of=bytes.txt bs=512KB count=7 $ sha1sum bytes.txt 74cef82f324de11f714be420749b4eca8d46d1e9 bytes.txt and the client: $ sha1sum proxy-mount/bytes.txt 74cef82f324de11f714be420749b4eca8d46d1e9 proxy-mount/bytes.txt Found a couple things along the way: - First, nobody seems to implement hildebrand@'s READPLUS. - Second, Ganesha's "iovec"/readv() support seems inane. There's only a single offset, unlike readv(), so I don't see the point. Ganesha's NFSD won't ever generate a >1 length iovec either to the FSAL layer (seemingly), which is probably why the v4 Proxy FSAL just ignores this (but doesn't check). - Finally, my hardcoded 4KB buffer in rpc.c didn't cut it when attempting to read a bigger file. I still don't understand how you're supposed to allow xdrmem_create or whatever to do the right thing for you / allocate. Change-Id: I6aa2e69d6bc376cbbe4d2742ebcb62d51ac0ed21 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V3/rpc.c 2 files changed, 115 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/48/487448/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487448 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6aa2e69d6bc376cbbe4d2742ebcb62d51ac0ed21 Gerrit-Change-Number: 487448 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Implement readdir!
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487447 ) Change subject: Implement readdir! ...................................................................... Implement readdir! $ ls -l proxy-mount/ total 16 -rw-r--r-- 1 boulos boulos 16 Feb 15 00:15 hello.txt drwxr-xr-x 2 boulos boulos 4096 Feb 22 18:12 subdir -rw-r--r-- 1 boulos boulos 8 Feb 26 02:35 woohoo.txt -rw-r--r-- 1 boulos boulos 11 Feb 15 00:15 yo.txt There are a few "Uhh, how does Ganesha" handle this, as well as the "Oh, it crashes Ganesha if you emit the .. or . entries." that should be documented for implementors of readdir in FSALs, but otherwise, seems to work. Change-Id: I57b9843e5ef5bc2c83eca9fbb53ab30131210913 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c 1 file changed, 144 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/47/487447/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487447 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I57b9843e5ef5bc2c83eca9fbb53ab30131210913 Gerrit-Change-Number: 487447 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Add aggressive debugging for FSAL handle functions.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487446 ) Change subject: Add aggressive debugging for FSAL handle functions. ...................................................................... Add aggressive debugging for FSAL handle functions. I believe I was incorrectly handing out some garbage during one of the handle_to_wire / wire_to_host variants, perhaps as a result of the lookup function special case for "." and "..". It's unclear what we *should* be returning (the FSAL API isn't clear about lifetimes or ownership), but once I cleaned up the NFS client state (via umount -f) these didn't recur. Either way, no reason to be silent in the future. Change-Id: I63c7ee20809f07c827222785d73cca2f1fb03632 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V3/rpc.c 2 files changed, 76 insertions(+), 13 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/46/487446/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487446 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I63c7ee20809f07c827222785d73cca2f1fb03632 Gerrit-Change-Number: 487446 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Refactor GETATTR3 code for reuse by FSAL handlers.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487445 ) Change subject: Refactor GETATTR3 code for reuse by FSAL handlers. ...................................................................... Refactor GETATTR3 code for reuse by FSAL handlers. There were getting to be three or four places where I needed to issue a GETATTR3, so it makes sense to collapse them all to one helper. Particularly to keep dealing with the NFSv3 attributes checking and so on. Change-Id: Id670b8ac1786ca09c348f971df689e3c0590770d Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V3/proxyv3_fsal_methods.h M src/FSAL/FSAL_PROXY_V3/utils.c 3 files changed, 86 insertions(+), 51 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/45/487445/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487445 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id670b8ac1786ca09c348f971df689e3c0590770d Gerrit-Change-Number: 487445 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Make MDCACHE respect NFSv3 requests for handles.
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487444 ) Change subject: Make MDCACHE respect NFSv3 requests for handles. ...................................................................... Make MDCACHE respect NFSv3 requests for handles. The MDCACHE helper currently statically assumes it should ask for an NFSv4 digest/handle, but for NFSv3 clients (and our new NFSv3 proxy) we won't be making a v4 handle. Change-Id: Icdc19b73a07328bc4a45779225e38fd579cf2ed6 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/44/487444/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487444 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Icdc19b73a07328bc4a45779225e38fd579cf2ed6 Gerrit-Change-Number: 487444 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Implement just enough for MOUNT and stat!
by Solomon Boulos (GerritHub) 17 Mar '20

17 Mar '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487443 ) Change subject: Implement just enough for MOUNT and stat! ...................................................................... Implement just enough for MOUNT and stat! Adding a bunch of the "handle" (fh3 for this) processing functions as well as the basic GETATTR3 implementation. This revealed that attrmask_t has a clumsy additional ATTR_RDATTR_ERR bit to say "Hey, let me know if there was an error", so we have to handle both ATTRS_NFS3 *and* that one. Now our three hop proxy does a thing! ganesha-client => ganesha-proxy (192.168.1.2) => nfsd $ sudo mount -vvv -t nfs -o proto=tcp,vers=3 192.168.1.2:/testy ${HOME}/proxy-mount mount.nfs: timeout set for Wed Feb 26 02:24:26 2020 mount.nfs: trying text-based options 'proto=tcp,vers=3,addr=192.168.1.2' mount.nfs: prog 100003, trying vers=3, prot=6 mount.nfs: trying 192.168.1.2 prog 100003 vers 3 prot TCP port 2049 mount.nfs: prog 100005, trying vers=3, prot=6 mount.nfs: trying 192.168.1.2 prog 100005 vers 3 prot TCP port 39259 $ stat proxy-mount File: proxy-mount Size: 4096 Blocks: 8 IO Block: 16384 directory Device: 24h/36d Inode: 541030 Links: 3 Access: (0777/drwxrwxrwx) Uid: (65534/ nobody) Gid: (65534/ nogroup) Access: 2020-02-22 18:11:58.869840505 +0000 Modify: 2020-02-22 18:11:58.225797236 +0000 Change: 2020-02-22 18:11:58.225797236 +0000 Birth: - $ stat proxy-mount/yo.txt File: proxy-mount/yo.txt Size: 11 Blocks: 8 IO Block: 1048576 regular file Device: 24h/36d Inode: 541603 Links: 1 Access: (0644/-rw-r--r--) Uid: ( 1000/ boulos) Gid: ( 1001/ boulos) Access: 2020-02-15 00:15:29.184026702 +0000 Modify: 2020-02-15 00:15:29.184026702 +0000 Change: 2020-02-15 00:15:29.184026702 +0000 Birth: - and then I made woohoo.txt. $ stat proxy-mount/woohoo.txt File: proxy-mount/woohoo.txt Size: 8 Blocks: 8 IO Block: 1048576 regular file Device: 24h/36d Inode: 524289 Links: 1 Access: (0644/-rw-r--r--) Uid: ( 1000/ boulos) Gid: ( 1001/ boulos) Access: 2020-02-26 02:35:46.554340139 +0000 Modify: 2020-02-26 02:35:46.554340139 +0000 Change: 2020-02-26 02:35:46.554340139 +0000 Birth: - showing all the right times! Change-Id: I394d31f80166c632b0ec3af3a4190398f72d291b Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V3/rpc.c M src/FSAL/FSAL_PROXY_V3/utils.c 3 files changed, 233 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/43/487443/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487443 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I394d31f80166c632b0ec3af3a4190398f72d291b Gerrit-Change-Number: 487443 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0