June 2020 - Devel - Nfs Ganesha List Archives

Change in ...nfs-ganesha[next]: Fix shadow-utils requirement on SLES12

by Malahal (GerritHub)

Malahal has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496060 ) Change subject: Fix shadow-utils requirement on SLES12 ...................................................................... Fix shadow-utils requirement on SLES12 commit 58877b02576334e9f9b21b2dec881031db7db49c added shadow-utils as a requirement but SLES12 doesn't have such a package. It has package named "shadow" covering the same. Added /usr/sbin/useradd and /usr/sbin/groupadd binaries as they are really what we need. Change-Id: I2d9c95c342cc746b49843c90253f49fcaa7cc395 Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> --- M src/nfs-ganesha.spec-in.cmake M src/scripts/ganeshactl/CMakeLists.txt 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/60/496060/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496060 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2d9c95c342cc746b49843c90253f49fcaa7cc395 Gerrit-Change-Number: 496060 Gerrit-PatchSet: 1 Gerrit-Owner: Malahal <malahal(a)gmail.com> Gerrit-MessageType: newchange

4 years, 10 months

1
0
0 / 0

Announce Push of V4-dev.22

by Frank Filz

Branch next Tag:V4-dev.22 Merge Highlights * bugfix: Resolve compilation fail when acl/libacl.h was not found * Always set the wcc attributes in NFSv3 setattr replies * spec: add libacl-devel to CephFS BuildRequires * systemd: revised drop-in conf file handling * MDCACHE: add lru release entries process Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: efb9445 Frank S. Filz V4-dev.22 b91fe03 sepia-liu MDCACHE: add lru release entries process 0c0d143 Kaleb S. KEITHLEY systemd: revised drop-in conf file handling 8f01a5d Thomas Serlin spec: add libacl-devel to CephFS BuildRequires 23454db David Hedberg Always set the wcc attributes in NFSv3 setattr replies 8eda102 Luo Muyao bugfix: Resolve compilation fail when acl/libacl.h was not found

4 years, 10 months

1
0
0 / 0

should we make nfs-ganesha an optional part of a ceph build?

by Jeff Layton

(I sent this to a smaller list of folks yesterday, but I think it probably warrants wider discussion). Recently Varsha added the necessary infrastructure to bring up nfs-ganesha via vstart.sh. The current implementation requires that ganesha already be installed on the box (usually via distro packaging), but that poses a bit of a problem. A distro ganesha package will have likely been built vs. a completely different version of libcephfs and librados. Even if you build right off of ceph master branch, you won't get the benefit of any recent client bugfixes when you want to test ganesha. You'd have to build new ganesha packages, install them, etc. I think we ought to consider making a nfs-ganesha build an optional part of a ceph build (maybe enable it with cmake -DNFS_GANESHA=ON or something). It doesn't take very long to build it (typically only a minute or two on my box), and we could disable the parts that ceph doesn't care about (other FSALs primarily). We could also have vstart just error out when you run it with NFS=X on a build that didn't have ganesha enabled. OTOH, the potential downside here is that it'll likely add other build- time dependencies, and would require some extra cmake or scripting wizardry. Nothing insurmountable, but it might represent a maintenance burden going forward, particularly for something that's basically only going to be used for vstart. I'm also not sure how we'd do this in practice. I don't think you can do optional submodules, so we might have to look at other methods of pulling in the ganesha tree, or just live with it as a submodule that only gets used when ganesha is enabled. Thoughts? -- Jeff Layton <jlayton(a)redhat.com>

4 years, 10 months

6
10
0 / 0

Change in ...nfs-ganesha[next]: [GPFS] Fix to let GPFS upcall thread exit at ganesha startup

by Madhu Thorat (GerritHub)

Hello Malahal, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495993 to review the following change. Change subject: [GPFS] Fix to let GPFS upcall thread exit at ganesha startup ...................................................................... [GPFS] Fix to let GPFS upcall thread exit at ganesha startup Currently during startup if GPFSFSAL_UP_Thread() gets called, it waits in nfs_init_wait() for init to complete. But if during startup gpfs_unclaim_filesystem() gets called, then the main thread may hang at pthread_join() for GPFS upcall thread, if the thread is waiting in nfs_init_wait(). To avoid this made use of 'stop_thread' variable in 'struct gpfs_filesystem', which is set to 'true' prior to calling pthread_join() in gpfs_unclaim_filesystem(). Also made changes to allow to pass timeout value to nfs_init_wait() which is now called in GPFSFSAL_UP_Thread() in while(1) loop, and after nfs_init_wait() completes if gpfs_fs->stop_thread==true then we return. Change-Id: I8cdf193ce955cd7248104741927307974d8f0958 Signed-off-by: Madhu Thorat <madhu.punjabi(a)in.ibm.com> Reviewed-by: Malahal Naineni <malahal(a)us.ibm.com> --- M src/FSAL/FSAL_GPFS/export.c M src/FSAL/FSAL_GPFS/fsal_up.c M src/FSAL/FSAL_GPFS/gpfs_methods.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c M src/MainNFSD/nfs_init.c M src/include/nfs_init.h 6 files changed, 46 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/93/495993/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495993 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8cdf193ce955cd7248104741927307974d8f0958 Gerrit-Change-Number: 495993 Gerrit-PatchSet: 1 Gerrit-Owner: Madhu Thorat <madhu.punjabi(a)in.ibm.com> Gerrit-Reviewer: Malahal <malahal(a)gmail.com> Gerrit-MessageType: newchange

4 years, 10 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: systemd: revised drop-in conf file handling

by Kaleb KEITHLEY (GerritHub)

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495955 ) Change subject: systemd: revised drop-in conf file handling ...................................................................... systemd: revised drop-in conf file handling see https://bugzilla.redhat.com/show_bug.cgi?id=1848208 systemd service file documentation still sucks rocks This is my current best guess, and at least it doesn't log errors Change-Id: Iec9847356090e561bfcd5f41a64b35c2e686a3d6 Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> --- M src/scripts/systemd/nfs-ganesha-lock.service.debian10 M src/scripts/systemd/nfs-ganesha-lock.service.el8 M src/scripts/systemd/rpc-statd.conf.debian10 M src/scripts/systemd/rpc-statd.conf.el8 4 files changed, 6 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/55/495955/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495955 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iec9847356090e561bfcd5f41a64b35c2e686a3d6 Gerrit-Change-Number: 495955 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com> Gerrit-MessageType: newchange

4 years, 10 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: MDCACHE: root_obj must be released before last unexport

by sepia-liu (GerritHub)

sepia-liu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495911 ) Change subject: MDCACHE: root_obj must be released before last unexport ...................................................................... MDCACHE: root_obj must be released before last unexport root object must be released before last export is released. If last export of root_obj is released, just left root object handle in cache, once the export resource is used through root_obj->export, NULL pointer used cause to crash such as obj->export->cmount in deconstruct_handle() of FSAL_CEPH. So can not remove cih_remove_checked() in mdcache_unexport. Another case, if the object entry to be root of multiple exports, here should not unhash and set entry as invalid when the first export unmount, but unhash in last unexport. So we need to judge. Change-Id: I0068441f94b6185f3b072391edb8c5ec29ea60ca Signed-off-by: sepia-liu <liuwei_coder(a)163.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/11/495911/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495911 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0068441f94b6185f3b072391edb8c5ec29ea60ca Gerrit-Change-Number: 495911 Gerrit-PatchSet: 1 Gerrit-Owner: sepia-liu <liuwei_coder(a)163.com> Gerrit-MessageType: newchange

4 years, 10 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: copy back the correct attributes to not loose fs_locations. (fix issu...

by Name of user not set (GerritHub)

martin(a)uni-mainz.de has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495903 ) Change subject: copy back the correct attributes to not loose fs_locations. (fix issue 557) ...................................................................... copy back the correct attributes to not loose fs_locations. (fix issue 557) Signed-off-by: Christoph Martin <martin(a)uni-mainz.de> Change-Id: I2e7f02fcdb2c2ca1e9c2920b650fa2cfbbb974c2 --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/03/495903/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495903 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2e7f02fcdb2c2ca1e9c2920b650fa2cfbbb974c2 Gerrit-Change-Number: 495903 Gerrit-PatchSet: 1 Gerrit-Owner: martin(a)uni-mainz.de Gerrit-MessageType: newchange

4 years, 10 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: Always set the wcc attributes in NFSv3 setattr replies

by Name of user not set (GerritHub)

david.hedberg(a)zavann.se has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495849 ) Change subject: Always set the wcc attributes in NFSv3 setattr replies ...................................................................... Always set the wcc attributes in NFSv3 setattr replies A special case was added in 4a3af6df1b46075b80f33e43e3f19fd768e6c43a, as the wcc was set using attribute information that could be incomplete if only the file size was modified. In this case, the reply would be marked as containing no wcc data at all. The attribute information for the wcc is now fetched using getattr calls to the FSAL layer and the check should no longer be needed. Signed-off-by: David Hedberg <david.hedberg(a)zavann.se> Change-Id: If8584d1b0ddb27ca200af9e85cf2ff11c2d28c2a --- M src/Protocols/NFS/nfs3_setattr.c 1 file changed, 3 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/495849/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495849 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If8584d1b0ddb27ca200af9e85cf2ff11c2d28c2a Gerrit-Change-Number: 495849 Gerrit-PatchSet: 1 Gerrit-Owner: david.hedberg(a)zavann.se Gerrit-MessageType: newchange

4 years, 10 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: bugfix: Resolve compilation fail when acl/libacl.h was not found

by MuYao Luo (GerritHub)

MuYao Luo has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495840 ) Change subject: bugfix: Resolve compilation fail when acl/libacl.h was not found ...................................................................... bugfix: Resolve compilation fail when acl/libacl.h was not found acl/libacl.h is included by posix_acls.h which is out of USE_NFSACL3 condition judgment, We should include it in this conditional statement to prevent compilation errors. Change-Id: Id1f0417f40ab635d94a51bc106b936e7b4c6f715 Signed-off-by: Luo Muyao <luo.muyao(a)zte.com.cn> --- M src/include/nfs_proto_tools.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/40/495840/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495840 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id1f0417f40ab635d94a51bc106b936e7b4c6f715 Gerrit-Change-Number: 495840 Gerrit-PatchSet: 1 Gerrit-Owner: MuYao Luo <luo.muyao(a)zte.com.cn> Gerrit-MessageType: newchange

4 years, 10 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: spec: add libacl-devel to CephFS BuildRequires

by Name of user not set (GerritHub)

Hello Daniel Gryniewicz, Kaleb KEITHLEY, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495827 to review the following change. Change subject: spec: add libacl-devel to CephFS BuildRequires ...................................................................... spec: add libacl-devel to CephFS BuildRequires Saw build failures on latest V4-dev.21: https://jenkins.ceph.com/job/nfs-ganesha/1297/ARCH=x86_64,AVAILABLE_ARCH=... https://jenkins.ceph.com/job/nfs-ganesha/1297/ARCH=x86_64,AVAILABLE_ARCH=... The libacl-devel package is available in the base repos for both CentOS 7/8. Change-Id: Iabeb2ae6e4ef6863e1d25c25614b9ae7c9460500 Signed-off-by: Thomas Serlin <tserlin(a)redhat.com> --- M src/nfs-ganesha.spec-in.cmake 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/27/495827/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495827 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iabeb2ae6e4ef6863e1d25c25614b9ae7c9460500 Gerrit-Change-Number: 495827 Gerrit-PatchSet: 1 Gerrit-Owner: tserlin(a)redhat.com Gerrit-Reviewer: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-Reviewer: Kaleb KEITHLEY <kaleb(a)redhat.com> Gerrit-MessageType: newchange

4 years, 10 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

Devel June 2020