June 2020 - Devel - NFS Ganesha List Archives

Agile Practices
by Frank Filz 15 Jun '20

15 Jun '20

Several of us from Red Hat (Daniel, Kaleb, Matt, and I) recently took some agile training. We would like to use some of that in improving how we manage development priorities and response to issues. Our training presented two methodologies, Scrum and Kanban. We generally preferred Kanban and would like to open a community discussion. We will take some time on the community call tomorrow. In the meantime, I started exploring how we could use github to help manage, and realized the "projects" that Supriti introduced us to a couple years ago are Kanban boards. Playing around, it's real easy to manage the backlog and moving cards through to completion, and additionally, issues can be turned into cards, or issues created from cards. The way I see this working: Cards can be used to manage the backlog and show progress on items (if an issue is also a card, the column it's in shows in the issue making it easy to cross reference). Issues are easy for outsiders to raise issues, they also provide a comment stream for discussion (non-issue cards can be edited, but that's not a good way to keep a conversation). Issues also provide labels which we can use to indicate priority or follow a github suggestion of labelling "good for beginners" issues. Issues can also be assigned to individuals (though I think you need to be added to the nfs-ganesha project to be assigned issues). I'd love it if there was integration with gerrithub, but I haven't found any yet, but we can certainly cross link between issues and gerrithib patches. Given gerrithub's management of multiple versions of patches and making the entire comment history easily available, I prefer to use gerrithub for patch submission even though github pull requests CAN be integrated with the Kanban project. I've created a Ganesha 4 project, though I'm not sure we want to necessarily have a project per release, maybe just a single project. Also, I'm not sure if we can link the project to the ntirpc repo also, or if we need to have a separate project for it (or just use soft links, but since ntirpc DOES use github pull requests, it would be nice to have that integration into the Kanban project. Please take some time to play around before tomorrow's meeting. Feel free to create a card for something you're working on, and possibly turning it into an issue, and play around with linking an issue you're commenting on to the project. Let us know what you think of this idea. Thanks Frank

1 0

libntirpc question
by Becker, Jeffrey C. (ARC-TN)[InuTeq, LLC] 15 Jun '20

15 Jun '20

Hi, In libntirpc/ntirpc/rpc/svc.h, we see… /* * Approved way of getting addresses */ #define svc_getcaller_netbuf(x) (&(x)->xp_remote.nb) #define svc_getlocal_netbuf(x) (&(x)->xp_local.nb) #define svc_getrpccaller(x) (&(x)->xp_remote.ss) #define svc_getrpclocal(x) (&(x)->xp_local.ss) I assume these return addresses in network order, and ntohl should be used to convert these to host order. Is that correct? Thanks. -Jeff

2 1

Announce Push of V4-dev.21
by Frank Filz 11 Jun '20

11 Jun '20

Branch next Tag:V4-dev.21 Merge Highlights * Fix warn and error reported by Jenkins * MDCACHE: remove call of cih_remove_checked in mdcache_unexport * MDCACHE: adjust export root object from LRU to MRU * CEPHFS - remove bad MDCACHE config from sample Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 0b3b701 Frank S. Filz V4-dev.21 e4348f0 Daniel Gryniewicz CEPHFS - remove bad MDCACHE config from sample 6e25459 sepia-liu MDCACHE: adjust export root object from LRU to MRU 0693097 sepia-liu MDCACHE: remove call of cih_remove_checked in mdcache_unexport 8ba3ebd Xi Jinyu Fix warn and error reported by Jenkins.

1 0

Ganesha core ins svc_auth_gss
by Sriram Patil 11 Jun '20

11 Jun '20

Hi, I saw a ganesha core for krb5p mounts. This happened when ganesha failed over/restarted and the client was reconnecting. The server received some RPCSEC_GSS_DATA requests which will fail because the GSS context is not available. But one of such request resulted in following core, #0 0x00007fbb1ef8903c in rbtree_x_cached_lookup (xt=0x7fbb1f1a0d48 <authgss_hash_st+40>, t=0x7fbaf0001680, nk=0x7fbb14468e80, hk=3355459200) at /build/mts/release/bora-16305188/cayman_nfs-ganesha/nfs-ganesha/src/src/libntirpc/ntirpc/misc/rbtree_x.h:65 #1 0x00007fbb1ef897e7 in authgss_ctx_hash_get (gc=0x7fbad80012a8) at /build/mts/release/bora-16305188/cayman_nfs-ganesha/nfs-ganesha/src/src/libntirpc/src/authgss_hash.c:159 #2 0x00007fbb1ef8c368 in _svcauth_gss (req=0x7fbad8000d40, no_dispatch=0x7fbb1446917f) at /build/mts/release/bora-16305188/cayman_nfs-ganesha/nfs-ganesha/src/src/libntirpc/src/svc_auth_gss.c:450 #3 0x00007fbb1ef78fee in svc_auth_authenticate (req=0x7fbad8000d40, no_dispatch=0x7fbb1446917f) at /build/mts/release/bora-16305188/cayman_nfs-ganesha/nfs-ganesha/src/src/libntirpc/src/svc_auth.c:98 #4 0x0000000000456116 in nfs_rpc_process_request (reqdata=0x7fbad8000d40) at /build/mts/release/bora-16305188/cayman_nfs-ganesha/nfs-ganesha/src/src/MainNFSD/nfs_worker_thread.c:724 #5 0x00000000004588c9 in nfs_rpc_valid_NFS (req=0x7fbad8000d40) at /build/mts/release/bora-16305188/cayman_nfs-ganesha/nfs-ganesha/src/src/MainNFSD/nfs_worker_thread.c:1538 #6 0x00007fbb1ef81752 in svc_vc_decode (req=0x7fbad8000d40) at /build/mts/release/bora-16305188/cayman_nfs-ganesha/nfs-ganesha/src/src/libntirpc/src/svc_vc.c:827 #7 0x000000000044b333 in nfs_rpc_decode_request (xprt=0x7fbb08000a90, xdrs=0x7fbad8000a90) at /build/mts/release/bora-16305188/cayman_nfs-ganesha/nfs-ganesha/src/src/MainNFSD/nfs_rpc_dispatcher_thread.c:1345 #8 0x00007fbb1ef81663 in svc_vc_recv (xprt=0x7fbb08000a90) at /build/mts/release/bora-16305188/cayman_nfs-ganesha/nfs-ganesha/src/src/libntirpc/src/svc_vc.c:800 #9 0x00007fbb1ef7ddb1 in svc_rqst_xprt_task (wpe=0x7fbb08000ca8) at /build/mts/release/bora-16305188/cayman_nfs-ganesha/nfs-ganesha/src/src/libntirpc/src/svc_rqst.c:769 #10 0x00007fbb1ef7e20e in svc_rqst_epoll_events (sr_rec=0xcf09f0, n_events=1) at /build/mts/release/bora-16305188/cayman_nfs-ganesha/nfs-ganesha/src/src/libntirpc/src/svc_rqst.c:941 #11 0x00007fbb1ef7e4a3 in svc_rqst_epoll_loop (sr_rec=0xcf09f0) at /build/mts/release/bora-16305188/cayman_nfs-ganesha/nfs-ganesha/src/src/libntirpc/src/svc_rqst.c:1014 #12 0x00007fbb1ef7e556 in svc_rqst_run_task (wpe=0xcf09f0) at /build/mts/release/bora-16305188/cayman_nfs-ganesha/nfs-ganesha/src/src/libntirpc/src/svc_rqst.c:1050 #13 0x00007fbb1ef86ef6 in work_pool_thread (arg=0x7fbae80008c0) at /build/mts/release/bora-16305188/cayman_nfs-ganesha/nfs-ganesha/src/src/libntirpc/src/work_pool.c:181 #14 0x00007fbb1db333d4 in start_thread (arg=0x7fbb1446a700) at pthread_create.c:334 #15 0x00007fbb1d452ebd in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109 I am using ntirpc 1.7.2. I see that there are multiple changes around GSS authentication after 1.7.2 as follows, cf01e379 _svcauth_gss - Clean up gss_data handling c99acef0 Do not use macro "svcauth_gss_return" e42d079a Fix memory leak for RPCSEC_GSS And probably some more. Any of these changes were related to above core pattern? Thanks, Sriram

2 1

Change in ...nfs-ganesha[next]: malloc() call changed to gsh_malloc()
by Trishali Nayar (GerritHub) 09 Jun '20

09 Jun '20

Trishali Nayar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495301 ) Change subject: malloc() call changed to gsh_malloc() ...................................................................... malloc() call changed to gsh_malloc() Change-Id: Ie63881b34913192d687a2f9351d42553a3d3f460 Signed-off-by: Trishali Nayar <ntrishal(a)in.ibm.com> --- M src/idmapper/idmapper_cache.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/01/495301/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495301 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie63881b34913192d687a2f9351d42553a3d3f460 Gerrit-Change-Number: 495301 Gerrit-PatchSet: 1 Gerrit-Owner: Trishali Nayar <ntrishal(a)in.ibm.com> Gerrit-MessageType: newchange

1 0

Ganesha / libntirpc 3.3
by Daniel Gryniewicz 08 Jun '20

08 Jun '20

We're happy to announce Ganesha and libntirpc versions 3.3. These are bug-fix updates to the stable V3 branches of the code. There are many bug fixes, and it's highly recommended that users update to these versions if possible. Daniel

1 0

ACL's on 4.1
by Trishali Nayar 08 Jun '20

08 Jun '20

Hi all, We were looking at the 4.1 RFC and found that there are some additional 'Access_mask' and 'Ace-flag' when compared to 4.0. - Access_mask: ACE4_WRITE_RETENTION ( Do see these in Linux src code as NFS4_ACE_WRITE_RETENTION, NFS4_ACE_WRITE_RETENTION_HOLD ACE4_WRITE_RETENTION_HOLD and in our ganesha code as ACE4_WRITE_RETENTION, ACE4_WRITE_RETENTION_HOLD) - Ace-flag : ACE4_INHERITED_ACE (Do see this in Linux src code as NFS4_ACE_INHERITED_ACE. and in our ganesha code as ACE4_FLAG_INHERITED in the GPFS FSAL header file ) But are these supported by 4.1 clients/servers? If you do man nfs4_acl it does not seem to show these additional ones. Are there any differences from an ACL perspective between 4.0 and 4.1, that anyone is aware of? Or even any difference between kNFS and Ganesha on this front? Your insights will be useful for us. Thanks and regards, Trishali. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Trishali Nayar IBM Systems ETZ, Pune. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

1 0

Change in ...nfs-ganesha[next]: CEPHFS - remove bad MDCACHE config from sample
by Daniel Gryniewicz (GerritHub) 08 Jun '20

08 Jun '20

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495185 ) Change subject: CEPHFS - remove bad MDCACHE config from sample ...................................................................... CEPHFS - remove bad MDCACHE config from sample nparts and cache_size are not related to metadata caching at all, but are related to the handle cache, which all FSALs need. Setting them to extremely small will destroy performance. Change-Id: Ib0722c5228c817295fae42daeff1f69de48af08d Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/config_samples/ceph.conf 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/85/495185/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495185 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib0722c5228c817295fae42daeff1f69de48af08d Gerrit-Change-Number: 495185 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: MDCACHE: remove call of cih_remove_checked in mdcache_unexport
by sepia-liu (GerritHub) 08 Jun '20

08 Jun '20

sepia-liu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495180 ) Change subject: MDCACHE: remove call of cih_remove_checked in mdcache_unexport ...................................................................... MDCACHE: remove call of cih_remove_checked in mdcache_unexport We do not need to unhash the root entry in mdcache_unexport, it was unhasded by mdcache_lru_cleanup_try_push in the loop if the object entry is junction node and not used by other export. It's not used here. Another case, if the object entry to be root of multiple exports, here should not unhash and set entry as invalid when the first export unmount. Until the last export is released, the entry holds the sentinel reference for recycling and releasing. Change-Id: Ie15ea032e78c4476bede191e8edcf1619cda4686 Signed-off-by: sepia-liu <liuwei_coder(a)163.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/80/495180/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495180 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie15ea032e78c4476bede191e8edcf1619cda4686 Gerrit-Change-Number: 495180 Gerrit-PatchSet: 1 Gerrit-Owner: sepia-liu <liuwei_coder(a)163.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Fix warn and error reported by Jenkins.
by xijinyu (GerritHub) 07 Jun '20

07 Jun '20

xijinyu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495127 ) Change subject: Fix warn and error reported by Jenkins. ...................................................................... Fix warn and error reported by Jenkins. From: https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/494913 src/support/server_stats.c Line 2343 WARNING: Missing a blank line after declarations + struct gsh_stats gsh_st = export_st->st; + if (gsh_st.nfsv3 != NULL) { Line 2432 ERROR: "(foo*)" should be "(foo *)" + op_preread = (struct xfer_op*)gsh_calloc(1, sizeof(struct xfer_op)); Line 2433 ERROR: "(foo*)" should be "(foo *)" + op_prewrite = (struct xfer_op*)gsh_calloc(1, sizeof(struct xfer_op)); Line 2434 ERROR: "(foo*)" should be "(foo *)" + op_read = (struct xfer_op*)gsh_calloc(1, sizeof(struct xfer_op)); Line 2435 ERROR: "(foo*)" should be "(foo *)" + op_write = (struct xfer_op*)gsh_calloc(1, sizeof(struct xfer_op)); Signed-off-by: Xi Jinyu <xijinyu(a)cmss.chinamobile.com> Change-Id: Icfd7c1e8de5fc9006beac617fb6abad98208f204 --- M src/support/server_stats.c 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/27/495127/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/495127 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Icfd7c1e8de5fc9006beac617fb6abad98208f204 Gerrit-Change-Number: 495127 Gerrit-PatchSet: 1 Gerrit-Owner: xijinyu <xijinyu(a)cmss.chinamobile.com> Gerrit-MessageType: newchange

1 0