Change in ...nfs-ganesha[next]: RQUOTA: use the op_context from nfs_request_t
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496238 )
Change subject: RQUOTA: use the op_context from nfs_request_t
......................................................................
RQUOTA: use the op_context from nfs_request_t
Every Ganesha RPC request has an op_context in the nfs_request_t, there
is no need to create an additional one in the RQUOTA procedures.
Change-Id: Ib281a3910bc434a25a51aa6ad373082410a3e23d
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/Protocols/RQUOTA/rquota_getquota.c
M src/Protocols/RQUOTA/rquota_setquota.c
2 files changed, 12 insertions(+), 22 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/38/496238/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496238
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ib281a3910bc434a25a51aa6ad373082410a3e23d
Gerrit-Change-Number: 496238
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
Gerrit-MessageType: newchange
4 years, 6 months
Change in ...nfs-ganesha[next]: Cleanup export refcounting for exports that are only config objects
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496237 )
Change subject: Cleanup export refcounting for exports that are only config objects
......................................................................
Cleanup export refcounting for exports that are only config objects
Until an export is committed during config, it isn't fully instantiated,
and in fact, on an update, a 2nd copy of the export is manifested that
is only used during the config process. Make sure that on releasing
an export that never was committed that we skip some of the cleanup.
This will also assure that the reference counting is correct.
Change-Id: Ica339fddabe702c344cb69ce472b91421447ffed
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/include/export_mgr.h
M src/include/nfs_exports.h
M src/support/export_mgr.c
M src/support/exports.c
4 files changed, 83 insertions(+), 33 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/37/496237/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496237
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ica339fddabe702c344cb69ce472b91421447ffed
Gerrit-Change-Number: 496237
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
Gerrit-MessageType: newchange
4 years, 6 months
Change in ...nfs-ganesha[next]: Add clarification about removal of cih_remove_checked call in 0693097d6
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496236 )
Change subject: Add clarification about removal of cih_remove_checked call in 0693097d6
......................................................................
Add clarification about removal of cih_remove_checked call in 0693097d6
In commit 0693097d61f33d9c8d2bd49b89d448c4f804dd0d a call to
cih_remove_checked was removed. This patch documents in comments why
that call is not necessary.
The call was not necessary because the loop that is unmapping entries
and exports will unmap the export root, and if the export root no
longer belongs to any export, it will be unhashed inside the loop.
The unhash outside the loop did nothing for export roots that only
belonged to one export, but any that belonged to two exports would
get incorrectly unhashed if one of those two exports was removed.
Change-Id: Ic596b516be0dcf7804b9ac5a1ef0976e282e6fb9
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c
M src/Protocols/NLM/nlm_util.c
2 files changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/36/496236/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496236
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ic596b516be0dcf7804b9ac5a1ef0976e282e6fb9
Gerrit-Change-Number: 496236
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
Gerrit-MessageType: newchange
4 years, 6 months
Change in ...nfs-ganesha[next]: Add some debug for working with exports
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496235 )
Change subject: Add some debug for working with exports
......................................................................
Add some debug for working with exports
Change-Id: I87b7126e5725c84644a2a3aa47a4831b3004ee03
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/FSAL/FSAL_VFS/export.c
M src/FSAL/FSAL_VFS/handle.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_hash.h
M src/FSAL/commonlib.c
M src/support/refstr.c
6 files changed, 40 insertions(+), 10 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/35/496235/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496235
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I87b7126e5725c84644a2a3aa47a4831b3004ee03
Gerrit-Change-Number: 496235
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
Gerrit-MessageType: newchange
4 years, 6 months
Change in ...nfs-ganesha[next]: Fix ACL refcount leak
by Malahal (GerritHub)
Malahal has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496199 )
Change subject: Fix ACL refcount leak
......................................................................
Fix ACL refcount leak
mdcache_is_referral() takes attrs parameter. This is probably to aid
in detecting an object has a referral or not, and the caller doesn't
care to release the passed in attr. mdcache_is_referral() fills in
attrs with ACL by calling fsal_copy_attrs() and no one releases such
an ACL ref.
mdcache_is_referral() doesn't need attrs parameter as it is the
custodian of attribute cache but sub-FSALs may need it. Made it as
unused parameter for mdcache_is_referral().
Also...
mdcache_readdir_chunked() calls populate_dirent (via cb()) with
'entry->attrs' without holding any lock. populate_dirent() calls
nfs4_readdir_callback(via state->cb) which inturn calls
mdcache_is_referral() which may call fsal_common_is_referral() which
could change attributes and the acl pointer without holding any lock!
Change-Id: I4f15acbcd4b2c0bb049f19c29346d4248085df20
Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com>
---
M src/FSAL/FSAL_GPFS/fsal_convert.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c
M src/include/fsal.h
4 files changed, 11 insertions(+), 3 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/99/496199/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496199
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I4f15acbcd4b2c0bb049f19c29346d4248085df20
Gerrit-Change-Number: 496199
Gerrit-PatchSet: 1
Gerrit-Owner: Malahal <malahal(a)gmail.com>
Gerrit-MessageType: newchange
4 years, 6 months
Change in ...nfs-ganesha[next]: FSAL_CEPH: endian-convert wire handles
by Jeff Layton (GerritHub)
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496146 )
Change subject: FSAL_CEPH: endian-convert wire handles
......................................................................
FSAL_CEPH: endian-convert wire handles
The wire handle is just treated as opaque now, which means we'll end up
with different filehandles on BE and LE arches. Most of the deployments
in the field currently are LE, so settle on the fields in there being
represented as LE values so we don't change the FH unnecessarily.
Change-Id: I646c7fc3835d0602d22644e4967d458909fc816c
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/FSAL/FSAL_CEPH/export.c
M src/FSAL/FSAL_CEPH/handle.c
2 files changed, 25 insertions(+), 4 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/46/496146/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496146
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I646c7fc3835d0602d22644e4967d458909fc816c
Gerrit-Change-Number: 496146
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
Gerrit-MessageType: newchange
4 years, 6 months
Change in ...nfs-ganesha[next]: FSAL_CEPH: break up vinodeno_t in wire handle portion
by Jeff Layton (GerritHub)
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496145 )
Change subject: FSAL_CEPH: break up vinodeno_t in wire handle portion
......................................................................
FSAL_CEPH: break up vinodeno_t in wire handle portion
The filehandle itself is packed, but the vinodeno_t struct embedded
in it won't necessarily be. In practice, all the arches we care about
won't add padding to vinodeno_t, but we shouldn't assume that. Replace
the chk_vi field with separate chk_ino and chk_snap fields.
Change-Id: If6242accf9fa2c09454956323b34d5066a30d867
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/FSAL/FSAL_CEPH/export.c
M src/FSAL/FSAL_CEPH/internal.c
M src/FSAL/FSAL_CEPH/internal.h
M src/FSAL/FSAL_CEPH/main.c
4 files changed, 14 insertions(+), 9 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/45/496145/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496145
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: If6242accf9fa2c09454956323b34d5066a30d867
Gerrit-Change-Number: 496145
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
Gerrit-MessageType: newchange
4 years, 6 months
Change in ...nfs-ganesha[next]: FSAL_CEPH: track export id as part of the host handle
by Jeff Layton (GerritHub)
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496144 )
Change subject: FSAL_CEPH: track export id as part of the host handle
......................................................................
FSAL_CEPH: track export id as part of the host handle
Typically, ganesha mixes the export_id in with the filehandle before
presenting it to clients, but then strips that out before converting it
to a host handle.
When a handle is reachable via two or more different exports, most FSALs
just keep a single cache entry for it. For FSAL_CEPH, we need to keep
them separate, as the different exports may use different cephx creds.
Add an export_id field to the host handle, and fill out the field from
the op_ctx when converting it from the wire handle. This leaves the
wire handle unchanged, but allows us to keep different cache entries
when the same inode shows up in different exports.
Change-Id: I6426a367061b880ee61c19586f4f54a3bc55ef0a
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/FSAL/FSAL_CEPH/export.c
M src/FSAL/FSAL_CEPH/handle.c
M src/FSAL/FSAL_CEPH/internal.c
M src/FSAL/FSAL_CEPH/internal.h
M src/FSAL/FSAL_CEPH/main.c
5 files changed, 21 insertions(+), 13 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/44/496144/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496144
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I6426a367061b880ee61c19586f4f54a3bc55ef0a
Gerrit-Change-Number: 496144
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
Gerrit-MessageType: newchange
4 years, 6 months
Change in ...nfs-ganesha[next]: NFS: add an on-stack buffer for wire_to_host conversions
by Jeff Layton (GerritHub)
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496143 )
Change subject: NFS: add an on-stack buffer for wire_to_host conversions
......................................................................
NFS: add an on-stack buffer for wire_to_host conversions
Currently, the callers just overwrite the wire handle with the converted
host handle. Overwriting the wire handle like that is somewhat nasty,
but it's also problematic if the host handle is larger than the
wire handle (as will soon be the case for FSAL_CEPH).
Copy the handle into an on-stack buffer first before calling
wire_to_host. Here we assume that the host handle will never be larger
than the max filehandle size for the protocol.
Change-Id: I71791be0c93d5a866da15e50973d1281a0e1ffa2
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/Protocols/NFS/nfs4_op_putfh.c
M src/support/nfs_filehandle_mgmt.c
2 files changed, 18 insertions(+), 3 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/43/496143/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496143
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I71791be0c93d5a866da15e50973d1281a0e1ffa2
Gerrit-Change-Number: 496143
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
Gerrit-MessageType: newchange
4 years, 6 months
Change in ...nfs-ganesha[next]: FSAL_CEPH: call fsal_attach_export last
by Jeff Layton (GerritHub)
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496142 )
Change subject: FSAL_CEPH: call fsal_attach_export last
......................................................................
FSAL_CEPH: call fsal_attach_export last
create_export doesn't call fsal_detach_export when it encounters an
error. We could fix this by calling fsal_detach_export in that
situation, but I see no reason to attach the thing to the fsal before
we've finished creating it. Move it to the end.
Change-Id: I2f992d7b22838c1bd1b5e791ba6766858c992825
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/FSAL/FSAL_CEPH/main.c
1 file changed, 8 insertions(+), 9 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/42/496142/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496142
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I2f992d7b22838c1bd1b5e791ba6766858c992825
Gerrit-Change-Number: 496142
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
Gerrit-MessageType: newchange
4 years, 6 months