December 2021 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: DRC: Better handle duplicate requests while a request is in progress
by Frank Filz (GerritHub) 07 Dec '21

07 Dec '21

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/528935 ) Change subject: DRC: Better handle duplicate requests while a request is in progress ...................................................................... DRC: Better handle duplicate requests while a request is in progress The old code would drop any duplicate request while the original request was still in progress, assuming that the response would be sent. Unfortunately, if a TCP connection is broken while the request is in progress, sending the response fails. The client never retries and gets stuck. Now when this occurs, we queue up the request and suspend it (utlizing the async infrastructure). When the original request processing completes and calls nfs_dupreq_finish() we track if there was an error sending the response. If so, we don't mark the DRC entry as complete and instead resume the first retry to attempt to send the response. That resumed retry will call nfs_dupreq_finish() after it tries to send the response, so if there is a queue of retries, there are more opportunities to re-send a failed response. The same retry logic is followed when nfs_dupreq_delete() is called if there are again queued duplicate requests, however, those retries instead are re-submitted for a new attempt to process. This logic occurs when there is an NFS_DROP result from a retryable error or an auth error. Once the request is succesfully completed, any additional queued requests are dropped. We limit the queue to 3 duplicates. That should be more than enough to get through an issue like this unless the server has severely stalled out on the original request. Change-Id: Ia1d207aefdddb6845987856c9f1073b2f7167e94 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/MainNFSD/nfs_worker_thread.c M src/RPCAL/nfs_dupreq.c M src/include/nfs_dupreq.h M src/include/nfs_proto_data.h M src/include/nfs_proto_functions.h 6 files changed, 372 insertions(+), 159 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/35/528935/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/528935 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia1d207aefdddb6845987856c9f1073b2f7167e94 Gerrit-Change-Number: 528935 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: On resume_op_context call SetClientIP
by Frank Filz (GerritHub) 07 Dec '21

07 Dec '21

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/528934 ) Change subject: On resume_op_context call SetClientIP ...................................................................... On resume_op_context call SetClientIP Set thread local variable for logging when an async request is resumed. Change-Id: I210da718b62d4735759a1a7f175ee9ee9de2c595 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/commonlib.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/528934/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/528934 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I210da718b62d4735759a1a7f175ee9ee9de2c595 Gerrit-Change-Number: 528934 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Announce Push of V4-rc5
by Frank Filz 03 Dec '21

03 Dec '21

Branch next Tag:V4-rc5 NOTE: This merge includes an ntirpc pull up. Please update your submodule Ganesha V4.0 is in sight! Merge Highlights * Set major fsid correctly for NFSv3. * Added support for NFSv3 file handle to work with NFSv4 mount * ntirpc 4.0rc2 pullup Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: e2e8c3e97 Frank S. Filz V4-rc5 f8978f29a Daniel Gryniewicz ntirpc 4.0rc2 pullup 0ef3bb414 Yogendra Charya Added support for NFSv3 file handle to work with NFSv4 mount 4eec0e1ae Bjorn Leffler Set major fsid correctly for NFSv3.

1 0

Change in ...nfs-ganesha[next]: selinux: non-fatal yum install error of nfs-ganesha
by Kaleb KEITHLEY (GerritHub) 02 Dec '21

02 Dec '21

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/528685 ) Change subject: selinux: non-fatal yum install error of nfs-ganesha ...................................................................... selinux: non-fatal yum install error of nfs-ganesha use ceph and glusterd interface definitions and conditionals to avoid (seemingly non-fatal?) errors when installing nfs-ganesha-selinux on top of ceph-selinux or glusterfs-selinux Change-Id: I35c1545cc8d4ba6ba29a74c28d61950d3ffb67fe Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> --- M src/selinux/ganesha.te 1 file changed, 41 insertions(+), 29 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/85/528685/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/528685 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I35c1545cc8d4ba6ba29a74c28d61950d3ffb67fe Gerrit-Change-Number: 528685 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: ntirpc 4.0rc2 pullup
by Daniel Gryniewicz (GerritHub) 01 Dec '21

01 Dec '21

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/528597 ) Change subject: ntirpc 4.0rc2 pullup ...................................................................... ntirpc 4.0rc2 pullup Change-Id: Id5c075d606c9e4f909eaa0a2fe2a0c81ea30323e Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/libntirpc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/528597/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/528597 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id5c075d606c9e4f909eaa0a2fe2a0c81ea30323e Gerrit-Change-Number: 528597 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

1 0