June 2021 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Use the st_[amc]tim field names on all OS targets
by Matthew DeVore (GerritHub) 16 Jun '21

16 Jun '21

Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519053 ) Change subject: Use the st_[amc]tim field names on all OS targets ...................................................................... Use the st_[amc]tim field names on all OS targets Out of macOS, FreeBSD, and Linux, only macOS seems to be missing the st_[amc]tim field names. I confirmed this on FreeBSD by checking the /usr/include/sys/stat.h file on a FreeBSD 13 system. In that file, two structs unconditionally included st_[amc]tim field names: 'struct stat' and freebsd11_stat. st_[amc]timespec are defined as aliases to st_[amc]tim. This allows some code in src/FSAL/commonlib.c which accesses these fields to compile on macOS. Change-Id: Ia1084f6caff4435d8796b3ce79c3f7361151a4b6 Signed-off-by: Matthew DeVore <matvore(a)google.com> --- M src/FSAL/fsal_convert.c M src/include/common_utils.h 2 files changed, 10 insertions(+), 20 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/53/519053/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519053 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia1084f6caff4435d8796b3ce79c3f7361151a4b6 Gerrit-Change-Number: 519053 Gerrit-PatchSet: 1 Gerrit-Owner: Matthew DeVore <matvore(a)comcast.net> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Define TCP_KEEPIDLE on OS that uses another name
by Matthew DeVore (GerritHub) 16 Jun '21

16 Jun '21

Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519052 ) Change subject: Define TCP_KEEPIDLE on OS that uses another name ...................................................................... Define TCP_KEEPIDLE on OS that uses another name FreeBSD actually has both TCP_KEEPIDLE and TCPCTL_KEEPIDLE and they appear to have similar meanings, though are defined to separate numbers. macOS and Linux only have one or the other. Change-Id: Ib884273bd2b7bba61861d6ad9066b6f797d4cc17 Signed-off-by: Matthew DeVore <matvore(a)google.com> --- M src/MainNFSD/nfs_rpc_dispatcher_thread.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/52/519052/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519052 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib884273bd2b7bba61861d6ad9066b6f797d4cc17 Gerrit-Change-Number: 519052 Gerrit-PatchSet: 1 Gerrit-Owner: Matthew DeVore <matvore(a)comcast.net> Gerrit-MessageType: newchange

1 0

ntirpc v3.5
by Daniel Gryniewicz 15 Jun '21

15 Jun '21

Announcing ntirpc v3.5. This stable release contains 3 commits, the most important of which fixes READDIR for UDP connections. Commits are: 1c6127b8 Add xdr_putbufs to xdrmem fef3758c Fix short UDP handling e8711ece Don't release on resume Daniel

1 0

Change in ...nfs-ganesha[next]: Add liburcu include path to compiler invocations
by Matthew DeVore (GerritHub) 14 Jun '21

14 Jun '21

Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/518912 ) Change subject: Add liburcu include path to compiler invocations ...................................................................... Add liburcu include path to compiler invocations This is required for macOS and FreeBSD builds, or any system where the liburcu package uses a directory other than the main system include path. Change-Id: I0502b0f9cb511d43a1f5b4b6bc9ffc3604f123fb Signed-off-by: Matthew DeVore <matvore(a)google.com> --- M src/CMakeLists.txt 1 file changed, 12 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/12/518912/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/518912 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0502b0f9cb511d43a1f5b4b6bc9ffc3604f123fb Gerrit-Change-Number: 518912 Gerrit-PatchSet: 1 Gerrit-Owner: Matthew DeVore <matvore(a)comcast.net> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Sanitize use of _GNU_SOURCE preprocessor define
by Matthew DeVore (GerritHub) 14 Jun '21

14 Jun '21

Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/518911 ) Change subject: Sanitize use of _GNU_SOURCE preprocessor define ...................................................................... Sanitize use of _GNU_SOURCE preprocessor define 1) define in just one place rather than every CMakeLists that wants it 2) only define if the platform supports it (to reduce command line to only meaningful elements, and clarify purpose of symbol for future maintainers) 3) for the check it was used for in abstract_mem.h, replace it with something that will work regardless of the compilation it is used in, as this header could be included in non-Ganesha compilation units Change-Id: Iec52a88c9f75ea1fe4a41e1a60dbb7090ec04c63 Signed-off-by: Matthew DeVore <matvore(a)google.com> --- M src/CMakeLists.txt M src/FSAL/FSAL_GLUSTER/CMakeLists.txt M src/FSAL/FSAL_LIZARDFS/CMakeLists.txt M src/FSAL/FSAL_MEM/CMakeLists.txt M src/FSAL/FSAL_PROXY_V3/CMakeLists.txt M src/FSAL/FSAL_PROXY_V4/CMakeLists.txt M src/FSAL/FSAL_PSEUDO/CMakeLists.txt M src/FSAL/FSAL_VFS/CMakeLists.txt M src/FSAL/FSAL_VFS/panfs/CMakeLists.txt M src/FSAL/FSAL_VFS/vfs/CMakeLists.txt M src/FSAL/FSAL_VFS/xfs/CMakeLists.txt M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/CMakeLists.txt M src/FSAL/Stackable_FSALs/FSAL_NULL/CMakeLists.txt M src/MainNFSD/CMakeLists.txt M src/RPCAL/gss_credcache.c M src/SAL/recovery/recovery_fs_ng.c M src/config_parsing/CMakeLists.txt M src/include/abstract_mem.h M src/log/CMakeLists.txt 19 files changed, 10 insertions(+), 25 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/11/518911/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/518911 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iec52a88c9f75ea1fe4a41e1a60dbb7090ec04c63 Gerrit-Change-Number: 518911 Gerrit-PatchSet: 1 Gerrit-Owner: Matthew DeVore <matvore(a)comcast.net> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Use ntirpc's bswap_## definitions
by Matthew DeVore (GerritHub) 14 Jun '21

14 Jun '21

Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/518910 ) Change subject: Use ntirpc's bswap_## definitions ...................................................................... Use ntirpc's bswap_## definitions Change-Id: Ib5fc1aafa9c3205385bcaf1cde8a7b746023a3ee Signed-off-by: Matthew DeVore <matvore(a)google.com> --- M src/FSAL/FSAL_MEM/mem_export.c M src/FSAL/FSAL_PSEUDO/export.c M src/include/nfs_fh.h M src/support/city.c 4 files changed, 4 insertions(+), 32 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/10/518910/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/518910 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib5fc1aafa9c3205385bcaf1cde8a7b746023a3ee Gerrit-Change-Number: 518910 Gerrit-PatchSet: 1 Gerrit-Owner: Matthew DeVore <matvore(a)comcast.net> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Pull up ntirpc changes
by Matthew DeVore (GerritHub) 14 Jun '21

14 Jun '21

Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/518909 ) Change subject: Pull up ntirpc changes ...................................................................... Pull up ntirpc changes Signed-off-by: Matthew DeVore <matvore(a)google.com> Change-Id: Iac64bffecba863f0ab82ce100ce8ff9cecbed4f5 --- M src/libntirpc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/09/518909/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/518909 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iac64bffecba863f0ab82ce100ce8ff9cecbed4f5 Gerrit-Change-Number: 518909 Gerrit-PatchSet: 1 Gerrit-Owner: Matthew DeVore <matvore(a)comcast.net> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Specify correct flags for Apple's /usr/bin/ld
by Matthew DeVore (GerritHub) 12 Jun '21

12 Jun '21

Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/518802 ) Change subject: Specify correct flags for Apple's /usr/bin/ld ...................................................................... Specify correct flags for Apple's /usr/bin/ld Change-Id: I43c71e40bc7bc873427f7a47f7a4a4158dfd0cab Signed-off-by: Matthew DeVore <matvore(a)google.com> --- M src/CMakeLists.txt M src/FSAL/FSAL_CEPH/CMakeLists.txt M src/FSAL/FSAL_GLUSTER/CMakeLists.txt M src/FSAL/FSAL_GPFS/CMakeLists.txt M src/FSAL/FSAL_MEM/CMakeLists.txt M src/FSAL/FSAL_PROXY_V3/CMakeLists.txt M src/FSAL/FSAL_PROXY_V4/CMakeLists.txt M src/FSAL/FSAL_RGW/CMakeLists.txt M src/FSAL/FSAL_VFS/panfs/CMakeLists.txt M src/FSAL/FSAL_VFS/vfs/CMakeLists.txt M src/FSAL/FSAL_VFS/xfs/CMakeLists.txt M src/FSAL/Stackable_FSALs/FSAL_NULL/CMakeLists.txt M src/MainNFSD/CMakeLists.txt M src/SAL/CMakeLists.txt M src/config_parsing/CMakeLists.txt 15 files changed, 41 insertions(+), 22 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/518802/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/518802 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I43c71e40bc7bc873427f7a47f7a4a4158dfd0cab Gerrit-Change-Number: 518802 Gerrit-PatchSet: 1 Gerrit-Owner: Matthew DeVore <matvore(a)comcast.net> Gerrit-MessageType: newchange

1 0

Announce Push of V4-dev.63
by Frank Filz 11 Jun '21

11 Jun '21

Branch next Tag:V4-dev.63 Merge Highlights * Add an option to display UTC timestamp in logs. * Guard use of P_MNT symbol with #ifdef * Start defining Darwin build based on FreeBSD * Fix open file limit detection on macOS Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 19ebc7754 Frank S. Filz V4-dev.63 b443b46d6 Matthew DeVore Fix open file limit detection on macOS 673be8b4d Matthew DeVore Start defining Darwin build based on FreeBSD 6f4142366 Matthew DeVore Guard use of P_MNT symbol with #ifdef 588d8170b Pradeep Add an option to display UTC timestamp in logs.

1 0

Change in ...nfs-ganesha[next]: Start defining Darwin build based on FreeBSD
by Matthew DeVore (GerritHub) 10 Jun '21

10 Jun '21

Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/518717 ) Change subject: Start defining Darwin build based on FreeBSD ...................................................................... Start defining Darwin build based on FreeBSD Some of the FreeBSD build logic as well as OS-specific source and headers can be used on macOS. So move those files to a generic BSD category, and define a BSDBASED build type and use that where it makes sense. I may have missed some places where it makes sense to use "#if BSDBASED" rather than "#if FREEBSD", but these are the obvious ones that are necessary for my macOS build to function. The subr.c and mntent compatibility code are not completely macOS-compatible yet. I will adjust them later. Signed-off-by: Matthew DeVore <matvore(a)google.com> Change-Id: Idec2f7ac960016c15774490981d2ea21dd2b62dd --- M src/CMakeLists.txt M src/FSAL/commonlib.c M src/FSAL/fsal_convert.c M src/FSAL/fsal_manager.c M src/cmake/modules/FindEPOLL.cmake M src/include/config-h.in.cmake R src/include/os/bsd/mntent.h M src/include/os/mntent.h M src/os/CMakeLists.txt R src/os/bsd/mntent_compat.c R src/os/bsd/subr.c 11 files changed, 44 insertions(+), 16 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/17/518717/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/518717 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Idec2f7ac960016c15774490981d2ea21dd2b62dd Gerrit-Change-Number: 518717 Gerrit-PatchSet: 1 Gerrit-Owner: Matthew DeVore <matvore(a)comcast.net> Gerrit-MessageType: newchange

1 0