February 2022 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Allow EXPORT pseudo path to be changed during export update
by Frank Filz (GerritHub) 20 Feb '24

20 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 ) Change subject: Allow EXPORT pseudo path to be changed during export update ...................................................................... Allow EXPORT pseudo path to be changed during export update This also fully allows adding or removing NFSv4 support from an export since we can now handle the PseudoFS swizzing that occurs. Note that an explicit PseudoFS export may be removed or added, though you can not change it from export_id 0 because we currently don't allow changing the export_id. Note that this patch doesn't handle DBUS add or remove export though that is an option to improve. I may add them to this patch (it wouldn't be that hard) but I want to get this reviewed as is right now. There are implications to a client of changing the PseudoFS. I have tested moving an export in the PseudoFS with a client mounted. The client will be able to continue accessing the export, though it may see an ESTALE error if it navigates out of the export. The current working directory will go bad and the pwd comment will fail indicating a disconnected mount. I have also seen referencing .. from the root of the export wrapping around back to the root (I believe this is how disconnected mounts are set up). FSAL_PSEUDO lookups and create handles (PUTFH or any use of an NFSv3 handle where the inode isn't cached) which fail during an export update are instead turned into ERR_FSAL_DELAY which turns into NFS4ERR_DELAY or NFS3ERR_JUKEBOX to force the client to retry under the completed update. Change-Id: I507dc17a651936936de82303ff1291677ce136be Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PSEUDO/handle.c M src/MainNFSD/libganesha_nfsd.ver M src/Protocols/NFS/nfs4_pseudo.c M src/include/export_mgr.h M src/include/nfs_proto_functions.h M src/support/export_mgr.c M src/support/exports.c 7 files changed, 560 insertions(+), 203 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/490334/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I507dc17a651936936de82303ff1291677ce136be Gerrit-Change-Number: 490334 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 2

Announce Push of V4.0.3
by Frank Filz 25 Feb '22

25 Feb '22

Branch next Tag:V4.0.3 Merge Highlights * Added new tunnable for readdir response size * Fix expired attr when mdc_readdir_uncached_cb * MDCACHE: Add comment for fds_avg and some cleanup * glist: Add function to do the thing like move to tail Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: c40241d1e Frank S. Filz V4.0.3 7d1ac6c8c Vicente Cheng glist: Add function to do the thing like move to tail 32e0cf60b Vicente Cheng MDCACHE: Add comment for fds_avg and some cleanup 03c133333 liyinshu Fix expired attr when mdc_readdir_uncached_cb 9c0b50584 Prabhu Murugesan Added new tunnable for readdir response size

1 0

Change in ...nfs-ganesha[next]: Added new config parameter (readdir_res_size) to improve readdir perf...
by Name of user not set (GerritHub) 15 Feb '22

15 Feb '22

prabhu.murugeshan(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/533219 ) Change subject: Added new config parameter (readdir_res_size) to improve readdir performance. The default value of readdir_res_size is 0, it means use the maxcount value from nfs request. The range of readdir_res_size is 4096-32768. Possible values are 4096,8192, 16384 and 32768. Recommanded value is 16384(16K) if readdir operation performed on directory which has more files. ...................................................................... Added new config parameter (readdir_res_size) to improve readdir performance. The default value of readdir_res_size is 0, it means use the maxcount value from nfs request. The range of readdir_res_size is 4096-32768. Possible values are 4096,8192, 16384 and 32768. Recommanded value is 16384(16K) if readdir operation performed on directory which has more files. Change-Id: I5b110236c7872eb2d9d9e0d08b421acb159a4212 Signed-off-by: Prabhu Murugesan <prabhu.murugeshan(a)ibm.com> --- M src/doc/man/ganesha-core-config.rst M src/support/nfs_read_conf.c M src/config_samples/config.txt M src/Protocols/NFS/nfs3_readdirplus.c M src/include/gsh_config.h M src/Protocols/NFS/nfs4_op_readdir.c 6 files changed, 40 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/19/533219/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/533219 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5b110236c7872eb2d9d9e0d08b421acb159a4212 Gerrit-Change-Number: 533219 Gerrit-PatchSet: 1 Gerrit-Owner: prabhu.murugeshan(a)ibm.com Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: FSAL: add FSAL_IS_ENOENT macro
by vicente (GerritHub) 15 Feb '22

15 Feb '22

vicente has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/533179 ) Change subject: FSAL: add FSAL_IS_ENOENT macro ...................................................................... FSAL: add FSAL_IS_ENOENT macro Change-Id: I0e4cdc7f5dd048482aa543d0f8660ea89ffb671b Signed-off-by: Vicente Cheng <vicente_cheng(a)bigtera.com> --- M src/FSAL/FSAL_GPFS/fsal_lookup.c M src/Protocols/NFS/nfs4_op_open.c M src/include/fsal_types.h M src/FSAL/FSAL_GLUSTER/handle.c M src/FSAL/FSAL_MEM/mem_handle.c M src/FSAL/FSAL_GPFS/handle.c M src/Protocols/NFS/nfs4_pseudo.c M src/FSAL/FSAL_GPFS/fsal_up.c M src/FSAL/FSAL_GLUSTER/fsal_up.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_file.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_up.c M src/Protocols/9P/9p_xattrwalk.c 13 files changed, 30 insertions(+), 20 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/79/533179/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/533179 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0e4cdc7f5dd048482aa543d0f8660ea89ffb671b Gerrit-Change-Number: 533179 Gerrit-PatchSet: 1 Gerrit-Owner: vicente <freeze.bilsted(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: glist: Add function to do the thing like move to tail
by vicente (GerritHub) 15 Feb '22

15 Feb '22

vicente has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/533178 ) Change subject: glist: Add function to do the thing like move to tail ...................................................................... glist: Add function to do the thing like move to tail - we combine delete and add to tail to complete move to tail Change-Id: I6825ae74eb59f7c63cd5ba6c7101178578c5c396 Signed-off-by: Vicente Cheng <vicente_cheng(a)bigtera.com> --- M src/SAL/nfs4_clientid.c M src/SAL/state_layout.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c M src/SAL/nfs4_state.c M src/Protocols/NFS/nfs4_op_layoutreturn.c M src/include/gsh_list.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h M src/SAL/state_lock.c 8 files changed, 45 insertions(+), 36 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/78/533178/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/533178 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6825ae74eb59f7c63cd5ba6c7101178578c5c396 Gerrit-Change-Number: 533178 Gerrit-PatchSet: 1 Gerrit-Owner: vicente <freeze.bilsted(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: MDCACHE: correct the fds_avg and some cleanup
by vicente (GerritHub) 15 Feb '22

15 Feb '22

vicente has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/533177 ) Change subject: MDCACHE: correct the fds_avg and some cleanup ...................................................................... MDCACHE: correct the fds_avg and some cleanup - fds_avg should be (high water + low water)/2 - avoid to do extra atomic_fetch in logger and some checking Change-Id: I950cfdecbed462fc4a7d323c8c260bd926fee63d Signed-off-by: Vicente Cheng <vicente_cheng(a)bigtera.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c 1 file changed, 30 insertions(+), 12 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/77/533177/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/533177 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I950cfdecbed462fc4a7d323c8c260bd926fee63d Gerrit-Change-Number: 533177 Gerrit-PatchSet: 1 Gerrit-Owner: vicente <freeze.bilsted(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Add SPDX Licence Identifier to source files with unknown license
by Frank Filz (GerritHub) 11 Feb '22

11 Feb '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/533010 ) Change subject: Add SPDX Licence Identifier to source files with unknown license ...................................................................... Add SPDX Licence Identifier to source files with unknown license It's not clear what license these files should have. Make that clear with a non-conforming SPDX Licence Identifier. Change-Id: Iea81c54a93316b2babdd582c87c44c7b4594cbd6 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/include/mount.h M src/support/murmur3.c M src/include/nfs23.h 3 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/10/533010/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/533010 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iea81c54a93316b2babdd582c87c44c7b4594cbd6 Gerrit-Change-Number: 533010 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Add missing license to original files also add SPDX licence tag
by Frank Filz (GerritHub) 11 Feb '22

11 Feb '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/533009 ) Change subject: Add missing license to original files also add SPDX licence tag ...................................................................... Add missing license to original files also add SPDX licence tag These files appear to predate the conversion of Ganesha to the LGPL license, so license them as such. Change-Id: I2ada58028fbc1f2dbef8425653e7b8bef10182e4 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/include/nfs_ip_stats.h M src/include/common_utils.h M src/include/gsh_rpc.h 3 files changed, 91 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/09/533009/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/533009 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2ada58028fbc1f2dbef8425653e7b8bef10182e4 Gerrit-Change-Number: 533009 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Add missing LGPL license and SPDX license identifier to contributed f...
by Frank Filz (GerritHub) 11 Feb '22

11 Feb '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/533008 ) Change subject: Add missing LGPL license and SPDX license identifier to contributed files ...................................................................... Add missing LGPL license and SPDX license identifier to contributed files These files appear to have been directly contributed to the Ganesha project with no explicit license so we assume the LGPL license. Change-Id: I8557180c839e4d8334ada80c6c6067188368d062 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/tracing/nfs_rpc.c M src/tracing/fsal_gluster.c M src/tracing/logger.c M src/tracing/nfs4.c M src/include/os/linux/sys_resource.h M src/include/os/freebsd/sys_resource.h M src/tracing/state.c M src/os/darwin/sys_resource.c M src/include/gsh_lttng/nfs4.h M src/tracing/fsal_ceph.c M src/tracing/mdcache.c M src/include/gsh_lttng/logger.h M src/include/gsh_lttng/state.h M src/include/gsh_lttng/mdcache.h M src/include/gsh_lttng/nfs_rpc.h M src/include/gsh_lttng/fsal_mem.h M src/include/gsh_lttng/fsal_gluster.h M src/include/os/darwin/sys_resource.h M src/tracing/fsal_mem.c M src/include/gsh_lttng/fsal_ceph.h 20 files changed, 389 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/08/533008/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/533008 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8557180c839e4d8334ada80c6c6067188368d062 Gerrit-Change-Number: 533008 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Add missing license to files to match files they were contributed with
by Frank Filz (GerritHub) 11 Feb '22

11 Feb '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/533007 ) Change subject: Add missing license to files to match files they were contributed with ...................................................................... Add missing license to files to match files they were contributed with Assume that all files contributed together have the same licensing. Also add SPDX tags Change-Id: I248279a87d4212a4b91def52b257b93abcc89cd4 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/dbus/dbus_priv.h M src/Protocols/NLM/sm_notify.c M src/FSAL/FSAL_PROXY_V4/handle_mapping/handle_mapping_internal.h M src/FSAL/FSAL_GPFS/gpfs_methods.h M src/FSAL/FSAL_GPFS/fsal_convert.c M src/FSAL/FSAL_GPFS/gpfsext.c M src/FSAL/FSAL_PROXY_V4/handle_mapping/test_handle_mapping_db.c M src/FSAL/FSAL_GPFS/fsal_create.c M src/include/config-h.in.cmake M src/FSAL/FSAL_PROXY_V4/handle_mapping/handle_mapping_db.c M src/FSAL/FSAL_PROXY_V4/handle_mapping/test_handle_mapping.c M src/log/test_display.c M src/FSAL/FSAL_PROXY_V4/fsal_nfsv4_macros.h M src/support/refstr.c M src/FSAL/FSAL_PROXY_V4/handle_mapping/handle_mapping_db.h 15 files changed, 385 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/07/533007/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/533007 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I248279a87d4212a4b91def52b257b93abcc89cd4 Gerrit-Change-Number: 533007 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0