October 2023 - Devel - NFS Ganesha List Archives

[XS] Change in ...nfs-ganesha[next]: CEPH: Disable ceph nonblocking-io for now - it doesn't work well
by Frank Filz (GerritHub) 19 Oct '23

19 Oct '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170952?usp=email ) Change subject: CEPH: Disable ceph nonblocking-io for now - it doesn't work well ...................................................................... CEPH: Disable ceph nonblocking-io for now - it doesn't work well It leaks memory for one thing. Change-Id: I9bee6802d289217ee206a8ab8d1160b26610dff7 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/cmake/modules/FindCEPHFS.cmake 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/52/1170952/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170952?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9bee6802d289217ee206a8ab8d1160b26610dff7 Gerrit-Change-Number: 1170952 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[XS] Change in ...nfs-ganesha[next]: CRASH:Memory access violation in posix_acl_2_fsal_acl
by Arnab Tah (GerritHub) 17 Oct '23

17 Oct '23

Arnab Tah has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170824?usp=email ) Change subject: CRASH:Memory access violation in posix_acl_2_fsal_acl ...................................................................... CRASH:Memory access violation in posix_acl_2_fsal_acl Commit 11d0261ff9d15079a9d3f7d8c9ff39342d4dd01b causes posix_acl_2_fsal_acl() to generate ACEs in the FSAL ACL that correspond to an input POSIX ACL mask ACE. However, ace_count(), which is used to calculate space for the output, wasn't modified to provide space for the additional ACEs. For some POSIX ACLs this can cause the output to overrun the allocated space resulting in a crash. STARTUP :MAJ :stack backtrace follows: /lib64/libganesha_nfsd.so.5.5.3(+0x96700)[0x7f17ba175700] /lib64/libganesha_nfsd.so.5.5.3(+0x66d90)[0x7f17ba145d90] /lib64/libpthread.so.0(+0x12cf0)[0x7f17b823fcf0] /lib64/libc.so.6(gsignal+0x10f)[0x7f17b7a94acf] /lib64/libc.so.6(abort+0x127)[0x7f17b7a67ea5] /lib64/libc.so.6(+0x8fcd7)[0x7f17b7ad5cd7] /lib64/libc.so.6(+0x96fdc)[0x7f17b7adcfdc] /lib64/libc.so.6(+0x9b1fc)[0x7f17b7ae11fc] /lib64/libc.so.6(realloc+0x33b)[0x7f17b7ae23db] /usr/lib64/ganesha/libfsalvfs.so(vfs_sub_getattrs+0x32b) [0x7f17b244d930] /usr/lib64/ganesha/libfsalvfs.so(+0xf10d)[0x7f17b244710d] /usr/lib64/ganesha/libfsalvfs.so(vfs_getattr2+0x23d) [0x7f17b244a6f7] /lib64/libganesha_nfsd.so.5.5.3(+0x16b786)[0x7f17ba24a786] Change-Id: I81efee93da9f4d7eadbb2e0b36aefdcaf36d3faa Signed-off-by: Arnab Tah <atah(a)ddn.com> --- M src/FSAL/posix_acls.c 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/24/1170824/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170824?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I81efee93da9f4d7eadbb2e0b36aefdcaf36d3faa Gerrit-Change-Number: 1170824 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Tah <atah(a)ddn.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: Remove exports from gpfs_filesystem_export_map when export removed
by Name of user not set (GerritHub) 12 Oct '23

12 Oct '23

yogendra858(a)yahoo.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170665?usp=email ) Change subject: Remove exports from gpfs_filesystem_export_map when export removed ...................................................................... Remove exports from gpfs_filesystem_export_map when export removed Change-Id: Ia01725d43cc8f094f7ef64bed2c5430d9ee9fe36 Signed-off-by: Yogendra Charya <Yogendra.Charya(a)ibm.com> --- M src/FSAL/FSAL_GPFS/export.c M src/FSAL/FSAL_GPFS/gpfs_methods.h 2 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/65/1170665/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia01725d43cc8f094f7ef64bed2c5430d9ee9fe36 Gerrit-Change-Number: 1170665 Gerrit-PatchSet: 1 Gerrit-Owner: yogendra858(a)yahoo.com Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: CMAKE: Fix use of USE_CB_SIMULATOR and USE_DBUS
by Frank Filz (GerritHub) 12 Oct '23

12 Oct '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170664?usp=email ) Change subject: CMAKE: Fix use of USE_CB_SIMULATOR and USE_DBUS ...................................................................... CMAKE: Fix use of USE_CB_SIMULATOR and USE_DBUS Don't force USE_DBUS on, and check USE_CB_SIMULATOR AFTER the library check for USE_DBUS so a cmake warning is thrown rather than a compile error. Change-Id: I1d50a1ae409ee494b4a561b015736e1dcb7aebab Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/CMakeLists.txt 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/64/1170664/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170664?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1d50a1ae409ee494b4a561b015736e1dcb7aebab Gerrit-Change-Number: 1170664 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: Fix for ganesha crash after removal of first export
by Name of user not set (GerritHub) 10 Oct '23

10 Oct '23

yogendra858(a)yahoo.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170563?usp=email ) Change subject: Fix for ganesha crash after removal of first export ...................................................................... Fix for ganesha crash after removal of first export Change-Id: Iff8e7ffe09dafe57c828df83bf81aeef2ec4dba2 Signed-off-by: Yogendra Charya <Yogendra.Charya(a)ibm.com> --- M src/FSAL/FSAL_GPFS/fsal_up.c 1 file changed, 25 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/63/1170563/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170563?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iff8e7ffe09dafe57c828df83bf81aeef2ec4dba2 Gerrit-Change-Number: 1170563 Gerrit-PatchSet: 1 Gerrit-Owner: yogendra858(a)yahoo.com Gerrit-MessageType: newchange

1 0

[XS] Change in ...nfs-ganesha[next]: fix tabs
by Yevhenii Huzii (GerritHub) 09 Oct '23

09 Oct '23

Yevhenii Huzii has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170469?usp=email ) Change subject: fix tabs ...................................................................... fix tabs Change-Id: I2134f792b080e5892850a2ae23bf9a240c87ee7d Signed-off-by: Yevhenii Huzii <yevhenii.huzii(a)gmail.com> --- M src/FSAL/FSAL_GLUSTER/handle.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/69/1170469/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170469?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2134f792b080e5892850a2ae23bf9a240c87ee7d Gerrit-Change-Number: 1170469 Gerrit-PatchSet: 1 Gerrit-Owner: Yevhenii Huzii <yevhenii.huzii(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XS] Change in ...nfs-ganesha[next]: Fixes Github issue #971
by Yevhenii Huzii (GerritHub) 09 Oct '23

09 Oct '23

Yevhenii Huzii has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170468?usp=email ) Change subject: Fixes Github issue #971 ...................................................................... Fixes Github issue #971 Change-Id: Ia81e8ed2df75c319ab4cf10a094817f67e85d141 Change-Id: I99e8e9b1fc2965add07b3bc67d57e9ba930d901f Signed-off-by: Yevhenii Huzii <yevhenii.huzii(a)gmail.com> --- M src/FSAL/FSAL_GLUSTER/handle.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/68/1170468/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170468?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I99e8e9b1fc2965add07b3bc67d57e9ba930d901f Gerrit-Change-Number: 1170468 Gerrit-PatchSet: 1 Gerrit-Owner: Yevhenii Huzii <yevhenii.huzii(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: main: periodically poke malloc()/free() to release memory
by Kaleb KEITHLEY (GerritHub) 03 Oct '23

03 Oct '23

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170254?usp=email ) Change subject: main: periodically poke malloc()/free() to release memory ...................................................................... main: periodically poke malloc()/free() to release memory Try to improve the odds that freed memory will be released to the operating system, potentially reducing VIRT and RES sizes. malloc_trim(3) is in glibc, and when compiling with tcmalloc or jemalloc it effectively becomes a no-op. For allocations above a certain size (128K default) malloc(3) uses mmap, which should usually be released when freed. But below that memory is allocated by the use of brk(2) to increase the size of the program in memory. Freeing memory allocated with brk(2) may or may not happen automatically. Calling malloc_trim(2) may release memory when it isn't released after freeing it. Change-Id: I543e320128db8f6382c462a1b52518a89a0bcfcb Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> --- M src/MainNFSD/nfs_init.c 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/54/1170254/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170254?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I543e320128db8f6382c462a1b52518a89a0bcfcb Gerrit-Change-Number: 1170254 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com> Gerrit-MessageType: newchange

1 0

[XS] Change in ...nfs-ganesha[next]: Fix bit shifting issue reported by UBSAN. The issue is (1 << 31) is a...
by Name of user not set (GerritHub) 02 Oct '23

02 Oct '23

drieber(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170205?usp=email ) Change subject: Fix bit shifting issue reported by UBSAN. The issue is (1 << 31) is acting on a signed integer (with value 1) and so shifting left 31 bits is undefined. ...................................................................... Fix bit shifting issue reported by UBSAN. The issue is (1 << 31) is acting on a signed integer (with value 1) and so shifting left 31 bits is undefined. Change-Id: I8df16d610bb3d7d1c754ba973a9a24b303056e79 Signed-off-by: David Rieber <drieber(a)google.com> --- M src/include/nfs_proto_tools.h 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/05/1170205/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170205?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8df16d610bb3d7d1c754ba973a9a24b303056e79 Gerrit-Change-Number: 1170205 Gerrit-PatchSet: 1 Gerrit-Owner: drieber(a)google.com Gerrit-MessageType: newchange

1 0

[XS] Change in ...nfs-ganesha[next]: UBSAN reports some issue about misaligned access to sockaddr_t which ...
by Name of user not set (GerritHub) 02 Oct '23

02 Oct '23

drieber(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170204?usp=email ) Change subject: UBSAN reports some issue about misaligned access to sockaddr_t which I don't fully understand. I tried to fix it a number of ways but in the end gave up. ...................................................................... UBSAN reports some issue about misaligned access to sockaddr_t which I don't fully understand. I tried to fix it a number of ways but in the end gave up. Change-Id: I5b032c724f62735ba6ef8c497b3d8e8b9a5938c3 Signed-off-by: David Rieber <drieber(a)google.com> --- M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/RPCAL/rpc_tools.c 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/04/1170204/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170204?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5b032c724f62735ba6ef8c497b3d8e8b9a5938c3 Gerrit-Change-Number: 1170204 Gerrit-PatchSet: 1 Gerrit-Owner: drieber(a)google.com Gerrit-MessageType: newchange

1 0