April 2023 - Devel - NFS Ganesha List Archives

[M] Change in ...nfs-ganesha[next]: CONFIG: Make most parameters and blocks unique, clarify the rest
by Frank Filz (GerritHub) 12 Apr '23

12 Apr '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552558 ) Change subject: CONFIG: Make most parameters and blocks unique, clarify the rest ...................................................................... CONFIG: Make most parameters and blocks unique, clarify the rest The config doesn't always do what is expected when parameters or blocks are repeated, so make any such that doesn't explicitly support repeats be required to be unique. For those items that DON'T need to be unique, make it more clear. Change-Id: I6a2e5dc8c57cda9ed1602ee6d6400fa31e79bced Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_CEPH/main.c M src/FSAL/FSAL_GLUSTER/main.c M src/FSAL/FSAL_GPFS/main.c M src/FSAL/FSAL_LIZARDFS/main.c M src/FSAL/FSAL_MEM/mem_main.c M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V4/main.c M src/FSAL/FSAL_RGW/main.c M src/FSAL/FSAL_VFS/xfs/main.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_read_conf.c M src/FSAL/fsal_manager.c M src/Protocols/9P/9p_read_conf.c M src/SAL/recovery/recovery_rados_kv.c M src/config_parsing/conf_url_rados.c M src/config_samples/config.txt M src/doc/man/ganesha-core-config.rst M src/doc/man/ganesha-export-config.rst M src/doc/man/ganesha-log-config.rst M src/include/config_parsing.h M src/log/log_functions.c M src/support/exports.c M src/support/nfs_ip_name.c M src/support/nfs_read_conf.c 23 files changed, 122 insertions(+), 85 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/58/552558/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552558 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6a2e5dc8c57cda9ed1602ee6d6400fa31e79bced Gerrit-Change-Number: 552558 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: Add find_unused_blocks to check for unused config blocks
by Frank Filz (GerritHub) 12 Apr '23

12 Apr '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552557 ) Change subject: Add find_unused_blocks to check for unused config blocks ...................................................................... Add find_unused_blocks to check for unused config blocks In combination with the -x command line option and the FSAL_LIST config block, this will assure that unused config blocks cause a fatal error thus avoiding running without the intended configuration because of a typo in a config block. Change-Id: I5e7bb63fc7056f0f7aacdeb1a7bac84e259f8b70 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/MainNFSD/libganesha_nfsd.ver M src/MainNFSD/nfs_main.c M src/config_parsing/analyse.h M src/config_parsing/conf_yacc.y M src/config_parsing/config_parsing.c M src/include/config_parsing.h 6 files changed, 60 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/57/552557/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552557 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5e7bb63fc7056f0f7aacdeb1a7bac84e259f8b70 Gerrit-Change-Number: 552557 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: Add FSAL_LIST config block to list the FSAL specific config blocks
by Frank Filz (GerritHub) 12 Apr '23

12 Apr '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552556 ) Change subject: Add FSAL_LIST config block to list the FSAL specific config blocks ...................................................................... Add FSAL_LIST config block to list the FSAL specific config blocks This will be used later to prevent those blocks from causing a fatal error if there are no exports for the FSAL. Change-Id: I92f8808f143a2013b3cb0a8c3a29fd02cf3e9139 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/fsal_manager.c M src/MainNFSD/nfs_lib.c M src/MainNFSD/nfs_main.c M src/config_samples/config.txt M src/doc/man/ganesha-config.rst M src/doc/man/ganesha-core-config.rst M src/include/fsal.h 7 files changed, 153 insertions(+), 16 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/56/552556/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552556 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I92f8808f143a2013b3cb0a8c3a29fd02cf3e9139 Gerrit-Change-Number: 552556 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: Add command line option for initial export config errors to be fatal
by Frank Filz (GerritHub) 10 Apr '23

10 Apr '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552407 ) Change subject: Add command line option for initial export config errors to be fatal ...................................................................... Add command line option for initial export config errors to be fatal If there are ANY config errors with export, and -x is specified on the Ganesha command line, a fatal error will be reported and Ganesha will fail to start. Change-Id: I5e79000075b5db4306833674017d73a0d9a61cf7 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/MainNFSD/nfs_init.c M src/MainNFSD/nfs_lib.c M src/MainNFSD/nfs_main.c M src/config_parsing/config_parsing.c M src/include/config_parsing.h M src/support/export_mgr.c 6 files changed, 59 insertions(+), 33 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/07/552407/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552407 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5e79000075b5db4306833674017d73a0d9a61cf7 Gerrit-Change-Number: 552407 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: FSAL_VFS: On Linux make setattr >0x7ffffffffffffff return EFBIG
by Frank Filz (GerritHub) 10 Apr '23

10 Apr '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552403 ) Change subject: FSAL_VFS: On Linux make setattr >0x7ffffffffffffff return EFBIG ...................................................................... FSAL_VFS: On Linux make setattr >0x7ffffffffffffff return EFBIG off_t is signed, so too large and the value is < 0 which would result in EINVAL from ftruncate. Make it return EFBIG which is what pynfs test SATT12x expects. Change-Id: I35eb20553372e92e434c7cdf572ece6e631dc944 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_VFS/file.c 1 file changed, 31 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/03/552403/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552403 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I35eb20553372e92e434c7cdf572ece6e631dc944 Gerrit-Change-Number: 552403 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: SAL: wrap init and destroy all_locks_mutex in #ifdef DEBUG_SAL
by Frank Filz (GerritHub) 10 Apr '23

10 Apr '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552393 ) Change subject: SAL: wrap init and destroy all_locks_mutex in #ifdef DEBUG_SAL ...................................................................... SAL: wrap init and destroy all_locks_mutex in #ifdef DEBUG_SAL Change-Id: I434637d539de2add11c27ee8de766b941e782a09 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/SAL/state_lock.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/93/552393/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552393 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I434637d539de2add11c27ee8de766b941e782a09 Gerrit-Change-Number: 552393 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

V5.0 tagging soon, possibly next week
by Frank Filz 07 Apr '23

07 Apr '23

We want to get the V5 features out soon and get folks using them and testing with them, so we are pushing an aggressive schedule with a proposal to tag V5.0 next week (April 14th). If you have any outstanding patches, please review the comments and work to get them merged. Thanks Frank Filz

1 0

Announce Push of V5-dev.5
by Frank Filz 07 Apr '23

07 Apr '23

Branch next Tag:V5-dev.5 Merge Highlights * free_state may not always be able to be called with a valid export * DUPREQ: When dupreq completely drops a request, don't clean up response * Expire lease immediately when reserve_lease fails. * FSAL - oops - missed some fsal_fd stuff * Remove unused fridgethr_defer_block * PROXY handle mapping - remove mutexes, not necessary for pool_alloc * pthread resources cleanup (mutex, condition, rwlock etc.) * Use global mutex and rwlock attributes as default for mutexes and rwlocks * Coverity fix repairs in Protocols/XDR Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 01a54c4ce Frank S. Filz V5-dev.5 45be9b24d Frank S. Filz Coverity fix repairs in Protocols/XDR 6da94ce09 Frank S. Filz Use global mutex and rwlock attributes as default for mutexes and rwlocks a4e52ddf1 Frank S. Filz pthread resources cleanup (mutex, condition, rwlock etc.) 49bc4bb2c Frank S. Filz PROXY handle mapping - remove mutexes, not necessary for pool_alloc fcc552f6e Frank S. Filz Remove unused fridgethr_defer_block dab080f5f Frank S. Filz FSAL - oops - missed some fsal_fd stuff 75cec08b2 Frank S. Filz Expire lease immediately when reserve_lease fails. 902bb8111 Frank S. Filz DUPREQ: When dupreq completely drops a request, don't clean up response 336abcba0 Frank S. Filz free_state may not always be able to be called with a valid export

1 0

[L] Change in ...nfs-ganesha[next]: Eradicate most refereces to cache inode.
by Frank Filz (GerritHub) 07 Apr '23

07 Apr '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552361 ) Change subject: Eradicate most refereces to cache inode. ...................................................................... Eradicate most refereces to cache inode. We still accept the CACHE_INODE config block and the CACHE_INODE and CACHE_INODE_LRU log components. There are a few lingering bits that come up with: grep -an 'caceh.*inode' `find . -type f` Change-Id: I9cf27bcbc4017e194ccdd8694b151ebff4e4db6b Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_CEPH/ds.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_avl.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_file.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_hash.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_hash.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_read_conf.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_up.c M src/FSAL/commonlib.c M src/Protocols/9P/9p_readdir.c M src/README.new_api M src/SAL/state_misc.c M src/config_samples/config.txt M src/config_samples/gpfs.ganesha.main.conf M src/doc/man/ganesha-cache-config.rst M src/doc/man/ganesha-log-config.rst M src/include/gsh_status.h M src/include/log.h M src/log/log_functions.c M src/scripts/ganeshactl/Ganesha/glib_dbus_stats.py M src/scripts/ganeshactl/ganesha_conf.py M src/scripts/runcp.sh M src/support/export_mgr.c M src/support/exports.c 27 files changed, 303 insertions(+), 286 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/61/552361/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552361 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9cf27bcbc4017e194ccdd8694b151ebff4e4db6b Gerrit-Change-Number: 552361 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: FSAL cap retries for stat while resolving POSIX filesystems
by Frank Filz (GerritHub) 06 Apr '23

06 Apr '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552333 ) Change subject: FSAL cap retries for stat while resolving POSIX filesystems ...................................................................... FSAL cap retries for stat while resolving POSIX filesystems Also, don't spin on stat, insert a small delay (default 100 msec) between retries. Count and delay are configurable. Change-Id: I6159a677e0524a7a4cd733f8afacf0206bc36f7c Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/localfs.c M src/config_samples/config.txt M src/doc/man/ganesha-core-config.rst M src/include/gsh_config.h M src/support/nfs_read_conf.c 5 files changed, 72 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/33/552333/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552333 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6159a677e0524a7a4cd733f8afacf0206bc36f7c Gerrit-Change-Number: 552333 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0