October 2024 - Devel - Nfs Ganesha List Archives

[XS] Change in ...nfs-ganesha[next]: Sync lru_run with release_export

by Xueqian Hu (GerritHub)

Xueqian Hu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202422?usp=email ) Change subject: Sync lru_run with release_export ...................................................................... Sync lru_run with release_export Hit ganesha crash when removing a export & lru_run to clean caches: Thread 17 (Thread 0x7fed38bbe700 (LWP 62657)): ... Thread 1 (Thread 0x7fed437d8700 (LWP 62634)): This could happen when the mdcache caches number is above the high water limit which will trigger the lru_run to clean caches, and at the same time the release export(from dbus) is also in progress. Steps to repro the crash: 1. add sleep in unexport code path like 10 seconds(I added delay at the beginning of state_release_export) 2. use short lru interval: LRU_Run_Interval = 5 3. set lru_state.entries_hiwat to low value like 0 4. from client side, use vi to read a file -> keep delegation -> hold the cache to prevent clean immediately 5. dbus call to remove the export Change-Id: I378138f94bd804c312d68d0fab631d077cf52da5 Signed-off-by: Xueqian Hu <xh140312(a)outlook.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/22/1202422/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202422?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I378138f94bd804c312d68d0fab631d077cf52da5 Gerrit-Change-Number: 1202422 Gerrit-PatchSet: 1 Gerrit-Owner: Xueqian Hu <xh140312(a)outlook.com>

2 months

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: log_functions: When clean up list is cleared we need to set cleanup_l...

by ofir vainshtein (GerritHub)

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202363?usp=email ) Change subject: log_functions: When clean up list is cleared we need to set cleanup_list to null ...................................................................... log_functions: When clean up list is cleared we need to set cleanup_list to null if we do not, it still references an already cleared and freed linked list Change-Id: I54b381ddcdf4a17a7454535753ab7d0b8f60f03b Signed-off-by: Ofir Vaisnhtein <ofirvins(a)google.com> --- M src/log/log_functions.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/63/1202363/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202363?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I54b381ddcdf4a17a7454535753ab7d0b8f60f03b Gerrit-Change-Number: 1202363 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

2 months

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: connection_manager: Add enum for stuck drains

by ofir vainshtein (GerritHub)

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202362?usp=email ) Change subject: connection_manager: Add enum for stuck drains ...................................................................... connection_manager: Add enum for stuck drains Change-Id: Iebe589bacf990782e679b31e34b979eb9cba3fca Signed-off-by: Ofir Vaisnhtein <ofirvins(a)google.com> --- M src/RPCAL/connection_manager.c M src/include/connection_manager.h 2 files changed, 34 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/62/1202362/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202362?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iebe589bacf990782e679b31e34b979eb9cba3fca Gerrit-Change-Number: 1202362 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

2 months

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: fsal_destoryer.c: Didn't call unload for static fsals

by ofir vainshtein (GerritHub)

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202361?usp=email ) Change subject: fsal_destoryer.c: Didn't call unload for static fsals ...................................................................... fsal_destoryer.c: Didn't call unload for static fsals m->dl_handle is used to determine if fsal is static, and static fsals are the only ones implementing unload so the condition made it so that static fsals were not unloaded on ganesha destroy Change-Id: Id0cc3245bb545f6bf38ce9852bef6c3e72a18666 Signed-off-by: Ofir Vaisnhtein <ofirvins(a)google.com> --- M src/FSAL/fsal_destroyer.c 1 file changed, 11 insertions(+), 13 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/61/1202361/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202361?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id0cc3245bb545f6bf38ce9852bef6c3e72a18666 Gerrit-Change-Number: 1202361 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

2 months

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Initialize read_arg->info properly for read_plus

by Name of user not set (GerritHub)

deepakarumugam.s(a)nutanix.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202319?usp=email ) Change subject: Initialize read_arg->info properly for read_plus ...................................................................... Initialize read_arg->info properly for read_plus We used to fill read_arg->info for readplus. The FSALs rely on this buffer being filled for readplus handling. But it looks like ac337c37db84855f406ab85c9a9583ead2a32975 deleted it. This looks like a accident - hence reintroducing this line. Currently VFS returns ENOTSUPP if this read_arg->info is not NULL (i.e.) if it is a readplus operation. But since we don't set read_arg->info properly we end up handling it like a normal read in FSAL_VFS and finally return an empty file to the client. Change-Id: I029c141e09b37434fd5c1801226f05dc82017408 Signed-off-by: Deepak Arumugam Sankara Subramanian <deepakarumugam.s(a)nutanix.com> --- M src/Protocols/NFS/nfs4_op_read.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/19/1202319/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202319?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I029c141e09b37434fd5c1801226f05dc82017408 Gerrit-Change-Number: 1202319 Gerrit-PatchSet: 1 Gerrit-Owner: deepakarumugam.s(a)nutanix.com

2 months

1
0
0 / 0

bedipi9079

by bedipi9079＠scarden.com

In particular promoting Xingma dishes, this branch has been in Harbor metropolis for a long time. After the maintenance, the chef has adjusted the menu and taste once more, so I went to strive it again. To be sincere, I had an amazing time this time. Less surprises. <a href="https://www.casualarticlesandblogsonline.com/voipphone">virtual phone</a>

2 months

1
0
0 / 0

bedipi9079

by bedipi9079＠scarden.com

In particular promoting Xingma dishes, this branch has been in Harbor metropolis for a long time. After the maintenance, the chef has adjusted the menu and taste once more, so I went to strive it again. To be sincere, I had an amazing time this time. Less surprises. <a href=https://www.casualarticlesandblogsonline.com/voipphone>virtual phone</a>

2 months

1
0
0 / 0

bedipi9079

by bedipi9079＠scarden.com

In particular promoting Xingma dishes, this branch has been in Harbor metropolis for a long time. After the maintenance, the chef has adjusted the menu and taste once more, so I went to strive it again. To be sincere, I had an amazing time this time. Less surprises. <a href="https://www.casualarticlesandblogsonline.com/voipphone" rel="nofollow">virtual phone</a>

2 months

1
0
0 / 0

bedipi9079

by bedipi9079＠scarden.com

https://www.casualarticlesandblogsonline.com In particular promoting Xingma dishes, this branch has been in Harbor metropolis for a long time. After the maintenance, the chef has adjusted the menu and taste once more, so I went to strive it again. To be sincere, I had an amazing time this time. Less surprises.

2 months

1
0
0 / 0

bedipi9079

by bedipi9079＠scarden.com

In particular promoting Xingma dishes, this branch has been in Harbor metropolis for a long time. After the maintenance, the chef has adjusted the menu and taste once more, so I went to strive it again. To be sincere, I had an amazing time this time. Less surprises. https://www.casualarticlesandblogsonline.com

2 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

Devel October 2024