December 2024 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: common_utils: Added additional documentation to doc strings
by Lior Suliman (GerritHub) 25 Dec '24

25 Dec '24

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1205849?usp=email to review the following change. Change subject: common_utils: Added additional documentation to doc strings ...................................................................... common_utils: Added additional documentation to doc strings Change-Id: I4d05300f092a6da84c4ff170a74af9c8b5b1875d Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/include/common_utils.h 1 file changed, 8 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/1205849/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1205849?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4d05300f092a6da84c4ff170a74af9c8b5b1875d Gerrit-Change-Number: 1205849 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

2 1

[M] Change in ...nfs-ganesha[next]: Sticky Grace Configurable option
by Name of user not set (GerritHub) 23 Dec '24

23 Dec '24

Vidya.Thumukunta(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206285?usp=email ) Change subject: Sticky Grace Configurable option ...................................................................... Sticky Grace Configurable option Change-Id: I6969b4ec8631663663dca51d4107f067967cc2bc Signed-off-by: VidyaThumukunta <Vidya.Thumukunta(a)ibm.com> --- M src/SAL/nfs4_recovery.c M src/config_samples/config.txt M src/doc/man/ganesha-core-config.rst M src/include/gsh_config.h M src/support/nfs_read_conf.c 5 files changed, 51 insertions(+), 20 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/85/1206285/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206285?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6969b4ec8631663663dca51d4107f067967cc2bc Gerrit-Change-Number: 1206285 Gerrit-PatchSet: 1 Gerrit-Owner: Vidya.Thumukunta(a)ibm.com

1 0

[S] Change in ...nfs-ganesha[next]: fix(export): check duplicated pseudo path before updating exports
by Zhitao Li (GerritHub) 20 Dec '24

20 Dec '24

Zhitao Li has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206176?usp=email ) Change subject: fix(export): check duplicated pseudo path before updating exports ...................................................................... fix(export): check duplicated pseudo path before updating exports Change-Id: I1ffd8b9edaabc3cf680d968838c058fdceea43b2 Signed-off-by: zhitaoli <zhitao.li(a)iomesh.com> --- M src/support/exports.c 1 file changed, 22 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/76/1206176/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206176?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1ffd8b9edaabc3cf680d968838c058fdceea43b2 Gerrit-Change-Number: 1206176 Gerrit-PatchSet: 1 Gerrit-Owner: Zhitao Li <zhitao.li(a)iomesh.com>

1 0

[S] Change in ...nfs-ganesha[next]: nfs_main.c: Use dup2 to simplify function calls
by bjfhdhhaha (GerritHub) 19 Dec '24

19 Dec '24

bjfhdhhaha has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206085?usp=email ) Change subject: nfs_main.c: Use dup2 to simplify function calls ...................................................................... nfs_main.c: Use dup2 to simplify function calls Change-Id: I5c40b644ec15e34950f0526ae734e1b23a6e716d Signed-off-by: bjfhdhhaha <1453769042(a)qq.com> --- M src/MainNFSD/nfs_main.c 1 file changed, 3 insertions(+), 26 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/85/1206085/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1206085?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5c40b644ec15e34950f0526ae734e1b23a6e716d Gerrit-Change-Number: 1206085 Gerrit-PatchSet: 1 Gerrit-Owner: bjfhdhhaha <1453769042(a)qq.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Fix the issue where the nfs4_op_write function always returns 0.
by yinlei (GerritHub) 18 Dec '24

18 Dec '24

yinlei has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1205959?usp=email ) Change subject: Fix the issue where the nfs4_op_write function always returns 0. ...................................................................... Fix the issue where the nfs4_op_write function always returns 0. Change-Id: I8be28ded14d4e37748f94a2f9d9d422245fff989 Signed-off-by: yinlei <yinlei2(a)lenovo.com> --- M src/Protocols/NFS/nfs4_op_write.c 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/59/1205959/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1205959?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8be28ded14d4e37748f94a2f9d9d422245fff989 Gerrit-Change-Number: 1205959 Gerrit-PatchSet: 1 Gerrit-Owner: yinlei <yinlei2(a)lenovo.com>

1 0

Announce Push of V6.4
by Frank Filz 13 Dec '24

13 Dec '24

Branch next Tag:V6.4 Merge Highlights This merge is mostly small patches from Google to closer match their internal repos. Patches that are bug fixes are listed first followed by some minor "features". * Fix build break for USE_NFS3=OFF * Replace _LINUX macro with linux * Handle suid, sgid bits reset during chown operation * src/SAL/state_lock: Fix a bug of adressing the wrong field * Free allocated strings * nfs4_op_open: Check permissions on upgrade re-open * Added a metric for dropped gss requests * fsal_manager.c: Add support to configure / init static fsals * Add dbus method reread_config * client_mgr: Expose DBUS method to disconnect a nfsv41 client * nfs4_pseudo.c: Update some comments * Added logs and lttng traces * Added missing includes and initializations * Clang format cc files * src: Clang formatting * CMakeLists: Resolve __FILE__ to a relative path to the project in logs by default * Replace malloc and free with gsh_malloc and gsh_free respectively * idmapping cache cleanup: log number of entries removed * Gss-callbacks: Remove rpc callback initialisation on startup * Extracted credentials squashing logic to a separate function * Extracted setting the extended groups to a separate function * Use cmake3 to build Ganesha on centos * Added an option to print the client XID as part of the log entry * Added nfs request to op context if a request is originated from nfs client Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 178e02de9 Frank S. Filz V6.4 a7bd32d8b izxl007 nfs4_pseudo.c: Update some comments 72b4544ca Sachin Punadikar Fix build break for USE_NFS3=OFF e090a299d Frank S. Filz Replace _LINUX macro with linux c6343a211 Lior Suliman Added a metric for dropped gss requests 0b9d7a984 Lior Suliman Added logs and lttng traces 7eeafc8b9 Dipit Grover Handle suid, sgid bits reset during chown operation 0d70330da Lior Suliman Added missing includes and initializations ea6d183e6 Lior Suliman Clang format cc files f2db73ff6 Lior Suliman fsal_manager.c: Add support to configure / init static fsals 6b3f9e437 Lior Suliman src: Clang formatting dfd26b7b9 Lior Suliman CMakeLists: Resolve __FILE__ to a relative path to the project in logs by default 5c0b0ff8a Lior Suliman Add dbus method reread_config dd2c3edc5 Lior Suliman src/SAL/state_lock: Fix a bug of adressing the wrong field a0ab1c690 Gaurav Sharma Replace malloc and free with gsh_malloc and gsh_free respectively 74266e89e Ofir Vainshtein nfs_lib.c: Free allocated strings cb098d40e Dipit Grover idmapping cache cleanup: log number of entries removed bacd45e72 Lior Suliman nfs4_op_open: Check permissions on upgrade re-open b89ee1347 Dipit Grover client_mgr: Expose DBUS method to disconnect a nfsv41 client 789b30dc2 Lior Suliman Gss-callbacks: Remove rpc callback initialisation on startup ed0ef716d Lior Suliman Extracted credentials squashing logic to a separate function 544b951e1 Lior Suliman Extracted setting the extended groups to a separate function 053f1351c Lior Suliman Use cmake3 to build Ganesha on centos 2b4682f04 Lior Suliman Added an option to print the client XID as part of the log entry 078e7281f Lior Suliman Added nfs request to op context if a request is originated from nfs client

1 0

[M] Change in ...nfs-ganesha[next]: Adding xattr support to FSAL_VFS
by Fritz Elfert (GerritHub) 11 Dec '24

11 Dec '24

Fritz Elfert has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1205520?usp=email ) Change subject: Adding xattr support to FSAL_VFS ...................................................................... Adding xattr support to FSAL_VFS Change-Id: Ibfcbc57bd331d344cc7560a8f0fd92c70bf5a822 Signed-off-by: Fritz Elfert <fritz-github(a)fritz-elfert.de> --- M src/FSAL/FSAL_VFS/handle.c M src/FSAL/FSAL_VFS/vfs/main-c.in.cmake 2 files changed, 185 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/20/1205520/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1205520?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ibfcbc57bd331d344cc7560a8f0fd92c70bf5a822 Gerrit-Change-Number: 1205520 Gerrit-PatchSet: 1 Gerrit-Owner: Fritz Elfert <fritz-github(a)fritz-elfert.de>

1 0

[M] Change in ...nfs-ganesha[next]: feat(recovery_fs): reject reclaim in edge conditions
by Zhitao Li (GerritHub) 09 Dec '24

09 Dec '24

Zhitao Li has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1205392?usp=email ) Change subject: feat(recovery_fs): reject reclaim in edge conditions ...................................................................... feat(recovery_fs): reject reclaim in edge conditions This commit enforces the state reclaim in recovery_fs backend. On OP_RECLAIM_COMPLETE, a file named `reclaim_complete` is created under the directory of the client id, like revoked file handles. When recovery starts, the existence of this file fills the client record in add_clid_entry() callback, which will be used to decide whether the relevant client can reclaim states or not. Change-Id: Ied2bbfd044594531a6580758032de30d16859c3e Signed-off-by: zhitaoli <zhitao.li(a)iomesh.com> --- M src/SAL/recovery/recovery_fs.c 1 file changed, 112 insertions(+), 23 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/92/1205392/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1205392?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ied2bbfd044594531a6580758032de30d16859c3e Gerrit-Change-Number: 1205392 Gerrit-PatchSet: 1 Gerrit-Owner: Zhitao Li <zhitao.li(a)iomesh.com>

1 0

[XS] Change in ...nfs-ganesha[next]: nfs4_pseudo.c: Minor comment fixup
by Zheng Zeng (GerritHub) 06 Dec '24

06 Dec '24

Zheng Zeng has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1205311?usp=email ) Change subject: nfs4_pseudo.c: Minor comment fixup ...................................................................... nfs4_pseudo.c: Minor comment fixup Change-Id: I5bd82d275ed803e08e82b8cd02bacf30dd92e6cb Signed-off-by: izxl007 <zengzheng007(a)163.com> --- M src/Protocols/NFS/nfs4_pseudo.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/11/1205311/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1205311?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5bd82d275ed803e08e82b8cd02bacf30dd92e6cb Gerrit-Change-Number: 1205311 Gerrit-PatchSet: 1 Gerrit-Owner: Zheng Zeng <zengzheng007(a)163.com>

1 0

[S] Change in ...nfs-ganesha[next]: nfs4_pseudo.c: Fix the description of the make_pseudofs_node function
by Zheng Zeng (GerritHub) 06 Dec '24

06 Dec '24

Zheng Zeng has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1205310?usp=email ) Change subject: nfs4_pseudo.c: Fix the description of the make_pseudofs_node function ...................................................................... nfs4_pseudo.c: Fix the description of the make_pseudofs_node function Change-Id: I8e219048f6d3eea01860c416df6a426420227b4f Signed-off-by: izxl007 <zengzheng007(a)163.com> --- M src/Protocols/NFS/nfs4_pseudo.c 1 file changed, 10 insertions(+), 11 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/10/1205310/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1205310?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8e219048f6d3eea01860c416df6a426420227b4f Gerrit-Change-Number: 1205310 Gerrit-PatchSet: 1 Gerrit-Owner: Zheng Zeng <zengzheng007(a)163.com>

1 0