March 2024 - Devel - NFS Ganesha List Archives

Daylight Saving Time and Community Meeting
by Frank Filz 11 Mar '24

11 Mar '24

Note to all, the US has started Daylight Saving Time as of yesterday. Our community meeting follows which means it will happen 1 hour earlier for those who do not observe Daylight Saving Time, or who have not yet started Daylight Saving Time. Thanks Frank

1 0

[S] Change in ...nfs-ganesha[next]: Remove from fd lru if open/reopen fails and fd is closed
by Name of user not set (GerritHub) 09 Mar '24

09 Mar '24

deepakarumugam.s(a)nutanix.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177971?usp=email ) Change subject: Remove from fd lru if open/reopen fails and fd is closed ...................................................................... Remove from fd lru if open/reopen fails and fd is closed Currently because we are inserting an fd into the lru and then doing the actual open/reopen - we could have situations where we track closed fds in the fd lru. The FSALs typically check if a fd is open before calling close_fsal_fd. This means that fds that are still in the fd lru can be freed. This leads to use after free scenarios. This was another bug we caught when we use asan build for ganesha We are calling fsal_reopen_fd from the same place under 2 scenarios (1) Actual open, the fd was previously closed. if actual open fails - fd remains closed and we end up storing the fd in the lru. (2) Reopen, the fd was previously open. We are reopening it with different flags. If there are failures during reopen today the FSALS don't close the previously open fds - which makes sense. It also makes sense to bump the fd in the lru irrespective of whether or not reopen failed. This patch handles the open error + above (2) scenarios by checking if the fsal closed the fd and removing it from the lru if it did. Change-Id: Iabc8254adaebf909e47740be1d955267958fedaa Signed-off-by: Deepak Arumugam Sankara Subramanian <deepakarumugam.s(a)nutanix.com> --- M src/FSAL/commonlib.c 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/71/1177971/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177971?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iabc8254adaebf909e47740be1d955267958fedaa Gerrit-Change-Number: 1177971 Gerrit-PatchSet: 1 Gerrit-Owner: deepakarumugam.s(a)nutanix.com

1 0

Working on proposed backports to V5-stable for V5.8
by Frank Filz 08 Mar '24

08 Mar '24

I have posted the currently merged V6-dev.x patches, along with notation for backport or not. Large chunks are still not identified either way. Please have a look at: https://docs.google.com/document/d/1zZJDT9RLuF6HZcfuDoE0VmmuIcPiOb3dq6AitzkI e2w/edit?usp=sharing Feel free to request permission to comment (I think you can do that through Google Documents). There are a bunch of candidates not yet merged, so once I merge V6-dev.7, I will update this document with additional patches. Thanks Frank Filz

1 1

Announce Push of V6-dev.7
by Frank Filz 08 Mar '24

08 Mar '24

Branch next Tag:V6-dev.7 NOTE: This merge includes an nitirpc pullup. Please update your submodule Merge Highlights * Fix some memory leaks in config and DRC * FSAL: add function to get an export ref from a filesystem. * GPFS: Fix unexport of 1st export on filesystem * Fix log_an_export critical path overhead * Expose option to FSALs to add object handles to FSAL level handle list * Use __GLIBC__ macro to set pthread RW lock kind * use may_write == false in nfs4_State_Get_Pointer * DBus to summarise the FD usage * Use after free in fd_lru * Reduce the default value of Readdir_Res_Size to 32KB * threads: set appropriate thread stack size for fridge and ntirpc workers Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: f495f2fd8 Frank S. Filz V6-dev.7 9e4a239ee Kaleb S. KEITHLEY threads: set appropriate thread stack size for fridge and ntirpc workers 0efd79871 Deepak Arumugam Sankara Subramanian Reduce the default value of Readdir_Res_Size to 32KB b0a492a43 Deepak Arumugam Sankara Subramanian Use after free in fd_lru 9eaaef6e7 Rojin George DBus to summarise the FD usage be2ab20ce Jon Kohler use may_write == false in nfs4_State_Get_Pointer 081dd698d Rojin George Use __GLIBC__ macro to set pthread RW lock kind 85dc0daf1 Rojin George Expose option to FSALs to add object handles to FSAL level handle list b1b96787c Rojin George Fix log_an_export critical path overhead 60e582ce6 Xueqian Hu Fix memory leak in DRC c7bcad997 Frank S. Filz GPFS: Fix unexport of 1st export on filesystem cdd421d90 Frank S. Filz FSAL: add function to get an export ref from a filesystem. 5771a094f Frank S. Filz Don't leak memory when PSEUDOFS block is not specified. 4452b5d6a Frank S. Filz Don't leak memory for FSAL_LIST config block 3482db42e Frank S. Filz CONFIG: Add ability to specify a block where memory is not allocated if unused

1 0

[M] Change in ...nfs-ganesha[next]: threads: set appropriate thread stack size for fridge and ntirpc workers
by Kaleb KEITHLEY (GerritHub) 07 Mar '24

07 Mar '24

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177874?usp=email ) Change subject: threads: set appropriate thread stack size for fridge and ntirpc workers ...................................................................... threads: set appropriate thread stack size for fridge and ntirpc workers Allow the user to set thread stack size with a command line option. See https://github.com/nfs-ganesha/ntirpc/pull/280 glibc's default thread stack size is 8M. N.B. This can be overridden across the whole process by setting the stack size with ulimit; by default threads will inherit the same size for their thread stack. Empirical testing shows that ganesha works with a thread stack size as small as 16K (the glibc minimum). The same testing shows that ganesha works with ntirpc worker thread stack size of 32K. Change-Id: Ie090175477327a0e72307e3a2282d90f15489f3b Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> --- M src/MainNFSD/nfs_init.c M src/MainNFSD/nfs_lib.c M src/MainNFSD/nfs_main.c M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/include/common_utils.h M src/include/nfs_init.h M src/support/delayed_exec.c M src/support/fridgethr.c 8 files changed, 71 insertions(+), 13 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/74/1177874/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177874?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie090175477327a0e72307e3a2282d90f15489f3b Gerrit-Change-Number: 1177874 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com>

1 0

[S] Change in ...nfs-ganesha[next]: FSAL_CEPH : Add warnings for export creation
by Sachin Punadikar (GerritHub) 06 Mar '24

06 Mar '24

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177770?usp=email ) Change subject: FSAL_CEPH : Add warnings for export creation ...................................................................... FSAL_CEPH : Add warnings for export creation While creating exports in CEPH FSAL, few checks were made to validate the passed in cmount path. On errors, a warning should be logged. Change-Id: I135241b6776090af2ed49adbf9e98783e538e0cd Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/FSAL/FSAL_CEPH/main.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/70/1177770/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177770?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I135241b6776090af2ed49adbf9e98783e538e0cd Gerrit-Change-Number: 1177770 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Use __GLIBC__ macro to set pthread RW lock kind
by Rojin George (GerritHub) 05 Mar '24

05 Mar '24

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177727?usp=email ) Change subject: Use __GLIBC__ macro to set pthread RW lock kind ...................................................................... Use __GLIBC__ macro to set pthread RW lock kind GLIBC is not a defined macro, use __GLIBC__ instead. Change-Id: I8c950ecb3beaf82ced7c5265b804e352aaf21421 Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/include/common_utils.h M src/libntirpc 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/27/1177727/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177727?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8c950ecb3beaf82ced7c5265b804e352aaf21421 Gerrit-Change-Number: 1177727 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: Expose option to FSALs to add object handles to FSAL level handle list
by Rojin George (GerritHub) 01 Mar '24

01 Mar '24

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177657?usp=email ) Change subject: Expose option to FSALs to add object handles to FSAL level handle list ...................................................................... Expose option to FSALs to add object handles to FSAL level handle list FSAL which have no usecase of storing the obj handles within fsal handlers, can skip this handle list at FSAL level. Thereby saving the CPU spend on acquiring fsm_lock during IO. Change-Id: I1fd6558cc25c7ba681da9d29483f6005e25bad3d Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/FSAL/FSAL_CEPH/internal.c M src/FSAL/FSAL_GLUSTER/gluster_internal.c M src/FSAL/FSAL_GLUSTER/handle.c M src/FSAL/FSAL_GPFS/handle.c M src/FSAL/FSAL_KVSFS/kvsfs_handle.c M src/FSAL/FSAL_LIZARDFS/lzfs_internal.c M src/FSAL/FSAL_MEM/mem_export.c M src/FSAL/FSAL_MEM/mem_handle.c M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V4/handle.c M src/FSAL/FSAL_PSEUDO/export.c M src/FSAL/FSAL_PSEUDO/handle.c M src/FSAL/FSAL_RGW/internal.c M src/FSAL/FSAL_VFS/handle.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c M src/FSAL/Stackable_FSALs/FSAL_NULL/handle.c M src/FSAL/commonlib.c M src/include/FSAL/fsal_commonlib.h 19 files changed, 55 insertions(+), 40 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/57/1177657/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177657?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1fd6558cc25c7ba681da9d29483f6005e25bad3d Gerrit-Change-Number: 1177657 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Idmapper: Refactor negative_cache_entry to add an explicit name-buffer
by Dipit Grover (GerritHub) 01 Mar '24

01 Mar '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177653?usp=email ) Change subject: Idmapper: Refactor negative_cache_entry to add an explicit name-buffer ...................................................................... Idmapper: Refactor negative_cache_entry to add an explicit name-buffer This CL adds an explicit name-buffer to the negative_cache_entity. This is intended to improve readability of alloc and free operations on the negative_cache_entity. These operations also allocate and free the name-buffer implicitly. Change-Id: I69e2ba4257ad4addd4f39ad0c97ea44a7b005197 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/idmapper/idmapper_negative_cache.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/53/1177653/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177653?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I69e2ba4257ad4addd4f39ad0c97ea44a7b005197 Gerrit-Change-Number: 1177653 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[S] Change in ...nfs-ganesha[next]: Idmapper: Add function to reap expired user-groups cached entries
by Dipit Grover (GerritHub) 01 Mar '24

01 Mar '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177652?usp=email ) Change subject: Idmapper: Add function to reap expired user-groups cached entries ...................................................................... Idmapper: Add function to reap expired user-groups cached entries This CL adds a function in uid2grp to reap expired user-groups cached entries. This function is called by the idmapper reaper as part of its periodic reaping. Change-Id: I0fc195230939793ba078107163147fb85acf87e9 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/idmapper/idmapper.c M src/include/uid2grp.h M src/support/uid2grp_cache.c 3 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/52/1177652/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177652?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0fc195230939793ba078107163147fb85acf87e9 Gerrit-Change-Number: 1177652 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0