March 2024 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: Idmapper: Limit max user-cache entries, and add a fifo queue
by Dipit Grover (GerritHub) 01 Mar '24

01 Mar '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177641?usp=email ) Change subject: Idmapper: Limit max user-cache entries, and add a fifo queue ...................................................................... Idmapper: Limit max user-cache entries, and add a fifo queue This change limits the max number of user entries in the cache. The limit is configurable through the DIRECTORY_SERVICES section in Ganesha config. The cache eviction strategy is determined using the fifo queue. The fifo queue order mimics the order of expiration time of the cache entries, since expiration time is a linear function of the insertion time -- expiration_time = insertion_time + cache_validity (constant) The head of the queue therefore contains the entry with least time-validity, and the tail of the queue contains the entry with most time-validity. The eviction happens from the head, and insertion happens at the tail. Change-Id: I78c4544f3b430b1d0be16de766ce5c1def3f79ba Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/doc/man/ganesha-core-config.rst M src/idmapper/idmapper_cache.c M src/include/gsh_config.h M src/support/nfs_read_conf.c 4 files changed, 42 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/41/1177641/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177641?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I78c4544f3b430b1d0be16de766ce5c1def3f79ba Gerrit-Change-Number: 1177641 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: Idmapper: Extract user and group cache removal into separate functions
by Dipit Grover (GerritHub) 01 Mar '24

01 Mar '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177640?usp=email ) Change subject: Idmapper: Extract user and group cache removal into separate functions ...................................................................... Idmapper: Extract user and group cache removal into separate functions Change-Id: Ie71b336be6cf2ef7ff986019a4a92d4c9025e1a7 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/idmapper/idmapper_cache.c 1 file changed, 34 insertions(+), 26 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/40/1177640/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177640?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie71b336be6cf2ef7ff986019a4a92d4c9025e1a7 Gerrit-Change-Number: 1177640 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Idmapper: Also clear user-groups cache when performing cleanup
by Dipit Grover (GerritHub) 01 Mar '24

01 Mar '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177639?usp=email ) Change subject: Idmapper: Also clear user-groups cache when performing cleanup ...................................................................... Idmapper: Also clear user-groups cache when performing cleanup Change-Id: I2d8e9a6cbc90b023ff1f771a6df1bc7f9bbea1bb Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/support/uid2grp_cache.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/1177639/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177639?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2d8e9a6cbc90b023ff1f771a6df1bc7f9bbea1bb Gerrit-Change-Number: 1177639 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Idmapper: Add idmapped-group's time validity to DIRECTORY_SERVICES co...
by Dipit Grover (GerritHub) 01 Mar '24

01 Mar '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177638?usp=email ) Change subject: Idmapper: Add idmapped-group's time validity to DIRECTORY_SERVICES config ...................................................................... Idmapper: Add idmapped-group's time validity to DIRECTORY_SERVICES config Currently, idmapping code uses a common config param to handle expiration of all idmapping entities. This CL extracts idmapped- -group's time validity into a separate config within DIRECTORY_SERVICES config section of Ganesha config. Change-Id: I44734da251a648cd60d24cd9b856abf79ceb1920 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/doc/man/ganesha-core-config.rst M src/idmapper/idmapper_cache.c M src/include/gsh_config.h M src/support/nfs_read_conf.c 4 files changed, 7 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/38/1177638/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177638?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I44734da251a648cd60d24cd9b856abf79ceb1920 Gerrit-Change-Number: 1177638 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Idmapper: Add idmapped-user's time validity to DIRECTORY_SERVICES config
by Dipit Grover (GerritHub) 01 Mar '24

01 Mar '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177637?usp=email ) Change subject: Idmapper: Add idmapped-user's time validity to DIRECTORY_SERVICES config ...................................................................... Idmapper: Add idmapped-user's time validity to DIRECTORY_SERVICES config Currently, idmapping code uses a common config param to handle expiration of all idmapping entities. This CL extracts idmapped- -user's time validity into a separate config within DIRECTORY_SERVICES config section of Ganesha config. Change-Id: I943d4f83aa2a0f3f02f7649b5ffd4ae38db1f895 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/doc/man/ganesha-core-config.rst M src/idmapper/idmapper_cache.c M src/include/gsh_config.h M src/support/nfs_read_conf.c 4 files changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/37/1177637/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177637?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I943d4f83aa2a0f3f02f7649b5ffd4ae38db1f895 Gerrit-Change-Number: 1177637 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: Idmapper: Move gsh-buffer comparator function to common_utils
by Dipit Grover (GerritHub) 01 Mar '24

01 Mar '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177636?usp=email ) Change subject: Idmapper: Move gsh-buffer comparator function to common_utils ...................................................................... Idmapper: Move gsh-buffer comparator function to common_utils Change-Id: Id3c8e6e48bf007fbfd654708c914abb3b69572e0 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/idmapper/idmapper_cache.c M src/include/common_utils.h M src/support/uid2grp_cache.c 3 files changed, 33 insertions(+), 63 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/36/1177636/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177636?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id3c8e6e48bf007fbfd654708c914abb3b69572e0 Gerrit-Change-Number: 1177636 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[S] Change in ...nfs-ganesha[next]: Don't leak memory when PSEUDOFS block is not specified.
by Frank Filz (GerritHub) 29 Feb '24

29 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177619?usp=email ) Change subject: Don't leak memory when PSEUDOFS block is not specified. ...................................................................... Don't leak memory when PSEUDOFS block is not specified. Change-Id: I0af8a7c07bb591394787edc70da40c7e1f1e427c Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/support/exports.c 1 file changed, 26 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/19/1177619/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177619?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0af8a7c07bb591394787edc70da40c7e1f1e427c Gerrit-Change-Number: 1177619 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Don't leak memory for FSAL_LIST config block
by Frank Filz (GerritHub) 29 Feb '24

29 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177618?usp=email ) Change subject: Don't leak memory for FSAL_LIST config block ...................................................................... Don't leak memory for FSAL_LIST config block A dummy block was allocated. It's not actually used for anything, so just use static memory. Change-Id: I81dcaf1665d82f332b4771753adce3a233478b20 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/fsal_manager.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/18/1177618/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177618?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I81dcaf1665d82f332b4771753adce3a233478b20 Gerrit-Change-Number: 1177618 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: CONFIG: Add ability to specify a block where memory is not allocated ...
by Frank Filz (GerritHub) 29 Feb '24

29 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177617?usp=email ) Change subject: CONFIG: Add ability to specify a block where memory is not allocated if unused ...................................................................... CONFIG: Add ability to specify a block where memory is not allocated if unused Some config blocks allocate memory for the defaults if not present in the config file. Allow these blocks to not be default initialized if not present. Change-Id: I851c9f99c86a9d7e807efc3c2e3c7ec37f049284 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/config_parsing/config_parsing.c M src/include/config_parsing.h 2 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/17/1177617/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177617?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I851c9f99c86a9d7e807efc3c2e3c7ec37f049284 Gerrit-Change-Number: 1177617 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0