March 2024 - Devel - NFS Ganesha List Archives

[M] Change in ...nfs-ganesha[next]: Idmapper: Limit max user-groups cache entries, and add a fifo queue
by Dipit Grover (GerritHub) 01 Mar '24

01 Mar '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177651?usp=email ) Change subject: Idmapper: Limit max user-groups cache entries, and add a fifo queue ...................................................................... Idmapper: Limit max user-groups cache entries, and add a fifo queue This change limits the max number of user-groups entries in the uid2grp cache. The limit is configurable through the DIRECTORY_SERVICES section in Ganesha config. The cache eviction strategy is determined using the fifo queue. The fifo queue order mimics the order of expiration time of the cache entries, since expiration time is a linear function of the insertion time -- expiration_time = insertion_time + cache_validity (constant) The head of the queue therefore contains the entry with least time-validity, and the tail of the queue contains the entry with most time-validity. The eviction happens from the head, and insertion happens at the tail. Change-Id: I8dae2b3597bc6604328dd6699d24eb128544fb93 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/doc/man/ganesha-core-config.rst M src/include/gsh_config.h M src/support/nfs_read_conf.c M src/support/uid2grp_cache.c 4 files changed, 52 insertions(+), 18 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/51/1177651/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177651?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8dae2b3597bc6604328dd6699d24eb128544fb93 Gerrit-Change-Number: 1177651 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: Idmapper: Add reaper function for negative cache
by Dipit Grover (GerritHub) 01 Mar '24

01 Mar '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177650?usp=email ) Change subject: Idmapper: Add reaper function for negative cache ...................................................................... Idmapper: Add reaper function for negative cache This CL adds a function to reap negative idmapper cache. This function will be called by the idmapper reaper. Change-Id: Ic1dfd2188c2816eca35e1dd03c3662c1a20c36e6 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/idmapper/idmapper.c M src/idmapper/idmapper_negative_cache.c M src/include/idmapper.h 3 files changed, 54 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/50/1177650/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177650?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic1dfd2188c2816eca35e1dd03c3662c1a20c36e6 Gerrit-Change-Number: 1177650 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: Idmapper: Move idmapper_cache reaper to idmapper
by Dipit Grover (GerritHub) 01 Mar '24

01 Mar '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177649?usp=email ) Change subject: Idmapper: Move idmapper_cache reaper to idmapper ...................................................................... Idmapper: Move idmapper_cache reaper to idmapper This CL moves the previously added idmapper-cache reaper to idmapper. The reaper would be responsible for reaping all idmapping caches (both positive and negative) Change-Id: Ia2acc53afcb06fc338f4e8ee88a5495f85b721b3 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/idmapper/idmapper.c M src/idmapper/idmapper_cache.c M src/include/idmapper.h 3 files changed, 78 insertions(+), 49 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/1177649/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177649?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia2acc53afcb06fc338f4e8ee88a5495f85b721b3 Gerrit-Change-Number: 1177649 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[S] Change in ...nfs-ganesha[next]: Idmapper: Integrate group negative-cache during name resolution
by Dipit Grover (GerritHub) 01 Mar '24

01 Mar '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177648?usp=email ) Change subject: Idmapper: Integrate group negative-cache during name resolution ...................................................................... Idmapper: Integrate group negative-cache during name resolution Change-Id: Ife26f53f2e014e3d5b06ca49641f9dc3d9121451 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/idmapper/idmapper.c M src/include/idmapper.h 2 files changed, 26 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/48/1177648/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177648?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ife26f53f2e014e3d5b06ca49641f9dc3d9121451 Gerrit-Change-Number: 1177648 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: Idmapper: Integrate user negative-cache during name/principal resolution
by Dipit Grover (GerritHub) 01 Mar '24

01 Mar '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177646?usp=email ) Change subject: Idmapper: Integrate user negative-cache during name/principal resolution ...................................................................... Idmapper: Integrate user negative-cache during name/principal resolution Change-Id: I0d5b1ddf6629c2821b2b842d92768290770e16a2 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/idmapper/idmapper.c M src/include/idmapper.h 2 files changed, 54 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/46/1177646/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177646?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0d5b1ddf6629c2821b2b842d92768290770e16a2 Gerrit-Change-Number: 1177646 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[L] Change in ...nfs-ganesha[next]: Idmapper: Introduce negative cache for group entries
by Dipit Grover (GerritHub) 01 Mar '24

01 Mar '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177647?usp=email ) Change subject: Idmapper: Introduce negative cache for group entries ...................................................................... Idmapper: Introduce negative cache for group entries This change introduces a negative cache for storing group entries that failed idmapping. The validity and max-count of such entries is derived from the DIRECTORY_SERVICES section of the Ganesha config. This cache is maintained separately from positive cache, to allow for independent operation, configuration and maintenance. To avoid code duplication, this CL generalises the existing code for negative user cache and adapts it for both negative user and negative group entities. Change-Id: I2120b730ce3b2bb33d953d657cc9717c8338311b Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/doc/man/ganesha-core-config.rst M src/idmapper/idmapper_negative_cache.c M src/include/gsh_config.h M src/include/idmapper.h M src/support/nfs_read_conf.c 5 files changed, 247 insertions(+), 86 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/47/1177647/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177647?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2120b730ce3b2bb33d953d657cc9717c8338311b Gerrit-Change-Number: 1177647 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[L] Change in ...nfs-ganesha[next]: Idmapper: Introduce negative cache for user entries
by Dipit Grover (GerritHub) 01 Mar '24

01 Mar '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177645?usp=email ) Change subject: Idmapper: Introduce negative cache for user entries ...................................................................... Idmapper: Introduce negative cache for user entries This change introduces a negative cache for storing user entries that failed idmapping. The validity and max-count of such entries is derived from the DIRECTORY_SERVICES section of the Ganesha config. This cache is maintained separately from positive cache, to allow for independent operation, configuration and maintenance. Note that we do not store the anonymous uid and gid resolved for such entries, because these resolved ids for a given entry can vary across different incoming nfs op-requests. Each request uses the anonymous uid,gid configured for the respective client's export that is being accessed. Change-Id: I4c2e085d33dbf70feb5d38bad5d1014669ec4953 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/doc/man/ganesha-core-config.rst M src/idmapper/CMakeLists.txt A src/idmapper/idmapper_negative_cache.c M src/include/gsh_config.h M src/include/idmapper.h M src/support/nfs_read_conf.c 6 files changed, 255 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/45/1177645/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177645?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4c2e085d33dbf70feb5d38bad5d1014669ec4953 Gerrit-Change-Number: 1177645 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: Idmapper: Remove redundant else block from name2id function
by Dipit Grover (GerritHub) 01 Mar '24

01 Mar '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177644?usp=email ) Change subject: Idmapper: Remove redundant else block from name2id function ...................................................................... Idmapper: Remove redundant else block from name2id function Change-Id: I2541a27aa3563dd050187bb18f5dbcf99eb396c4 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/idmapper/idmapper.c 1 file changed, 36 insertions(+), 39 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/44/1177644/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177644?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2541a27aa3563dd050187bb18f5dbcf99eb396c4 Gerrit-Change-Number: 1177644 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: Idmapper: Introduce reaper to remove expired user, group cache entries
by Dipit Grover (GerritHub) 01 Mar '24

01 Mar '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177643?usp=email ) Change subject: Idmapper: Introduce reaper to remove expired user, group cache entries ...................................................................... Idmapper: Introduce reaper to remove expired user, group cache entries This change adds cache reaper functionality for the user and group caches. The reaper runs periodically and removes the expired cache entries. The reaper execution interval is configurable through the Ganesha config. Note that the default value of this execution interval is currently set to about ten years, which basically means that the reaper is disabled. It will be enabled in the future based on the cache performance in production. Change-Id: I6588798f72e94f3157e1622872c1da3c2924534c Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/doc/man/ganesha-core-config.rst M src/idmapper/idmapper_cache.c M src/include/gsh_config.h M src/support/nfs_read_conf.c 4 files changed, 93 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/43/1177643/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177643?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6588798f72e94f3157e1622872c1da3c2924534c Gerrit-Change-Number: 1177643 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[S] Change in ...nfs-ganesha[next]: Idmapper: Limit max group-cache entries, and add a fifo queue
by Dipit Grover (GerritHub) 01 Mar '24

01 Mar '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177642?usp=email ) Change subject: Idmapper: Limit max group-cache entries, and add a fifo queue ...................................................................... Idmapper: Limit max group-cache entries, and add a fifo queue This change limits the max number of group entries in the cache. The limit is configurable through the DIRECTORY_SERVICES section in Ganesha config. The cache eviction strategy is determined using the fifo queue. The fifo queue order mimics the order of expiration time of the cache entries, since expiration time is a linear function of the insertion time -- expiration_time = insertion_time + cache_validity (constant) The head of the queue therefore contains the entry with least time-validity, and the tail of the queue contains the entry with most time-validity. The eviction happens from the head, and insertion happens at the tail. Change-Id: If590670162bd5a814959d4a81d5fd02eaa990256 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/doc/man/ganesha-core-config.rst M src/idmapper/idmapper_cache.c M src/include/gsh_config.h M src/support/nfs_read_conf.c 4 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/42/1177642/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177642?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If590670162bd5a814959d4a81d5fd02eaa990256 Gerrit-Change-Number: 1177642 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0