September 2024 - Devel - NFS Ganesha List Archives

[XS] Change in ...nfs-ganesha[next]: nfs4_op_open: Check permissions on upgrade re-open
by Lior Suliman (GerritHub) 18 Sep '24

18 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201415?usp=email ) Change subject: nfs4_op_open: Check permissions on upgrade re-open ...................................................................... nfs4_op_open: Check permissions on upgrade re-open Without the permission check here it means that if a client has an open state on a file, it can just open any other open state without a permission checks. Specifically it means that if you have read permissions and open a file for read, then while you have that open state, you can open the file for write, even without having permissions. Change-Id: I005d9dd3e484da812887551ac3f3b159a05db761 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/Protocols/NFS/nfs4_op_open.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/1201415/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201415?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I005d9dd3e484da812887551ac3f3b159a05db761 Gerrit-Change-Number: 1201415 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

1 0

[XS] Change in ...nfs-ganesha[next]: CMakeLists: Resolve __FILE__ to a relative path to the project
by Lior Suliman (GerritHub) 18 Sep '24

18 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201406?usp=email ) Change subject: CMakeLists: Resolve __FILE__ to a relative path to the project ...................................................................... CMakeLists: Resolve __FILE__ to a relative path to the project This is made so logs will not contain the full path to source files Change-Id: I9c7b98d0eecae497f8d8524821529ba94668edca src/CMakeLists: Added a check for the file-prefix-map flag before using it RockyLinux: Use -fmacro-prefix-map instead of -ffile-prefix-map - The intention behind introducing a new compiler flag was to eliminate lengthy file names in Ganesha logs. However, this flag also modifies the source file paths in binary executables, making it impossible to debug using gdb. Change-Id: Id55cf35f0b0415967c7c11d87e0f3fb508f0a2e8 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/CMakeLists.txt 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/06/1201406/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201406?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id55cf35f0b0415967c7c11d87e0f3fb508f0a2e8 Gerrit-Change-Number: 1201406 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

1 0

[M] Change in ...nfs-ganesha[next]: client_mgr: Expose DBUS method to disconnect a nfsv41 client
by Lior Suliman (GerritHub) 18 Sep '24

18 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201405?usp=email ) Change subject: client_mgr: Expose DBUS method to disconnect a nfsv41 client ...................................................................... client_mgr: Expose DBUS method to disconnect a nfsv41 client The exposed DBUS API will destroy all the connections of an nfs41-client. Change-Id: Ide4453d92c7ee5691b496e3527792417f72d79d6 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/include/server_stats_private.h M src/support/client_mgr.c 2 files changed, 61 insertions(+), 20 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/05/1201405/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201405?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ide4453d92c7ee5691b496e3527792417f72d79d6 Gerrit-Change-Number: 1201405 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-CC: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[XS] Change in ...nfs-ganesha[next]: FSAL/FSAL_CEPH/handle.c: Moved tracepoint to reduce indentation
by Lior Suliman (GerritHub) 18 Sep '24

18 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201404?usp=email ) Change subject: FSAL/FSAL_CEPH/handle.c: Moved tracepoint to reduce indentation ...................................................................... FSAL/FSAL_CEPH/handle.c: Moved tracepoint to reduce indentation Change-Id: Ie1489c2ebd240f4959d96589e943277480499390 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/FSAL/FSAL_CEPH/handle.c 1 file changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/04/1201404/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201404?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie1489c2ebd240f4959d96589e943277480499390 Gerrit-Change-Number: 1201404 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

1 0

[XS] Change in ...nfs-ganesha[next]: MDCACHE: Fix Coverity CID 502134 - move writelock in mdcache_setattr2
by Frank Filz (GerritHub) 17 Sep '24

17 Sep '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201403?usp=email ) Change subject: MDCACHE: Fix Coverity CID 502134 - move writelock in mdcache_setattr2 ...................................................................... MDCACHE: Fix Coverity CID 502134 - move writelock in mdcache_setattr2 By moving the writelock in mdcache_setattr2 to the top, we protect the use of change from before the attributes are changed in the backend through the verification that it changed. Change-Id: Ica749a34a07e20a7a0b12a971cbb2644a437b8d4 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/03/1201403/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201403?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ica749a34a07e20a7a0b12a971cbb2644a437b8d4 Gerrit-Change-Number: 1201403 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: parsing: fix Coverity CID 502136 - string buffers need +1 for NUL
by Frank Filz (GerritHub) 17 Sep '24

17 Sep '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201402?usp=email ) Change subject: parsing: fix Coverity CID 502136 - string buffers need +1 for NUL ...................................................................... parsing: fix Coverity CID 502136 - string buffers need +1 for NUL Change-Id: I7fdcf7bfb3e5e7c1189cb84e913b7ad0c5acd72c Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/config_parsing/conf_lex.l 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/1201402/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201402?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7fdcf7bfb3e5e7c1189cb84e913b7ad0c5acd72c Gerrit-Change-Number: 1201402 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: src/MainNFSD/nfs_rpc_dispatcher_thread: Fix typo
by Lior Suliman (GerritHub) 17 Sep '24

17 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201397?usp=email ) Change subject: src/MainNFSD/nfs_rpc_dispatcher_thread: Fix typo ...................................................................... src/MainNFSD/nfs_rpc_dispatcher_thread: Fix typo Change-Id: I05608cf6bc0a4404dda42209ce3544ce3952c0c5 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/MainNFSD/nfs_rpc_dispatcher_thread.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/1201397/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201397?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I05608cf6bc0a4404dda42209ce3544ce3952c0c5 Gerrit-Change-Number: 1201397 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

1 0

[M] Change in ...nfs-ganesha[next]: nfs4_clientid: Add method to destroy all connections of a client
by Lior Suliman (GerritHub) 17 Sep '24

17 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201395?usp=email ) Change subject: nfs4_clientid: Add method to destroy all connections of a client ...................................................................... nfs4_clientid: Add method to destroy all connections of a client This method will be used by the DBUS API to destroy all the connections of a nfs41-client. Signed-off-by: Lior Suliman <liorsu(a)gmail.com> Change-Id: Ibd90c1d7b0f2b68d340b9d349e3d3600af83c5ca --- M src/SAL/nfs4_clientid.c M src/include/sal_functions.h 2 files changed, 74 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/1201395/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201395?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ibd90c1d7b0f2b68d340b9d349e3d3600af83c5ca Gerrit-Change-Number: 1201395 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-CC: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[XS] Change in ...nfs-ganesha[next]: nfs4_clientid: log cred_flavor when printing the client record
by Lior Suliman (GerritHub) 17 Sep '24

17 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201394?usp=email ) Change subject: nfs4_clientid: log cred_flavor when printing the client record ...................................................................... nfs4_clientid: log cred_flavor when printing the client record Signed-off-by: Lior Suliman <liorsu(a)gmail.com> Change-Id: I839c3921b011e63290662d7678382b3fc796a6fd --- M src/SAL/nfs4_clientid.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/94/1201394/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201394?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I839c3921b011e63290662d7678382b3fc796a6fd Gerrit-Change-Number: 1201394 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-CC: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: nfs41_Session: Add method to destroy all connection-xprts of a session
by Lior Suliman (GerritHub) 17 Sep '24

17 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201393?usp=email ) Change subject: nfs41_Session: Add method to destroy all connection-xprts of a session ...................................................................... nfs41_Session: Add method to destroy all connection-xprts of a session This method will be used by the DBUS API to destroy all the connections of a nfs41-client. Change-Id: I6abee241747eaaffa34986f9e830d3112cb4d274 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/SAL/nfs41_session_id.c M src/include/sal_functions.h 2 files changed, 61 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/93/1201393/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201393?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6abee241747eaaffa34986f9e830d3112cb4d274 Gerrit-Change-Number: 1201393 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-CC: Dipit Grover <dipitgrover(a)gmail.com>

1 0