September 2024 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: Use cmake3 to build Ganesha on centos
by Lior Suliman (GerritHub) 16 Sep '24

16 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201314?usp=email ) Change subject: Use cmake3 to build Ganesha on centos ...................................................................... Use cmake3 to build Ganesha on centos Signed-off-by: Lior Suliman <liorsu(a)gmail.com> Change-Id: I8cfd36a47a4d17618b7aacbea4c0088aaf3c4d0a --- A src/build.sh M src/nfs-ganesha.spec-in.cmake 2 files changed, 25 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/14/1201314/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201314?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8cfd36a47a4d17618b7aacbea4c0088aaf3c4d0a Gerrit-Change-Number: 1201314 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

1 0

[S] Change in ...nfs-ganesha[next]: Change NFSv3 proxy FSAL to return delay instead of invalid val or ser...
by Lior Suliman (GerritHub) 16 Sep '24

16 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201312?usp=email ) Change subject: Change NFSv3 proxy FSAL to return delay instead of invalid val or server fault to the client [b/234604886] ...................................................................... Change NFSv3 proxy FSAL to return delay instead of invalid val or server fault to the client [b/234604886] If there is an error in sending / receiving a response to / from the NFSv3 server, return the client with NFS4ERR_DELAY that will cause it to retry issuing that operation https://datatracker.ietf.org/doc/html/rfc5661#section-15.1.1.3 For this not to be an issue, we also need to change the current way the XID is generated by the NFSv3 proxy FSAL so that two requests that are the same will yield with the same XID, otherwise it can be executed more than once by the NFSv3 back-end server as they will be recognized as different request Change-Id: I7f6947898d208bd5ae61768bf710e6e6592d31dd Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V3/nlm.c 2 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/12/1201312/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201312?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7f6947898d208bd5ae61768bf710e6e6592d31dd Gerrit-Change-Number: 1201312 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Update .gitignore
by Lior Suliman (GerritHub) 16 Sep '24

16 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201311?usp=email ) Change subject: Update .gitignore ...................................................................... Update .gitignore Change-Id: I7f11e431b170713ce6cd11f8d716c9cf816d1e87 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M .gitignore 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/11/1201311/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201311?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7f11e431b170713ce6cd11f8d716c9cf816d1e87 Gerrit-Change-Number: 1201311 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

1 0

[S] Change in ...nfs-ganesha[next]: Use cmake3 to build Ganesha on centos
by Lior Suliman (GerritHub) 16 Sep '24

16 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201310?usp=email ) Change subject: Use cmake3 to build Ganesha on centos ...................................................................... Use cmake3 to build Ganesha on centos Change-Id: I061f342e122e72b8c64e36dde3369cffcd451b66 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- A src/build.sh M src/nfs-ganesha.spec-in.cmake 2 files changed, 25 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/10/1201310/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201310?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I061f342e122e72b8c64e36dde3369cffcd451b66 Gerrit-Change-Number: 1201310 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

1 0

[M] Change in ...nfs-ganesha[next]: Added nfs request to op context if a request is originated from nfs c...
by Lior Suliman (GerritHub) 16 Sep '24

16 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201309?usp=email ) Change subject: Added nfs request to op context if a request is originated from nfs client ...................................................................... Added nfs request to op context if a request is originated from nfs client Change-Id: Ia37abd5402005aed3efa8be7cdd90bcf24b108b4 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/FSAL/commonlib.c M src/MainNFSD/9p_dispatcher.c M src/MainNFSD/nfs_worker_thread.c M src/Protocols/9P/9p_proto_tools.c M src/Protocols/NFS/nfs4_pseudo.c M src/Protocols/NLM/nlm_util.c M src/SAL/state_async.c M src/SAL/state_lock.c M src/include/fsal.h M src/include/fsal_api.h M src/include/fsal_types.h M src/support/export_mgr.c 12 files changed, 34 insertions(+), 25 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/09/1201309/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201309?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia37abd5402005aed3efa8be7cdd90bcf24b108b4 Gerrit-Change-Number: 1201309 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

1 0

[S] Change in ...nfs-ganesha[next]: src: Clang formatting
by Lior Suliman (GerritHub) 16 Sep '24

16 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201308?usp=email ) Change subject: src: Clang formatting ...................................................................... src: Clang formatting Change-Id: I8c47d71bf6fcaf13296837bc042c179648988dd3 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/RPCAL/connection_manager.c M src/include/fsal_api.h M src/support/exports.c 3 files changed, 15 insertions(+), 15 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/08/1201308/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201308?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8c47d71bf6fcaf13296837bc042c179648988dd3 Gerrit-Change-Number: 1201308 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

1 0

[S] Change in ...nfs-ganesha[next]: nfs4_op_readdir: Always return NFS4ERR_TOOSMALL if we didn't have eno...
by Name of user not set (GerritHub) 16 Sep '24

16 Sep '24

shaharhoch(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201307?usp=email ) Change subject: nfs4_op_readdir: Always return NFS4ERR_TOOSMALL if we didn't have enough space for a single entry ...................................................................... nfs4_op_readdir: Always return NFS4ERR_TOOSMALL if we didn't have enough space for a single entry There were some flows that set it on failure and some that didn't. Better to always check on failure flow and set it. Change-Id: Ib2cde47fab7d9055d14495e335018a0e27b2d43f Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/Protocols/NFS/nfs4_op_readdir.c 1 file changed, 4 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/07/1201307/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201307?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib2cde47fab7d9055d14495e335018a0e27b2d43f Gerrit-Change-Number: 1201307 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)google.com

1 0

[S] Change in ...nfs-ganesha[next]: nfs4_op_readdir: Fix xdr memory allocation
by Name of user not set (GerritHub) 15 Sep '24

15 Sep '24

shaharhoch(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201273?usp=email ) Change subject: nfs4_op_readdir: Fix xdr memory allocation ...................................................................... nfs4_op_readdir: Fix xdr memory allocation The memory allocation calculation for XDR encoding of READDIR response wasn't done well. The math as it was didn't really make sense, but the main problem was that if we reach the maximum size response we went over the allocated buffer size and got an error on encoding which caused us to return SERVER_FAULT. The maximum size possible happened when the dir entries filled the allocated buffer exactly, and reached EOF, since in that case we needed to also add a FALSE bool for the last entry. In this case we went over the allocated buffer and got an error. I fixed the memory allocation calculation, and hopefully made it more clear. I also tested it when returning the max response size and did not get an error. Change-Id: Ifd333efe292116e54b0e8089d2ed43916937d1b4 Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/Protocols/NFS/nfs4_op_readdir.c 1 file changed, 22 insertions(+), 15 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/73/1201273/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201273?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ifd333efe292116e54b0e8089d2ed43916937d1b4 Gerrit-Change-Number: 1201273 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)google.com

1 0

[S] Change in ...nfs-ganesha[next]: MDCACHE: Fix Coverity CID 502123 - fix lock inversion
by Frank Filz (GerritHub) 13 Sep '24

13 Sep '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201234?usp=email ) Change subject: MDCACHE: Fix Coverity CID 502123 - fix lock inversion ...................................................................... MDCACHE: Fix Coverity CID 502123 - fix lock inversion Instead of doing the mdcache_dirent_invalidate_all in mdcache_refresh_attrs with the attr_lock held, pass the need for invalidate out to the one caller who needs it, who will take the content_lock and call mdcache_dirent_invalidate_all after dropping the attr_lock. Change-Id: I33d24bf4a69dab0de75f34ddd84dc3fcd80af4c2 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h 2 files changed, 19 insertions(+), 11 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/1201234/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201234?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I33d24bf4a69dab0de75f34ddd84dc3fcd80af4c2 Gerrit-Change-Number: 1201234 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Fix vfs_sub_getattrs if called for referral handling
by Christoph Martin (GerritHub) 13 Sep '24

13 Sep '24

Christoph Martin has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201193?usp=email ) Change subject: Fix vfs_sub_getattrs if called for referral handling ...................................................................... Fix vfs_sub_getattrs if called for referral handling Change-Id: I6146df185896a7991e527fa151353f2e9c0e9b54 Signed-off-by: Christoph Martin <martin(a)uni-mainz.de> --- M src/FSAL/FSAL_VFS/vfs/attrs.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/93/1201193/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201193?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6146df185896a7991e527fa151353f2e9c0e9b54 Gerrit-Change-Number: 1201193 Gerrit-PatchSet: 1 Gerrit-Owner: Christoph Martin <martin(a)uni-mainz.de>

1 0