September 2024 - Devel - NFS Ganesha List Archives

[M] Change in ...nfs-ganesha[next]: nfs41_Session: Add method to destroy all connection-xprts of a session
by Lior Suliman (GerritHub) 17 Sep '24

17 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201392?usp=email ) Change subject: nfs41_Session: Add method to destroy all connection-xprts of a session ...................................................................... nfs41_Session: Add method to destroy all connection-xprts of a session This method will be used by the DBUS API to destroy all the connections of a nfs41-client. Signed-off-by: Lior Suliman <liorsu(a)gmail.com> Change-Id: I64f1e7cb8a8d2d3f52b107d7620527d29d9740d4 --- M src/SAL/nfs41_session_id.c M src/include/sal_functions.h 2 files changed, 61 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/92/1201392/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201392?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I64f1e7cb8a8d2d3f52b107d7620527d29d9740d4 Gerrit-Change-Number: 1201392 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-CC: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Gss-callbacks: Set default gss-callback status as false
by Lior Suliman (GerritHub) 16 Sep '24

16 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201355?usp=email ) Change subject: Gss-callbacks: Set default gss-callback status as false ...................................................................... Gss-callbacks: Set default gss-callback status as false This commit sets the global gss-callback status as false on bootup. During init, we also remove the initialisation of krb5 creds cache, and let that be handled as part of the status setting. Change-Id: I2d11ba1985fb92fd02be05c4856d6f32d16a8f77 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/MainNFSD/nfs_rpc_callback.c 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/55/1201355/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201355?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2d11ba1985fb92fd02be05c4856d6f32d16a8f77 Gerrit-Change-Number: 1201355 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

1 0

[XS] Change in ...nfs-ganesha[next]: nfsv4 monitoring: Add metric for dropped rpcsec_gss requests count
by Lior Suliman (GerritHub) 16 Sep '24

16 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201354?usp=email ) Change subject: nfsv4 monitoring: Add metric for dropped rpcsec_gss requests count ...................................................................... nfsv4 monitoring: Add metric for dropped rpcsec_gss requests count Signed-off-by: Lior Suliman <liorsu(a)gmail.com> Change-Id: If029170654b37ce32287b2b69eb2cb1ee2d97305 --- M src/build.sh M src/nfs-ganesha.spec-in.cmake 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/54/1201354/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201354?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If029170654b37ce32287b2b69eb2cb1ee2d97305 Gerrit-Change-Number: 1201354 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

1 0

[M] Change in ...nfs-ganesha[next]: Extracted credentials squashing logic to a separate function
by Lior Suliman (GerritHub) 16 Sep '24

16 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201350?usp=email ) Change subject: Extracted credentials squashing logic to a separate function ...................................................................... Extracted credentials squashing logic to a separate function Signed-off-by: Lior Suliman <liorsu(a)gmail.com> Change-Id: I7dab61aa331e7aea63105571d18461a38490a009 --- M src/support/nfs_creds.c 1 file changed, 96 insertions(+), 92 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/50/1201350/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201350?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7dab61aa331e7aea63105571d18461a38490a009 Gerrit-Change-Number: 1201350 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

1 0

[M] Change in ...nfs-ganesha[next]: Extracted setting the extended groups to a separate function
by Lior Suliman (GerritHub) 16 Sep '24

16 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201349?usp=email ) Change subject: Extracted setting the extended groups to a separate function ...................................................................... Extracted setting the extended groups to a separate function Signed-off-by: Lior Suliman <liorsu(a)gmail.com> Change-Id: I1f0d7a73e56ef7042206fd6c44f9925a102243a7 --- M src/support/nfs_creds.c 1 file changed, 47 insertions(+), 42 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/1201349/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201349?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1f0d7a73e56ef7042206fd6c44f9925a102243a7 Gerrit-Change-Number: 1201349 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

1 0

[XS] Change in ...nfs-ganesha[next]: log_functions: Call gsh_backtrace on Fatal
by Assaf Yaari (GerritHub) 16 Sep '24

16 Sep '24

Assaf Yaari has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201342?usp=email ) Change subject: log_functions: Call gsh_backtrace on Fatal ...................................................................... log_functions: Call gsh_backtrace on Fatal It is very helpfull to see the backtrace on LogFatal conditions. Change-Id: I9655bfa5aa6b8fe749d632e6992318d5d6f1cd44 Signed-off-by: Assaf Yaari <assafy(a)google.com> --- M src/log/log_functions.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/42/1201342/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201342?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9655bfa5aa6b8fe749d632e6992318d5d6f1cd44 Gerrit-Change-Number: 1201342 Gerrit-PatchSet: 1 Gerrit-Owner: Assaf Yaari <assafy(a)google.com>

1 0

[S] Change in ...nfs-ganesha[next]: Added an option to print the client XID as part of the log entry
by Lior Suliman (GerritHub) 16 Sep '24

16 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201318?usp=email ) Change subject: Added an option to print the client XID as part of the log entry ...................................................................... Added an option to print the client XID as part of the log entry Signed-off-by: Lior Suliman <liorsu(a)gmail.com> Change-Id: I8c0564a9ab764f373ce7d4d4b2b36f4f7380ca3e --- M src/config_samples/logging.txt M src/doc/man/ganesha-log-config.rst M src/log/log_functions.c 3 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/18/1201318/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201318?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8c0564a9ab764f373ce7d4d4b2b36f4f7380ca3e Gerrit-Change-Number: 1201318 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

1 0

[XS] Change in ...nfs-ganesha[next]: FSAL_PROXY_V3: Fixed a bug that the FSAL ECFS used the original creds...
by Lior Suliman (GerritHub) 16 Sep '24

16 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201317?usp=email ) Change subject: FSAL_PROXY_V3: Fixed a bug that the FSAL ECFS used the original creds and not the resolved creds ...................................................................... FSAL_PROXY_V3: Fixed a bug that the FSAL ECFS used the original creds and not the resolved creds Signed-off-by: Lior Suliman <liorsu(a)gmail.com> Change-Id: I03e16de995e301d07c39ecef774a4b27b252f26b --- M src/FSAL/FSAL_PROXY_V3/main.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/17/1201317/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201317?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I03e16de995e301d07c39ecef774a4b27b252f26b Gerrit-Change-Number: 1201317 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

1 0

[S] Change in ...nfs-ganesha[next]: Turn on more compilation warnings and resolve existing ones
by Lior Suliman (GerritHub) 16 Sep '24

16 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201316?usp=email ) Change subject: Turn on more compilation warnings and resolve existing ones ...................................................................... Turn on more compilation warnings and resolve existing ones Signed-off-by: Lior Suliman <liorsu(a)gmail.com> Change-Id: I05413e76442077161e752da7ba57756a6da7a33e --- M src/CMakeLists.txt M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_avl.c M src/FSAL/fsal_helper.c M src/Protocols/NFS/nfs_proto_tools.c M src/SAL/nfs4_recovery.c M src/SAL/recovery/recovery_fs.c M src/include/fsal_api.h M src/support/client_mgr.c M src/support/fridgethr.c 9 files changed, 14 insertions(+), 14 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/16/1201316/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201316?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I05413e76442077161e752da7ba57756a6da7a33e Gerrit-Change-Number: 1201316 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

1 0

[S] Change in ...nfs-ganesha[next]: Change NFSv3 proxy FSAL to return delay instead of invalid val or ser...
by Lior Suliman (GerritHub) 16 Sep '24

16 Sep '24

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201315?usp=email ) Change subject: Change NFSv3 proxy FSAL to return delay instead of invalid val or server fault to the client [b/234604886] ...................................................................... Change NFSv3 proxy FSAL to return delay instead of invalid val or server fault to the client [b/234604886] If there is an error in sending / receiving a response to / from the NFSv3 server, return the client with NFS4ERR_DELAY that will cause it to retry issuing that operation https://datatracker.ietf.org/doc/html/rfc5661#section-15.1.1.3 For this not to be an issue, we also need to change the current way the XID is generated by the NFSv3 proxy FSAL so that two requests that are the same will yield with the same XID, otherwise it can be executed more than once by the NFSv3 back-end server as they will be recognized as different request Signed-off-by: Lior Suliman <liorsu(a)gmail.com> Change-Id: If94c1485ec0ea8fca4e9ad2afc8128eaa0baaa77 --- M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V3/nlm.c 2 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/1201315/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201315?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If94c1485ec0ea8fca4e9ad2afc8128eaa0baaa77 Gerrit-Change-Number: 1201315 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

1 0