March 2025 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: feat(dupreq): only evict(retire) completed entries
by Zhitao Li (GerritHub) 22 Mar '25

22 Mar '25

Zhitao Li has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1211994?usp=email ) Change subject: feat(dupreq): only evict(retire) completed entries ...................................................................... feat(dupreq): only evict(retire) completed entries Change-Id: I76e5bb410c4b4b2878f74d653906a140d47fe25f Signed-off-by: zhitaoli <zhitao.li(a)iomesh.com> --- M src/RPCAL/nfs_dupreq.c 1 file changed, 3 insertions(+), 19 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/94/1211994/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1211994?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I76e5bb410c4b4b2878f74d653906a140d47fe25f Gerrit-Change-Number: 1211994 Gerrit-PatchSet: 1 Gerrit-Owner: Zhitao Li <zhitao.li(a)iomesh.com>

1 0

[XS] Change in ...nfs-ganesha[next]: fix(dupreq): set dupreq_entry_t.rc on nfs_dupreq_finish
by Zhitao Li (GerritHub) 22 Mar '25

22 Mar '25

Zhitao Li has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1211993?usp=email ) Change subject: fix(dupreq): set dupreq_entry_t.rc on nfs_dupreq_finish ...................................................................... fix(dupreq): set dupreq_entry_t.rc on nfs_dupreq_finish Change-Id: I721ef5ff934362ae63624709041a19b268581173 Signed-off-by: zhitaoli <zhitao.li(a)iomesh.com> --- M src/RPCAL/nfs_dupreq.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/93/1211993/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1211993?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I721ef5ff934362ae63624709041a19b268581173 Gerrit-Change-Number: 1211993 Gerrit-PatchSet: 1 Gerrit-Owner: Zhitao Li <zhitao.li(a)iomesh.com>

1 0

[XS] Change in ...nfs-ganesha[next]: libganesha_monitoring file not found
by Pragadeeswaran Sathyanaraynaan (GerritHub) 21 Mar '25

21 Mar '25

Pragadeeswaran Sathyanaraynaan has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1211939?usp=email ) Change subject: libganesha_monitoring file not found ...................................................................... libganesha_monitoring file not found During packaging, the below error is observed Processing files: ganesha_monitoring-7-dev.9.el9.x86_64 error: File not found: /root/rpmbuild/BUILDROOT/nfs-ganesha-7-dev.9.el9.x86_64/usr/lib64/libganesha_monitoring* Due to the recent move of monitoring module to ntirpc repo, we are modifying the library to match with the enable. Change-Id: Ief5fa6f23de5c4a785a55a0eb3dfca9e610b66e1 Signed-off-by: Pragadeeswaran Sathyanarayanan <pragadeeswaran.sathyanarayanan(a)ibm.com> --- M src/nfs-ganesha.spec-in.cmake 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/1211939/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1211939?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ief5fa6f23de5c4a785a55a0eb3dfca9e610b66e1 Gerrit-Change-Number: 1211939 Gerrit-PatchSet: 1 Gerrit-Owner: Pragadeeswaran Sathyanaraynaan <psathyan(a)redhat.com>

1 0

Announce Push of V7-dev.10
by Frank Filz 20 Mar '25

20 Mar '25

Branch next Tag:V7-dev.10 Merge Highlights * clang-format: update to newer clang-format * fix monitoring lib loading multiple times * Move fsal_obj_handle_fini() just before gsh_free() in FSAL_GLUSTER handle_release() to prevent SIGSEGV. * Fix for memory leaks in reread exports config. * CEPH:ceph reclaim for node takeover * Added new metric showing ganesha version * Dump total op count in ShowClients and ShowExports * fix(nfs3): drop NFS3ERR_JUKEBOX as configured Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 85e59dd46 Frank S. Filz V7-dev.10 9f98621ad zhitaoli fix(nfs3): drop NFS3ERR_JUKEBOX as configured e457c0dc5 Deepak Arumugam Sankara Subramanian Dump total op count in ShowClients and ShowExports ab14d1cdc Sreedhat Agraharam Added new metric showing ganesha version dd4e8eef6 Sachin Punadikar CEPH:ceph reclaim for node takeover eeb4a2b2c Naresh Chillarege Fix for memory leaks in reread exports config. In case of error while rereading the exports config config_struct memory is not cleanedup. 72565026a Guillaume PENIN Move fsal_obj_handle_fini() just before gsh_free() in FSAL_GLUSTER handle_release() to prevent SIGSEGV. c243ceee8 Roy Babayov fix monitoring lib loading multiple times e9ec7d660 Frank S. Filz clang-format: update to newer clang-format

1 0

[S] Change in ...nfs-ganesha[next]: Added new metric showing ganesha version
by Name of user not set (GerritHub) 20 Mar '25

20 Mar '25

sragraha(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1211857?usp=email ) Change subject: Added new metric showing ganesha version ...................................................................... Added new metric showing ganesha version Change-Id: I6a330ccc6256d4d1f04dbca376dbee4f9513eaed Signed-off-by: Sreedhat Agraharam <sragraha(a)redhat.com> --- M src/MainNFSD/nfs_metrics.c M src/monitoring/dynamic_metrics.cc 2 files changed, 14 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/57/1211857/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1211857?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6a330ccc6256d4d1f04dbca376dbee4f9513eaed Gerrit-Change-Number: 1211857 Gerrit-PatchSet: 1 Gerrit-Owner: sragraha(a)redhat.com

1 0

[XS] Change in ...nfs-ganesha[next]: Exposing ganesha version in a metric form
by Name of user not set (GerritHub) 20 Mar '25

20 Mar '25

sragraha(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1211856?usp=email ) Change subject: Exposing ganesha version in a metric form ...................................................................... Exposing ganesha version in a metric form Change-Id: I3616030df4f787c780854839e39c475f5acc4f2a Signed-off-by: Agraharam S. Agraharam <sragraha(a)redhat.com> --- M src/CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/56/1211856/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1211856?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3616030df4f787c780854839e39c475f5acc4f2a Gerrit-Change-Number: 1211856 Gerrit-PatchSet: 1 Gerrit-Owner: sragraha(a)redhat.com Gerrit-CC: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[M] Change in ...nfs-ganesha[next]: feat(monitoring): report NFSv3 error code instead of nfs_req_result
by Zhitao Li (GerritHub) 19 Mar '25

19 Mar '25

Zhitao Li has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1211843?usp=email ) Change subject: feat(monitoring): report NFSv3 error code instead of nfs_req_result ...................................................................... feat(monitoring): report NFSv3 error code instead of nfs_req_result Change-Id: I93da335a0ecbb69ab8019e7cb5828057f661eb6a Signed-off-by: zhitaoli <zhitao.li(a)iomesh.com> --- M src/MainNFSD/nfs_metrics.c M src/include/nfs_metrics.h M src/include/nfs_proto_data.h A src/include/nfs_req_result.h M src/monitoring/CMakeLists.txt M src/support/server_stats.c 6 files changed, 99 insertions(+), 30 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/43/1211843/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1211843?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I93da335a0ecbb69ab8019e7cb5828057f661eb6a Gerrit-Change-Number: 1211843 Gerrit-PatchSet: 1 Gerrit-Owner: Zhitao Li <zhitao.li(a)iomesh.com>

1 0

[XS] Change in ...nfs-ganesha[next]: fix monitoring lib loading multiple times
by Name of user not set (GerritHub) 19 Mar '25

19 Mar '25

roybabayov(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1211833?usp=email ) Change subject: fix monitoring lib loading multiple times ...................................................................... fix monitoring lib loading multiple times Before this fix the library would have loaded multiple times - from ganesha.nfsd and libganesha_nfsd. This resulted in multiple instances of the dynamic_metrics. Can see more info on https://github.com/nfs-ganesha/nfs-ganesha/issues/1252 This commit fixes the issue so the library will only load once in ganesha. The fix is similar to one already added in libntirpc in https://github.com/nfs-ganesha/ntirpc/pull/341 Change-Id: I62c3dff7e2b80b3600fae58d4498e44f6b250240 Signed-off-by: Roy Babayov <roybabayov(a)google.com> --- M src/libntirpc M src/monitoring/CMakeLists.txt 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/33/1211833/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1211833?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I62c3dff7e2b80b3600fae58d4498e44f6b250240 Gerrit-Change-Number: 1211833 Gerrit-PatchSet: 1 Gerrit-Owner: roybabayov(a)gmail.com

1 0

[S] Change in ...nfs-ganesha[next]: Fix for memory leaks in reread exports config. In case of error while...
by Name of user not set (GerritHub) 19 Mar '25

19 Mar '25

Attention is currently required from: deeraj.patil(a)ibm.com. Hello deeraj.patil(a)ibm.com, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1211793?usp=email to review the following change. Change subject: Fix for memory leaks in reread exports config. In case of error while rereading the exports config config_struct memory is not cleanedup. ...................................................................... Fix for memory leaks in reread exports config. In case of error while rereading the exports config config_struct memory is not cleanedup. Change-Id: I51132f06de4ebb172f4658791e1246ff9369f617 Signed-off-by: Naresh Chillarege <naresh.chillarege(a)ibm.com> --- M src/MainNFSD/nfs_init.c 1 file changed, 9 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/93/1211793/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1211793?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I51132f06de4ebb172f4658791e1246ff9369f617 Gerrit-Change-Number: 1211793 Gerrit-PatchSet: 1 Gerrit-Owner: Naresh.Chillarege(a)ibm.com Gerrit-Reviewer: deeraj.patil(a)ibm.com Gerrit-Attention: deeraj.patil(a)ibm.com

1 0

[S] Change in ...nfs-ganesha[next]: Dump total op count in ShowClients and ShowExports
by Name of user not set (GerritHub) 17 Mar '25

17 Mar '25

deepakarumugam.s(a)nutanix.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1211713?usp=email ) Change subject: Dump total op count in ShowClients and ShowExports ...................................................................... Dump total op count in ShowClients and ShowExports useful for finding out most active clients and most used exports in a system with large number of clients and exports Change-Id: I1ce7379cd21032843a1a6728161d4cbbd86504f7 Signed-off-by: Deepak Arumugam Sankara Subramanian <deepakarumugam.s(a)nutanix.com> --- M src/include/server_stats_private.h M src/support/server_stats.c 2 files changed, 28 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/13/1211713/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1211713?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1ce7379cd21032843a1a6728161d4cbbd86504f7 Gerrit-Change-Number: 1211713 Gerrit-PatchSet: 1 Gerrit-Owner: deepakarumugam.s(a)nutanix.com

1 0