May 2025 - Devel - NFS Ganesha List Archives

[XS] Change in ...nfs-ganesha[next]: Coverity 502601: Fix null dereference in nfsacl_setacl() Avoid passin...
by Name of user not set (GerritHub) 22 May '25

22 May '25

Vidya.Thumukunta(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215644?usp=email ) Change subject: Coverity 502601: Fix null dereference in nfsacl_setacl() Avoid passing NULL acl_access to nfs3_acl_2_fsal_acl(). ...................................................................... Coverity 502601: Fix null dereference in nfsacl_setacl() Avoid passing NULL acl_access to nfs3_acl_2_fsal_acl(). Change-Id: I1a5d69ca36455170747e0eaa14226dbcbd0b6074 Signed-off-by: VidyaThumukunta <Vidya.Thumukunta(a)ibm.com> --- M src/Protocols/NFSACL/nfsacl_setacl.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/44/1215644/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215644?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1a5d69ca36455170747e0eaa14226dbcbd0b6074 Gerrit-Change-Number: 1215644 Gerrit-PatchSet: 1 Gerrit-Owner: Vidya.Thumukunta(a)ibm.com

1 0

We have a new community chat to replace IRC
by Frank Filz 19 May '25

19 May '25

We have a new community chat set up. You may be able to get directly to it with https://app.element.io/#/room/#devel:nfs-ganesha.org or sign on to matrix.org. Channels are #devel:nfs-ganesha.org, #support, and #ntirpc Thanks Frank

1 0

[S] Change in ...nfs-ganesha[next]: send tlv_headers to connection register
by Name of user not set (GerritHub) 19 May '25

19 May '25

roybabayov(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215456?usp=email ) Change subject: send tlv_headers to connection register ...................................................................... send tlv_headers to connection register The tlv headers can contain extra identification of the client that might be required for the FSAL to register the connection. For example, in Google cloud, the tlv contain the pscConnectionId that identifies the client network - https://cloud.google.com/vpc/docs/about-vpc-hosted-services#proxy-protocol Change-Id: Iff0119221344610ebc829c859d02bb5cbfe56642 Signed-off-by: Roy Babayov <roybabayov(a)google.com> --- M src/RPCAL/connection_manager.c M src/include/connection_manager.h 2 files changed, 19 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/56/1215456/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215456?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iff0119221344610ebc829c859d02bb5cbfe56642 Gerrit-Change-Number: 1215456 Gerrit-PatchSet: 1 Gerrit-Owner: roybabayov(a)gmail.com

1 0

[M] Change in ...nfs-ganesha[next]: scripts: Clean up ganesha_mgr help
by Martin Schwenke (GerritHub) 18 May '25

18 May '25

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215437?usp=email ) Change subject: scripts: Clean up ganesha_mgr help ...................................................................... scripts: Clean up ganesha_mgr help Use a multiline f-string to neaten the usage message. Add a couple of functions to print help messages and exit. Use them to reduce duplication and increase consistency of both the content of error messages and the code that produces them. Consistently print the name of the actual script being run. Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: I9da99cf52e37e496f45578c2a18cb1226a066ae2 --- M src/scripts/ganeshactl/ganesha_mgr.py 1 file changed, 95 insertions(+), 124 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/37/1215437/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215437?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9da99cf52e37e496f45578c2a18cb1226a066ae2 Gerrit-Change-Number: 1215437 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net>

1 0

Announce Push of V7-dev.14
by Frank Filz 16 May '25

16 May '25

Branch next Tag:V7-dev.14 Merge Highlights * idmapper/idmapper.c: Encode numeric ids when idmapping is disabled * build/compile/startup fixes for monitoring * CEPH: fix attr cache not work when disable ACL Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 66a850ea7 Frank S. Filz V7-dev.14 2b72daa74 wangshaohui.0512 CEPH: fix attr cache not work when disable ACL 4db9d44de Sachin Punadikar Monitoring: Do not dump core for socket errors 64d5706f0 Sachin Punadikar Fix compilation error for USE_MONITORING=OFF 60578c6a8 Kaleb S. KEITHLEY monitoring: monitoriing is always enabled by default dd5c8ab1e Kaleb S. KEITHLEY config: default to monitoring enabled eb061a3f2 Lior Suliman idmapper/idmapper.c: Encode numeric ids when idmapping is disabled

1 0

[S] Change in ...nfs-ganesha[next]: Coverity 502244 Data race condition: In display_log_component: Thread...
by Suhas Athani (GerritHub) 16 May '25

16 May '25

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215150?usp=email ) Change subject: Coverity 502244 Data race condition: In display_log_component: Thread shared data is accessed without holding an appropriate lock, possibly causing a race condition. Fix added. ...................................................................... Coverity 502244 Data race condition: In display_log_component: Thread shared data is accessed without holding an appropriate lock, possibly causing a race condition. Fix added. Change-Id: I8a4ae680267b932ee5cd770bd8b4f8641911ed21 Signed-off-by: s-athani <suhas.athani(a)ibm.com> --- M src/log/log_functions.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/50/1215150/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215150?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8a4ae680267b932ee5cd770bd8b4f8641911ed21 Gerrit-Change-Number: 1215150 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

1 0

[S] Change in ...nfs-ganesha[next]: Monitoring: Do not dump core for socket errors
by Sachin Punadikar (GerritHub) 16 May '25

16 May '25

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215122?usp=email ) Change subject: Monitoring: Do not dump core for socket errors ...................................................................... Monitoring: Do not dump core for socket errors At the start of Ganesha process, it starts listening on monitoring port. As this is very beginning, it do not make any value add if it dumps core (via abort) for any socket related error. Error messages are suficient to describe the problem. Change-Id: Iccd240372e70ffc02454ad16de24034682e2871f Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/monitoring/prometheus_exposer.cc 1 file changed, 12 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/22/1215122/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215122?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iccd240372e70ffc02454ad16de24034682e2871f Gerrit-Change-Number: 1215122 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0

[XS] Change in ...nfs-ganesha[next]: idmapper/idmapper.c: Encode numeric ids when idmapping is disabled
by Lior Suliman (GerritHub) 15 May '25

15 May '25

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215094?usp=email to review the following change. Change subject: idmapper/idmapper.c: Encode numeric ids when idmapping is disabled ...................................................................... idmapper/idmapper.c: Encode numeric ids when idmapping is disabled Change-Id: I4e78f5aa39f39ba576ab9858c91a52568d483dbb Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/idmapper/idmapper.c 1 file changed, 1 insertion(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/94/1215094/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215094?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4e78f5aa39f39ba576ab9858c91a52568d483dbb Gerrit-Change-Number: 1215094 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: build: fix the build error with invalid preprocessing token
by vicente (GerritHub) 13 May '25

13 May '25

vicente has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214855?usp=email ) Change subject: build: fix the build error with invalid preprocessing token ...................................................................... build: fix the build error with invalid preprocessing token We encounter the following error during build In file included from /nfs-ganesha/src/monitoring/include/prometheus_exposer.h:35, from /nfs-ganesha/src/monitoring/prometheus_exposer.cc:37: /nfs-ganesha/src/libntirpc/src/monitoring/include/monitoring.h:162:22: error: pasting "NOT_USED_" and "*" does not give a valid preprocessing token 162 | #define UNUSED_(arg) NOT_USED_##arg UNUSED_ATTR | ^~~~~~~~~ /nfs-ganesha/src/libntirpc/src/monitoring/include/monitoring.h:161:21: note: in expansion of macro 'UNUSED_' 161 | #define UNUSED(...) UNUSED_(__VA_ARGS__) | ^~~~~~~ /nfs-ganesha/src/monitoring/include/prometheus_exposer.h:105:44: note: in expansion of macro 'UNUSED' 105 | prometheus_exposer__start(const sockaddr_t UNUSED(*addr), | ^~~~~~ The `NOT_USED_##arg` is invalidate with the pointer preprocessing. We should move the pointer out of the macro likes libntirpc does. Change-Id: Ieec01fd4957a2d6a65b02eb9a12c90abd15cb496 Signed-off-by: Vicente Cheng <vicente.cheng(a)suse.com> --- M src/monitoring/include/prometheus_exposer.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/55/1214855/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214855?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ieec01fd4957a2d6a65b02eb9a12c90abd15cb496 Gerrit-Change-Number: 1214855 Gerrit-PatchSet: 1 Gerrit-Owner: vicente <freeze.bilsted(a)gmail.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Coverity 502087: Fix potential end() iterator increment in compact_fa...
by Name of user not set (GerritHub) 13 May '25

13 May '25

Vidya.Thumukunta(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214839?usp=email ) Change subject: Coverity 502087: Fix potential end() iterator increment in compact_family() ...................................................................... Coverity 502087: Fix potential end() iterator increment in compact_family() Change-Id: I61d6fa5878db830267f9aedd4bb3574f4f36d429 Signed-off-by: VidyaThumukunta <Vidya.Thumukunta(a)ibm.com> --- M src/monitoring/prometheus_exposer.cc 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/1214839/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214839?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I61d6fa5878db830267f9aedd4bb3574f4f36d429 Gerrit-Change-Number: 1214839 Gerrit-PatchSet: 1 Gerrit-Owner: Vidya.Thumukunta(a)ibm.com

1 0