May 2025 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: CEPH: fix attr cache not work when disable ACL
by Shaohui Wang (GerritHub) 12 May '25

12 May '25

Shaohui Wang has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214815?usp=email ) Change subject: CEPH: fix attr cache not work when disable ACL ...................................................................... CEPH: fix attr cache not work when disable ACL In the CephFS FSAL export implementation, the callback function fs_supported_attrs is not properly implemented. By default, the ATTR_ACL flag is always set in the returned attributes. However, when the DISABLE_ACL option is enabled in the export configuration, the ATTR_ACL flag should be explicitly unset in the request_mask. This inconsistency between the attribute handling in request_mask and attrs fs_supported_attrs returned causes the mdcache_is_attrs_valid function to always return false, preventing any cache hits for inode attributes in the metadata cache. Change-Id: I4f9dde91d55fd85f6ca17fd22e896194a09cba81 Signed-off-by: Shaohui Wang <wangshaohui.0512(a)bytedance.com> --- M src/FSAL/FSAL_CEPH/export.c M src/FSAL/FSAL_CEPH/internal.h M src/FSAL/FSAL_CEPH/main.c 3 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/1214815/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214815?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4f9dde91d55fd85f6ca17fd22e896194a09cba81 Gerrit-Change-Number: 1214815 Gerrit-PatchSet: 1 Gerrit-Owner: Shaohui Wang <wangshaohui.0512(a)bytedance.com>

1 0

[S] Change in ...nfs-ganesha[next]: monitoring: monitoriing is always enabled by default
by Kaleb KEITHLEY (GerritHub) 12 May '25

12 May '25

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214801?usp=email ) Change subject: monitoring: monitoriing is always enabled by default ...................................................................... monitoring: monitoriing is always enabled by default eliminate conditionals for monitoring; it's enabled by default Change-Id: Idfee736318845fd7347174199bb17045bae36364 Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> --- M src/nfs-ganesha.spec-in.cmake 1 file changed, 0 insertions(+), 14 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/01/1214801/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214801?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Idfee736318845fd7347174199bb17045bae36364 Gerrit-Change-Number: 1214801 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com>

1 0

[XS] Change in ...nfs-ganesha[next]: config: default to monitoring enabled
by Kaleb KEITHLEY (GerritHub) 12 May '25

12 May '25

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214799?usp=email ) Change subject: config: default to monitoring enabled ...................................................................... config: default to monitoring enabled monitoring has moved to (lib)ntirpc, where it defaults to enabled If we were using ntirpc only as a submodule, we could probably eliminate this here. But since we package ntirpc separately in Fedora, CentOS, etc., and in ntirpc monitoring is enabled by default, we need to keep it here too, and have it enabled by default. Other users who don't want monitoring can disable it in their ntirpc (submodule or separate package) and disable it here too. Change-Id: I9ad3574d820eaf260d7a1244488e2273165eb94d Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> --- M src/CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/99/1214799/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214799?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9ad3574d820eaf260d7a1244488e2273165eb94d Gerrit-Change-Number: 1214799 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com>

1 0

[S] Change in ...nfs-ganesha[next]: [WIP] Patchset for Write delegations.
by Animesh Javali (GerritHub) 12 May '25

12 May '25

Animesh Javali has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214795?usp=email ) Change subject: [WIP] Patchset for Write delegations. ...................................................................... [WIP] Patchset for Write delegations. Changes include: - Resetting field `io_work` in `ceph_close_my_fd()` to prevent the reuse of its stale value in Global file descriptor. (This caused subsequent WRITE & READ to hang after a delegreturn.) - Making `ceph_fsal_lease_op2()` handle FSAL_DELEG_NONE correctly by marking FDs for closure (`close_on_complete`). - Enabling Read and Write file delegations by switching delegation option from `FSAL_OPTION_FILE_READ_DELEG` to `FSAL_OPTION_FILE_DELEGATIONS`. - Settting `client_oc` option to true to enable Object Cacher. - In `nfs4_op_open`, store the associated open state key (`stateid_other`) within the delegation state to open the files using this information later via fsal_start_io. - Disabling non-blocking and zerocopy IO flags. - Extending `state_deleg` struct in `sal_data.h` to include `openstate_key` for linking delegations to their corresponding open states. Change-Id: Icd21eee9d182148e19ab03c7f3b43cfc07d08672 Signed-off-by: Animesh Javali <Animesh.Javali(a)ibm.com> --- M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_CEPH/main.c M src/Protocols/NFS/nfs4_op_open.c M src/include/config-h.in.cmake M src/include/sal_data.h 5 files changed, 35 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/1214795/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214795?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Icd21eee9d182148e19ab03c7f3b43cfc07d08672 Gerrit-Change-Number: 1214795 Gerrit-PatchSet: 1 Gerrit-Owner: Animesh Javali <Animesh.Javali(a)ibm.com>

1 0

[M] Change in ...nfs-ganesha[next]: WIP fsal: Add delegation-aware FD reuse to fsal_start_io()
by Suhas Athani (GerritHub) 12 May '25

12 May '25

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214788?usp=email ) Change subject: WIP fsal: Add delegation-aware FD reuse to fsal_start_io() ...................................................................... WIP fsal: Add delegation-aware FD reuse to fsal_start_io() When a WRITE delegation is granted (DELEG_GRANTED), this change allows fsal_start_io() to reuse the associated file descriptor from the original open state, avoiding unnecessary reopen logic. This is done by resolving the delegated state to its openstate and attempting to start I/O on the related FD. Reference counting for openstate is properly maintained, and logs are added for both successful reuse and fallback paths. A placeholder is included for handling DELEG_RECALL_WIP cases in future updates. Change-Id: Ia52e44d9d9a2ad2f1e33a76cdbce888384eb1a72 Signed-off-by: s-athani <suhas.athani(a)ibm.com> --- M src/FSAL/commonlib.c 1 file changed, 61 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/88/1214788/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214788?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia52e44d9d9a2ad2f1e33a76cdbce888384eb1a72 Gerrit-Change-Number: 1214788 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Fix compilation error for USE_MONITORING=OFF
by Sachin Punadikar (GerritHub) 12 May '25

12 May '25

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214775?usp=email ) Change subject: Fix compilation error for USE_MONITORING=OFF ...................................................................... Fix compilation error for USE_MONITORING=OFF Fixing the compilation error in case MONITORING is not enabled. The issue got introduced via commit 0e6d553a0 Change-Id: I5778cc285166673281dc244fffead4059304751c Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/monitoring/include/prometheus_exposer.h 1 file changed, 3 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/75/1214775/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214775?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5778cc285166673281dc244fffead4059304751c Gerrit-Change-Number: 1214775 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Fix CTAD maybe unsupported warning
by Lior Suliman (GerritHub) 10 May '25

10 May '25

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214732?usp=email to review the following change. Change subject: Fix CTAD maybe unsupported warning ...................................................................... Fix CTAD maybe unsupported warning Change-Id: I461fb1ba2d73c32150963bcd9083b11fb7d3a7e8 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/monitoring/prometheus_exposer.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/32/1214732/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214732?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I461fb1ba2d73c32150963bcd9083b11fb7d3a7e8 Gerrit-Change-Number: 1214732 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

Announce Push of V7-dev.13
by Frank Filz 09 May '25

09 May '25

Branch next Tag:V7-dev.13 Merge Highlights * several Coverity fixes * Added mntpath label for export_id metrics. * SAL: NFS V3 locks not released prior to DBUS reply sent * idmapper: should not set idmapping_enabled to true by default * Config: Add support for Monitoring_Addr * Add missing bcond for UNWIND_ENRICHED_BT * selinux: Error observed during package install in cthon04 job * ganesha_mgr usage message correction * feat(dupreq): don't retire inflight entries Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: b84bcb996 Frank S. Filz V7-dev.13 dc8794271 zhitaoli feat(dupreq): don't retire inflight entries d8b872e2a Bipali Gade ganesha_mgr usage message correction f8e1b7d25 Kaleb S. KEITHLEY selinux: Error observed during package install in cthon04 job ce86a3f9c Kaleb S. KEITHLEY Add missing bcond for UNWIND_ENRICHED_BT 0e6d553a0 Sachin Punadikar Config: Add support for Monitoring_Addr b3441848d Vicente Cheng idmapper: should not set idmapping_enabled to true by default a7ea33434 Peter Schwenke SAL: NFS V3 locks not released prior to DBUS reply sent 64132bbb8 Animesh Javali Fix for coverity:542651 In encode_fs_locations: Added fix to prevent leak of memory or pointers to system resources 2b39895dc s-athani Coverity 502077 Overflowed array index write: In cidr_net_supernet: Write to array at integer-overflowed index. Fix integer underflow risk by validating CIDR prefix length. 9024b1bbe s-athani Coverity 509139 : In layoutcommit: A value assigned to a variable is never used. Stored value is overwritten before it can be used. Fix added. 62a34952f Frank S. Filz Added mntpath label for export_id metrics. f36ea8999 Rajesh Prasad Coverity Issue - 542648 e446486b6 Rajesh Prasad RDMA Transport Enablement for NFS v4.0, v4.1 and v4.2

1 0

[XS] Change in ...nfs-ganesha[next]: CID 461869: Fixed Resource leak by freeing of buf
by Name of user not set (GerritHub) 08 May '25

08 May '25

Yogendra.Tangalapally(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214641?usp=email ) Change subject: CID 461869: Fixed Resource leak by freeing of buf ...................................................................... CID 461869: Fixed Resource leak by freeing of buf CID 461869: Resource leak (RESOURCE_LEAK) leaked_storage: Variable buf going out of scope leaks the storage it points to. Change-Id: I384c488daf9742ca5496ef307b2aa439b2c7cbfb Signed-off-by: Yogendra Charya Tangalapally <Yogendra.Tangalapally(a)ibm.com> --- M src/FSAL/FSAL_GPFS/handle.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/41/1214641/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214641?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I384c488daf9742ca5496ef307b2aa439b2c7cbfb Gerrit-Change-Number: 1214641 Gerrit-PatchSet: 1 Gerrit-Owner: Yogendra.Tangalapally(a)ibm.com

1 0

[S] Change in ...nfs-ganesha[next]: selinux: Error observed during package install in cthon04 job
by Kaleb KEITHLEY (GerritHub) 05 May '25

05 May '25

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214444?usp=email ) Change subject: selinux: Error observed during package install in cthon04 job ...................................................................... selinux: Error observed during package install in cthon04 job https://github.com/nfs-ganesha/nfs-ganesha/issues/1259 In https://bugzilla.redhat.com/show_bug.cgi?id=2356228#c3 zpytela(a)redhat.com says: The type ceph_t is not defined and that's why installing fails. Such failures could be prevented using optional blocks. This change, using optional blocks, seems to work, in that it installs without the previously seen warning, but zptyela [ibid] says: You should rather look for the proper interface from the ceph module. But I can find nothing that looks applicable. Change-Id: Ibfcf71cd2781d7c50ef47e0b9b4cc6a0ce6423b6 Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> --- M src/selinux/ganesha.te 1 file changed, 11 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/44/1214444/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214444?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ibfcf71cd2781d7c50ef47e0b9b4cc6a0ce6423b6 Gerrit-Change-Number: 1214444 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com>

1 0