May 2025 - Devel - NFS Ganesha List Archives

[M] Change in ...nfs-ganesha[next]: SAL: Support non-numeric nodeid
by Sachin Punadikar (GerritHub) 30 May '25

30 May '25

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1216097?usp=email ) Change subject: SAL: Support non-numeric nodeid ...................................................................... SAL: Support non-numeric nodeid "nodeid" is part of RADOS_KV block. Currently it supports numeric nodeid only. Added support for non-numeric nodeid to help in upgrade scenarios. Change-Id: I02cac0cc05c338bc0e50c70470e2d6d778702ee5 Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/SAL/recovery/recovery_rados.h M src/SAL/recovery/recovery_rados_cluster.c M src/SAL/recovery/recovery_rados_kv.c M src/SAL/recovery/recovery_rados_ng.c M src/doc/man/ganesha-core-config.rst 5 files changed, 85 insertions(+), 118 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/1216097/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1216097?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I02cac0cc05c338bc0e50c70470e2d6d778702ee5 Gerrit-Change-Number: 1216097 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0

[M] Change in ...nfs-ganesha[next]: CEPH: Support old logic of ceph uuid generation
by Sachin Punadikar (GerritHub) 28 May '25

28 May '25

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1216035?usp=email ) Change subject: CEPH: Support old logic of ceph uuid generation ...................................................................... CEPH: Support old logic of ceph uuid generation Added code for supporting old logic of ceph client uuid generation. This logic will help old NFS Ganesha setups to continue work without disruption during upgrade. Change-Id: I3a29c1a3ecc2a0319d172419ea6cfd63892232a6 Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/FSAL/FSAL_CEPH/internal.h M src/FSAL/FSAL_CEPH/main.c M src/doc/man/ganesha-ceph-config.rst 3 files changed, 35 insertions(+), 16 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/35/1216035/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1216035?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3a29c1a3ecc2a0319d172419ea6cfd63892232a6 Gerrit-Change-Number: 1216035 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0

[XL] Change in ...nfs-ganesha[next]: LOG: Conditional Logging and Tracing Feature
by Nishant Puri (GerritHub) 28 May '25

28 May '25

Nishant Puri has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1216021?usp=email ) Change subject: LOG: Conditional Logging and Tracing Feature ...................................................................... LOG: Conditional Logging and Tracing Feature The conditional logging feature enhances the existing component-level logging by allowing it to be applied selectively to specified clients or exports. All other clients and exports (those not explicitly specified) will adhere to the new conditional component-level logging behavior. This feature can be enabled through either of the following methods: 1. DBUS Interface 2. Ganesha configuration file Change-Id: I9bbb867961ae5eafe58eeedd778a0eb15e337c92 Signed-off-by: Nishant Puri <npuri(a)redhat.com> --- M src/FSAL/commonlib.c M src/MainNFSD/libganesha_nfsd.ver M src/MainNFSD/nfs_admin_thread.c M src/MainNFSD/nfs_init.c M src/MainNFSD/nfs_main.c M src/config_samples/config.txt M src/config_samples/logging.txt M src/include/fsal_api.h M src/include/log.h M src/include/nfs_init.h M src/log/log_functions.c M src/support/client_mgr.c 12 files changed, 1,145 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/21/1216021/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1216021?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9bbb867961ae5eafe58eeedd778a0eb15e337c92 Gerrit-Change-Number: 1216021 Gerrit-PatchSet: 1 Gerrit-Owner: Nishant Puri <npuri(a)redhat.com>

1 0

[XS] Change in ...nfs-ganesha[next]: doc: Fix typo in export config sample
by Martin Schwenke (GerritHub) 27 May '25

27 May '25

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215990?usp=email ) Change subject: doc: Fix typo in export config sample ...................................................................... doc: Fix typo in export config sample Surely this is meant to be a /24 subnet. The subsequent comment claims to talk about a larger block, but a /16 isn't larger than a /8. Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: I4c9db95f70148cb4a6496d8a8261a996bf1e2ce7 --- M src/config_samples/export.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/90/1215990/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215990?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4c9db95f70148cb4a6496d8a8261a996bf1e2ce7 Gerrit-Change-Number: 1215990 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net>

1 0

[S] Change in ...nfs-ganesha[next]: ganesha-rados-grace : support non-numeric nodeid
by Sachin Punadikar (GerritHub) 22 May '25

22 May '25

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215719?usp=email ) Change subject: ganesha-rados-grace : support non-numeric nodeid ...................................................................... ganesha-rados-grace : support non-numeric nodeid To support backward compatibility, wherein old nodeid (which are non-numeric strings) is required to be removed from rados object storing grace membership, need to allow and process non-numeric nodeid. The tool checks if passed in nodeid is numeric or non-numeric, and then process it correctly. Change-Id: I414ce8c6976e284ac58ecd5acec284af8c269829 Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/tools/ganesha-rados-grace.c 1 file changed, 27 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/19/1215719/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215719?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I414ce8c6976e284ac58ecd5acec284af8c269829 Gerrit-Change-Number: 1215719 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0

[M] Change in ...nfs-ganesha[next]: NFS-Ganesha: Add SSSD timeout and skip cache options
by Lior Suliman (GerritHub) 22 May '25

22 May '25

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215676?usp=email to review the following change. Change subject: NFS-Ganesha: Add SSSD timeout and skip cache options ...................................................................... NFS-Ganesha: Add SSSD timeout and skip cache options This commit adds 2 new configurations: - Sssd_Implementation_Timeout: The timeout to use for each direct to sssd idmapping operations. Default 30 seconds. - Sssd_Implementation_Skip_Cache: Whether to skip SSSD cache when performing SSSD direct idmapping operations. Default false. Both configurations are effective only when using SSSD pwnam implementation. This is needed to allow clients to use the SSSD pwnam implementation while preventing clients' request from being blocked by potential SSSD issues. Change-Id: I62d1d86db5efb5582d8b87b8913599d8e065045d Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/doc/man/ganesha-core-config.rst M src/idmapper/sss_nss_idmap.c M src/include/gsh_config.h M src/support/nfs_read_conf.c 4 files changed, 42 insertions(+), 12 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/76/1215676/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215676?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I62d1d86db5efb5582d8b87b8913599d8e065045d Gerrit-Change-Number: 1215676 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[S] Change in ...nfs-ganesha[next]: Use idmapper_negative_cache for uid when fetching groups.
by Lior Suliman (GerritHub) 22 May '25

22 May '25

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215675?usp=email to review the following change. Change subject: Use idmapper_negative_cache for uid when fetching groups. ...................................................................... Use idmapper_negative_cache for uid when fetching groups. If fetching groups for uid failed, meaning uid does not exist, we would previously loop trying to get the groups for that uid on every request. This commit implements the negative cache, to avoid the loop. Added uid negative lookup, and save into the cache if not found. Change-Id: Ia6ce0d4fb513d4464e0d837956a540d2962b42ee Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/support/uid2grp.c 1 file changed, 37 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/75/1215675/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215675?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia6ce0d4fb513d4464e0d837956a540d2962b42ee Gerrit-Change-Number: 1215675 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[M] Change in ...nfs-ganesha[next]: NFS-Ganesha: Add negative-cache by UIDs
by Lior Suliman (GerritHub) 22 May '25

22 May '25

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215674?usp=email to review the following change. Change subject: NFS-Ganesha: Add negative-cache by UIDs ...................................................................... NFS-Ganesha: Add negative-cache by UIDs We need to be able to store the negative answers from idmapper when mapping a uid. This is done by introducing a new negative-cache type. Change-Id: I270a7b1b64747d0cfca5513d4ed6e1649ff1038f Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/FSAL/localfs.c M src/idmapper/idmapper_monitoring.c M src/idmapper/idmapper_negative_cache.c M src/include/idmapper.h M src/include/idmapper_monitoring.h 5 files changed, 221 insertions(+), 22 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/74/1215674/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215674?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I270a7b1b64747d0cfca5513d4ed6e1649ff1038f Gerrit-Change-Number: 1215674 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[S] Change in ...nfs-ganesha[next]: Add config option to select pwnam implementation
by Lior Suliman (GerritHub) 22 May '25

22 May '25

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215673?usp=email to review the following change. Change subject: Add config option to select pwnam implementation ...................................................................... Add config option to select pwnam implementation Adds a config to select between the two available implementations for the `pwnam` wrapper: `nsswitch` and `sssd`. This is needed to enable support of ID mapping when using sssd without nsswitch. Change-Id: Ia1fee858d1eef424c559dcaf4f95d6a607159a25 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/doc/man/ganesha-core-config.rst M src/idmapper/idmapper.c M src/include/gsh_config.h M src/support/nfs_read_conf.c 4 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/73/1215673/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215673?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia1fee858d1eef424c559dcaf4f95d6a607159a25 Gerrit-Change-Number: 1215673 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Minor fix in tracepoint formatting in nfs4_op_sequence.c
by Lior Suliman (GerritHub) 22 May '25

22 May '25

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215672?usp=email to review the following change. Change subject: Minor fix in tracepoint formatting in nfs4_op_sequence.c ...................................................................... Minor fix in tracepoint formatting in nfs4_op_sequence.c The names used in the format strings are too long if we include the large base file name. which creates a format string that is larger than 256 chars and gets truncated. Change-Id: I3d8deb7c0d1ba626b367464b1d8cca8a696faf9f Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/Protocols/NFS/nfs4_op_sequence.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/72/1215672/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215672?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3d8deb7c0d1ba626b367464b1d8cca8a696faf9f Gerrit-Change-Number: 1215672 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0