September 2025 - Devel - NFS Ganesha List Archives

[XS] Change in ...nfs-ganesha[next]: Fix up the protocol number for SCTP in FSAL_encode_ipv4_netaddr
by Peter Schwenke (GerritHub) 11 Sep '25

11 Sep '25

Peter Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222435?usp=email ) Change subject: Fix up the protocol number for SCTP in FSAL_encode_ipv4_netaddr ...................................................................... Fix up the protocol number for SCTP in FSAL_encode_ipv4_netaddr The protocol number was 123. According to /etc/protocols /usr/include/linux/in.h, /usr/include/glib-2.0/gio/gioenums.h, /usr/include/netinet/in.h and /usr/include/wireshark/epan/ipproto.h it should be 132. There is a 123 definition in the Internal Socket Options at /usr/include/linux/sctp.h:#define SCTP_STREAM_SCHEDULER 123. Change-Id: Ida3788b730500a3c00071c8a16e3ecabe3b5cb26 Signed-off-by: Peter Schwenke <pschwenke(a)ddn.com> --- M src/FSAL/common_pnfs.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/35/1222435/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222435?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ida3788b730500a3c00071c8a16e3ecabe3b5cb26 Gerrit-Change-Number: 1222435 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Schwenke <pschwenke(a)ddn.com>

1 0

[L] Change in ...nfs-ganesha[next]: Move IP related functions from rpc_tools. to ip_utils.c
by Peter Schwenke (GerritHub) 11 Sep '25

11 Sep '25

Peter Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222434?usp=email ) Change subject: Move IP related functions from rpc_tools. to ip_utils.c ...................................................................... Move IP related functions from rpc_tools. to ip_utils.c Some of the functions do require RPC_VSOCK and rpc-ish data members. However, for the most part, they fit better as general ip_utils. Change-Id: Ia8c845cf1e5776973e69f589ec9774d150c1ee66 Signed-off-by: Peter Schwenke <pschwenke(a)ddn.com> --- M src/RPCAL/rpc_tools.c M src/include/display.h M src/include/gsh_rpc.h M src/include/ip_utils.h M src/support/ip_utils.c 5 files changed, 463 insertions(+), 436 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/1222434/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222434?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia8c845cf1e5776973e69f589ec9774d150c1ee66 Gerrit-Change-Number: 1222434 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Schwenke <pschwenke(a)ddn.com>

1 0

[XL] Change in ...nfs-ganesha[next]: Remove third party library libcidr
by Peter Schwenke (GerritHub) 11 Sep '25

11 Sep '25

Peter Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222433?usp=email ) Change subject: Remove third party library libcidr ...................................................................... Remove third party library libcidr The functionality is replaced by cidr_* functions in ip_utils.c Change-Id: I670ebc8462cf76a9d799ebc18b20b34d99efbda6 Signed-off-by: Peter Schwenke <pschwenke(a)ddn.com> --- M src/CMakeLists.txt D src/cidr/CMakeLists.txt D src/cidr/LICENSE D src/cidr/README.reindent D src/cidr/cidr_addr.c D src/cidr/cidr_compare.c D src/cidr/cidr_from_str.c D src/cidr/cidr_get.c D src/cidr/cidr_inaddr.c D src/cidr/cidr_mem.c D src/cidr/cidr_misc.c D src/cidr/cidr_net.c D src/cidr/cidr_num.c D src/cidr/cidr_pow2_p.h D src/cidr/cidr_to_str.c D src/include/cidr.h 16 files changed, 0 insertions(+), 2,830 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/33/1222433/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222433?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I670ebc8462cf76a9d799ebc18b20b34d99efbda6 Gerrit-Change-Number: 1222433 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Schwenke <pschwenke(a)ddn.com>

1 0

[L] Change in ...nfs-ganesha[next]: Replace libcidr
by Peter Schwenke (GerritHub) 11 Sep '25

11 Sep '25

Peter Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222432?usp=email ) Change subject: Replace libcidr ...................................................................... Replace libcidr libcidr has been used by NFS Ganesha for quite some time. Only a handful of functions from it were used and a whole directory of source code exists for it. Maintenance of it gets difficult things like clang format changes make it difficult if fixes were made upstream (unlikely). CIDR has been made an opaque type, because there aren't reasons for it to be changed by other code. These new functions are simpler and make use of the IP parsing and conversion functions currently in rpc_tools.c. The second arg of cidr_contains is just a sockaddr_t because there was no need to implement the mask on that argument. NFS Ganesha doesn't require that. The function has been renamed to cidr_contains_ip. The unused flags arg dropped from cidr_to_str(). Add test program test_cidr.c This required some of the ip_utils.c:cidr_* functions to be added to MainNFSD/libganesha_nfsd.ver so they can be linked to the test program. The plan is to move the IP-related functions from rpc_tools to here. We will then have the functions in a more easily found file. In export_mgr.c, the behaviour for DisplayExport was kept the same, in case, someone is parsing the output or something. One byte is send on dbus from the old style character arrays for ip addres and mask. Similarly, for the protocol 1 was sent for IPv4 and 2 for IPv6. Similarly for the CIDR version. That behaviour has been mimicked for now. It is probably worth cleaning that up at some point. Change-Id: I77103440d67f1a3318f0492122e9e2a25d535aa5 Signed-off-by: Peter Schwenke <pschwenke(a)ddn.com> --- M src/MainNFSD/CMakeLists.txt M src/MainNFSD/libganesha_nfsd.ver M src/Protocols/NFS/mnt_Export.c M src/include/client_mgr.h A src/include/ip_utils.h M src/scripts/runcp.sh M src/support/CMakeLists.txt M src/support/client_mgr.c M src/support/export_mgr.c M src/support/exports.c A src/support/ip_utils.c M src/test/CMakeLists.txt A src/test/test_cidr.c 13 files changed, 724 insertions(+), 42 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/32/1222432/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222432?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I77103440d67f1a3318f0492122e9e2a25d535aa5 Gerrit-Change-Number: 1222432 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Schwenke <pschwenke(a)ddn.com>

1 0

[S] Change in ...nfs-ganesha[next]: Move 2 comments that were causing bizarre clang-format behaviour
by Peter Schwenke (GerritHub) 11 Sep '25

11 Sep '25

Peter Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222431?usp=email ) Change subject: Move 2 comments that were causing bizarre clang-format behaviour ...................................................................... Move 2 comments that were causing bizarre clang-format behaviour The 2 "NOTE: the Client sub-block..." comments have been moved to after ifdefs. They should be attached to the client sub-block line anyway. Otherwise, the above line would be clanged to column 1. Change-Id: I3f0278a517ce4dd11eeaf89339a3dc17e0669f84 Signed-off-by: Peter Schwenke <pschwenke(a)ddn.com> --- M src/support/exports.c 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/31/1222431/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222431?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3f0278a517ce4dd11eeaf89339a3dc17e0669f84 Gerrit-Change-Number: 1222431 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Schwenke <pschwenke(a)ddn.com>

1 0

[S] Change in ...nfs-ganesha[next]: Enable callback channel setup for RDMA. Tirpc PR https://github.com/n...
by Gaurav (GerritHub) 10 Sep '25

10 Sep '25

Gaurav has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222344?usp=email ) Change subject: Enable callback channel setup for RDMA. Tirpc PR https://github.com/nfs-ganesha/ntirpc/pull/353 ...................................................................... Enable callback channel setup for RDMA. Tirpc PR https://github.com/nfs-ganesha/ntirpc/pull/353 Change-Id: Ib0bc0fa844a7fe58d49ced1fb95e3911c3def167 Signed-off-by: Gaurav Gangalwar <gaurav.gangalwar(a)gmail.com> --- M src/MainNFSD/nfs_rpc_callback.c 1 file changed, 8 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/44/1222344/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222344?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib0bc0fa844a7fe58d49ced1fb95e3911c3def167 Gerrit-Change-Number: 1222344 Gerrit-PatchSet: 1 Gerrit-Owner: Gaurav <gaurav.gangalwar(a)gmail.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Fix compile issue with DUSE_MONITORING=OFF
by Gaurav (GerritHub) 10 Sep '25

10 Sep '25

Gaurav has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222343?usp=email ) Change subject: Fix compile issue with DUSE_MONITORING=OFF ...................................................................... Fix compile issue with DUSE_MONITORING=OFF Change-Id: I0485e82611e936562a9d8e895fb384641102c17d Signed-off-by: Gaurav Gangalwar <gaurav.gangalwar(a)gmail.com> --- M src/MainNFSD/nfs_main.c M src/monitoring/prometheus_exposer.cc 2 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/43/1222343/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222343?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0485e82611e936562a9d8e895fb384641102c17d Gerrit-Change-Number: 1222343 Gerrit-PatchSet: 1 Gerrit-Owner: Gaurav <gaurav.gangalwar(a)gmail.com>

1 0

[XS] Change in ...nfs-ganesha[next]: SAL: Fix crash during shutdown due to invalid svc_rqst_rec in svc_rqs...
by Nishant Puri (GerritHub) 10 Sep '25

10 Sep '25

Nishant Puri has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222291?usp=email ) Change subject: SAL: Fix crash during shutdown due to invalid svc_rqst_rec in svc_rqst_expire_insert ...................................................................... SAL: Fix crash during shutdown due to invalid svc_rqst_rec in svc_rqst_expire_insert During shutdown, svc_destroy clears cx_rec->ev_p as part of xprt unregister. Later, state_export_unlock_all may still trigger RPC callbacks that dereference the freed ev_p (svc_rqst_expire_insert), leading to crashes. Fix by validating, if admin_shutdown is in progress while granting the lock we will not trigger the callbacks. Change-Id: I80257143de6fd8fbc11b19e7de0a6d7bb76a8773 Signed-off-by: Nishant Puri <npuri(a)redhat.com> --- M src/SAL/state_lock.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/91/1222291/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222291?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I80257143de6fd8fbc11b19e7de0a6d7bb76a8773 Gerrit-Change-Number: 1222291 Gerrit-PatchSet: 1 Gerrit-Owner: Nishant Puri <npuri(a)redhat.com>

1 0

[M] Change in ...nfs-ganesha[next]: Clang-formatted the code base
by Lior Suliman (GerritHub) 09 Sep '25

09 Sep '25

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222268?usp=email to review the following change. Change subject: Clang-formatted the code base ...................................................................... Clang-formatted the code base Change-Id: Ic991c47412d304c730ba539c6528bc6e9ca004b7 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/MainNFSD/nfs_qos.c M src/Protocols/NFS/nfs4_op_xattr.c M src/RPCAL/connection_manager.c M src/SAL/state_lock.c M src/config_parsing/test_parse.c M src/gtest/fsal_api/test_handle_to_wire_latency.cc M src/gtest/fsal_api/test_lock_op2_latency.cc M src/gtest/fsal_api/test_mkdir_latency.cc M src/gtest/fsal_api/test_readlink_latency.cc M src/gtest/fsal_api/test_reopen2_latency.cc M src/include/sss_nss_idmap.h M src/log/log_functions.c M src/support/exports.c M src/support/nfs_qosmgr.c M src/support/uid2grp.c 15 files changed, 119 insertions(+), 81 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/68/1222268/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222268?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic991c47412d304c730ba539c6528bc6e9ca004b7 Gerrit-Change-Number: 1222268 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Disable nfs_qos and nfs_qosmgr when the ENABLE_QOS is not enabled
by Lior Suliman (GerritHub) 09 Sep '25

09 Sep '25

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222267?usp=email to review the following change. Change subject: Disable nfs_qos and nfs_qosmgr when the ENABLE_QOS is not enabled ...................................................................... Disable nfs_qos and nfs_qosmgr when the ENABLE_QOS is not enabled Change-Id: I2cff23404143c50da043d9a44f7fa44153951641 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/MainNFSD/nfs_qos.c M src/support/nfs_qosmgr.c 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/67/1222267/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222267?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2cff23404143c50da043d9a44f7fa44153951641 Gerrit-Change-Number: 1222267 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0