March 2026 - Devel - Nfs Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: Fix handling of WRITE and READ deleg with ATTRS

by Animesh Javali (GerritHub)

Animesh Javali has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234257?usp=email ) Change subject: Fix handling of WRITE and READ deleg with ATTRS ...................................................................... Fix handling of WRITE and READ deleg with ATTRS In nfs4_op_write(), the existing validation relied on a bitwise check against OPEN_DELEGATE_WRITE, which does not work for OPEN_DELEGATE_WRITE_ATTRS_DELEG This resulted in valid WRITE_ATTRS_DELEG stateids being rejected with NFS4ERR_BAD_STATEID. Fix this by explicitly allowing both OPEN_DELEGATE_WRITE and OPEN_DELEGATE_WRITE_ATTRS_DELEG. Update queue_deleg_transition_handler() to treat READ_ATTRS_DELEG and WRITE_ATTRS_DELEG equivalently to their READ/WRITE counterparts when evaluating export-level delegation permissions (EXPORT_OPTION_READ_DELEG / EXPORT_OPTION_WRITE_DELEG). This ensures correct recall behavior when delegations are disabled via export configuration for attribute-aware delegations. Change-Id: I1848c6a3764ca1c588d26a47a11029aad228162d Signed-off-by: Animesh Javali <Animesh.Javali(a)ibm.com> --- M src/Protocols/NFS/nfs4_op_write.c M src/support/export_mgr.c 2 files changed, 19 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/57/1234257/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234257?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1848c6a3764ca1c588d26a47a11029aad228162d Gerrit-Change-Number: 1234257 Gerrit-PatchSet: 1 Gerrit-Owner: Animesh Javali <Animesh.Javali(a)ibm.com>

1 week, 3 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Fix for Coverity IDs: 509127,509133

by Animesh Javali (GerritHub)

Animesh Javali has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234237?usp=email ) Change subject: Fix for Coverity IDs: 509127,509133 ...................................................................... Fix for Coverity IDs: 509127,509133 Fixed big parameter passed by value. Coverity flagged that struct sau_attr_reply is being passed by value in isOffsetChangedByClient() and hasRecentModificationTime(), leading to unnecessary copying of a large structure. This change converts the function parameters to pass by reference(pointer), avoiding the overhead of copying while maintaining the same functionality. Change-Id: Ifca860124a05984b60c97e481aec7d85c90cc84e Signed-off-by: Animesh Javali <Animesh.Javali(a)ibm.com> --- M src/FSAL/FSAL_SAUNAFS/mds_handle.c 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/37/1234237/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234237?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ifca860124a05984b60c97e481aec7d85c90cc84e Gerrit-Change-Number: 1234237 Gerrit-PatchSet: 1 Gerrit-Owner: Animesh Javali <Animesh.Javali(a)ibm.com>

1 week, 3 days

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: Add log rotation functionality to Ganesha.

by ofir vainshtein (GerritHub)

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234087?usp=email ) Change subject: Add log rotation functionality to Ganesha. ...................................................................... Add log rotation functionality to Ganesha. This change introduces the ability to rotate Ganesha log files based on size and/or time. A new "Rotate" block can be added within the "LOG" section of the configuration. The options are: - size_kb: Rotate when the log file size exceeds this value in KB. - time_sec: Rotate when the time since the last rotation exceeds this value in seconds. When rotation occurs, the current log file is renamed to <log_file_path>.old. Change-Id: I08f410b615874eadcd1a740ad79d87b8c6aae772 Signed-off-by: Ofir Vainshtein <ofirvins(a)google.com> --- M src/doc/man/ganesha-log-config.rst M src/log/log_functions.c 2 files changed, 134 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/87/1234087/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234087?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I08f410b615874eadcd1a740ad79d87b8c6aae772 Gerrit-Change-Number: 1234087 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 week, 6 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Add a rolling log index to Ganesha logs.

by ofir vainshtein (GerritHub)

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234086?usp=email ) Change subject: Add a rolling log index to Ganesha logs. ...................................................................... Add a rolling log index to Ganesha logs. Introduces a new log format option, LOG_INDEX, which adds a monotonically increasing index to each log line. The index is a 5-digit number that wraps around at 100000. This helps in tracking the order of log messages. The super_ut configuration is updated to enable this new option. note because index is taken before write and not under exclusive lock with it. logs are not guaranteed to appear in order in the file Change-Id: Ieb251326238810d9c3251b36a0d40c2d4844d52d Signed-off-by: Ofir Vainshtein <ofirvins(a)google.com> --- M src/doc/man/ganesha-log-config.rst M src/include/abstract_atomic.h M src/log/log_functions.c 3 files changed, 45 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/86/1234086/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ieb251326238810d9c3251b36a0d40c2d4844d52d Gerrit-Change-Number: 1234086 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 week, 6 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Move STATELOCK acquisition out of state_test and process_blocked_lock...

by ofir vainshtein (GerritHub)

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234085?usp=email ) Change subject: Move STATELOCK acquisition out of state_test and process_blocked_lock_upcall ...................................................................... Move STATELOCK acquisition out of state_test and process_blocked_lock_upcall The STATELOCK is now acquired by the callers of state_test and process_blocked_lock_upcall rather than inside these functions. This ensures that the lock is held consistently across operations involving state objects. Also fixed state_test access of lock_entry fields without lock Change-Id: I82ba6f828e7b2be73580f967b0a3b7c775a69e89 Signed-off-by: Ofir Vainshtein <ofirvins(a)google.com> --- M src/Protocols/NFS/nfs4_op_lockt.c M src/SAL/state_async.c M src/SAL/state_lock.c 3 files changed, 14 insertions(+), 16 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/85/1234085/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234085?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I82ba6f828e7b2be73580f967b0a3b7c775a69e89 Gerrit-Change-Number: 1234085 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 week, 6 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Add LTTng tracepoints for state object reference counting.

by ofir vainshtein (GerritHub)

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234084?usp=email ) Change subject: Add LTTng tracepoints for state object reference counting. ...................................................................... Add LTTng tracepoints for state object reference counting. This change introduces GSH_AUTO_TRACEPOINT calls in nfs4_state_dec_ref to log state object decref operations, including the state pointer and the resulting refcount. Change-Id: I192d6e38304d1c10b8c86cfae8b8b0340bd2f215 Signed-off-by: Ofir Vainshtein <ofirvins(a)google.com> --- M src/SAL/nfs4_state_id.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/84/1234084/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234084?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I192d6e38304d1c10b8c86cfae8b8b0340bd2f215 Gerrit-Change-Number: 1234084 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 week, 6 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Fix state object deletion during owner purge in NFSv4 lock handling.

by ofir vainshtein (GerritHub)

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234083?usp=email ) Change subject: Fix state object deletion during owner purge in NFSv4 lock handling. ...................................................................... Fix state object deletion during owner purge in NFSv4 lock handling. The `state_nfs4_owner_unlock_all` function now deletes the state object if `state_unlock` returns any non-error status, not just `STATE_SUCCESS`. This prevents state leaks when `state_unlock` returns other acceptable statuses. Change-Id: I3bf6011f5a1a94416ed98bffdd6a41f72bfdee75 Signed-off-by: Ofir Vainshtein <ofirvins(a)google.com> --- M src/SAL/state_lock.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/83/1234083/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234083?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3bf6011f5a1a94416ed98bffdd6a41f72bfdee75 Gerrit-Change-Number: 1234083 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 week, 6 days

1
0
0 / 0

Announce Push of V9.9

by Frank Filz

Branch next Tag:V9.9 Merge Highlights * ganesha_mgr: accept short log component names for get/set log * Updated the Man page for NFS Over RDMA support. * mdcache: optimize mdc_get_parent to reduce content_lock contention * idmapper: fix cache invalidation after config reload Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 8e706d72a Frank S. Filz V9.9 958626269 xueqian.hu idmapper: fix cache invalidation after config reload da4fb058b sajikvr mdcache: optimize mdc_get_parent to reduce content_lock contention 1ff7c1e32 Rajesh Prasad Updated the Man page for NFS Over RDMA support. b33235ab9 Nishant Puri ganesha_mgr: accept short log component names for get/set log

2 weeks, 2 days

1
0
0 / 0

[L] Change in ...nfs-ganesha[next]: Enhance header files to support both C and C++ compilation

by Name of user not set (GerritHub)

sragraha(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233754?usp=email ) Change subject: Enhance header files to support both C and C++ compilation ...................................................................... Enhance header files to support both C and C++ compilation This change standardizes the header interface, making it robust for use of both C and C++ source files, which is critical for prometheus .cc files usability. Change-Id: Id8355941660d40654dc3a7d2f5293d2570996f8f Signed-off-by: Sreedhar Agraharam <sragraha(a)redhat.com> --- M src/FSAL/FSAL_RGW/handle.c M src/include/9p.h M src/include/abstract_mem.h M src/include/common_utils.h M src/include/fsal.h M src/include/gsh_lttng/gsh_lttng.h M src/include/gsh_refstr.h M src/include/hashtable.h M src/include/log.h M src/include/nfs_fh.h M src/include/nfsacl.h M src/include/nfsv41.h M src/include/sal_data.h 13 files changed, 263 insertions(+), 121 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/54/1233754/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233754?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id8355941660d40654dc3a7d2f5293d2570996f8f Gerrit-Change-Number: 1233754 Gerrit-PatchSet: 1 Gerrit-Owner: sragraha(a)redhat.com

2 weeks, 4 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: mdcache: optimize mdc_get_parent to reduce content_lock contention

by Xueqian Hu (GerritHub)

Xueqian Hu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233751?usp=email ) Change subject: mdcache: optimize mdc_get_parent to reduce content_lock contention ...................................................................... mdcache: optimize mdc_get_parent to reduce content_lock contention In mdcache_create_handle (PUTFH path), mdc_get_parent was called unconditionally for every entry, acquiring content_lock in exclusive write mode even for non-directory entries where parent pointers are not applicable. This caused unnecessary serialization on every NFSv4 PUTFH operation. Two optimizations: 1. Skip mdc_get_parent entirely for non-directory entries in mdcache_create_handle, since parent pointers are only meaningful for directories. 2. In mdc_get_parent, use a shared read lock first to check if the parent pointer is already cached and valid (the common case). Only upgrade to an exclusive write lock when the parent pointer actually needs to be refreshed. After acquiring the write lock, re-check to avoid redundant '..' lookups if another thread already refreshed it. Change-Id: Ifefe27bd21561bac21fe8cab9a435f280d3bb316 Signed-off-by: xueqian.hu <xh140312(a)outlook.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 2 files changed, 27 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/51/1233751/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233751?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ifefe27bd21561bac21fe8cab9a435f280d3bb316 Gerrit-Change-Number: 1233751 Gerrit-PatchSet: 1 Gerrit-Owner: Xueqian Hu <xh140312(a)outlook.com>

2 weeks, 5 days

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

Devel March 2026