March 2026 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: Fix handling of WRITE and READ deleg with ATTRS
by Animesh Javali (GerritHub) 25 Mar '26

25 Mar '26

Animesh Javali has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234257?usp=email ) Change subject: Fix handling of WRITE and READ deleg with ATTRS ...................................................................... Fix handling of WRITE and READ deleg with ATTRS In nfs4_op_write(), the existing validation relied on a bitwise check against OPEN_DELEGATE_WRITE, which does not work for OPEN_DELEGATE_WRITE_ATTRS_DELEG This resulted in valid WRITE_ATTRS_DELEG stateids being rejected with NFS4ERR_BAD_STATEID. Fix this by explicitly allowing both OPEN_DELEGATE_WRITE and OPEN_DELEGATE_WRITE_ATTRS_DELEG. Update queue_deleg_transition_handler() to treat READ_ATTRS_DELEG and WRITE_ATTRS_DELEG equivalently to their READ/WRITE counterparts when evaluating export-level delegation permissions (EXPORT_OPTION_READ_DELEG / EXPORT_OPTION_WRITE_DELEG). This ensures correct recall behavior when delegations are disabled via export configuration for attribute-aware delegations. Change-Id: I1848c6a3764ca1c588d26a47a11029aad228162d Signed-off-by: Animesh Javali <Animesh.Javali(a)ibm.com> --- M src/Protocols/NFS/nfs4_op_write.c M src/support/export_mgr.c 2 files changed, 19 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/57/1234257/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234257?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1848c6a3764ca1c588d26a47a11029aad228162d Gerrit-Change-Number: 1234257 Gerrit-PatchSet: 1 Gerrit-Owner: Animesh Javali <Animesh.Javali(a)ibm.com>

1 0

[S] Change in ...nfs-ganesha[next]: Fix for Coverity IDs: 509127,509133
by Animesh Javali (GerritHub) 25 Mar '26

25 Mar '26

Animesh Javali has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234237?usp=email ) Change subject: Fix for Coverity IDs: 509127,509133 ...................................................................... Fix for Coverity IDs: 509127,509133 Fixed big parameter passed by value. Coverity flagged that struct sau_attr_reply is being passed by value in isOffsetChangedByClient() and hasRecentModificationTime(), leading to unnecessary copying of a large structure. This change converts the function parameters to pass by reference(pointer), avoiding the overhead of copying while maintaining the same functionality. Change-Id: Ifca860124a05984b60c97e481aec7d85c90cc84e Signed-off-by: Animesh Javali <Animesh.Javali(a)ibm.com> --- M src/FSAL/FSAL_SAUNAFS/mds_handle.c 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/37/1234237/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234237?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ifca860124a05984b60c97e481aec7d85c90cc84e Gerrit-Change-Number: 1234237 Gerrit-PatchSet: 1 Gerrit-Owner: Animesh Javali <Animesh.Javali(a)ibm.com>

1 0

[M] Change in ...nfs-ganesha[next]: Add log rotation functionality to Ganesha.
by ofir vainshtein (GerritHub) 22 Mar '26

22 Mar '26

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234087?usp=email ) Change subject: Add log rotation functionality to Ganesha. ...................................................................... Add log rotation functionality to Ganesha. This change introduces the ability to rotate Ganesha log files based on size and/or time. A new "Rotate" block can be added within the "LOG" section of the configuration. The options are: - size_kb: Rotate when the log file size exceeds this value in KB. - time_sec: Rotate when the time since the last rotation exceeds this value in seconds. When rotation occurs, the current log file is renamed to <log_file_path>.old. Change-Id: I08f410b615874eadcd1a740ad79d87b8c6aae772 Signed-off-by: Ofir Vainshtein <ofirvins(a)google.com> --- M src/doc/man/ganesha-log-config.rst M src/log/log_functions.c 2 files changed, 134 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/87/1234087/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234087?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I08f410b615874eadcd1a740ad79d87b8c6aae772 Gerrit-Change-Number: 1234087 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 0

[S] Change in ...nfs-ganesha[next]: Add a rolling log index to Ganesha logs.
by ofir vainshtein (GerritHub) 22 Mar '26

22 Mar '26

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234086?usp=email ) Change subject: Add a rolling log index to Ganesha logs. ...................................................................... Add a rolling log index to Ganesha logs. Introduces a new log format option, LOG_INDEX, which adds a monotonically increasing index to each log line. The index is a 5-digit number that wraps around at 100000. This helps in tracking the order of log messages. The super_ut configuration is updated to enable this new option. note because index is taken before write and not under exclusive lock with it. logs are not guaranteed to appear in order in the file Change-Id: Ieb251326238810d9c3251b36a0d40c2d4844d52d Signed-off-by: Ofir Vainshtein <ofirvins(a)google.com> --- M src/doc/man/ganesha-log-config.rst M src/include/abstract_atomic.h M src/log/log_functions.c 3 files changed, 45 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/86/1234086/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ieb251326238810d9c3251b36a0d40c2d4844d52d Gerrit-Change-Number: 1234086 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 0

[S] Change in ...nfs-ganesha[next]: Move STATELOCK acquisition out of state_test and process_blocked_lock...
by ofir vainshtein (GerritHub) 22 Mar '26

22 Mar '26

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234085?usp=email ) Change subject: Move STATELOCK acquisition out of state_test and process_blocked_lock_upcall ...................................................................... Move STATELOCK acquisition out of state_test and process_blocked_lock_upcall The STATELOCK is now acquired by the callers of state_test and process_blocked_lock_upcall rather than inside these functions. This ensures that the lock is held consistently across operations involving state objects. Also fixed state_test access of lock_entry fields without lock Change-Id: I82ba6f828e7b2be73580f967b0a3b7c775a69e89 Signed-off-by: Ofir Vainshtein <ofirvins(a)google.com> --- M src/Protocols/NFS/nfs4_op_lockt.c M src/SAL/state_async.c M src/SAL/state_lock.c 3 files changed, 14 insertions(+), 16 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/85/1234085/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234085?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I82ba6f828e7b2be73580f967b0a3b7c775a69e89 Gerrit-Change-Number: 1234085 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Add LTTng tracepoints for state object reference counting.
by ofir vainshtein (GerritHub) 22 Mar '26

22 Mar '26

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234084?usp=email ) Change subject: Add LTTng tracepoints for state object reference counting. ...................................................................... Add LTTng tracepoints for state object reference counting. This change introduces GSH_AUTO_TRACEPOINT calls in nfs4_state_dec_ref to log state object decref operations, including the state pointer and the resulting refcount. Change-Id: I192d6e38304d1c10b8c86cfae8b8b0340bd2f215 Signed-off-by: Ofir Vainshtein <ofirvins(a)google.com> --- M src/SAL/nfs4_state_id.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/84/1234084/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234084?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I192d6e38304d1c10b8c86cfae8b8b0340bd2f215 Gerrit-Change-Number: 1234084 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Fix state object deletion during owner purge in NFSv4 lock handling.
by ofir vainshtein (GerritHub) 22 Mar '26

22 Mar '26

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234083?usp=email ) Change subject: Fix state object deletion during owner purge in NFSv4 lock handling. ...................................................................... Fix state object deletion during owner purge in NFSv4 lock handling. The `state_nfs4_owner_unlock_all` function now deletes the state object if `state_unlock` returns any non-error status, not just `STATE_SUCCESS`. This prevents state leaks when `state_unlock` returns other acceptable statuses. Change-Id: I3bf6011f5a1a94416ed98bffdd6a41f72bfdee75 Signed-off-by: Ofir Vainshtein <ofirvins(a)google.com> --- M src/SAL/state_lock.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/83/1234083/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1234083?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3bf6011f5a1a94416ed98bffdd6a41f72bfdee75 Gerrit-Change-Number: 1234083 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 0

Announce Push of V9.9
by Frank Filz 19 Mar '26

19 Mar '26

Branch next Tag:V9.9 Merge Highlights * ganesha_mgr: accept short log component names for get/set log * Updated the Man page for NFS Over RDMA support. * mdcache: optimize mdc_get_parent to reduce content_lock contention * idmapper: fix cache invalidation after config reload Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 8e706d72a Frank S. Filz V9.9 958626269 xueqian.hu idmapper: fix cache invalidation after config reload da4fb058b sajikvr mdcache: optimize mdc_get_parent to reduce content_lock contention 1ff7c1e32 Rajesh Prasad Updated the Man page for NFS Over RDMA support. b33235ab9 Nishant Puri ganesha_mgr: accept short log component names for get/set log

1 0

[L] Change in ...nfs-ganesha[next]: Enhance header files to support both C and C++ compilation
by Name of user not set (GerritHub) 17 Mar '26

17 Mar '26

sragraha(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233754?usp=email ) Change subject: Enhance header files to support both C and C++ compilation ...................................................................... Enhance header files to support both C and C++ compilation This change standardizes the header interface, making it robust for use of both C and C++ source files, which is critical for prometheus .cc files usability. Change-Id: Id8355941660d40654dc3a7d2f5293d2570996f8f Signed-off-by: Sreedhar Agraharam <sragraha(a)redhat.com> --- M src/FSAL/FSAL_RGW/handle.c M src/include/9p.h M src/include/abstract_mem.h M src/include/common_utils.h M src/include/fsal.h M src/include/gsh_lttng/gsh_lttng.h M src/include/gsh_refstr.h M src/include/hashtable.h M src/include/log.h M src/include/nfs_fh.h M src/include/nfsacl.h M src/include/nfsv41.h M src/include/sal_data.h 13 files changed, 263 insertions(+), 121 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/54/1233754/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233754?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id8355941660d40654dc3a7d2f5293d2570996f8f Gerrit-Change-Number: 1233754 Gerrit-PatchSet: 1 Gerrit-Owner: sragraha(a)redhat.com

1 0

[S] Change in ...nfs-ganesha[next]: mdcache: optimize mdc_get_parent to reduce content_lock contention
by Xueqian Hu (GerritHub) 16 Mar '26

16 Mar '26

Xueqian Hu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233751?usp=email ) Change subject: mdcache: optimize mdc_get_parent to reduce content_lock contention ...................................................................... mdcache: optimize mdc_get_parent to reduce content_lock contention In mdcache_create_handle (PUTFH path), mdc_get_parent was called unconditionally for every entry, acquiring content_lock in exclusive write mode even for non-directory entries where parent pointers are not applicable. This caused unnecessary serialization on every NFSv4 PUTFH operation. Two optimizations: 1. Skip mdc_get_parent entirely for non-directory entries in mdcache_create_handle, since parent pointers are only meaningful for directories. 2. In mdc_get_parent, use a shared read lock first to check if the parent pointer is already cached and valid (the common case). Only upgrade to an exclusive write lock when the parent pointer actually needs to be refreshed. After acquiring the write lock, re-check to avoid redundant '..' lookups if another thread already refreshed it. Change-Id: Ifefe27bd21561bac21fe8cab9a435f280d3bb316 Signed-off-by: xueqian.hu <xh140312(a)outlook.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 2 files changed, 27 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/51/1233751/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233751?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ifefe27bd21561bac21fe8cab9a435f280d3bb316 Gerrit-Change-Number: 1233751 Gerrit-PatchSet: 1 Gerrit-Owner: Xueqian Hu <xh140312(a)outlook.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Updated the Man page for NFS Over RDMA support.
by Rajesh Prasad (GerritHub) 16 Mar '26

16 Mar '26

Rajesh Prasad has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233742?usp=email ) Change subject: Updated the Man page for NFS Over RDMA support. ...................................................................... Updated the Man page for NFS Over RDMA support. Change-Id: If12b8558f6691902cfafe1048e3a8858a8fc846c Signed-off-by: Rajesh Prasad <raprasad(a)redhat.com> --- M src/doc/man/ganesha-core-config.rst 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/42/1233742/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233742?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If12b8558f6691902cfafe1048e3a8858a8fc846c Gerrit-Change-Number: 1233742 Gerrit-PatchSet: 1 Gerrit-Owner: Rajesh Prasad <raprasad(a)redhat.com>

1 0

[S] Change in ...nfs-ganesha[next]: ganesha_mgr: accept short log component names for get/set log
by Nishant Puri (GerritHub) 16 Mar '26

16 Mar '26

Nishant Puri has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233718?usp=email ) Change subject: ganesha_mgr: accept short log component names for get/set log ...................................................................... ganesha_mgr: accept short log component names for get/set log The DBus log interfaces use property names with a "COMPONENT_" prefix (e.g. COMPONENT_FSAL), while the config file uses short names (FSAL, ALL, NFS_V4). ganesha_mgr was passing the component name through to DBus unchanged, so "ganesha_mgr get log FSAL" failed and only "ganesha_mgr get log COMPONENT_FSAL" worked. Add _log_component_prop_name() in ganesha_mgr_utils.py to normalize the component name: if it does not already start with "COMPONENT_", prepend it. Use this in LogManager and CondLogManager Get/Set so both short names and COMPONENT_* names work for "get log", "set log", "get log conditional", and "set log conditional". Change-Id: Icc7ac03d9c2dc9bcc1012705078ba7b8b27d7b4e Signed-off-by: Nishant Puri <npuri(a)redhat.com> --- M src/scripts/ganeshactl/Ganesha/ganesha_mgr_utils.py 1 file changed, 10 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/18/1233718/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233718?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Icc7ac03d9c2dc9bcc1012705078ba7b8b27d7b4e Gerrit-Change-Number: 1233718 Gerrit-PatchSet: 1 Gerrit-Owner: Nishant Puri <npuri(a)redhat.com>

1 0

Announce Push of V9.8
by Frank Filz 13 Mar '26

13 Mar '26

Branch next Tag:V9.8 Merge Highlights * add bcond support for NFS_RDMA and RPC_RDMA * 4 fixes to fsal_fd handling * Coverity 502061: Fix null dereference in nfsacl_setacl() * NFSv4.1: Send initial CB_NULL after CREATE_SESSION to fix pynfs CSESS20/21 * Enhancing enable_udp option to control rquota in ganesha config file. * delayed_executor: Deny submission after shutdown. * Fix compilation failure - Variable cannot be declared in a case block * ganesha_mgr: add conditional logging commands via log.conditional DBus Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 9758b7918 Frank S. Filz V9.8 f2e4a9b75 Nishant Puri ganesha_mgr: add conditional logging commands via log.conditional DBus 943ea4017 Shahar Hochma Fix compilation failure - Variable cannot be declared in a case block 4d120d34e Nikhil Adhau delayed_executor: Deny submission after shutdown. 07faf2bc0 Ananya Gupta Enhancing enable_udp option to control rquota in ganesha config file. 50955874e VidyaThumukunta NFSv4.1: Send initial CB_NULL after CREATE_SESSION to fix pynfs CSESS20/21 2e31c440a VidyaThumukunta Coverity 502061: Fix null dereference in nfsacl_setacl() Avoid passing NULL acl_access to nfs3_acl_2_fsal_acl(). 9d74bf3ec Deeraj.Patil Map the reopen fd to correct fsal_export. 0f0f155e7 Deeraj.Patil close_fsal_fd: remove GLOBAL_FD on close from lru list. a884c8ca3 Deeraj.Patil NFSv3 stop new IO's when unexport in progress. c7bc48d1f Deeraj.Patil Export cleanup, releasing FD's. eced4cc58 Prabhu Murugesan add bcond support for NFS_RDMA and RPC_RDMA

1 0

[L] Change in ...nfs-ganesha[next]: ganesha_mgr: add conditional logging commands via log.conditional DBus
by Nishant Puri (GerritHub) 13 Mar '26

13 Mar '26

Nishant Puri has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233570?usp=email ) Change subject: ganesha_mgr: add conditional logging commands via log.conditional DBus ...................................................................... ganesha_mgr: add conditional logging commands via log.conditional DBus Add ganesha_mgr subcommands that call the org.ganesha.nfsd.log.conditional DBus interface for managing conditional logging clients, exports, and match policy. Show: - show conditional_clients (ShowConditionalLogClientList) - show conditional_exports (ShowConditionalLogExportList) - show conditional_match_policy (ShowMatchPolicy) Update: - update conditional_match_policy <ANY|ALL> (ChangeMatchPolicy) Output is the backend message only; no "Returns: status = ..." line. Add: - add conditional_clients <ipaddr> (ClientEnable; IP/CIDR only) - add conditional_exports <export_id> (ExportEnable) Remove: - remove conditional_clients <ipaddr> (ClientDisable) If the argument looks like shell-expanded '*' (e.g. multiple args or a single non-IP/CIDR token), the command is not run and the user is told to quote the asterisk: remove conditional_clients '*' - remove conditional_exports <export_id> (ExportDisable) Helpers are implemented in Ganesha/ganesha_mgr_utils.py (CondLogManager); CLI parsing, help text, and per-command behavior are in ganesha_mgr.py. Change-Id: I35fcdc9f0baa8baed603a4d2a46638c71b4ebd42 Signed-off-by: Nishant Puri <npuri(a)redhat.com> --- M src/scripts/ganeshactl/Ganesha/ganesha_mgr_utils.py M src/scripts/ganeshactl/ganesha_mgr.py 2 files changed, 248 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/70/1233570/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233570?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I35fcdc9f0baa8baed603a4d2a46638c71b4ebd42 Gerrit-Change-Number: 1233570 Gerrit-PatchSet: 1 Gerrit-Owner: Nishant Puri <npuri(a)redhat.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Fix compilation failure - Variable cannot be declared in a case block
by Name of user not set (GerritHub) 12 Mar '26

12 Mar '26

shaharhoch(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233565?usp=email ) Change subject: Fix compilation failure - Variable cannot be declared in a case block ...................................................................... Fix compilation failure - Variable cannot be declared in a case block Change-Id: Iafb5898b7eb5aad6923dc3e0e6000486a496323c Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/support/client_mgr.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/65/1233565/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233565?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iafb5898b7eb5aad6923dc3e0e6000486a496323c Gerrit-Change-Number: 1233565 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)google.com

1 0

[S] Change in ...nfs-ganesha[next]: idmapper: fix cache invalidation after config reload
by Xueqian Hu (GerritHub) 12 Mar '26

12 Mar '26

Xueqian Hu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233564?usp=email ) Change subject: idmapper: fix cache invalidation after config reload ...................................................................... idmapper: fix cache invalidation after config reload reread_config() resets idmapped_user/group_time_validity to -1 without the fallback to manage_gids_expiration, causing the idmapper cache to be permanently disabled after any config reload. Change-Id: I13a239e5c702db604620504ed732a179a93fd32c Signed-off-by: xueqian.hu <xh140312(a)outlook.com> --- M src/MainNFSD/nfs_init.c 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/64/1233564/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233564?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I13a239e5c702db604620504ed732a179a93fd32c Gerrit-Change-Number: 1233564 Gerrit-PatchSet: 1 Gerrit-Owner: Xueqian Hu <xh140312(a)outlook.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Downgrade LogWarn to LogDebug for unsupported principal code paths
by Xueqian Hu (GerritHub) 12 Mar '26

12 Mar '26

Xueqian Hu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233560?usp=email ) Change subject: Downgrade LogWarn to LogDebug for unsupported principal code paths ...................................................................... Downgrade LogWarn to LogDebug for unsupported principal code paths Change-Id: I5dd18a5316f49cb4498360e0b3f96b184e9e6307 Signed-off-by: xueqian.hu <xh140312(a)outlook.com> --- M src/support/nfs_creds.c M src/support/uid2grp.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/60/1233560/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1233560?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5dd18a5316f49cb4498360e0b3f96b184e9e6307 Gerrit-Change-Number: 1233560 Gerrit-PatchSet: 1 Gerrit-Owner: Xueqian Hu <xh140312(a)outlook.com>

1 0

Ganesha and SELinux
by alexpagan01＠gmail.com 05 Mar '26

05 Mar '26

Greetings! Ive been looking everywhere for more information and came upon this website. So, straight to the point, I have configured ganesha to export a file directory as nfsv4.2 with security_label = true so i can have selinux mls labels propagate between server and client but after mounting the server on the client and verifying flags, the security_label flag does not appear and the files inside the mount remain at a default state of sensitivity level 0. Im hoping people here experienced in ganesha are able to help me fix this issue. Please and thank you

4 4

[S] Change in ...nfs-ganesha[next]: Enhancing enable_udp option to control rquota in ganesha config file.
by Ananya Gupta (GerritHub) 05 Mar '26

05 Mar '26

Ananya Gupta has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1232804?usp=email ) Change subject: Enhancing enable_udp option to control rquota in ganesha config file. ...................................................................... Enhancing enable_udp option to control rquota in ganesha config file. enable_udp options: true: udp enabled for all protocols false: udp disabled for all protocols mount: udp enabled for only mount rquota: udp enabled for only rquota NLM: udp enabled for only NLM mount, rquota: for both mount and rquota protocol Change-Id: I14d771eed06cbd63807c5d84d766ed7dc39cc807 Signed-off-by: Ananya Gupta <ananyagupta4506(a)gmail.com> --- M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/doc/man/ganesha-core-config.rst M src/include/gsh_config.h M src/support/nfs_read_conf.c 4 files changed, 17 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/04/1232804/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1232804?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I14d771eed06cbd63807c5d84d766ed7dc39cc807 Gerrit-Change-Number: 1232804 Gerrit-PatchSet: 1 Gerrit-Owner: Ananya Gupta <ananyagupta4506(a)gmail.com>

1 0

[S] Change in ...nfs-ganesha[next]: [reopen fd] : Map the reopen fd to correct fsal_export.
by Name of user not set (GerritHub) 02 Mar '26

02 Mar '26

deeraj.patil(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1232499?usp=email ) Change subject: [reopen fd] : Map the reopen fd to correct fsal_export. ...................................................................... [reopen fd] : Map the reopen fd to correct fsal_export. Issue is consistantly seen in below senario : export_1-> io running -> unexported -> aftersometime -> re_exported with same id When an mdcache entry survives an unexport/reexport cycle (remains in L1/L2 cache), its embedded fsal_fd->fsal_export may point to: 1. Freed memory (exp_ops=NULL): crash in insert_fd_lru or the LRU reaper when it dereferences fsal_fd->fsal_export->owning_export. 2. Reallocated memory for a different export: the old export's memory is reused for a new export struct. fsal_fd->fsal_export is a valid pointer but to the WRONG export. The FD is inserted into the global LRU under the wrong export's accounting; access-control decisions use the wrong export context silent data corruption. Change-Id: Ib2d5cb062a5ec12dd5d7265e22855ebdf234b2e7 Signed-off-by: Deeraj.Patil <Deeraj.Patil(a)ibm.com> --- M src/FSAL/commonlib.c 1 file changed, 38 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/99/1232499/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1232499?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib2d5cb062a5ec12dd5d7265e22855ebdf234b2e7 Gerrit-Change-Number: 1232499 Gerrit-PatchSet: 1 Gerrit-Owner: deeraj.patil(a)ibm.com

1 0

[S] Change in ...nfs-ganesha[next]: close_fsal_fd: remove GLOBAL_FD on close from lru list.
by Name of user not set (GerritHub) 02 Mar '26

02 Mar '26

deeraj.patil(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1232498?usp=email ) Change subject: close_fsal_fd: remove GLOBAL_FD on close from lru list. ...................................................................... close_fsal_fd: remove GLOBAL_FD on close from lru list. The previous logic skipped remove_fd_lru when ERR_FSAL_NOT_OPENED was returned (FD already logically closed). When doing release(), which internally calls the close_fsal_fd on FD already in closed state, this FD doesn't get removed from global_lru_list and is freed. This dangling entry is pickedup by the reaper thread causing unintented behaviour (Use-after-free). Change-Id: I14dc304c2126ff991b223c841ffd22a1a7ba953d Signed-off-by: Deeraj.Patil <Deeraj.Patil(a)ibm.com> --- M src/FSAL/commonlib.c 1 file changed, 18 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/98/1232498/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1232498?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I14dc304c2126ff991b223c841ffd22a1a7ba953d Gerrit-Change-Number: 1232498 Gerrit-PatchSet: 1 Gerrit-Owner: deeraj.patil(a)ibm.com

1 0

[S] Change in ...nfs-ganesha[next]: [unexport] : NFSv3 stop new IO's when unexport in progress.
by Name of user not set (GerritHub) 02 Mar '26

02 Mar '26

deeraj.patil(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1232497?usp=email ) Change subject: [unexport] : NFSv3 stop new IO's when unexport in progress. ...................................................................... [unexport] : NFSv3 stop new IO's when unexport in progress. mdcache_locate_host is called for every NFS request (NFSv3 and NFSv4) that carries a file handle via create_handle. On a cache hit it returns the cached entry without checking whether the current export is being unexported or whether the entry is still mapped to the requesting export. A concurrent NFSv3 request arriving while mdcache_unexport is removing entries can receive a valid-looking entry whose backing export is being freed. The caller then proceeds to reopen_fsal_fd, re-inserting a FD into the global LRU under the dying export's fsal_export pointer, eventually causing a use-after-free in the LRU reaper. After a cache hit, call mdc_check_mapping() to verify the entry is still mapped to the current export and MDC_UNEXPORT is not set. Change-Id: I5b0b0f74a71977dab27045029f38a0f3309af5d4 Signed-off-by: Deeraj.Patil <Deeraj.Patil(a)ibm.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/1232497/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1232497?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5b0b0f74a71977dab27045029f38a0f3309af5d4 Gerrit-Change-Number: 1232497 Gerrit-PatchSet: 1 Gerrit-Owner: deeraj.patil(a)ibm.com

1 0

[M] Change in ...nfs-ganesha[next]: [mdcache] : Export cleanup, releasing FD's.
by Name of user not set (GerritHub) 02 Mar '26

02 Mar '26

deeraj.patil(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1232496?usp=email ) Change subject: [mdcache] : Export cleanup, releasing FD's. ...................................................................... [mdcache] : Export cleanup, releasing FD's. When an export is removed (SIGHUP or admin), the call sequence is: prepare_unexport -> state_release_export -> unexport -> exp_release. NFSv3 is stateless: state_release_export closes nothing for NFSv3. Global FDs on mdcache entries (opened by NFSv3 READ/WRITE) survive with fsal_export pointers that are about to be freed. The LRU reaper running concurrently can dereference those pointers after exp_release frees the export struct (use-after-free). In-flight NFSv3 threads that already resolved a file handle can also call reopen_fsal_fd between unexport's fsal_close calls and exp_release, re-inserting a FD into the global LRU for a being-freed export. Nested export case (exportA inside exportB): entries shared between exportA and exportB both needs to drain global FD base on which export is getting released. And is tracked via cleanup_export/cleanup_pending; the export drain waits for all of them before releasing the export struct. Two early-stop flags prevent new FDs from being created on a dying export: EXPORT_STALE is set in release_export before prepare_unexport, and MDC_UNEXPORT is set in mdcache_prepare_unexport itself. During mdcache_unexport, global FDs are force-closed via fsal_close on every entry; entries that become fully unmapped (expmap==NULL) are additionally tracked by setting entry->cleanup_export and incrementing exp->cleanup_pending, while entries still mapped to a sibling export only get their FD closed (no tracking needed, they stay alive). The same tracking applies in mdcache_unmount for junction entries. When the LRU thread finally cleans a tracked entry in mdcache_lru_clean, it decrements cleanup_pending and signals cleanup_cond when it hits zero; if mdcache_lru_cleanup_try_push fails due to active refs, the tracking fields are left in place so the wait still covers that entry. Finally, mdcache_exp_release calls mdcache_drain_export_cleanup() a simple cond var wait on cleanup_pending == 0 before freeing anything, guaranteeing no LRU thread or reaper can dereference the export after it is freed. Change-Id: I44f761479883e84e43f8a23f5c3a9fbe563490fd Signed-off-by: Deeraj.Patil <Deeraj.Patil(a)ibm.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_main.c M src/support/exports.c 5 files changed, 121 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/96/1232496/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1232496?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I44f761479883e84e43f8a23f5c3a9fbe563490fd Gerrit-Change-Number: 1232496 Gerrit-PatchSet: 1 Gerrit-Owner: deeraj.patil(a)ibm.com

1 0