[L] Change in ...nfs-ganesha[next]: Grpc: Add CacheMgr gRPC APIs
by Name of user not set (GerritHub)
Vidya.Thumukunta(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1244769?usp=email )
Change subject: Grpc: Add CacheMgr gRPC APIs
......................................................................
Grpc: Add CacheMgr gRPC APIs
Implement gRPC equivalents for the CacheMgr DBus APIs by introducing
the CacheMgrService. Add support for the following methods:
- ShowIdMapperUsers
- ShowIdMapperGroups
- ShowNegativeUsers
- ShowNegativeGroups
- ShowNegativeUIDs
- ShowUid2Grp
Introduce helper APIs in the cache modules to populate gRPC-specific
data structures while keeping the existing DBus implementation
unchanged.
Change-Id: I76e2d983244a7a617012127f80bfc7ac69dc54a9
Signed-off-by: VidyaThumukunta <vidya.thumukunta(a)ibm.com>
---
M src/grpc_server/GrpcServer.cc
M src/grpc_server/GrpcServer.h
M src/grpc_server/nfsService.h
M src/grpc_server/nfsServiceServer.cc
A src/grpc_server/proto/cacheMgrService.proto
M src/idmapper/idmapper_cache.c
M src/idmapper/idmapper_negative_cache.c
M src/include/idmapper.h
M src/support/uid2grp_cache.c
9 files changed, 575 insertions(+), 62 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/69/1244769/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1244769?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I76e2d983244a7a617012127f80bfc7ac69dc54a9
Gerrit-Change-Number: 1244769
Gerrit-PatchSet: 1
Gerrit-Owner: Vidya.Thumukunta(a)ibm.com
1 month, 1 week
[M] Change in ...nfs-ganesha[next]: NFS Ganesha Crash - pthread_mutex_lock on NULL in svc_rqst_expire_ins...
by Rajesh Prasad (GerritHub)
Rajesh Prasad has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1244768?usp=email )
Change subject: NFS Ganesha Crash - pthread_mutex_lock on NULL in svc_rqst_expire_insert()
......................................................................
NFS Ganesha Crash - pthread_mutex_lock on NULL in svc_rqst_expire_insert()
PROBLEM | FIX
1 Inline grant from LOCKU worker | `state_block_schedule()` in
`grant_blocked_locks()`
2 `CLNT_CALL_BACK` without `ev_p` | v4.0: `CLNT_CALL_WAIT`; libntirpc:
guard `ev_p`
3 `CLNT_CALL_WAIT` / destroy on v4.1 shared xprt | v4.1: keep
`CLNT_CALL_BACK`; don't
destroy shared client on
failure
4 Retry storm when channel down | Skip v4.0 grant when
`cb_chan_down`; downgrade noisy
CRIT logs
Broken Flow :
```
LOCKU worker thread
grant_blocked_locks()
try_to_grant_lock() ← synchronous
nfsv4_granted_callback()
nfs_rpc_call()
CLNT_CALL_BACK() ← always
svc_rqst_expire_insert()
mutex_lock(NULL) ← CRASH on State_Async/v4.0
```
Fixed Flow :
```
LOCKU worker thread
grant_blocked_locks()
state_block_schedule() ← async handoff
...
State_Async thread
try_to_grant_lock()
[skip if v4.0 && cb_chan_down]
nfsv4_granted_callback()
nfs_rpc_cb_single()
├─ v4.0 → nfs_rpc_v40_single()
│ nfs_rpc_call()
│ CLNT_CALL_WAIT()
│ nfs_rpc_call_finish_success()
│
└─ v4.1 → nfs_rpc_v41_single()
nfs_rpc_call()
CLNT_CALL_BACK()
nfs_rpc_call_process() [async on reply]
[on failure: clear session_bc_up, retry other
session]
```
Change-Id: Ia68cd82dfd572e061d48e34ef9eee8fba41c01ca
Signed-off-by: Rajesh Prasad <raprasad(a)redhat.com>
---
M src/MainNFSD/nfs_rpc_callback.c
M src/SAL/state_lock.c
2 files changed, 100 insertions(+), 9 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/68/1244768/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1244768?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ia68cd82dfd572e061d48e34ef9eee8fba41c01ca
Gerrit-Change-Number: 1244768
Gerrit-PatchSet: 1
Gerrit-Owner: Rajesh Prasad <raprasad(a)redhat.com>
1 month, 1 week
[S] Change in ...nfs-ganesha[next]: log: ignore duplicate conditional logging list entries
by Nishant Puri (GerritHub)
Nishant Puri has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1244612?usp=email )
Change subject: log: ignore duplicate conditional logging list entries
......................................................................
log: ignore duplicate conditional logging list entries
Duplicate export IDs or clients in Log { Conditional { ... } } were
reported via config_proc_error() but set err_type->exists, causing
read_log_config() to fail and abort startup or reload.
After logging a duplicate, clear err_type->exists and return success from
the conditional logging adders so the first entry is kept and parsing
continues. Warnings remain in the config error buffer, so startup still
fails when ganesha.nfsd is invoked with -x.
Change-Id: Ib3915bdd8175ca1d5812c29bcdfa21c50799e740
Signed-off-by: Nishant Puri <npuri(a)redhat.com>
---
M src/log/log_functions.c
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/12/1244612/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1244612?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ib3915bdd8175ca1d5812c29bcdfa21c50799e740
Gerrit-Change-Number: 1244612
Gerrit-PatchSet: 1
Gerrit-Owner: Nishant Puri <npuri(a)redhat.com>
1 month, 1 week
[L] Change in ...nfs-ganesha[next]: Add runtime Cluster_Members update via D-Bus and gRPC
by Suhas Athani (GerritHub)
Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1244581?usp=email )
Change subject: Add runtime Cluster_Members update via D-Bus and gRPC
......................................................................
Add runtime Cluster_Members update via D-Bus and gRPC
- Add runtime Set/Show for NFS_CORE_PARAM.Cluster_Members
(IPv4/IPv6 host addresses only).
- Expose the same APIs on D-Bus (org.ganesha.nfsd.admin) and
gRPC (nfsService.ClusterMembers).
- Protect list updates with nfs_core_lock, keep the NSM notify
thread lifecycle in sync, and leave the previous list unchanged
on validation failure.
Details:
- New helpers in cluster_members.c / cluster_members.h.
- D-Bus: SetClusterMembers / ShowClusterMembers on
/org/ganesha/nfsd/admin.
- gRPC: SetClusterMembers / ShowClusterMembers.
- Config reread / SIGHUP can also refresh Cluster_Members.
- Runtime updates are per-node and do not rewrite ganesha.conf.
- Self IPs are moved to cluster_self and omitted from Show.
Change-Id: Idf631c4c648ff0d835bf07962f5ee7991b5ddd5e
Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com>
---
M src/MainNFSD/nfs_admin_thread.c
M src/MainNFSD/nfs_init.c
M src/Protocols/NLM/nsm.c
M src/doc/man/ganesha-core-config.rst
M src/grpc_server/GrpcServer.cc
M src/grpc_server/GrpcServer.h
M src/grpc_server/nfsService.h
M src/grpc_server/nfsServiceServer.cc
M src/grpc_server/proto/nfsService.proto
A src/include/cluster_members.h
M src/include/gsh_config.h
M src/include/nfs_core.h
M src/include/nsm.h
M src/include/sal_functions.h
M src/support/CMakeLists.txt
M src/support/client_mgr.c
A src/support/cluster_members.c
M src/support/nfs_read_conf.c
18 files changed, 879 insertions(+), 78 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/81/1244581/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1244581?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Idf631c4c648ff0d835bf07962f5ee7991b5ddd5e
Gerrit-Change-Number: 1244581
Gerrit-PatchSet: 1
Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>
1 month, 1 week
Announce Push of V14.1
by Frank Filz
Branch next
Tag: V14.1
NOTE: This merge includes an ntirpc pullup, pleade update your submodule.
Merge Highlights
* More gRPC commands
* Several build fixes
* ntirpc pullup with bug fixes including to allow RDMA rpcbind registration
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
b895a1c89 Frank S. Filz V14.1
b135397c5 Naresh Chillarege Fixed rpm build issue without cluster qos
enabled.
208a1b582 VidyaThumukunta Grpc: Add export management APIs
3f81c3eed VidyaThumukunta Grpc: Add remaining export statistics APIs
b7e25ed3f Marcus Watts packaging : jumbo fixups for el9,10
9fbcecdf7 Frank S. Filz Pullup ntirpc 14.1
1 month, 1 week