[L] Change in ...nfs-ganesha[next]: Revert "Monitoring: Add scrape-time NFSv4 export and ops metrics upda...
by Name of user not set (GerritHub)
sragraha(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1248355?usp=email )
Change subject: Revert "Monitoring: Add scrape-time NFSv4 export and ops metrics update support"
......................................................................
Revert "Monitoring: Add scrape-time NFSv4 export and ops metrics update support"
This reverts commit 1eb59ba89f84de089f8beb1286a869a1af89ae4f.
Change-Id: I4f70821b93be4a2d64e7d597b46767162a1a7d6b
Signed-off-by: Sreedhar Agraharam <sragraha(a)redhat.com>
---
M src/MainNFSD/libganesha_nfsd.ver
M src/MainNFSD/nfs_metrics.c
M src/MainNFSD/nfs_rpc_dispatcher_thread.c
D src/include/export_metrics_types.h
M src/include/fsal_api.h
M src/include/nfs_core.h
M src/include/nfs_metrics.h
M src/include/server_stats.h
M src/monitoring/dynamic_metrics.cc
M src/monitoring/include/dynamic_metrics.h
M src/monitoring/include/prometheus_exposer.h
M src/monitoring/prometheus_exposer.cc
M src/support/server_stats.c
13 files changed, 204 insertions(+), 451 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/55/1248355/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1248355?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I4f70821b93be4a2d64e7d597b46767162a1a7d6b
Gerrit-Change-Number: 1248355
Gerrit-PatchSet: 1
Gerrit-Owner: sragraha(a)redhat.com
3 weeks, 5 days
[M] Change in ...nfs-ganesha[next]: Fix USE_DBUS=OFF build
by Suhas Athani (GerritHub)
Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1248324?usp=email )
Change subject: Fix USE_DBUS=OFF build
......................................................................
Fix USE_DBUS=OFF build
- Guard mem_stats_status_message() with USE_DBUS in
server_stats.c. It was always compiled but only called from the
D-Bus GetMemoryStatsStatus handler.
- Move client_is_connected() out of the USE_DBUS block in
client_mgr.c. gRPC ShowClients (grpc_show_fill_cb) also needs
it, with D-Bus off that produced build error.
Change-Id: I0634576fb85f3b6b7be7b340a63e08de7ce3d077
Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com>
---
M src/support/client_mgr.c
M src/support/server_stats.c
2 files changed, 39 insertions(+), 39 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/24/1248324/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1248324?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I0634576fb85f3b6b7be7b340a63e08de7ce3d077
Gerrit-Change-Number: 1248324
Gerrit-PatchSet: 1
Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>
3 weeks, 5 days
Announce Push of V15.3
by Frank Filz
Branch next
Tag:V15.3
NOTE: This merge includes an ntirpc pullup, please update your submodule.
Merge Highlights
Thuis merge has a LOT of patches, so this really is a highlights:
* libntirpc pullup to 15.3
* Dynamic config options: Cluster_Members, ntirpc params, EXPORT
Access_Check_Policy params
* gRPC and a few dBUS commands (including some dynamic config)
* Prometheus monitoring updates
* Generic
* A number of bug fixes
* Several build fixes
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
065288862 Frank S. Filz V15.3
61f44bfcf VidyaThumukunta Added ganesha_export_metadata Prometheus metric
78f523c73 Mark Ruvald Pedersen XDR: stop consuming the entry3/entryplus3
discriminator twice
8e7e5af90 Prabhu Murugesan spec: support cmake3 on RHEL 7 and cmake on all
other distros
dd1c97b31 Nishant Puri memstats: fix mem_comp mismatches and add
Mem_Stats_Disable
459a86ed0 marc eshel Fix support for xattr replace option.
adb04ce5c Marc Eshel Increase buffer size to allow for more than 3 FH
dda63ea83 Suhas Athani QoS D-Bus: status replies, client refs, Get packing,
crash fixes
b4bf212b0 Suhas Athani QoS: allow build with ENABLE_QOS and USE_DBUS=OFF
bb957d950 VidyaThumukunta gRPC: add Per_Export_Per_Client QoS admin RPCs
16b75d1d0 Suhas Athani gRPC: add Per_Export QoS admin RPCs
94f89bead VidyaThumukunta gRPC: Fix compilation error when USE_DBUS=OFF &
USE_GRPC=ON
3fb4d269b Oscar Ou Return NFS4ERR_REQ_TOO_BIG when a request exceeds
ca_maxrequestsize
8869663a3 t.hosseini FSAL: add a generic NFSv4.2 READ_PLUS fallback
d2d5beb6a Sreedhar Agraharam Monitoring: Add conditional support for legacy
and new metrics nomenclature.
1eb59ba89 Sreedhar Agraharam Monitoring: Add scrape-time NFSv4 export and
ops metrics update support
ab587eb05 Sreedhar Agraharam Monitoring: Remove Dynamically Declared RPC
Metrics
44ba8ec06 Sreedhar Agraharam Monitoring: Added Export storage utilization
Metrics
0845d2e64 Sreedhar Agraharam Monitoring: Added a new metric to track
NFS-Ganesha service uptime.
78ca678d5 Bjorn Leffler Fix compilation error when build time flag
USE_DBUS=OFF is used
e66499649 Bjorn Leffler Give MY_RTLD_FLAGS a fallback definition
fc3fa931e Bjorn Leffler Pass a struct in6_addr to IN6_IS_ADDR_UNSPECIFIED
b5ebe276a Bjorn Leffler Guard the <sys/sysinfo.h> include with HAVE_PROCPS
7a6c8f3b2 Bjorn Leffler Initialise export_opt_lock statically
f0cfcd233 Mike Borozdin Fix buffer overflow risk in gss_credcache and
centralize gsh_gethostname
940bdd4eb Mike Borozdin support/nfs_ip_name: check caller buffer size
against sizeof(ipstring) and use strlcpy
6329f6222 Mike Borozdin doc: add missing man pages to CMakeLists.txt
57b2e0aed Sachin Punadikar CEPH: Limit number of ceph clients in Ganesha
b6f1e76d1 Sachin Punadikar Support export fencing via Server_Addrs
cd20f69aa Miki Ivry Fix lttng traces in nfs4_op_copy
ed7a7a1d2 Miki Ivry Organize includes
f7525678f Prabhu Murugesan Add activity-based connection tracking for NFSv3
5865fbdc6 Prabhu Murugesan FSAL: Fix STATE/TEMP counter decrement in
close_fsal_fd()
1f00cc2a8 Prabhu Murugesan cmake: build KMIP only with Ceph FSCRYPT support
42e80ae45 Prabhu Murugesan uid2grp: handle MSPAC builds at call site in
principal2grp
ab7dee621 Prabhu Murugesan Remove CLNTALLSTATS check from GetAllClientIOops
07b4b43db Prabhu Murugesan Fix DBus parsing issue: revert conditional
latency field writing
75df392cb Prabhu Murugesan FSAL: Respect xattr support when reporting
supported attributes
d77ce70ca Suhas Athani Add runtime Cluster_Members update via D-Bus and gRPC
d2068a074 Frank S. Filz Config: make several NFS_CORE_PARAM parameters
dynamic
9aceafc19 Frank S. Filz EXPORTS: Make Access_Check_Policy fields dynamically
updateable
451094f04 Frank S. Filz Make several ip_utils functions take log component
as a parameter
23129709a Frank S. Filz Add documentation of memory component parameter
dadaf3f8c Frank S. Filz CEPH: Add better error reporting for create_export
path
b35255004 Frank S. Filz Make more use of noop_conf_init
b1ba1deb9 Frank S. Filz Add some parameters that were missing from
config.txt
87a0d5564 Frank S. Filz clang-format fixup of several files
8cbb42039 Frank S. Filz libntirpc pullup to 15.3
3 weeks, 6 days
[L] Change in ...nfs-ganesha[next]: Add a gRPC metrics service for NFS Ganesha.
by Name of user not set (GerritHub)
inneek(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1248206?usp=email )
Change subject: Add a gRPC metrics service for NFS Ganesha.
......................................................................
Add a gRPC metrics service for NFS Ganesha.
Change-Id: I7e725ecadd0cbfa1ce23b6544ad332cc93378aa4
Signed-off-by: Inna Batenkov <inneek(a)gmail.com>
---
M src/grpc_server/CMakeLists.txt
M src/grpc_server/GrpcServer.cc
M src/grpc_server/GrpcServer.h
A src/grpc_server/nfsMetricsService.cc
A src/grpc_server/nfsMetricsService.h
A src/grpc_server/nfsMetricsService_test.cc
M src/grpc_server/nfsServiceUtil.cc
M src/grpc_server/nfsServiceUtil.h
A src/grpc_server/proto/nfsMetricsService.proto
9 files changed, 450 insertions(+), 31 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/06/1248206/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1248206?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I7e725ecadd0cbfa1ce23b6544ad332cc93378aa4
Gerrit-Change-Number: 1248206
Gerrit-PatchSet: 1
Gerrit-Owner: inneek(a)gmail.com
3 weeks, 6 days
[L] Change in ...nfs-ganesha[next]: QoS D-Bus: status replies, client refs, Get packing, crash fixes
by Suhas Athani (GerritHub)
Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1247836?usp=email )
Change subject: QoS D-Bus: status replies, client refs, Get packing, crash fixes
......................................................................
QoS D-Bus: status replies, client refs, Get packing, crash fixes
Fixes several bugs in the QoS D-Bus methods on /org/ganesha/nfsd/QosMgr
(org.ganesha.nfsd.qos) for Per_Export, Per_Client, and
Per_Export_Per_Client. Failures now return structured status replies
(boolean false + message) instead of generic D-Bus errors or hangs.
Client lookups drop their gsh_client ref. Get replies are packed on
the reply iterator.
Status replies
- CHECK_DBUS_*_OR_return and CHECK_ARG_OR_return now return true
after gsh_dbus_status_reply(). Returning false made
dbus_message_entrypoint() discard the status body and substitute
Error org.ganesha.nfsd.qos: <MethodName>
- Per_Client handlers add missing else branches when qos_class is
NULL so callers get "check config values" instead of a silent
generic error. Handlers return true after cleanup.
Iterator / lock bugs
- GetExportTokens and GetExportDefaultClientBandwidth: call
dbus_message_iter_init_append() before argument validation and
export lookup. It previously ran only on the success path, leaving
the reply iterator uninitialized on invalid export id (hang or
corrupt reply).
- SetExportIOPS: use check_dbus_next_arg() for read_iops and
write_iops. After consuming export_id, check_dbus_arg() re-read
the same slot and never advanced, so SetExportIOPS always failed.
- EnableExportQosBwControl: drop g_qos_config_lock before
qos_perexport_insert(), which takes the same non-recursive mutex.
Holding the lock across that call deadlocked the D-Bus thread.
Config/precondition failures return a status reply and true.
Client lookup refs (put_gsh_client)
lookup_client() takes a ref via get_gsh_client(). QoS D-Bus never
called put_gsh_client(). Per-client Set methods also used
CHECK_DBUS_NEXT_ARG_OR_return after lookup, which returned without
dropping the ref.
Now every successful lookup is paired with put_gsh_client(),
including argument-error paths after lookup (Set methods use
check_dbus_* + goto out instead of the early-return macros).
Aligns with ClientMgr D-Bus.
GetClient reply packing
GetClientBandwidth, GetClientIOPS, and GetClientTokens appended onto
the inbound args iterator. That iterator is read-only; once qos_class
exists (after NFSv4 I/O) libdbus aborted in
dbus_message_iter_append_basic(). Pack those fields on the reply
iterator.
Change-Id: I5b3f0738827aea50a619c9604d75cf6a3c991183
Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com>
---
M src/support/nfs_qosmgr.c
1 file changed, 157 insertions(+), 135 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/36/1247836/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1247836?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I5b3f0738827aea50a619c9604d75cf6a3c991183
Gerrit-Change-Number: 1247836
Gerrit-PatchSet: 1
Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>
4 weeks, 1 day