[NFS-Ganesha-Devel] [S] Change in ...nfs-ganesha[next]: CEPH: Fix crash in ceph_fsal_release

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1217111?usp=email ) Change subject: CEPH: Fix crash in ceph_fsal_release ...................................................................... CEPH: Fix crash in ceph_fsal_release In "ceph_fsal_release", check is being done whether the object handle is export root. To check this op_ctx is required. In shutdown path, op_ctx is not available and hence the crash. With this fix, the check will be carried out only when op_ctx is available. (gdb) bt 0 0x00007fc8db631bd6 in ceph_fsal_release (obj_hdl=0x7fc7dc00ec90) at /usr/src/debug/nfs-ganesha-6.5-18.el9cp.x86_64/src/FSAL/FSAL_CEPH/handle.c:82 1 0x00007fc8de3f4ccf in shutdown_handles (fsal=0x7fc8db63d000 <CephFSM>) at /usr/src/debug/nfs-ganesha-6.5-18.el9cp.x86_64/src/FSAL/fsal_destroyer.c:67 2 destroy_fsals () at /usr/src/debug/nfs-ganesha-6.5-18.el9cp.x86_64/src/FSAL/fsal_destroyer.c:151 3 0x00007fc8de40dd76 in do_shutdown () at /usr/src/debug/nfs-ganesha-6.5-18.el9cp.x86_64/src/MainNFSD/nfs_admin_thread.c:819 4 admin_thread (UnusedArg=<optimized out>) at /usr/src/debug/nfs-ganesha-6.5-18.el9cp.x86_64/src/MainNFSD/nfs_admin_thread.c:843 5 0x00007fc8de21819a in start_thread () from /lib64/libc.so.6 6 0x00007fc8de29d210 in clone3 () from /lib64/libc.so.6 (gdb) f 0 0 0x00007fc8db631bd6 in ceph_fsal_release (obj_hdl=0x7fc7dc00ec90) at /usr/src/debug/nfs-ganesha-6.5-18.el9cp.x86_64/src/FSAL/FSAL_CEPH/handle.c:82 82 container_of(op_ctx->fsal_export, struct ceph_export, export); (gdb) p op_ctx $2 = (struct req_op_context *) 0x0 Change-Id: I07d9042b767e46d050d7ac87ae894b58c325b645 Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com&gt; --- M src/FSAL/FSAL_CEPH/handle.c 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/11/1217111/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1217111?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I07d9042b767e46d050d7ac87ae894b58c325b645 Gerrit-Change-Number: 1217111 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com&gt;