Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/505172 ) Change subject: readdir: Lock only after confirming dir and parms ...................................................................... readdir: Lock only after confirming dir and parms Before this patch, nfs4_readdir_callback locked the junction lock before checking if the object was a directory or not. Now nfs4_readdir_callback only locks before checking the object, but after confirming other things that don't require a lock. Fixes crash that occurs on macOS when running st_readdir.testFirst from pynfs, because it prevents access of the lock in the wrong side of the lock union in state_hdl. Change-Id: I0e2a87c1d81e458c1da8601afef190bed896d78f Signed-off-by: Matthew DeVore <matvore(a)google.com&gt; --- M src/Protocols/NFS/nfs4_op_readdir.c 1 file changed, 10 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/72/505172/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/505172 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0e2a87c1d81e458c1da8601afef190bed896d78f Gerrit-Change-Number: 505172 Gerrit-PatchSet: 1 Gerrit-Owner: Matthew DeVore <matvore(a)google.com&gt; Gerrit-MessageType: newchange