deeraj.patil(a)ibm.com has uploaded this change for review. (
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1232498?usp=email )
Change subject: close_fsal_fd: remove GLOBAL_FD on close from lru list.
......................................................................
close_fsal_fd: remove GLOBAL_FD on close from lru list.
The previous logic skipped remove_fd_lru when ERR_FSAL_NOT_OPENED was
returned (FD already logically closed).
When doing release(), which internally calls the close_fsal_fd on FD already
in closed state, this FD doesn't get removed from global_lru_list and is freed.
This dangling entry is pickedup by the reaper thread causing unintented
behaviour (Use-after-free).
Change-Id: I14dc304c2126ff991b223c841ffd22a1a7ba953d
Signed-off-by: Deeraj.Patil <Deeraj.Patil(a)ibm.com>
---
M src/FSAL/commonlib.c
1 file changed, 18 insertions(+), 10 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/98/1232498/1
--
To view, visit
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1232498?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I14dc304c2126ff991b223c841ffd22a1a7ba953d
Gerrit-Change-Number: 1232498
Gerrit-PatchSet: 1
Gerrit-Owner: deeraj.patil(a)ibm.com