Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1217676?usp=email to review the following change. Change subject: uid2grp: Correctly handle getgrouplist() return value. ...................................................................... uid2grp: Correctly handle getgrouplist() return value. The POSIX getgrouplist() function returns 0 on success and an error value on failure, not -1 on failure as it's commonly assumed. This change fixes the check for errors after calls to getgrouplist(), and logs the returned error code to assist with debugging. Change-Id: I4a9bb0ad9bd27a08c50383f255851aa40cf611d5 Signed-off-by: Lior Suliman <liorsu(a)gmail.com&gt; --- M src/support/uid2grp.c 1 file changed, 11 insertions(+), 11 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/76/1217676/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1217676?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4a9bb0ad9bd27a08c50383f255851aa40cf611d5 Gerrit-Change-Number: 1217676 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com&gt; Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com&gt; Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com&gt;