November 2021 - Devel - NFS Ganesha List Archives

mount subdirectories under an export dir with acls and root_squash is enabled
by Chakra Divi 11 Nov '21

11 Nov '21

Hi Team, I'm trying to mount a sub-directory under an export dir which is throwing permission denied when root squash is enabled even though it has root permissions. I have added acls on the export directory - which is sending an fsal_access call to my fsal layer with anonymous_uid so getting permission denied from my layer. I'm using ganesha v3-stable version. Am i missing anything ? Do i need make any change to allow mount only operation to use uids instead of anon uids Regards, Chakra

3 4

Change in ...nfs-ganesha[next]: ganesha-rados-grace: use int type for getopt retval
by Michael Fritch (GerritHub) 11 Nov '21

11 Nov '21

Michael Fritch has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/527221 ) Change subject: ganesha-rados-grace: use int type for getopt retval ...................................................................... ganesha-rados-grace: use int type for getopt retval the implicit conversion of a -1 retval from getopt is interpreted as a value of 255 on an aarch64 platform, which then causes the default case of the switch statement to always print a usage message and exit. Signed-off-by: Michael Fritch <mfritch(a)suse.com> Change-Id: I21caf0c4882d3c9b821836c000c1645287b9ba5c --- M src/tools/ganesha-rados-grace.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/21/527221/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/527221 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I21caf0c4882d3c9b821836c000c1645287b9ba5c Gerrit-Change-Number: 527221 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Fritch <mfritch(a)suse.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Some additional INFO messages about socket binding
by Frank Filz (GerritHub) 11 Nov '21

11 Nov '21

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/527216 ) Change subject: Some additional INFO messages about socket binding ...................................................................... Some additional INFO messages about socket binding Change-Id: I8f2fc6a66a593440b24ddc0a8e093f209a4e1ded Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/MainNFSD/nfs_rpc_dispatcher_thread.c 1 file changed, 76 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/16/527216/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/527216 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8f2fc6a66a593440b24ddc0a8e093f209a4e1ded Gerrit-Change-Number: 527216 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Use sockaddr_t everywhere in Ganesha for ease of code reading
by Frank Filz (GerritHub) 11 Nov '21

11 Nov '21

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/527215 ) Change subject: Use sockaddr_t everywhere in Ganesha for ease of code reading ...................................................................... Use sockaddr_t everywhere in Ganesha for ease of code reading Change-Id: I060d5804831109cbc061f3a01679bc17825970de Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PROXY_V3/rpc.c M src/MainNFSD/nfs_rpc_callback.c M src/Protocols/9P/9p_lock.c M src/Protocols/NFS/nfs4_op_exchange_id.c M src/SAL/9p_owner.c M src/SAL/nlm_owner.c M src/include/9p.h M src/include/gsh_config.h M src/include/nfs_proto_data.h M src/include/sal_data.h M src/include/sal_functions.h 11 files changed, 14 insertions(+), 17 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/527215/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/527215 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I060d5804831109cbc061f3a01679bc17825970de Gerrit-Change-Number: 527215 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Fix incorrect format specifier in LogCrit
by Matthew DeVore (GerritHub) 09 Nov '21

09 Nov '21

Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/527066 ) Change subject: Fix incorrect format specifier in LogCrit ...................................................................... Fix incorrect format specifier in LogCrit In the process of trying to build FSAL_PROXY_V3 with Clang, I ran into a compiler error about an incorrect format specifier. In the process of passing uint16_t types through the tertiary operator, they are converted to a 32-bit type. For demonstration, the output of this is 4: int main(int argc, char **argv) { uint16_t x,y; printf("%zu\n", sizeof(rand() % 1 ? x : y)); } In practice this does not cause problems once compiled, since integer types are promoted to at least int size when passed to varargs, but the use of PRIu16 is a little awkward anyway, so it's worth changing. This could be solved by casting the tertiary operator to uint16_t, but I switched to the 'unsigned' type for readability. Change-Id: Ibe59e7e4025a7ccd9a944b487f484e2438273d3f Signed-off-by: Matthew DeVore <matvore(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/rpc.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/66/527066/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/527066 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ibe59e7e4025a7ccd9a944b487f484e2438273d3f Gerrit-Change-Number: 527066 Gerrit-PatchSet: 1 Gerrit-Owner: Matthew DeVore <me(a)matvore.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Pullup ntirpc 4.0rc1 and fix resulting failures
by Daniel Gryniewicz (GerritHub) 09 Nov '21

09 Nov '21

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/527048 ) Change subject: Pullup ntirpc 4.0rc1 and fix resulting failures ...................................................................... Pullup ntirpc 4.0rc1 and fix resulting failures Ntirpc had a prototype for xdrproc_t that was a vararg function, but it was casting non-vararg functions to that prototype. This is undefined behavior, but works on x86_64 with gcc. It fails on other combinations however, so it was changed to a prototype with actual arguments. This necessitates changes in PROXY_V3, which uses that prototype. Change-Id: I68200a1af214b86003b2716c8b3972afa08daa43 Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V3/proxyv3_fsal_methods.h M src/FSAL/FSAL_PROXY_V3/rpc.c M src/libntirpc 4 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/48/527048/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/527048 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I68200a1af214b86003b2716c8b3972afa08daa43 Gerrit-Change-Number: 527048 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

1 0

weekly community call and V4-rc series, open issues, and unmerged patches
by Frank Filz 08 Nov '21

08 Nov '21

First off, warning to all who do not follow US practices for Daylight Savings Time - because of the ending of Daylight Savings Time, our meeting time has shifted one hour later with respect to UTC. It remains at 7:00 AM Pacific Time (now Pacific Standard Time). It seems like activity on V4-rc is slowing down. As a topic for tomorrow's call, I would like to review the outstanding patches and issues with an eye to which ones are worth getting into V4.0 and possibly bringing the rc process to an end in the next week or two. If you do not attend these calls, but have an interest in anything, please respond and let us know. Thanks Frank Filz

1 0

Change in ...nfs-ganesha[next]: Use non-shadowed initialized variable
by Matthew DeVore (GerritHub) 08 Nov '21

08 Nov '21

Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526978 ) Change subject: Use non-shadowed initialized variable ...................................................................... Use non-shadowed initialized variable Probably introduced in 9fb03f1ecf2e8b95a1ebf2178a2eb719a467407d. I have not tested it before or after this fix, but the code is apparently wrong--in the exports loop, the glist_entry (container_of) invocation reads the uninitialized glist in the loop's scope, which shadows the glist declared at function scope. Signed-off-by: Matthew DeVore <matvore(a)google.com> Change-Id: Ic26d17f5cbe00aca4916d0607992f70f9a8c9ed7 --- M src/FSAL/localfs.c 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/78/526978/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526978 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic26d17f5cbe00aca4916d0607992f70f9a8c9ed7 Gerrit-Change-Number: 526978 Gerrit-PatchSet: 1 Gerrit-Owner: Matthew DeVore <me(a)matvore.com> Gerrit-MessageType: newchange

1 0

Announce Push of V4-rc3
by Frank Filz 05 Nov '21

05 Nov '21

Branch next Tag:V4-rc3 Ganesha V4.0 is in sight! Merge Highlights * Keep pidfile locked while running Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: a4969e3d6 Frank S. Filz V4-rc3 ba923ef21 Olivier Garaud Keep pidfile locked while running

1 0