November 2021 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Allow EXPORT pseudo path to be changed during export update
by Frank Filz (GerritHub) 20 Feb '24

20 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 ) Change subject: Allow EXPORT pseudo path to be changed during export update ...................................................................... Allow EXPORT pseudo path to be changed during export update This also fully allows adding or removing NFSv4 support from an export since we can now handle the PseudoFS swizzing that occurs. Note that an explicit PseudoFS export may be removed or added, though you can not change it from export_id 0 because we currently don't allow changing the export_id. Note that this patch doesn't handle DBUS add or remove export though that is an option to improve. I may add them to this patch (it wouldn't be that hard) but I want to get this reviewed as is right now. There are implications to a client of changing the PseudoFS. I have tested moving an export in the PseudoFS with a client mounted. The client will be able to continue accessing the export, though it may see an ESTALE error if it navigates out of the export. The current working directory will go bad and the pwd comment will fail indicating a disconnected mount. I have also seen referencing .. from the root of the export wrapping around back to the root (I believe this is how disconnected mounts are set up). FSAL_PSEUDO lookups and create handles (PUTFH or any use of an NFSv3 handle where the inode isn't cached) which fail during an export update are instead turned into ERR_FSAL_DELAY which turns into NFS4ERR_DELAY or NFS3ERR_JUKEBOX to force the client to retry under the completed update. Change-Id: I507dc17a651936936de82303ff1291677ce136be Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PSEUDO/handle.c M src/MainNFSD/libganesha_nfsd.ver M src/Protocols/NFS/nfs4_pseudo.c M src/include/export_mgr.h M src/include/nfs_proto_functions.h M src/support/export_mgr.c M src/support/exports.c 7 files changed, 560 insertions(+), 203 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/490334/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I507dc17a651936936de82303ff1291677ce136be Gerrit-Change-Number: 490334 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 2

Change in ...nfs-ganesha[next]: Set major fsid correctly for NFSv3.
by Bjorn Leffler (GerritHub) 29 Nov '21

29 Nov '21

Bjorn Leffler has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/528422 ) Change subject: Set major fsid correctly for NFSv3. ...................................................................... Set major fsid correctly for NFSv3. Signed-off-by: Bjorn Leffler <leffler(a)google.com> Change-Id: Id588fa4838691fc7bd6f502744567390eb07e93f --- M src/Protocols/XDR/xdr_nfs23.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/22/528422/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/528422 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id588fa4838691fc7bd6f502744567390eb07e93f Gerrit-Change-Number: 528422 Gerrit-PatchSet: 1 Gerrit-Owner: Bjorn Leffler <leffler(a)google.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Make client/export related dbus command more clarify
by vicente (GerritHub) 29 Nov '21

29 Nov '21

vicente has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/528399 ) Change subject: Make client/export related dbus command more clarify ...................................................................... Make client/export related dbus command more clarify - Old format and specific macro would make user hard to know that the relationship between number 0/1 (boolean) and protocols. Add the protocol string would help user to know the protocol stats easy. - Also refine some python code for latest format Change-Id: I3186005fd9d2b4e310c88febbcae8553c05c65de Signed-off-by: Vicente Cheng <vicente_cheng(a)bigtera.com> --- M src/include/server_stats_private.h M src/scripts/ganeshactl/Ganesha/glib_dbus_stats.py M src/support/client_mgr.c M src/support/export_mgr.c M src/support/server_stats.c 5 files changed, 216 insertions(+), 95 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/99/528399/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/528399 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3186005fd9d2b4e310c88febbcae8553c05c65de Gerrit-Change-Number: 528399 Gerrit-PatchSet: 1 Gerrit-Owner: vicente <freeze.bilsted(a)gmail.com> Gerrit-MessageType: newchange

1 0

Compiling ntirpc and Ganesha with clang: container_of macros?
by Bjorn Leffler 25 Nov '21

25 Nov '21

I have compiled ntirpc, NFS Ganesha and all dependencies with clang. When I try to run the code, I get a SIGILL signal triggered from the "opr_containerof" macro in ntirpc/ntirpc/misc/opr.h. I'd like to fix this. My preferred option would be to unify the ntirpc "opr_containerof" and Ganesha "container_of" macros into a single "container_of" macro. A macro that's defined once (in ntirpc) and that compiles and runs with both gcc and clang. I've got a few questions around all this. First of all, does this sound like a good idea? I could simply update the opr_containerof macro, so that it also works with clang. What does OPR mean? Is the "opr_containerof" macro used anywhere else but Ganesha? Thanks, Bjorn

2 3

Change in ...nfs-ganesha[next]: Add functions to convert NFS v3 proc and v4 op codes into human reada...
by Bjorn Leffler (GerritHub) 25 Nov '21

25 Nov '21

Bjorn Leffler has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/528111 ) Change subject: Add functions to convert NFS v3 proc and v4 op codes into human readable names. ...................................................................... Add functions to convert NFS v3 proc and v4 op codes into human readable names. Change NFSv3 naming from op to proc for consistency. Signed-off-by: Bjorn Leffler <leffler(a)google.com> Change-Id: Id17c34a970ff9d3aef9b16513322edc31155beaa --- M src/MainNFSD/libganesha_nfsd.ver M src/Protocols/NFS/nfs4_Compound.c M src/include/nfs_convert.h M src/support/nfs_convert.c M src/support/server_stats.c 5 files changed, 187 insertions(+), 226 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/11/528111/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/528111 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id17c34a970ff9d3aef9b16513322edc31155beaa Gerrit-Change-Number: 528111 Gerrit-PatchSet: 1 Gerrit-Owner: Bjorn Leffler <leffler(a)google.com> Gerrit-MessageType: newchange

1 0

First Pass at V4.0 release notes
by Frank Filz 24 Nov '21

24 Nov '21

https://github.com/nfs-ganesha/nfs-ganesha/wiki/ReleaseNotes_4 Please have a look and either respond here with comments or simply edit. Thanks Frank

1 0

Prohibit NFS4.1 mount
by Tuan Viet Nguyen 24 Nov '21

24 Nov '21

Hello, Our FSAL does not support NFS4.1 yet and I'd like to refuse to mount for 4.1 version. I'm exploring 2 following options: 1/ A way to tell ganesha that we don't have export for 4.1 at init 2/ Return NOTSUPPORTED for one of the NFS message during mount stage (like PUTFH, GETATTR, etc). But related function in the fsal level do not have input param containing the minorversion. Can anyone give me a hint? Thank you

2 4

Monitoring in Ganesha?
by Bjorn Leffler 22 Nov '21

22 Nov '21

Apart from the counters that you can access through dbus, is there any other monitoring built into Ganesha? I'm thinking of adding it with this higher level plan: - Exporting metrics from Ganesha to Prometheus. - Aggregate data in Prometheus. - Display monitoring consoles and graphs with Grafana. - Package up Prometheus, Grafana and the preconfigured rules/dashboards as a Docker image. - This makes it straightforward to deploy monitoring alongside a Gansha binary. My rough coding plan for the code is to: - Add a USE_MONITORING directive to the CMakeLists.txt files. - Add a build dependency to the Prometheus C client <https://github.com/digitalocean/prometheus-client-c>. - Create a src/monitoring directory for the new source files and templates. - Increment counters and timers throughout the code. - Use histograms to compute latency percentiles, heatmaps, etc. Is this a good idea? Any objections or suggestions? Thanks, Bjorn

3 6

Change in ...nfs-ganesha[next]: Initial checkin of NFS Ganesha Monitoring stack.
by Bjorn Leffler (GerritHub) 22 Nov '21

22 Nov '21

Bjorn Leffler has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/527854 ) Change subject: Initial checkin of NFS Ganesha Monitoring stack. ...................................................................... Initial checkin of NFS Ganesha Monitoring stack. Signed-off-by: Bjorn Leffler <leffler(a)google.com> Change-Id: I7bc632837ad2dc44cb29d5daa3f098ca0f7bae9e --- M src/CMakeLists.txt M src/MainNFSD/CMakeLists.txt M src/MainNFSD/nfs_main.c M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/include/gsh_config.h M src/include/log.h A src/include/monitoring.h M src/libntirpc M src/log/log_functions.c A src/monitoring/CMakeLists.txt A src/monitoring/monitoring.cc A src/monitoring/nfs_names.c A src/monitoring/nfs_names.h M src/support/fridgethr.c M src/support/nfs_read_conf.c M src/support/server_stats.c 16 files changed, 1,162 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/54/527854/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/527854 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7bc632837ad2dc44cb29d5daa3f098ca0f7bae9e Gerrit-Change-Number: 527854 Gerrit-PatchSet: 1 Gerrit-Owner: Bjorn Leffler <leffler(a)google.com> Gerrit-MessageType: newchange

1 0

Announce Push of V4-rc4
by Frank Filz 15 Nov '21

15 Nov '21

Branch next Tag:V4-rc4 NOTE: This merge includes an ntirpc pull up. Please update your submodule Ganesha V4.0 is in sight! Merge Highlights * A variety of type cleanups * Additional LogInfo about socket binding * xdrproc_t type cleanup with ntirpc pullup Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: d22946080 Frank S. Filz V4-rc4 1ce9d1420 Daniel Gryniewicz Pullup ntirpc 4.0rc1 and fix resulting failures 950b8fac6 Matthew DeVore Fix incorrect format specifier in LogCrit fa1b06829 Matthew DeVore Use non-shadowed initialized variable 324f76466 Frank S. Filz Some additional INFO messages about socket binding 48cce27b1 Frank S. Filz Use sockaddr_t everywhere in Ganesha for ease of code reading 3db6bc0cb Michael Fritch ganesha-rados-grace: use int type for getopt retval

1 0