November 2022 - Devel - NFS Ganesha List Archives

Announce Push of V4.0.12
by Frank Filz 04 Nov '22

04 Nov '22

Branch next Tag:V4.0.12 Merge Highlights * More fixes of Coverity issues * NFS: Add a config to limit the number of entries returned in readdir * FSAL_PROXY_V3: Support POSIX attributes instead of ATTRS_NFS3 * SETATTR: FSALs were asking for FSAL_O_RDWR when truncating with a stateid * Improve documentation of code submission process * Other minor changes Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: b08457543 Frank S. Filz V4.0.12 6ac713c6c Frank S. Filz NFS: Add a config to limit the number of entries returned in readdir c529eaa4f Kaleb S. KEITHLEY Add pull_request_template.md with instructions to submit patches to gerrithub instead 742252583 Paul Moyer fixed coverity issue 275287 (dead code) by ifdefing out the unused code c2d2aafb4 Paul Moyer fixed coverity complaints 132619, 132621, 132623, 313012 - rtc 867 ba2167bb3 Vicente Cheng doc: Add more description about Dir_Chunk 89f726750 Shahar Hochma libganesha_nfsd.ver: Export symbol convert_ipv6_to_ipv4 9aec8e76d Assaf Yaari FSAL_PROXY_V3: Support POSIX attributes instead of ATTRS_NFS3 e7efb5ee8 Frank S. Filz Update README.md to include contributing and building references. d571bd00f Frank S. Filz FSAL_MEM: fix comment typo d5d822322 Frank S. Filz SETATTR: FSALs were asking for FSAL_O_RDWR when truncating with a stateid 8bc76270d Frank S. Filz CID 356091 - fully set status in nfs_readdir_dot_entry 1abd8d2c7 Frank S. Filz CID 361408 - ignore return from display_cat()

1 0

[S] Change in ...nfs-ganesha[next]: Update README.md to include contributing and building references.
by Frank Filz (GerritHub) 04 Nov '22

04 Nov '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545750 ) Change subject: Update README.md to include contributing and building references. ...................................................................... Update README.md to include contributing and building references. Change-Id: I174ee86c2c25228a0fa47748efddbf2725cc5a8b Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M README.md 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/50/545750/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545750 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I174ee86c2c25228a0fa47748efddbf2725cc5a8b Gerrit-Change-Number: 545750 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: Add pull_request_template.md with instructions to submit patches to g...
by Kaleb KEITHLEY (GerritHub) 04 Nov '22

04 Nov '22

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545749 ) Change subject: Add pull_request_template.md with instructions to submit patches to gerrithub instead ...................................................................... Add pull_request_template.md with instructions to submit patches to gerrithub instead Change-Id: Ibcb7b2789314542f7a933c098248dfe2ecf92680 Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> --- A .github/pull_request_template.md 1 file changed, 37 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/545749/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545749 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ibcb7b2789314542f7a933c098248dfe2ecf92680 Gerrit-Change-Number: 545749 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: FSAL_MEM: fix comment typo
by Frank Filz (GerritHub) 04 Nov '22

04 Nov '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545747 ) Change subject: FSAL_MEM: fix comment typo ...................................................................... FSAL_MEM: fix comment typo Change-Id: I5a75285ef9172a2c03848628a72c2df9748cead6 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_MEM/mem_handle.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/47/545747/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545747 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5a75285ef9172a2c03848628a72c2df9748cead6 Gerrit-Change-Number: 545747 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Re: [S] Change in ...nfs-ganesha[next]: fixed coverity issue 275287 (dead code) by ifdefing out the unused code
by Frank Filz 04 Nov '22

04 Nov '22

I’m going to cc: the devel mailing list for more opinions This code looks (mostly) safe to me. The concern I have is that it isn’t using gsh_malloc and gsh_free yet I assume that the buffer when freed later is freed with gsh_free. Frank From: Paul Moyer [mailto:Paul.Moyer@ibm.com] Sent: Friday, November 4, 2022 7:55 AM To: Frank Filz <ffilzlnx(a)mindspring.com> Subject: RE: [S] Change in ...nfs-ganesha[next]: fixed coverity issue 275287 (dead code) by ifdefing out the unused code After looking at this closer I don’t think it is a problem: In function ‘xdr_utf8string_decode’, inlined from ‘inline_xdr_utf8string’ at /home/moyer/275287/nfs-ganesha/src/include/nfsv41.h:4055:3, inlined from ‘decode_acl’ at /home/moyer/275287/nfs-ganesha/src/Protocols/NFS/nfs_proto_tools.c:834:29: /home/moyer/275287/nfs-ganesha/src/include/nfsv41.h:4041:8: warning: attempt to free a non-heap object ‘buffer’ [-Wfree-nonheap-object] free(sp); ^ looking at the code (snipets) 3991 static inline bool 3992 xdr_utf8string_decode(XDR *xdrs, utf8string *objp, u_int maxsize) 3993 { 3994 /* sp is the actual string pointer */ 3995 char *sp = objp->utf8string_val; 4026 if (!sp) { 4027 sp = (char *)malloc(size + 1); 4036 ret = xdr_opaque_decode(xdrs, sp, size); 4038 if (!ret) { 4039 if (!objp->utf8string_val) { 4040 /* Only free if we allocated */ 4041 free(sp); 4042 } 4043 return ret; 4044 } 4045 4046 objp->utf8string_val = sp; /* only valid po inter */ so the flow seems to be: sp is a pointer assigned to a string inside obj which is passed as a parameter if sp is null, malloc is called and sp now points to “locally” allocated space if an error occurs in xdr_opaque_decode(), enter the error path starting at 4038 if the string (in the passed object) that sp was originally assigned to is null, sp is free'd therefore, sp is only malloc'ed if the original string is null, and if the original string is null, sp is free'd which is consistent with the comment on 4040, though the logic took some study ... the pointer in the passed object is subsequently replaced with sp: if the pointer was not null to begin with, sp would already point to the same string if the pointer was null, memory would be allocated and the passed object would be updated with a pointer to the “locally” allocated memory i think this works because this method is declared as "static inline", so the allocated memory is ultimately local to the caller anyway ? Let me know what you think. From: Frank Filz <ffilzlnx(a)mindspring.com <mailto:ffilzlnx@mindspring.com> > Sent: Thursday, November 3, 2022 3:07 PM To: Paul Moyer <Paul.Moyer(a)ibm.com <mailto:Paul.Moyer@ibm.com> > Subject: [EXTERNAL] RE: [S] Change in ...nfs-ganesha[next]: fixed coverity issue 275287 (dead code) by ifdefing out the unused code Hmm, I’ve never seen that warning. And I didn’t realize we had code that did malloc/free… We should investigate that more closely. Frank From: Paul Moyer [mailto: Paul. Moyer@ ibm. com] ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ZjQcmQRYFpfptBannerStart This Message Is From an External Sender This message came from outside your organization. ZjQcmQRYFpfptBannerEnd Hmm, I’ve never seen that warning. And I didn’t realize we had code that did malloc/free… We should investigate that more closely. Frank From: Paul Moyer [mailto:Paul.Moyer@ibm.com] Sent: Thursday, November 3, 2022 11:19 AM To: ffilzlnx(a)mindspring.com <mailto:ffilzlnx@mindspring.com> Subject: RE: [S] Change in ...nfs-ganesha[next]: fixed coverity issue 275287 (dead code) by ifdefing out the unused code Sorry for the email, but I have yet to figure out IRC. While building the fix for 275287 I happened to notice a compiler warning: [ 43%] Building C object Protocols/NFS/CMakeFiles/nfsproto.dir/nfs_proto_tools.c.o In file included from /home/moyer/275287/nfs-ganesha/src/include/fsal_types.h:44:0, from /home/moyer/275287/nfs-ganesha/src/include/fsal_api.h:45, from /home/moyer/275287/nfs-ganesha/src/include/fsal.h:63, from /home/moyer/275287/nfs-ganesha/src/Protocols/NFS/nfs_proto_tools.c:35: In function ‘xdr_utf8string_decode’, inlined from ‘inline_xdr_utf8string’ at /home/moyer/275287/nfs-ganesha/src/include/nfsv41.h:4055:3, inlined from ‘decode_acl’ at /home/moyer/275287/nfs-ganesha/src/Protocols/NFS/nfs_proto_tools.c:834:29: /home/moyer/275287/nfs-ganesha/src/include/nfsv41.h:4041:8: warning: attempt to free a non-heap object ‘buffer’ [-Wfree-nonheap-object] free(sp); ^ There is even a comment in the code 4040 /* Only free if we allocated */ 4041 free(sp); Which makes me think someone else may have seen this before but decided not to fix it. Anyway, should I fix this warning with 275287 ? From: Frank Filz (GerritHub) <gerrit(a)gerrithub.io <mailto:gerrit@gerrithub.io> > Sent: Thursday, November 3, 2022 1:29 PM To: Paul Moyer <Paul.Moyer(a)ibm.com <mailto:Paul.Moyer@ibm.com> > Cc: Daniel Gryniewicz <dang(a)redhat.com <mailto:dang@redhat.com> >; yogendra858(a)yahoo.com <mailto:yogendra858@yahoo.com> ; alokchandra.mallick(a)gmail.com <mailto:alokchandra.mallick@gmail.com> ; Gluster Community Jenkins <gerrithub(a)gluster.org <mailto:gerrithub@gluster.org> > Subject: [EXTERNAL] [S] Change in ...nfs-ganesha[next]: fixed coverity issue 275287 (dead code) by ifdefing out the unused code Attention is currently required from: Daniel Gryniewicz, yogendra858@ yahoo. com, alokchandra. mallick@ gmail. com, Paul Moyer. Patch set 1: Code-Review -1 View Change 1 comment: File src/SAL/recovery/recovery_fs_ng. c: Patch Set #1, Line 371: ‍ ‍ ‍ ZjQcmQRYFpfptBannerStart This Message Is From an External Sender This message came from outside your organization. ZjQcmQRYFpfptBannerEnd Attention is currently required from: Daniel Gryniewicz, yogendra858(a)yahoo.com <mailto:yogendra858@yahoo.com> , alokchandra.mallick(a)gmail.com <mailto:alokchandra.mallick@gmail.com> , Paul Moyer. Patch set 1:Code-Review -1 View Change <https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545670> 1 comment: * File src/SAL/recovery/recovery_fs_ng.c: * Patch Set #1, Line 371: <https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545670/comment/4e74c97b_4…> { oops, need to ifdef out rc... To view, visit change 545670 <https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545670> . To unsubscribe, or for help writing mail filters, visit settings <https://review.gerrithub.io/settings> . Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1fa6854136986774cc8f9cb87371f5709cbef935 Gerrit-Change-Number: 545670 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Moyer <paul.moyer(a)ibm.com <mailto:paul.moyer@ibm.com> > Gerrit-Reviewer: Daniel Gryniewicz <dang(a)redhat.com <mailto:dang@redhat.com> > Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com <mailto:ffilzlnx@mindspring.com> > Gerrit-Reviewer: Gluster Community Jenkins <gerrithub(a)gluster.org <mailto:gerrithub@gluster.org> > Gerrit-Reviewer: alokchandra.mallick(a)gmail.com <mailto:alokchandra.mallick@gmail.com> Gerrit-Reviewer: yogendra858(a)yahoo.com <mailto:yogendra858@yahoo.com> Gerrit-Attention: Daniel Gryniewicz <dang(a)redhat.com <mailto:dang@redhat.com> > Gerrit-Attention: yogendra858(a)yahoo.com <mailto:yogendra858@yahoo.com> Gerrit-Attention: alokchandra.mallick(a)gmail.com <mailto:alokchandra.mallick@gmail.com> Gerrit-Attention: Paul Moyer <paul.moyer(a)ibm.com <mailto:paul.moyer@ibm.com> > Gerrit-Comment-Date: Thu, 03 Nov 2022 17:29:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...nfs-ganesha[next]: fixed coverity issue 275287 (dead code) by ifdefing out the unused code
by Paul Moyer (GerritHub) 03 Nov '22

03 Nov '22

Paul Moyer has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545670 ) Change subject: fixed coverity issue 275287 (dead code) by ifdefing out the unused code ...................................................................... fixed coverity issue 275287 (dead code) by ifdefing out the unused code Change-Id: I1fa6854136986774cc8f9cb87371f5709cbef935 Signed-off-by: Paul Moyer <paul.moyer(a)ibm.com> --- M src/SAL/recovery/recovery_fs_ng.c 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/70/545670/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545670 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1fa6854136986774cc8f9cb87371f5709cbef935 Gerrit-Change-Number: 545670 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Moyer <paul.moyer(a)ibm.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: SETATTR: FSALs were asking for FSAL_O_RDWR when truncating with a sta...
by Frank Filz (GerritHub) 02 Nov '22

02 Nov '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545617 ) Change subject: SETATTR: FSALs were asking for FSAL_O_RDWR when truncating with a stateid ...................................................................... SETATTR: FSALs were asking for FSAL_O_RDWR when truncating with a stateid We only need FSAL_O_WRITE when we have a stateid. Failing this, we opened the global fd and that then prevented local fs execution of a binary that had been copied. Change-Id: Ic476ddf529ba0c45c4d83a4150b4181166a3330a Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_GLUSTER/handle.c M src/FSAL/FSAL_LIZARDFS/handle.c M src/FSAL/FSAL_RGW/handle.c M src/FSAL/FSAL_VFS/file.c 5 files changed, 20 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/17/545617/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545617 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic476ddf529ba0c45c4d83a4150b4181166a3330a Gerrit-Change-Number: 545617 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: CID 356091 - fully set status in nfs_readdir_dot_entry
by Frank Filz (GerritHub) 02 Nov '22

02 Nov '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545616 ) Change subject: CID 356091 - fully set status in nfs_readdir_dot_entry ...................................................................... CID 356091 - fully set status in nfs_readdir_dot_entry Change-Id: Ie03ca7b1c11f2085f9e9d54dd17085104e9a96f2 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NFS/nfs3_readdir.c M src/SAL/nfs41_session_id.c 2 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/16/545616/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545616 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie03ca7b1c11f2085f9e9d54dd17085104e9a96f2 Gerrit-Change-Number: 545616 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: CID 361408 - ignore return from display_cat()
by Frank Filz (GerritHub) 02 Nov '22

02 Nov '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545615 ) Change subject: CID 361408 - ignore return from display_cat() ...................................................................... CID 361408 - ignore return from display_cat() Just appending 2 characters, don't worry about return. Change-Id: I49237faf997d533e4a2732ae92b1480836c61692 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/SAL/nfs41_session_id.c 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/545615/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545615 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I49237faf997d533e4a2732ae92b1480836c61692 Gerrit-Change-Number: 545615 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: fixed coverity complaints 132619, 132621, 132623, 313012 - rtc 867
by Paul Moyer (GerritHub) 01 Nov '22

01 Nov '22

Paul Moyer has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545549 ) Change subject: fixed coverity complaints 132619, 132621, 132623, 313012 - rtc 867 ...................................................................... fixed coverity complaints 132619, 132621, 132623, 313012 - rtc 867 Change-Id: I23e6013c2d867143945c7e0e9b652948b0517ac7 Signed-off-by: Paul Moyer <paul.moyer(a)ibm.com> --- M src/Protocols/NFS/nfs_proto_tools.c M src/Protocols/XDR/xdr_nfsacl.c 2 files changed, 20 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/545549/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545549 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I23e6013c2d867143945c7e0e9b652948b0517ac7 Gerrit-Change-Number: 545549 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Moyer <paul.moyer(a)ibm.com> Gerrit-MessageType: newchange

1 0