June 2023 - Devel - NFS Ganesha List Archives

[M] Change in ...nfs-ganesha[next]: Fix possible race when populating pseudo fs
by Name of user not set (GerritHub) 22 Jun '23

22 Jun '23

shaharhoch(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555950?usp=email ) Change subject: Fix possible race when populating pseudo fs ...................................................................... Fix possible race when populating pseudo fs When we create entires in the pseudo fs we create the entry by calling PSEUDO FSAL mkdir. This creates the entrie, but doesn't populate the export junction in the handle. Once we get the handle, we populate the junction, but there could be a race where get get a lookup request for that entry after the mkdir, but before the junction export is updated. We fix this by not returning an entry in the PSEUDO FSAL lookyp while an export update is in progress and the export junction of the handle is NULL. In addition, in order to make sure the handle is fully updated when it is returned, we populate the export junction after every thing else the handle points to is updated. Change-Id: I7e1dd78bbb1945b3c1ea29d051f42836ec6940e5 Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/FSAL/FSAL_PSEUDO/handle.c M src/Protocols/NFS/nfs4_pseudo.c 2 files changed, 55 insertions(+), 17 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/50/555950/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555950?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7e1dd78bbb1945b3c1ea29d051f42836ec6940e5 Gerrit-Change-Number: 555950 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)gmail.com Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: multilock: Fixed format strings to print unsigned long long
by Lior Suliman (GerritHub) 22 Jun '23

22 Jun '23

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555943?usp=email to review the following change. Change subject: multilock: Fixed format strings to print unsigned long long ...................................................................... multilock: Fixed format strings to print unsigned long long Change-Id: Icf4bddccc8d1aafed6a445056fa0f3a72639837e Signed-off-by: Lior Suliman <liorsu(a)google.com> --- M src/tools/multilock/ml_functions.c M src/tools/multilock/ml_posix_client.c 2 files changed, 20 insertions(+), 20 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/43/555943/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555943?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Icf4bddccc8d1aafed6a445056fa0f3a72639837e Gerrit-Change-Number: 555943 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)gmail.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[XS] Change in ...nfs-ganesha[next]: Add LogEventLimited to trace in fsal_common_is_referral
by Name of user not set (GerritHub) 22 Jun '23

22 Jun '23

Attention is currently required from: Madhu Thorat. Hello Madhu Thorat, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555917?usp=email to review the following change. Change subject: Add LogEventLimited to trace in fsal_common_is_referral ...................................................................... Add LogEventLimited to trace in fsal_common_is_referral Under high load, the rate of messages like this : fsal_common_is_referral :FSAL :EVENT :Failed to get attrs for referral, handle: 0x7f3c700f5640, valid_mask: 0, request_mask: 14c086, supported: 0, error: The file no longer exists is really high (~100 times a second for this customer) and is filling up ganesha.log heavily. Modified LogEvent to LogEventLimited to limit EVENT logs. Change-Id: Id14cd315e9240a015f5ea66598911d94ed149922 Signed-off-by: Madhu Thorat <madhu.punjabi(a)in.ibm.com> --- M src/FSAL/commonlib.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/17/555917/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555917?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id14cd315e9240a015f5ea66598911d94ed149922 Gerrit-Change-Number: 555917 Gerrit-PatchSet: 1 Gerrit-Owner: skmprabhu252(a)gmail.com Gerrit-Reviewer: Madhu Thorat <madhu.punjabi(a)in.ibm.com> Gerrit-Attention: Madhu Thorat <madhu.punjabi(a)in.ibm.com> Gerrit-MessageType: newchange

1 0

[XS] Change in ...nfs-ganesha[next]: FSAL_MDCACHE/mdcache_handle: Fixed rename to compare the old and new ...
by Lior Suliman (GerritHub) 21 Jun '23

21 Jun '23

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555852?usp=email ) Change subject: FSAL_MDCACHE/mdcache_handle: Fixed rename to compare the old and new directory handles and names and not only the source and destination handles ...................................................................... FSAL_MDCACHE/mdcache_handle: Fixed rename to compare the old and new directory handles and names and not only the source and destination handles This fixes a Time-of-check Time-of-use bug checking for the file handle of the source before moving and then the file handle of the target before moving and comparing them. There can be a scenario that two or more clients will perform the rename at the same time both will pass the source lookup and one of them will perform the move while the other can get a success for it as well. This damaged the atomicity of the rename operation. The FSAL should handle the case when those are different entries with the same file handle (hard-links). Change-Id: I70bcfa28e9369c52d6b1385ac70eed20fc07f48d Signed-off-by: Lior Suliman <liorsu(a)google.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/52/555852/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555852?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I70bcfa28e9369c52d6b1385ac70eed20fc07f48d Gerrit-Change-Number: 555852 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XL] Change in ...nfs-ganesha[next]: multilock: Added scenarios to sample_tests
by Lior Suliman (GerritHub) 21 Jun '23

21 Jun '23

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555851?usp=email ) Change subject: multilock: Added scenarios to sample_tests ...................................................................... multilock: Added scenarios to sample_tests Change-Id: I7aab604e47d4bd04960de452324c616229c52260 Signed-off-by: Lior Suliman <liorsu(a)google.com> --- A src/tools/multilock/sample_tests/blocking_lock_ofd A src/tools/multilock/sample_tests/blocking_lock_posix A src/tools/multilock/sample_tests/downgrade_blocking_lock_alarm_ofd A src/tools/multilock/sample_tests/downgrade_blocking_lock_alarm_posix A src/tools/multilock/sample_tests/downgrade_lock_ofd A src/tools/multilock/sample_tests/downgrade_lock_posix A src/tools/multilock/sample_tests/lock_splitting_ofd A src/tools/multilock/sample_tests/lock_splitting_posix A src/tools/multilock/sample_tests/read_lock_two_clients_ofd A src/tools/multilock/sample_tests/read_lock_two_clients_posix A src/tools/multilock/sample_tests/take_128_locks_medium_range_medium_gap_ofd A src/tools/multilock/sample_tests/take_128_locks_medium_range_medium_gap_posix A src/tools/multilock/sample_tests/take_128_locks_small_range_none_gap_ofd A src/tools/multilock/sample_tests/take_128_locks_small_range_none_gap_posix A src/tools/multilock/sample_tests/take_release_locks_ofd A src/tools/multilock/sample_tests/take_release_locks_posix A src/tools/multilock/sample_tests/upgrade_blocking_lock_ofd A src/tools/multilock/sample_tests/upgrade_blocking_lock_posix A src/tools/multilock/sample_tests/upgrade_read_lock_ofd A src/tools/multilock/sample_tests/upgrade_read_lock_posix A src/tools/multilock/sample_tests/write_lock_two_clients_ofd A src/tools/multilock/sample_tests/write_lock_two_clients_posix 22 files changed, 3,028 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/51/555851/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555851?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7aab604e47d4bd04960de452324c616229c52260 Gerrit-Change-Number: 555851 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XS] Change in ...nfs-ganesha[next]: multilock: Added SO_REUSEADDR to the multilock console server
by Lior Suliman (GerritHub) 21 Jun '23

21 Jun '23

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555850?usp=email ) Change subject: multilock: Added SO_REUSEADDR to the multilock console server ...................................................................... multilock: Added SO_REUSEADDR to the multilock console server Change-Id: Ic095fbf3d8ea6bb8d44568613ae522a54844ac66 Signed-off-by: Lior Suliman <liorsu(a)google.com> --- M src/tools/multilock/ml_console.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/50/555850/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555850?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic095fbf3d8ea6bb8d44568613ae522a54844ac66 Gerrit-Change-Number: 555850 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: multilock: Allow the usage of the full UINT64 range for locks
by Lior Suliman (GerritHub) 21 Jun '23

21 Jun '23

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555849?usp=email ) Change subject: multilock: Allow the usage of the full UINT64 range for locks ...................................................................... multilock: Allow the usage of the full UINT64 range for locks Change-Id: I4d0f4c36dc703d246fc4316877fe11a31def9caa Signed-off-by: Lior Suliman <liorsu(a)google.com> --- M src/tools/multilock/ml_functions.c M src/tools/multilock/multilock.h 2 files changed, 41 insertions(+), 41 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/555849/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555849?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4d0f4c36dc703d246fc4316877fe11a31def9caa Gerrit-Change-Number: 555849 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XS] Change in ...nfs-ganesha[next]: init_fds_limit(): Log EVENT to print current set FD limit
by Name of user not set (GerritHub) 21 Jun '23

21 Jun '23

yogendra858(a)yahoo.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555829?usp=email ) Change subject: init_fds_limit(): Log EVENT to print current set FD limit ...................................................................... init_fds_limit(): Log EVENT to print current set FD limit In init_fds_limit() Log EVENT to print the set system-imposed FD limit. Signed-off-by: Madhu Thorat <madhu.punjabi(a)in.ibm.com> (cherry picked from commit e8f4fd2f64c4105021f7cc79d4c760826cc251f0) (cherry picked from commit 262e35028648f57cdd0c0e613d024f96e1018bb5) Change-Id: Iaa8a17f81550145c73986236cacbafb8dbb053e0 Signed-off-by: Yogendra Charya <Yogendra.Charya(a)ibm.com> --- M src/FSAL/commonlib.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/29/555829/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555829?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iaa8a17f81550145c73986236cacbafb8dbb053e0 Gerrit-Change-Number: 555829 Gerrit-PatchSet: 1 Gerrit-Owner: yogendra858(a)yahoo.com Gerrit-CC: Madhu Thorat <madhu.punjabi(a)in.ibm.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: GLUSTER: fixup new fsal_fd handling
by Frank Filz (GerritHub) 19 Jun '23

19 Jun '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555752?usp=email ) Change subject: GLUSTER: fixup new fsal_fd handling ...................................................................... GLUSTER: fixup new fsal_fd handling The close_func and reopen_func methods were not assigned. Also a minor change in glusterfs_close_my_fd. Also remove unused glusterfs_open_my_fd. Change-Id: If3cd895597809ec8534c48e70a5cdac1992e22a2 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_GLUSTER/handle.c 1 file changed, 16 insertions(+), 79 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/52/555752/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555752?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If3cd895597809ec8534c48e70a5cdac1992e22a2 Gerrit-Change-Number: 555752 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

absolute path of the FD.
by 89i2q1ss＠nqmo.com 19 Jun '23

19 Jun '23

FD created at below path does not have correct link in /proc/self/fd. With vfs_readlink_by_handle , I can get a relative path but cannot get the absolute path of the FD. https://www.worldescortspage.com

1 0