June 2023 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: Fix crash @ free_client_record()
by Name of user not set (GerritHub) 16 Jun '23

16 Jun '23

skmprabhu252(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555626?usp=email ) Change subject: Fix crash @ free_client_record() ...................................................................... Fix crash @ free_client_record() Fixes: ttps://github.com/nfs-ganesha/nfs-ganesha/issues/961 mutex lock is not required if client_rec is NULL. Change-Id: I072a8ecf30fa4c33ab0056c85302ec8c46022c2d Signed-off-by: Prabhu Murugesan <prabhu.murugesan1(a)ibm.com> --- M src/SAL/nfs4_lease.c 1 file changed, 16 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/26/555626/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555626?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I072a8ecf30fa4c33ab0056c85302ec8c46022c2d Gerrit-Change-Number: 555626 Gerrit-PatchSet: 1 Gerrit-Owner: skmprabhu252(a)gmail.com Gerrit-MessageType: newchange

1 0

[XS] Change in ...nfs-ganesha[next]: TEMP PATCH FOR CI TEST AGAINST V5-dev.3
by Frank Filz (GerritHub) 15 Jun '23

15 Jun '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555575?usp=email ) Change subject: TEMP PATCH FOR CI TEST AGAINST V5-dev.3 ...................................................................... TEMP PATCH FOR CI TEST AGAINST V5-dev.3 Change-Id: I209b9e1eff01e30dc10171451c67cd9d1034ff01 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/75/555575/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555575?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I209b9e1eff01e30dc10171451c67cd9d1034ff01 Gerrit-Change-Number: 555575 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: [GPFS] Change handle_size to 48 if GPFS returned handle with size 40
by Name of user not set (GerritHub) 14 Jun '23

14 Jun '23

Attention is currently required from: Madhu Thorat. Hello Madhu Thorat, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555482?usp=email to review the following change. Change subject: [GPFS] Change handle_size to 48 if GPFS returned handle with size 40 ...................................................................... [GPFS] Change handle_size to 48 if GPFS returned handle with size 40 Currently for lookup of name (specifically for ..), GPFS may return a handle with handle_size=40, which is not correct. Expected value of handle_size for a GPFS handle is 48 bytes. Till we don't have a fix from GPFS for this issue we will have this workaround to change the handle_size to 48 in case GPFS returned handle with handle_size=40. Change-Id: If547549397d2577301fa752abf6e60f05e11da1c Signed-off-by: Madhu Thorat <madhu.punjabi(a)in.ibm.com> --- M src/FSAL/FSAL_GPFS/fsal_internal.c 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/82/555482/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555482?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If547549397d2577301fa752abf6e60f05e11da1c Gerrit-Change-Number: 555482 Gerrit-PatchSet: 1 Gerrit-Owner: skmprabhu252(a)gmail.com Gerrit-Reviewer: Madhu Thorat <madhu.punjabi(a)in.ibm.com> Gerrit-Attention: Madhu Thorat <madhu.punjabi(a)in.ibm.com> Gerrit-MessageType: newchange

1 0

[XS] Change in ...nfs-ganesha[next]: uid2grp - fix placement of PTHREAD_MUTEX_destroy
by Frank Filz (GerritHub) 13 Jun '23

13 Jun '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555411?usp=email ) Change subject: uid2grp - fix placement of PTHREAD_MUTEX_destroy ...................................................................... uid2grp - fix placement of PTHREAD_MUTEX_destroy I'm still suspicious of the life cycle management of group_data since uid2grp_release_group_data doesn't remove the entry from the table, but I guess it also doesn't release the last reference, which actually is never released... This patch basically puts us back to where we were before adding PTHREAD_MUTEX_destroy... Change-Id: I0cc5b0db44b708f9c5a1bc6a338d47cd262721bc Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/support/uid2grp.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/11/555411/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555411?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0cc5b0db44b708f9c5a1bc6a338d47cd262721bc Gerrit-Change-Number: 555411 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: Modify the time that cannot go backwards to monotonic time
by adrian (GerritHub) 11 Jun '23

11 Jun '23

adrian has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555292?usp=email ) Change subject: Modify the time that cannot go backwards to monotonic time ...................................................................... Modify the time that cannot go backwards to monotonic time There are times in ganesha that can't go backwards, but it may be wall clock. During work of ganesha, may experience sudden changes in system time, such as an administrator modifying the time, some NFS services may be abnormal. So modifying the time to monotonic time avoids this. Change-Id: I9dad02b5d170be2f9cf528bf64f75dd0240817e1 Signed-off-by: adrian <adriann(a)aliyun.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c M src/FSAL/commonlib.c M src/MainNFSD/nfs_reaper_thread.c M src/MainNFSD/nfs_rpc_callback.c M src/Protocols/NFS/nfs4_op_create_session.c M src/Protocols/NFS/nfs4_op_setclientid_confirm.c M src/RPCAL/nfs_dupreq.c M src/SAL/nfs4_clientid.c M src/SAL/nfs4_lease.c M src/SAL/nfs4_owner.c M src/SAL/nfs4_recovery.c M src/SAL/nfs4_state.c M src/dbus/dbus_server.c M src/idmapper/idmapper_cache.c M src/include/common_utils.h M src/support/delayed_exec.c M src/support/fridgethr.c M src/support/netgroup_cache.c M src/support/uid2grp.c 21 files changed, 195 insertions(+), 51 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/92/555292/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555292?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9dad02b5d170be2f9cf528bf64f75dd0240817e1 Gerrit-Change-Number: 555292 Gerrit-PatchSet: 1 Gerrit-Owner: adrian <adriann(a)aliyun.com> Gerrit-MessageType: newchange

1 0

Announce Push of V5.3
by Frank Filz 09 Jun '23

09 Jun '23

Branch next Tag:V5.3 Merge Highlights * Add PSEUDOFS config block * nfs4_op_open: Allow open with CLAIM_PREVIOUS when FSAL supports grace period * GPFS: fix 40 byte sized old file handles * Fixed GPFS create export issue during claim_posix_filesystem * build: Fix Python detection * build: Fix developer warning for LSB module * scripts: Add podman container creation with Ganesha dependencies Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: f4085b698 Frank S. Filz V5.3 a35124d75 Martin Schwenke scripts: Add podman container creation with Ganesha dependencies f40ada3f9 Martin Schwenke build: Fix developer warning for LSB module f765f795f Martin Schwenke build: Fix Python detection e21025367 Yogendra Charya Fixed GPFS create export issue during claim_posix_filesystem 4c7f92346 Malahal Naineni GPFS: fix 40 byte sized old file handles 448c04b4b Shahar Hochma nfs4_op_open: Allow open with CLAIM_PREVIOUS when FSAL supports grace period 0542ff429 Frank S. Filz Add PSEUDOFS config block

1 0

[L] Change in ...nfs-ganesha[next]: Add PSEUDOFS config block
by Frank Filz (GerritHub) 07 Jun '23

07 Jun '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555099?usp=email ) Change subject: Add PSEUDOFS config block ...................................................................... Add PSEUDOFS config block This provides a very simple way to configure the pseudofs root with several options that are allowed, including specifying a CLIENT list. This is very useful if a restrictive client list is specified in EXPORT_DEFAULTS. For example, the following would restrict access to the pseudofs: EXPORT_DEFAULTS { Anonymous_uid = -99; Anonymous_gid = -99; Protocols = 3,4; Manage_Gids = false; Squash = None; Access_Type = RW; CLIENT { Access_Type=RW; Clients=192.168.0.0/24,192.168.1.0/24; } CLIENT { Access_Type=NONE; Clients=*; } } With this change, the following simple definition restores access to the pseudofs: PSEUDOFS { CLIENT { Clients=*; } } Thus patch also includes several logging changes that became obvious while debugging. Additionally in updating the config documentation for this patch, some errors were observed and fixed. Change-Id: I5dccfab272c1ffe2a6750ba2304db706233b9a55 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/config_samples/config.txt M src/doc/man/ganesha-ceph-config.rst M src/doc/man/ganesha-export-config.rst M src/support/exports.c 4 files changed, 619 insertions(+), 65 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/99/555099/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555099?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5dccfab272c1ffe2a6750ba2304db706233b9a55 Gerrit-Change-Number: 555099 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[XS] Change in ...nfs-ganesha[next]: Fixed GPFS create export issue during claim_posix_filesystem
by Name of user not set (GerritHub) 07 Jun '23

07 Jun '23

skmprabhu252(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555058?usp=email ) Change subject: Fixed GPFS create export issue during claim_posix_filesystem ...................................................................... Fixed GPFS create export issue during claim_posix_filesystem Added 'tmpfs' to the ignore list while populating posix filesystems Change-Id: If36dd094f0f620b6b601a5bcdb3024bcf2834b88 Signed-off-by: Yogendra Charya <Yogendra.Charya(a)ibm.com> --- M src/FSAL/localfs.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/58/555058/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/555058?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If36dd094f0f620b6b601a5bcdb3024bcf2834b88 Gerrit-Change-Number: 555058 Gerrit-PatchSet: 1 Gerrit-Owner: skmprabhu252(a)gmail.com Gerrit-MessageType: newchange

1 0

[L] Change in ...nfs-ganesha[next]: scripts: Add podman container creation with Ganesha dependencies
by Martin Schwenke (GerritHub) 02 Jun '23

02 Jun '23

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/554899?usp=email ) Change subject: scripts: Add podman container creation with Ganesha dependencies ...................................................................... scripts: Add podman container creation with Ganesha dependencies Create a container to work in interactively: ganesha-container fedora 38 Run a build test in all supported containers: ganesha-container all sh -c "rm -rf build/* && cd build && cmake -DUSE_FSAL_VFS=ON -DUSE_DBUS=ON -DENABLE_VFS_POSIX_ACL=YES -DUSE_ADMIN_TOOLS=YES ../nfs-ganesha/src && make -j" Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: Ie809edf3623aff1027e42623ec5864f0b2ed6500 --- A src/scripts/podman/Containerfile A src/scripts/podman/ganesha-container A src/scripts/podman/install-packages.sh 3 files changed, 460 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/99/554899/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/554899?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie809edf3623aff1027e42623ec5864f0b2ed6500 Gerrit-Change-Number: 554899 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net> Gerrit-MessageType: newchange

1 0