November 2025 - Devel - NFS Ganesha List Archives

[XS] Change in ...nfs-ganesha[next]: [MDCACHE] Refresh destination directory attr after hardlink operation
by Name of user not set (GerritHub) 25 Nov '25

25 Nov '25

pradeepthomas(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226991?usp=email ) Change subject: [MDCACHE] Refresh destination directory attr after hardlink operation ...................................................................... [MDCACHE] Refresh destination directory attr after hardlink operation When directory cache is disabled, after hardlink operation, ganesha returns stale attributes to client for the destination dir. This causes a failure in nfstest_posix test. Issue can be reproduced with "stat .; ln file1 file1.1; stat ." Signed-off-by: Pradeep <pradeepthomas(a)gmail.com> Change-Id: I4f13b69e0d3bf88e17b6d906acfaa3fdb872e89b --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/91/1226991/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226991?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4f13b69e0d3bf88e17b6d906acfaa3fdb872e89b Gerrit-Change-Number: 1226991 Gerrit-PatchSet: 1 Gerrit-Owner: pradeepthomas(a)gmail.com

1 0

[XS] Change in ...nfs-ganesha[next]: Update `snbd_last_poll_time` for blocked locks.
by ofir vainshtein (GerritHub) 24 Nov '25

24 Nov '25

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226904?usp=email ) Change subject: Update `snbd_last_poll_time` for blocked locks. ...................................................................... Update `snbd_last_poll_time` for blocked locks. This change updates the `snbd_last_poll_time` when a blocked lock upcall is processed and when a blocking lock eligibility test is scheduled (as it can happen some time after schedule). Change-Id: Id422e93807bad605daa7cc877b62ded22de68e9e Signed-off-by: Ofir Vainshtein <ofirvins(a)google.com> --- M src/SAL/state_async.c M src/SAL/state_lock.c 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/04/1226904/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226904?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id422e93807bad605daa7cc877b62ded22de68e9e Gerrit-Change-Number: 1226904 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 0

[S] Change in ...nfs-ganesha[next]: Fix lock leak. return lock error if we get stale lock requests of rel...
by ofir vainshtein (GerritHub) 24 Nov '25

24 Nov '25

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226903?usp=email ) Change subject: Fix lock leak. return lock error if we get stale lock requests of released owners ...................................................................... Fix lock leak. return lock error if we get stale lock requests of released owners In case where lock request is received when state was already released, We could have still served a lock. this caused a lock leak in ganesha if lock was then added to file lock list. but if it didn't we would have gotten a lock leak in the underlying storage Change-Id: I27dd2bbed838bef8b6fcc088946a7ba877de8882 Signed-off-by: Ofir Vainshtein <ofirvins(a)google.com> --- M src/SAL/state_lock.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/03/1226903/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226903?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I27dd2bbed838bef8b6fcc088946a7ba877de8882 Gerrit-Change-Number: 1226903 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 0

[S] Change in ...nfs-ganesha[next]: Limit logs when releasing expired clients.
by ofir vainshtein (GerritHub) 24 Nov '25

24 Nov '25

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226902?usp=email ) Change subject: Limit logs when releasing expired clients. ...................................................................... Limit logs when releasing expired clients. Change-Id: I8f663bb9578c52f479ca864c1b8bc2ceb7d4b488 Signed-off-by: Ofir Vainshtein <ofirvins(a)google.com> --- M src/SAL/nfs4_clientid.c 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/1226902/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226902?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8f663bb9578c52f479ca864c1b8bc2ceb7d4b488 Gerrit-Change-Number: 1226902 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 0

Announce Push of V9.2
by Frank Filz 21 Nov '25

21 Nov '25

Branch next Tag:V9.2 Merge Highlights * Get rid of confusing cmp_sockaddr and rename sockaddr_cmpf to sockaddr_cmp * Add NFSv4 parameter to disable NFSv4 blocking locks support * Check mutex ops in set_idmapping_status (Coverity CID 542634) * Fix buffer overruns in ip_utils.c (Coverity CIDs 638312, 638296) * CEPH: Fix file handle leak Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: e35369068 Frank S. Filz V9.2 a26e2c33d Sachin Punadikar CEPH: Fix file handle leak 68697d296 Suhas Athani Fix buffer overruns in ip_utils.c (Coverity CIDs 638312, 638296) 6bd061661 Suhas Athani Check mutex ops in set_idmapping_status (Coverity CID 542634) cc580b574 xueqian.hu Add NFSv4 parameter to disable NFSv4 blocking locks support 69ac3770c Frank S. Filz Get rid of confusing cmp_sockaddr and rename sockaddr_cmpf to sockaddr_cmp

1 0

[L] Change in ...nfs-ganesha[next]: Make FSAL readlink use utf8string instead of gsh_buffdesc and elimina...
by Frank Filz (GerritHub) 21 Nov '25

21 Nov '25

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226855?usp=email ) Change subject: Make FSAL readlink use utf8string instead of gsh_buffdesc and eliminate gsh_strldup ...................................................................... Make FSAL readlink use utf8string instead of gsh_buffdesc and eliminate gsh_strldup gsh_strldup was used in several places to make copies of a string in either a gsh_buffdesc or a utf8string which use different types for the length. Also the length in gsh_buffdesc is the length of the buffer so it is string length +1. The length was not being consistently set. Changing the FSAL readlink method to take a utf8string instead of a gsh_buffdesc allows for a clear definitions since we assure that internally all utf8strings are NUL terminated with the length just being a conveniemce. Introduced a new function that copies a character buffer (that need not be NUL terminated) into a utf8string, making a copy of the buffer, adding a NUL termination, and setting the utf8string_len properly. This allows elimination of all uses of the gsh_strldup macro that doesn't convert to an inline function well (due the the unknown type of the length variable) as part of a subsequent patch to make more header files usable with C++. Change-Id: Ifd5a250ba500f005d4345cac0fd1defaa14f8485 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_GLUSTER/handle.c M src/FSAL/FSAL_GPFS/handle.c M src/FSAL/FSAL_KVSFS/kvsfs_handle.c M src/FSAL/FSAL_LIZARDFS/handle.c M src/FSAL/FSAL_MEM/mem_handle.c M src/FSAL/FSAL_MEM/mem_int.h M src/FSAL/FSAL_PROXY_V3/main.c M src/FSAL/FSAL_PROXY_V4/handle.c M src/FSAL/FSAL_RGW/handle.c M src/FSAL/FSAL_SAUNAFS/handle.c M src/FSAL/FSAL_VFS/handle.c M src/FSAL/FSAL_VFS/handle_syscalls.c M src/FSAL/FSAL_VFS/vfs_methods.h M src/FSAL/FSAL_VFS/xfs/handle_syscalls.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c M src/FSAL/Stackable_FSALs/FSAL_NULL/handle.c M src/FSAL/default_methods.c M src/FSAL/fsal_helper.c M src/Protocols/9P/9p_readlink.c M src/Protocols/NFS/nfs3_readlink.c M src/Protocols/NFS/nfs4_op_readlink.c M src/gtest/fsal_api/test_readlink_latency.cc M src/gtest/fsal_api/test_symlink_latency.cc M src/include/abstract_mem.h M src/include/fsal.h M src/include/fsal_api.h M src/include/nfsv41.h 28 files changed, 145 insertions(+), 150 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/55/1226855/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226855?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ifd5a250ba500f005d4345cac0fd1defaa14f8485 Gerrit-Change-Number: 1226855 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[S] Change in ...nfs-ganesha[next]: clang-format fixups
by Frank Filz (GerritHub) 21 Nov '25

21 Nov '25

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226854?usp=email ) Change subject: clang-format fixups ...................................................................... clang-format fixups Change-Id: I7e04a8d4d58cdf805d9c79edaf64193d20b93c2c Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_KVSFS/kvsfs_handle.c M src/gtest/fsal_api/test_readlink_latency.cc M src/gtest/fsal_api/test_symlink_latency.cc M src/include/fsal_api.h 4 files changed, 11 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/54/1226854/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7e04a8d4d58cdf805d9c79edaf64193d20b93c2c Gerrit-Change-Number: 1226854 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: TEST IGNORE
by Frank Filz (GerritHub) 20 Nov '25

20 Nov '25

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226771?usp=email ) Change subject: TEST IGNORE ...................................................................... TEST IGNORE Change-Id: Icc923592d12d6454b0eb9f87f07929beb5c79cfd Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/71/1226771/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226771?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Icc923592d12d6454b0eb9f87f07929beb5c79cfd Gerrit-Change-Number: 1226771 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: CEPH: Fix file handle leak
by Sachin Punadikar (GerritHub) 19 Nov '25

19 Nov '25

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226697?usp=email ) Change subject: CEPH: Fix file handle leak ...................................................................... CEPH: Fix file handle leak Fixing file handle leak which can occur during readdir operation. Change-Id: I9fb15630591bc4cf9685068040563b2a66bdebf7 Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/FSAL/FSAL_CEPH/handle.c 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/1226697/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226697?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9fb15630591bc4cf9685068040563b2a66bdebf7 Gerrit-Change-Number: 1226697 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Move full debug log after NULL state check in fsal_start_io()
by Suhas Athani (GerritHub) 19 Nov '25

19 Nov '25

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226665?usp=email ) Change subject: Move full debug log after NULL state check in fsal_start_io() ...................................................................... Move full debug log after NULL state check in fsal_start_io() The debug log statement printing the open state pointer and state type in fsal_start_io() was placed before checking if state is NULL. This could lead to potential dereference of a NULL pointer when full debug logging is enabled. This patch moves the LogFullDebug() call after the NULL check to ensure safe access to state fields. Change-Id: I68167e3d8209221559285e49690f5b28feaab081 Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com> --- M src/FSAL/commonlib.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/65/1226665/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I68167e3d8209221559285e49690f5b28feaab081 Gerrit-Change-Number: 1226665 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

1 0