November 2025 - Devel - NFS Ganesha List Archives

[XS] Change in ...nfs-ganesha[next]: Fix potential buffer overflow in cidr_from_str (Coverity CID 638296)
by Suhas Athani (GerritHub) 18 Nov '25

18 Nov '25

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226626?usp=email ) Change subject: Fix potential buffer overflow in cidr_from_str (Coverity CID 638296) ...................................................................... Fix potential buffer overflow in cidr_from_str (Coverity CID 638296) Fixes a buffer overflow in cidr_from_str by replacing strcpy with strlcpy and adding input length checks. Returns an error if the input address exceeds buffer size, ensuring safe string handling. Change-Id: Ied39b85f62231cd2667aefd2ab5f344314241682 Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com> --- M src/support/ip_utils.c 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/26/1226626/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226626?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ied39b85f62231cd2667aefd2ab5f344314241682 Gerrit-Change-Number: 1226626 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Fix buffer overrun in cidr_from_inaddr (Coverity CID 638312)
by Suhas Athani (GerritHub) 18 Nov '25

18 Nov '25

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226625?usp=email ) Change subject: Fix buffer overrun in cidr_from_inaddr (Coverity CID 638312) ...................................................................... Fix buffer overrun in cidr_from_inaddr (Coverity CID 638312) Fixes a buffer overrun in cidr_from_inaddr by copying just the in_addr structure. Change-Id: Ia14b0c93ed7ad175aaeb05f6e0e25299e87bb032 Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com> --- M src/support/ip_utils.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/25/1226625/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226625?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia14b0c93ed7ad175aaeb05f6e0e25299e87bb032 Gerrit-Change-Number: 1226625 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

1 0

[S] Change in ...nfs-ganesha[next]: Check mutex ops in set_idmapping_status (Coverity CID 542634)
by Suhas Athani (GerritHub) 18 Nov '25

18 Nov '25

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226623?usp=email ) Change subject: Check mutex ops in set_idmapping_status (Coverity CID 542634) ...................................................................... Check mutex ops in set_idmapping_status (Coverity CID 542634) Switch set_idmapping_status to PTHREAD_MUTEX_lock/unlock, ensuring mutex acquisition failures are caught and logged instead of proceeding unchecked. Change-Id: I4c8057553ce252446b81f9d15656dc98fe06d754 Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com> --- M src/idmapper/idmapper.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/23/1226623/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226623?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4c8057553ce252446b81f9d15656dc98fe06d754 Gerrit-Change-Number: 1226623 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Fix some compilation warnings that can cause compilation failures
by Name of user not set (GerritHub) 18 Nov '25

18 Nov '25

shaharhoch(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226621?usp=email ) Change subject: Fix some compilation warnings that can cause compilation failures ...................................................................... Fix some compilation warnings that can cause compilation failures Change-Id: I10a17e5ae2993e09679041a037ab754bc3df1fe8 Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/Protocols/NFS/nfs4_op_free_stateid.c M src/monitoring/dynamic_metrics.cc 3 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/21/1226621/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226621?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I10a17e5ae2993e09679041a037ab754bc3df1fe8 Gerrit-Change-Number: 1226621 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)google.com

1 0

[S] Change in ...nfs-ganesha[next]: Add NFSv4 parameter to disable NFSv4 blocking locks support
by Xueqian Hu (GerritHub) 16 Nov '25

16 Nov '25

Xueqian Hu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226493?usp=email ) Change subject: Add NFSv4 parameter to disable NFSv4 blocking locks support ...................................................................... Add NFSv4 parameter to disable NFSv4 blocking locks support Change-Id: I85e675dae34498d7bec0635e65a346f219ab2d4a Signed-off-by: xueqian.hu <xh140312(a)outlook.com> --- M src/Protocols/NFS/nfs4_op_lock.c M src/config_samples/config.txt M src/doc/man/ganesha-core-config.rst M src/include/gsh_config.h M src/support/nfs_read_conf.c 5 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/93/1226493/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226493?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I85e675dae34498d7bec0635e65a346f219ab2d4a Gerrit-Change-Number: 1226493 Gerrit-PatchSet: 1 Gerrit-Owner: Xueqian Hu <xh140312(a)outlook.com>

1 0

[S] Change in ...nfs-ganesha[next]: Validate CLAIM_DELEGATE* stateids in open4_claim_deleg()
by Suhas Athani (GerritHub) 14 Nov '25

14 Nov '25

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226434?usp=email ) Change subject: Validate CLAIM_DELEGATE* stateids in open4_claim_deleg() ...................................................................... Validate CLAIM_DELEGATE* stateids in open4_claim_deleg() - Replace the old “FIXME: vet stateid here” path with a call to nfs4_Check_Stateid, using STATEID_NO_SPECIAL. - Reject claims whose stateid is missing or not a delegation (STATE_TYPE_DELEG) and add a debug log for that case. - Preserve the full‑debug logging of the matching delegation and make sure we drop the state reference unconditionally. This ensures CLAIM_DELEGATE_CUR/CLAIM_DELEG_CUR_FH opens only succeed when the client presents a live delegation stateid tied to the correct file, preventing stale or unrelated stateids from being accepted. Change-Id: I1f4dc7ddab74a99dedc6dee86c120c1e27af5a73 Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com> --- M src/Protocols/NFS/nfs4_op_open.c 1 file changed, 25 insertions(+), 17 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/1226434/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226434?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1f4dc7ddab74a99dedc6dee86c120c1e27af5a73 Gerrit-Change-Number: 1226434 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

1 0

[M] Change in ...nfs-ganesha[next]: Monitoring: Add duplicated metrics with "nfs_" prefix alongside exist...
by Name of user not set (GerritHub) 14 Nov '25

14 Nov '25

sragraha(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226403?usp=email ) Change subject: Monitoring: Add duplicated metrics with "nfs_" prefix alongside existing ones for one release ...................................................................... Monitoring: Add duplicated metrics with "nfs_" prefix alongside existing ones for one release This change introduces duplicated metrics that are identical to existing ones but prefixed with "nfs_". This approach allows users to familiarize themselves with the new metric naming convention without removing the original metrics. The duplication is intended as a temporary measure for the current release. In a future release, the "nfs_" prefixing will be applied directly at metric registration, and the duplicated metrics will be removed. Change-Id: I92954188fc7bd96c21c9116579f20a51883f72b6 Signed-off-by: Sreedhar Agraharam <sragraha(a)redhat.com> --- M src/monitoring/prometheus_exposer.cc 1 file changed, 49 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/03/1226403/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226403?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I92954188fc7bd96c21c9116579f20a51883f72b6 Gerrit-Change-Number: 1226403 Gerrit-PatchSet: 1 Gerrit-Owner: sragraha(a)redhat.com

1 0

[S] Change in ...nfs-ganesha[next]: Fix race condition in clientid expiration during compound operations
by Nikhil Adhau (GerritHub) 13 Nov '25

13 Nov '25

Nikhil Adhau has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226374?usp=email ) Change subject: Fix race condition in clientid expiration during compound operations ...................................................................... Fix race condition in clientid expiration during compound operations Add reference counting for data->preserved_clientid to prevent the clientid structure from being freed while still in use during NFSv4 compound operations. The crash occurred when a clientid expired while a compound operation was still using it, causing update_lease_simple() to acquire a mutex on a freed clientid structure. Change-Id: I85a17cfe87bc3bd8dc325191da085a17fc18389c Signed-off-by: Nikhil Adhau <nikhiladhau999(a)gmail.com> --- M src/Protocols/NFS/nfs4_Compound.c M src/Protocols/NFS/nfs4_op_bind_conn.c M src/Protocols/NFS/nfs4_op_sequence.c M src/SAL/nfs4_state_id.c 4 files changed, 26 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/74/1226374/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226374?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I85a17cfe87bc3bd8dc325191da085a17fc18389c Gerrit-Change-Number: 1226374 Gerrit-PatchSet: 1 Gerrit-Owner: Nikhil Adhau <nikhiladhau999(a)gmail.com>

1 0

Announce Push of V9.1
by Frank Filz 07 Nov '25

07 Nov '25

Branch next Tag:V9.1 Other Merge Highlights * nfs3/reopen: Retry open if failed with EPERM * Modify Enable_UDP config option to take NLM option * Fix IP address comparison for client manager * Modify cmp_sockaddr() to use nearly identical sockaddr_cmpf() * Add cid_confirmed_saved to nfs_client_id_t * SAL: Allow IP based recovery from RecovDir * Logging: Use consistent logging components in recovery_fs.c * FSAL_GLUSTER: Fix crash on rm with GlusterFS 6.0 and NFSv3 * Use PTHREAD_MUTEX macros for mutex operations * Fix data race in TCP DRC recycle queue length (CID 583557). * Remove redundant null check for session->clientid_record * Fix rpm build error for GPFS FSAL * Fix crash in NFS3 read when read_count is zero * Fix Coverity issues: CID 583547, 542655, 509140 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 5a8357fca Frank S. Filz V9.1 8488f6908 VidyaThumukunta Fix Coverity issues: CID 583547, 542655, 509140 6c1515687 xueqian.hu Fix crash in NFS3 read when read_count is zero 69ba2c3dc Sachin Punadikar Fix rpm build error for GPFS FSAL 9e902ded5 Suhas Athani Remove redundant null check for session->clientid_record 09c3e4387 Suhas Athani Fix data race in TCP DRC recycle queue length (CID 583557). c88a3c4b5 Suhas Athani Use PTHREAD_MUTEX macros for mutex operations 84ee40fbc Dillon Peng FSAL_GLUSTER: Fix crash on rm with GlusterFS 6.0 and NFSv3 335d93c79 Peter Schwenke Logging: Use consistent logging components in recovery_fs.c b05ac8795 Peter Schwenke SAL: Allow IP based recovery from RecovDir ea85a5481 Peter Schwenke Add cid_confirmed_saved to nfs_client_id_t c014341e9 Peter Schwenke Modify cmp_sockaddr() to use nearly identical sockaddr_cmpf() ba2844c5f Peter Schwenke Fix IP address comparison for client manager 003c018ea Peter Schwenke Modify Enable_UDP config option to take NLM option a2558144d Mohammed Rafi KC nfs3/reopen: Retry open if failed with EPERM

1 0

[S] Change in ...nfs-ganesha[next]: Get rid of confusing cmp_sockaddr and rename sockaddr_cmpf to sockadd...
by Frank Filz (GerritHub) 07 Nov '25

07 Nov '25

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226026?usp=email ) Change subject: Get rid of confusing cmp_sockaddr and rename sockaddr_cmpf to sockaddr_cmp ...................................................................... Get rid of confusing cmp_sockaddr and rename sockaddr_cmpf to sockaddr_cmp Change-Id: Ie1a054768132f0881f32f4ee931ce3c741385290 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/RPCAL/nfs_dupreq.c M src/SAL/nfs4_clientid.c M src/SAL/nfs4_recovery.c M src/SAL/nlm_owner.c M src/include/ip_utils.h M src/support/client_mgr.c M src/support/ip_utils.c M src/support/nfs_ip_name.c 8 files changed, 17 insertions(+), 32 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/26/1226026/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226026?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie1a054768132f0881f32f4ee931ce3c741385290 Gerrit-Change-Number: 1226026 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0