[XS] Change in ...nfs-ganesha[next]: uid2grp: Fix LTTNG format string
by Lior Suliman (GerritHub)
Attention is currently required from: Frank Filz.
Hello Frank Filz,
I'd like you to do a code review.
Please visit
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1217679?usp=email
to review the following change.
Change subject: uid2grp: Fix LTTNG format string
......................................................................
uid2grp: Fix LTTNG format string
Change-Id: I8ce4c4ac1a8650ffdef770623e61b7e34d6545bb
Signed-off-by: Lior Suliman <liorsu(a)gmail.com>
---
M src/support/uid2grp.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/79/1217679/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1217679?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I8ce4c4ac1a8650ffdef770623e61b7e34d6545bb
Gerrit-Change-Number: 1217679
Gerrit-PatchSet: 1
Gerrit-Owner: Lior Suliman <liorsu(a)google.com>
Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com>
Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>
1 month
Announce Push of V7-dev.17
by Frank Filz
Branch next
Tag:V7-dev.17
Merge Highlights
* Major update of idmapping to support alternate forms and adding monitoring
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
db086c4df Frank S. Filz V7-dev.17
607988771 Lior Suliman uid2grp: Correctly handle getgrouplist() return
value.
95737bd52 Lior Suliman NFS-Ganesha: Add SSSD timeout and skip cache options
65f5f6b69 Lior Suliman NFS-Ganesha: Add negative-cache by UIDs
704f409a5 Lior Suliman Minor fix in tracepoint formatting in
nfs4_op_sequence.c
fff93dcfd Lior Suliman Fix CTAD maybe unsupported warning
06888cc23 Lior Suliman NFS-Ganesha: Add pwnam wrappers module
038392223 Lior Suliman Added monitoring metric for when user exceeds
max_groups_membership
e29c1ac2d Lior Suliman Allow max groups membership to be configurable
01bb2e2a6 Lior Suliman Refactored idmapping code paths, added logs and lttng
traces refactored and added metrics
689267cb0 Lior Suliman Add Dbus method for showing and purging negative
cache
0f1ffd98a Lior Suliman Add Dbus method for showing uid2grp cache
50bfc3e8b Lior Suliman Split Dbus idmapper show to show users and show
groups
1 month
[S] Change in ...nfs-ganesha[next]: uid2grp: Correctly handle getgrouplist() return value.
by Lior Suliman (GerritHub)
Attention is currently required from: Frank Filz.
Hello Frank Filz,
I'd like you to do a code review.
Please visit
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1217676?usp=email
to review the following change.
Change subject: uid2grp: Correctly handle getgrouplist() return value.
......................................................................
uid2grp: Correctly handle getgrouplist() return value.
The POSIX getgrouplist() function returns 0 on success
and an error value on failure, not -1 on failure as it's
commonly assumed.
This change fixes the check for errors after calls to
getgrouplist(), and logs the returned error code to assist
with debugging.
Change-Id: I4a9bb0ad9bd27a08c50383f255851aa40cf611d5
Signed-off-by: Lior Suliman <liorsu(a)gmail.com>
---
M src/support/uid2grp.c
1 file changed, 11 insertions(+), 11 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/76/1217676/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1217676?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I4a9bb0ad9bd27a08c50383f255851aa40cf611d5
Gerrit-Change-Number: 1217676
Gerrit-PatchSet: 1
Gerrit-Owner: Lior Suliman <liorsu(a)google.com>
Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com>
Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>
1 month
[L] Change in ...nfs-ganesha[next]: WIP - Work In Progress
by Name of user not set (GerritHub)
Avani.Rateria(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1217643?usp=email )
Change subject: WIP - Work In Progress
......................................................................
WIP - Work In Progress
Added mTLS with gRPC Infra. We would need both client as well as server
certificate to communicate with gRPC.
Work to do:
1) The location of the ceritificates should be provided in the conf file
2) Update the client side infra to support secure gRPC
gRPC (gRPC Remote Procedure Call) is an open-source framework that
enables communication between services through remote procedure
calls (RPCs). It is built on top of HTTP/2 and uses Protocol Buffers
(protobuf) as the interface definition language (IDL).
Change-Id: Id51fafb8c89b98bb50eee72e926d776a03daf3e4
Signed-off-by: AvaniRateria <Avani.Rateria(a)ibm.com>
---
M src/CMakeLists.txt
M src/MainNFSD/CMakeLists.txt
M src/MainNFSD/nfs_init.c
A src/grpc_server/CMakeLists.txt
A src/grpc_server/GrpcServer.cc
A src/grpc_server/nfsService.h
A src/grpc_server/nfsServiceClient.cpp
A src/grpc_server/nfsServiceServer.cpp
M src/include/config-h.in.cmake
A src/include/gRPC/GrpcServer.h
M src/include/gsh_config.h
A src/proto/CMakeLists.txt
A src/proto/nfsService.proto
M src/support/nfs_read_conf.c
14 files changed, 796 insertions(+), 10 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/43/1217643/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1217643?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Id51fafb8c89b98bb50eee72e926d776a03daf3e4
Gerrit-Change-Number: 1217643
Gerrit-PatchSet: 1
Gerrit-Owner: Avani.Rateria(a)ibm.com
1 month
Announce Push of V7-dev.16
by Frank Filz
Branch next
Tag:V7-dev.16
Merge Highlights
* Additional debug for clientid and hashtable
* Change cr_server_addr to sockaddr_t to properly support IPv6
* Add virtual server mode
* parsing: fix Coverity CID 502136 - string buffers need +1 for NUL
* NLM: use hashtable_getlatch in state_add_grant_cookie
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
ff7c7d444 Frank S. Filz V7-dev.16
8c5432ddc Frank S. Filz NLM: use hashtable_getlatch in
state_add_grant_cookie
ac02830c9 Frank S. Filz parsing: fix Coverity CID 502136 - string buffers
need +1 for NUL
ee3e72153 Frank S. Filz Use virtual_server mode to add server addr to
NFSv4.1+ EXCHANGE_ID major_id
389690098 Frank S. Filz Config: add virtual server mode config flag
43b53f749 Frank S. Filz CLIENTID: Additional debug
acee4aa05 Frank S. Filz HASHTABLE: Additional debug
d20b0be59 Frank S. Filz Change cr_server_addr to sockaddr_t to properly
support IPv6
1 month
Announce Push of V7-dev.15
by Frank Filz
Branch next
Tag:V7-dev.15
NOTE: This merge includes an ntirpc pullup, please update your submodule
Merge Highlights
* doc: Fix typo in export config sample
* several script updates
* selinux: additional rules for (found on) Fedora 42
* Coverty check: Update pthread syscalls with internal macro
* ganesha service info in ceph status command
* server scope metric: Updated ganesha info metric with server_scope info
* NFS4: Fix the minimum maxcount and response length of listxattr
* Fix crash at GPFSFSAL_getattrs()
* Fix crash at cancel_all_nlm_blocked()->cancel_blocked_lock()
* Fix test parser code
* Added alert rule to detect potential ganesha hang based on RPC activity
* fix(Config_parese): fix param type of token_compare_hash
* Support non-numeric nodeid in recovery databases
* CEPH: Support old logic of ceph uuid generation
* Close monitoring port in shutdown path
* LibACL isn't optional, fail cmake if it's not there
* feat(recovery): reject reclaim in edge conditions
* feat(recovery_fs): enforce reclaim with reclaim_complete info
* send network_id to connection manager
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
f22fca833 Frank S. Filz V7-dev.15
af438b618 Roy Babayov send network_id to connection manager
39bb70ddf Frank S. Filz libntirpc pullup
9f3ad1396 zhitaoli feat(recovery_fs): enforce reclaim with reclaim_complete
info
fcc9f1fad zhitaoli feat(recovery): reject reclaim in edge conditions
44ccfcdff Daniel Gryniewicz LibACL isn't optional, fail cmake if it's not
there
3e2a022ed Sachin Punadikar Close monitoring port in shutdown path
3ca844e89 Sachin Punadikar CEPH: Support non-numeric nodeid
d5916fb11 Sachin Punadikar CEPH: Support old logic of ceph uuid generation
483505fe1 Sachin Punadikar ganesha-rados-grace : support non-numeric nodeid
479fcad04 will fix(Config_parese): fix param type of token_compare_hash
0db57c368 VidyaThumukunta Added alert rule to detect potential ganesha hang
based on RPC activity
852405fb8 Prabhu Murugesan Fix test parser code
543529df4 Prabhu Murugesan Fix crash at
cancel_all_nlm_blocked()->cancel_blocked_lock()
7f9c10c53 Prabhu Murugesan Fix crash at GPFSFSAL_getattrs()
21a00467e Prabhu Murugesan Fix ASOC scan finding -Popen command injection
11bca7ade adrian NFS4: Fix the minimum maxcount and response length of
listxattr
0caef004b Sreedhat Agraharam server scope metric: Updated ganesha info
metric with server_scope info
17c6f5c1b Sreedhat Agraharam ganesha service info in ceph status command
8b7c6ac7f Sreedhat Agraharam Coverty check: Update pthread syscalls with
internal macro
a3a16f75a Kaleb S. KEITHLEY selinux: additional rules for (found on) Fedora
42
e79ca0ded Martin Schwenke scripts: Clean up ganesha_mgr help
9f27ff947 Martin Schwenke doc: Fix typo in export config sample
1 month
gfe near me
by xifice2018＠ethsms.com
Each call girl site has a list of foreign girls that might attract you more than you think. You can take some time to look at the directory of foreign escorts and, of course, decide to contact them. It is good to know that these escorts tend to charge a little more money for their services, so you consider that.
https://www.thailandescortsmap.com
1 month, 1 week
[S] Change in ...nfs-ganesha[next]: Close monitoring port in shutdown path
by Sachin Punadikar (GerritHub)
Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1217229?usp=email )
Change subject: Close monitoring port in shutdown path
......................................................................
Close monitoring port in shutdown path
At start of NFS Ganesha, monitoring port is opened, but not closed in
shutdown path. Added required code.
Change-Id: I4fe5c78889d2877851a141082e2418ef405338cd
Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com>
---
M src/MainNFSD/nfs_admin_thread.c
M src/monitoring/include/prometheus_exposer.h
M src/monitoring/prometheus_exposer.cc
3 files changed, 25 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/29/1217229/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1217229?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I4fe5c78889d2877851a141082e2418ef405338cd
Gerrit-Change-Number: 1217229
Gerrit-PatchSet: 1
Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>
1 month, 1 week
Re: [NFS-Ganesha-Support] Re: Unsupported FSALs
by Frank Filz
If you are still committed to supporting FSAL_GLUSTER, could you take a look at this patch:
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/547270
Thanks
Frank
From: Rafi Kavungal [mailto:rafi.kavungal@iternity.com]
Sent: Thursday, April 10, 2025 1:35 AM
To: Frank Filz <ffilzlnx(a)mindspring.com>; devel(a)lists.nfs-ganesha.org
Cc: support(a)lists.nfs-ganesha.org
Subject: [NFS-Ganesha-Support] Re: [NFS-Ganesha-Devel] Unsupported FSALs
Wonderful, I will start looking into the issues. I have already added the meeting invites to my calendar. Though it is bit out of my working hours, I hope to join the call regularly.
-Rafi
Rafi
Kavungal
Software Engineer
| iTernity
<mailto:rafi.kavungal@iternity.com> rafi.kavungal(a)iternity.com
<tel:+49%20761%2059034810> +49 761 59034810
<http://Homeoffice+Indien>
<https://iternity.com/> Website
<https://iternity.com/know-how/newsletter/> Newsletter
<https://support.iternity.com/> Support Portal
<https://iternity.com/privacy/> See our privacy policy if you want us to delete your personal data.
iTernity GmbH. Managing Directors: Armin Weißer, Ralf Steinemann.
Registered at the District Court Freiburg: HRB-Nr. 701332.
USt.Id DE242664311
From: Frank Filz <ffilzlnx(a)mindspring.com <mailto:ffilzlnx@mindspring.com> >
Sent: 09 April 2025 12:03 AM
To: Rafi Kavungal <rafi.kavungal(a)iternity.com <mailto:rafi.kavungal@iternity.com> >; devel(a)lists.nfs-ganesha.org <mailto:devel@lists.nfs-ganesha.org>
Cc: support(a)lists.nfs-ganesha.org <mailto:support@lists.nfs-ganesha.org>
Subject: RE: [NFS-Ganesha-Devel] Unsupported FSALs
That is great. I just relabled all the FSAL_GLUSTER github issues that were labeled as UNSUPPORTED FSAL as GLUSTER.
If you could start taking a look at them, that would be a big help.
We also invite you to join our weekly community call, Tuesday’s 7:00 AM Pacific Time. If you’d like me to add you to the calendar invite, I will do so, but here’s the call details:
Ganesha community call
Tuesday, April 8 · 7:00 – 8:00am
Time zone: America/Los_Angeles
Google Meet joining info
Video call link: <https://meet.google.com/mkh-ctnj-tqz> https://meet.google.com/mkh-ctnj-tqz
Or dial: (US) +1 401-702-0462 PIN: 495 972 631#
More phone numbers: <https://tel.meet/mkh-ctnj-tqz?pin=2844708468265> https://tel.meet/mkh-ctnj-tqz?pin=2844708468265
Or join via SIP: <sip:2844708468265@gmeet.redhat.com> sip:2844708468265@gmeet.redhat.com
Thanks
Frank
From: Rafi Kavungal [ <mailto:rafi.kavungal@iternity.com> mailto:rafi.kavungal@iternity.com]
Sent: Tuesday, April 8, 2025 7:17 AM
To: Frank Filz < <mailto:ffilzlnx@mindspring.com> ffilzlnx(a)mindspring.com>; <mailto:devel@lists.nfs-ganesha.org> devel(a)lists.nfs-ganesha.org
Cc: <mailto:support@lists.nfs-ganesha.org> support(a)lists.nfs-ganesha.org
Subject: RE: [NFS-Ganesha-Devel] Unsupported FSALs
Hi Frank,
We heavily rely on Gluster FSAL for our archive product. We have two active developers working on the project. While we mostly mastered the gluster project, we are confident that we can support the Gluster FSAL with the help of community. Since NFS-Ganesha is such an important part of our project, we will definitely want to do everything to keep Gluster FSAL moving with Ganesha community.
Let us know how we can take it forward.
Regards
Rafi
Rafi
Kavungal
Software Engineer
<mailto:rafi.kavungal@iternity.com> rafi.kavungal(a)iternity.com
<tel:+49%20761%2059034810> +49 761 59034810
<http://homeoffice+indien/>
<https://iternity.com/de/dmea/articles/iternity-at-dmea-2025/>
<https://iternity.com/managed-storage/>
iTernity GmbH
<https://www.linkedin.com/company/iternity-gmbh>
<https://www.xing.com/companies/iternitygmbh>
<https://www.youtube.com/user/iTernityCAS>
<https://iternity.com/know-how/newsletter/> Newsletter
See our <https://iternity.com/privacy/> privacy policy if you want us to delete your personal data.
iTernity GmbH. Managing Directors: Armin Weißer, Ralf Steinemann.
Registered at the District Court Freiburg: HRB-Nr. 701332.
USt.Id DE242664311. [v01.023]
From: Frank Filz < <mailto:ffilzlnx@mindspring.com> ffilzlnx(a)mindspring.com>
Sent: 01 April 2025 02:29 AM
To: <mailto:devel@lists.nfs-ganesha.org> devel(a)lists.nfs-ganesha.org
Cc: <mailto:support@lists.nfs-ganesha.org> support(a)lists.nfs-ganesha.org
Subject: [NFS-Ganesha-Devel] Unsupported FSALs
Community,
We have a number of FSALs in Ganesha that have no effective support, I’d like to understand who might still be relying on them and if there is anyone who might step up to support them, or whether we can consider removing some on an expedited timeline (normally we declare a FSAL is deprecated in one release, and then remove it in the next). Note that with the magic of git, deleted FSALs could easily be resurrected (though they might not have been updated to match API changes). The risk of not removing unsupported code is first that folks will use code with little or no support and open github issues that cannot effectively be addressed, and that unsupported code may not be properly updated as API changes are made.
The following FSALs are suspect:
src/FSAL/FSAL_VFS/xfs – this is marginally supported, but could be replaced with plain FSAL_VFS
src/FSAL/FSAL_VFS – there is also a Lustre FSAL that is built from this
src/FSAL/FSAL_GLUSTER
src/FSAL/FSAL_LIZARDFS
src/FSAL/FSAL_PROXY_V3
src/FSAL/FSAL_PROXY_V4
src/FSAL/FSAL_KVSFS
src/FSAL/FSAL_SAUNAFS
Thank for your thoughts
Frank Filz
1 month, 1 week
[S] Change in ...nfs-ganesha[next]: CEPH: Fix crash in ceph_fsal_release
by Sachin Punadikar (GerritHub)
Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1217111?usp=email )
Change subject: CEPH: Fix crash in ceph_fsal_release
......................................................................
CEPH: Fix crash in ceph_fsal_release
In "ceph_fsal_release", check is being done whether the object handle is
export root. To check this op_ctx is required.
In shutdown path, op_ctx is not available and hence the crash. With this
fix, the check will be carried out only when op_ctx is available.
(gdb) bt
0 0x00007fc8db631bd6 in ceph_fsal_release (obj_hdl=0x7fc7dc00ec90) at /usr/src/debug/nfs-ganesha-6.5-18.el9cp.x86_64/src/FSAL/FSAL_CEPH/handle.c:82
1 0x00007fc8de3f4ccf in shutdown_handles (fsal=0x7fc8db63d000 <CephFSM>) at /usr/src/debug/nfs-ganesha-6.5-18.el9cp.x86_64/src/FSAL/fsal_destroyer.c:67
2 destroy_fsals () at /usr/src/debug/nfs-ganesha-6.5-18.el9cp.x86_64/src/FSAL/fsal_destroyer.c:151
3 0x00007fc8de40dd76 in do_shutdown () at /usr/src/debug/nfs-ganesha-6.5-18.el9cp.x86_64/src/MainNFSD/nfs_admin_thread.c:819
4 admin_thread (UnusedArg=<optimized out>) at /usr/src/debug/nfs-ganesha-6.5-18.el9cp.x86_64/src/MainNFSD/nfs_admin_thread.c:843
5 0x00007fc8de21819a in start_thread () from /lib64/libc.so.6
6 0x00007fc8de29d210 in clone3 () from /lib64/libc.so.6
(gdb) f 0
0 0x00007fc8db631bd6 in ceph_fsal_release (obj_hdl=0x7fc7dc00ec90) at /usr/src/debug/nfs-ganesha-6.5-18.el9cp.x86_64/src/FSAL/FSAL_CEPH/handle.c:82
82 container_of(op_ctx->fsal_export, struct ceph_export, export);
(gdb) p op_ctx
$2 = (struct req_op_context *) 0x0
Change-Id: I07d9042b767e46d050d7ac87ae894b58c325b645
Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com>
---
M src/FSAL/FSAL_CEPH/handle.c
1 file changed, 8 insertions(+), 4 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/11/1217111/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1217111?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I07d9042b767e46d050d7ac87ae894b58c325b645
Gerrit-Change-Number: 1217111
Gerrit-PatchSet: 1
Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>
1 month, 2 weeks
