April 2026 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: RECOVERY: Do not call grace during shutdown
by Sachin Punadikar (GerritHub) 22 Apr '26

22 Apr '26

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236112?usp=email ) Change subject: RECOVERY: Do not call grace during shutdown ...................................................................... RECOVERY: Do not call grace during shutdown Call to "rados_grace_join" during shutdown in function "rados_cluster_shutdown" leads to increamenting current epoch. When the same Ganesha instance (identified with nodeid) gets started (either on same node or somewhere else), then current epoch is increased again. This double increament in epoch leads to not finding recovery object, at restart of that Ganesha instance. This happens only for graceful shutdown of Ganesha. Change-Id: I8e13b117400913c9be9ed894d14216e4dd7b1cdd Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/SAL/recovery/recovery_rados_cluster.c 1 file changed, 14 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/12/1236112/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236112?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8e13b117400913c9be9ed894d14216e4dd7b1cdd Gerrit-Change-Number: 1236112 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0

[S] Change in ...nfs-ganesha[next]: log: enforce full coverage of log components at compile time
by Lior Suliman (GerritHub) 21 Apr '26

21 Apr '26

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236018?usp=email to review the following change. Change subject: log: enforce full coverage of log components at compile time ...................................................................... log: enforce full coverage of log components at compile time Remove explicit sizing from the LogComponents and default_conditional_log_levels arrays, allowing the compiler to determine their size from the initializer lists. To maintain safety, this patch introduces a CT_ASSERT macro and adds compile-time checks to verify that both arrays contain exactly COMPONENT_COUNT elements. This ensures that any future additions to the log components will require corresponding updates to these arrays, preventing silent omissions. Change-Id: I1a36fa7641f18fa859e011cc81396f64b8c17168 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/include/log.h M src/log/log_functions.c 2 files changed, 17 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/18/1236018/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236018?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1a36fa7641f18fa859e011cc81396f64b8c17168 Gerrit-Change-Number: 1236018 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[S] Change in ...nfs-ganesha[next]: MDCACHE: Skip stale directory entry
by Peter Schwenke (GerritHub) 21 Apr '26

21 Apr '26

Peter Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236015?usp=email ) Change subject: MDCACHE: Skip stale directory entry ...................................................................... MDCACHE: Skip stale directory entry This fixes a race condition where a directory entry is found but when during the ops->getattrs2 call we find that the file has been deleted. In the VFS case, this is during vfs_getattr2 it fails when it tries to lookup the file. The positioning of the skip needs to be after the callback. attrs hasn't been filled so, in this case, fsal_release_attrs doesn't need to be called. However, a skip might be added for some other reason at a later date. I do not understand the significance of whence_is_name, so that should be looked at during the review. It is important, that we go to check for eod. That is the conditining for exiting the loop and, maybe, this entry had the eod flag. Change-Id: I68a22210f69bf6cf88beb199b23dbb1af021c965 Signed-off-by: Peter Schwenke <pschwenke(a)ddn.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 1 file changed, 14 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/1236015/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236015?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I68a22210f69bf6cf88beb199b23dbb1af021c965 Gerrit-Change-Number: 1236015 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Schwenke <pschwenke(a)ddn.com>

1 0

[M] Change in ...nfs-ganesha[next]: FSAL: Use Filesystem_Id in NFS file handles
by Peter Schwenke (GerritHub) 21 Apr '26

21 Apr '26

Peter Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236014?usp=email ) Change subject: FSAL: Use Filesystem_Id in NFS file handles ...................................................................... FSAL: Use Filesystem_Id in NFS file handles If Filesystem_id is specified in an EXPORT, use it for the filesystem fsid. This allows multiple directories to be exported from the same underlying filesystem. Add config option nfs_param.core_param.fsid_override to enable the above behaviour. I have had this patch for a while. I'll submit it for consideration. Change-Id: I8505600a77e56fd4cb8214b251bad3a782a98695 Signed-off-by: Peter Schwenke <pschwenke(a)ddn.com> --- M src/FSAL/FSAL_VFS/export.c M src/FSAL/FSAL_VFS/handle.c M src/FSAL/fsal_helper.c M src/FSAL/localfs.c M src/config_samples/config.txt M src/doc/man/ganesha-core-config.rst M src/include/FSAL/fsal_localfs.h M src/include/gsh_config.h M src/support/nfs_read_conf.c 9 files changed, 109 insertions(+), 12 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/14/1236014/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1236014?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8505600a77e56fd4cb8214b251bad3a782a98695 Gerrit-Change-Number: 1236014 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Schwenke <pschwenke(a)ddn.com>

1 0

[M] Change in ...nfs-ganesha[next]: idmapper: Implement RFC 5661 compliant numeric ID parsing
by Lior Suliman (GerritHub) 19 Apr '26

19 Apr '26

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235931?usp=email to review the following change. Change subject: idmapper: Implement RFC 5661 compliant numeric ID parsing ...................................................................... idmapper: Implement RFC 5661 compliant numeric ID parsing This patch introduces string_to_numeric_uid_gid to strictly enforce RFC 5661, Section 5.9 requirements for numeric owners and groups. The new helper ensures: No leading zeros (except for the value "0"). No non-numeric characters (e.g., '+' or '-'). Proper 32-bit range validation with error logging. The atless2id and pwentname2id functions were updated to use this safer parsing logic. Additionally, name2id now bypasses cache lookups and defaults to numeric parsing when ID mapping is disabled. Change-Id: I5f8cd6f9d56041931e54e335d0b03283d1015aca Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/idmapper/idmapper.c 1 file changed, 63 insertions(+), 14 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/31/1235931/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235931?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5f8cd6f9d56041931e54e335d0b03283d1015aca Gerrit-Change-Number: 1235931 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[M] Change in ...nfs-ganesha[next]: network: unify ipv4 and ipv6-mapped address handling
by Lior Suliman (GerritHub) 19 Apr '26

19 Apr '26

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235929?usp=email to review the following change. Change subject: network: unify ipv4 and ipv6-mapped address handling ...................................................................... network: unify ipv4 and ipv6-mapped address handling Fix sockaddr comparison and hashing to treat native IPv4 addresses and their IPv6-mapped counterparts as identical logical endpoints. Previously, comparing native IPv4 and IPv6-mapped addresses could yield inconsistent ordering, breaking sorted structures like AVL trees. The comparison logic now normalizes both addresses to a consistent format before evaluation to ensure a strict weak ordering. Additionally, update the hashing function to return identical keys for IPv4 and equivalent mapped IPv6 addresses, preventing duplicate entries in hash-based data structures. Change-Id: I90966c115da059087da5cdeb4ed7b5c1be45dd54 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/include/ip_utils.h M src/support/ip_utils.c 2 files changed, 74 insertions(+), 34 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/29/1235929/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235929?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I90966c115da059087da5cdeb4ed7b5c1be45dd54 Gerrit-Change-Number: 1235929 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

Announce Push of V9.12
by Frank Filz 18 Apr '26

18 Apr '26

Branch next Tag:V9.12 Merge Highlights * Avoid same-client lock-path delegation recall in FSAL_UP (fix recall24) * Add missing log component to default conditinal log levels * Add missing include * Add log rotation functionality to Ganesha. * config_samples/config.txt - fixup formatting * Recovery - Additional logging for better debugging * IBMCEPH-14009: Deleg type 5 support for ALLOCATE op Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 14308c21c Frank S. Filz V9.12 32bcd147f Animesh Javali IBMCEPH-14009: Deleg type 5 support for ALLOCATE op 6d79ab941 Sachin Punadikar Recovery - Additional logging for better debugging c21695720 Frank S. Filz config_samples/config.txt - fixup formatting acbaa7c48 Ofir Vainshtein Add log rotation functionality to Ganesha. 98886cfa3 Lior Suliman Add missing include 85b8a38d9 Lior Suliman Add missing log component to default conditinal log levels c892d0103 Suhas Athani Avoid same-client lock-path delegation recall in FSAL_UP (fix recall24)

1 0

[XS] Change in ...nfs-ganesha[next]: Add missing include
by Lior Suliman (GerritHub) 17 Apr '26

17 Apr '26

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235721?usp=email to review the following change. Change subject: Add missing include ...................................................................... Add missing include Change-Id: Ide54f4008c7676e3267c6e3e40a44a1ab9cf2b11 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/include/sal_functions.h 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/21/1235721/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235721?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ide54f4008c7676e3267c6e3e40a44a1ab9cf2b11 Gerrit-Change-Number: 1235721 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Add missing log component to default conditinal log levels
by Lior Suliman (GerritHub) 17 Apr '26

17 Apr '26

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235720?usp=email to review the following change. Change subject: Add missing log component to default conditinal log levels ...................................................................... Add missing log component to default conditinal log levels This can cause a buffer overflow when setting a level for all logs Change-Id: I709333e5dd6aeaecd6b61560785e48f64290a355 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/log/log_functions.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/20/1235720/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235720?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I709333e5dd6aeaecd6b61560785e48f64290a355 Gerrit-Change-Number: 1235720 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[M] Change in ...nfs-ganesha[next]: Better document use of add_client and use correct field for HAProxy_H...
by Frank Filz (GerritHub) 17 Apr '26

17 Apr '26

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235463?usp=email ) Change subject: Better document use of add_client and use correct field for HAProxy_Hosts ...................................................................... Better document use of add_client and use correct field for HAProxy_Hosts Change-Id: I71a0860d5c5a0d5dcbfe6811fd0cffb7211071f5 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/support/exports.c M src/support/nfs_read_conf.c 2 files changed, 47 insertions(+), 21 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/63/1235463/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235463?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I71a0860d5c5a0d5dcbfe6811fd0cffb7211071f5 Gerrit-Change-Number: 1235463 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0