[S] Change in ...nfs-ganesha[next]: VFS: Skip dangling directory entries during readdir
by Martin Schwenke (GerritHub)
Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235475?usp=email )
Change subject: VFS: Skip dangling directory entries during readdir
......................................................................
VFS: Skip dangling directory entries during readdir
After deciding this is a sane thing to do, it turns out there is a
similar check in FSAL_GPFS. It is more ambitious, also matching
ERR_FSAL_STALE and ERR_FSAL_XDEV. However, it is hard to see how the
either case applies here, so be conservative.
Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com>
Signed-off-by: Peter Schwenke <pschwenke(a)ddn.com>
Change-Id: I2a8cd0abbb60547eaa71bf4c881a360d1cf11a58
---
M src/FSAL/FSAL_VFS/handle.c
1 file changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/75/1235475/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235475?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I2a8cd0abbb60547eaa71bf4c881a360d1cf11a58
Gerrit-Change-Number: 1235475
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Schwenke <martin(a)meltin.net>
1 month, 2 weeks
[M] Change in ...nfs-ganesha[next]: Avoid same-client lock-path delegation recall in FSAL_UP (fix recall24)
by Suhas Athani (GerritHub)
Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235527?usp=email )
Change subject: Avoid same-client lock-path delegation recall in FSAL_UP (fix recall24)
......................................................................
Avoid same-client lock-path delegation recall in FSAL_UP (fix recall24)
This change fixes recall24 by preventing spurious NFS delegation recall
when a backend upcall arrives during same-client lock/open-mode
transitions.
With Ceph delegation callbacks, lock-driven reopen activity could trigger
up_async_delegrecall, leading to delegrecall_one/CB_RECALL even when all
active locks belong to the same client that owns the delegation.
Fix:
Added a guard in FSAL_UP (delegrecall_impl_per_state) to skip recall when:
- the file has active locks, and
- all active NFSv4 lock owners map to the same clientid as the delegation
owner.
In that case, delegation state is restored to DELEG_GRANTED and CB_RECALL
is not issued.
This test case is from nfstest delegation suite -
https://github.com/kofemann/nfstest/blob/master/test/nfstest_delegation
Change-Id: I9760d5db1d7cc433501df77abb9048ab8e1b4d97
Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com>
---
M src/FSAL/FSAL_CEPH/handle.c
M src/FSAL_UP/fsal_up_top.c
2 files changed, 77 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/27/1235527/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235527?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I9760d5db1d7cc433501df77abb9048ab8e1b4d97
Gerrit-Change-Number: 1235527
Gerrit-PatchSet: 1
Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>
1 month, 2 weeks
[XS] Change in ...nfs-ganesha[next]: Fix: IBMCEPH-14009
by Animesh Javali (GerritHub)
Animesh Javali has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235802?usp=email )
Change subject: Fix: IBMCEPH-14009
......................................................................
Fix: IBMCEPH-14009
With NFSv4.2, when the server grants
"OPEN_DELEGATE_WRITE_ATTRS_DELEG", workloads that trigger
"ALLOCATE" via nfs4_op_allocate hit stateid validation
failures in the server.
On the client side, this leads to repeated attempts to
"TEST_STATEID" via nfs4_op_test_stateid operations,
causing the I/O to stall.
Added code to include OPEN_DELEGATE_WRITE_ATTRS_DELEG
along with regular write delegation.
Change-Id: Ibde44b8e99fc4b9557d21470452c0a05ef333097
Signed-off-by: Animesh Javali <Animesh.Javali(a)ibm.com>
---
M src/Protocols/NFS/nfs4_op_allocate.c
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/1235802/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235802?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ibde44b8e99fc4b9557d21470452c0a05ef333097
Gerrit-Change-Number: 1235802
Gerrit-PatchSet: 1
Gerrit-Owner: Animesh Javali <Animesh.Javali(a)ibm.com>
1 month, 2 weeks
[S] Change in ...nfs-ganesha[next]: SAL: Add "none" recovery backend
by Lior Suliman (GerritHub)
Attention is currently required from: Frank Filz.
Hello Frank Filz,
I'd like you to do a code review.
Please visit
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235789?usp=email
to review the following change.
Change subject: SAL: Add "none" recovery backend
......................................................................
SAL: Add "none" recovery backend
This commit adds a new recovery backend option called "none".
When selected, it uses the default (empty) recovery backend,
effectively disabling recovery persistence. This is useful for
environments where recovery is handled externally or not required.
Change-Id: Ia0038928bc5472e7abbd8b4b89a523a07de8274a
Signed-off-by: Lior Suliman <liorsu(a)gmail.com>
---
M src/SAL/nfs4_recovery.c
M src/include/gsh_recovery.h
M src/support/nfs_read_conf.c
3 files changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/89/1235789/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235789?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ia0038928bc5472e7abbd8b4b89a523a07de8274a
Gerrit-Change-Number: 1235789
Gerrit-PatchSet: 1
Gerrit-Owner: Lior Suliman <liorsu(a)google.com>
Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com>
Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>
1 month, 2 weeks
Announce Push of V9.11
by Frank Filz
Branch next
Tag:V9.11
Merge Highlights
* Limit logs when releasing expired clients.
* Fix state object deletion during owner purge in NFSv4 lock handling.
* Add LTTng tracepoints for state object reference counting.
* Move STATELOCK acquisition out of state_test and
process_blocked_lock_upcall
* IBMCEPH-13719: release object ref and owner in
queue_deleg_transition_handler
* mdcache: Reduce lock retry latency
* Fixed unable to unmount fs after all exports removed
* Return NFS4ERR_NOTSUPP for GET_DIR_DELEGATION (NFSv4.1 op 46) #1385
* Accept RO as Delegations alias for read-only delegations
* IBMCEPH-13841: Fix nfs4_op_getattr() crash when op_ctx->clientid is NULL
* RADOS_KV: fix segfault when exiting.
* CONFIG - fix for unknown block "rados_urls"
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
065784ed4 Frank S. Filz V9.11
882fd26c2 Marcus Watts CONFIG - fix for unknown block "rados_urls"
05512ce95 Marcus Watts RADOS_KV: fix segfault when exiting.
ee698806e Suhas Athani IBMCEPH-13841: Fix nfs4_op_getattr() crash when
op_ctx->clientid is NULL
715ecea20 Suhas Athani Accept RO as Delegations alias for read-only
delegations
98eb77c4f Suhas Athani Return NFS4ERR_NOTSUPP for GET_DIR_DELEGATION
(NFSv4.1 op 46) #1385
f72f0f99f Yogendra Charya Tangalapally Fixed unable to unmount fs after all
exports removed
abf65b75a Prabhu Murugesan mdcache: Reduce lock retry latency
fb3473ff0 Animesh Javali BMCEPH-13719: release object ref and owner in
queue_deleg_transition_handler
db933c638 Ofir Vainshtein Move STATELOCK acquisition out of state_test and
process_blocked_lock_upcall
9308bfff0 Ofir Vainshtein Add LTTng tracepoints for state object reference
counting.
cc7d6f0db Ofir Vainshtein Fix state object deletion during owner purge in
NFSv4 lock handling.
45714f5c3 Ofir Vainshtein Limit logs when releasing expired clients.
1 month, 3 weeks
[S] Change in ...nfs-ganesha[next]: Fixed unable to unmount fs after all exports removed
by Name of user not set (GerritHub)
Yogendra.Tangalapally(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235302?usp=email )
Change subject: Fixed unable to unmount fs after all exports removed
......................................................................
Fixed unable to unmount fs after all exports removed
Fixed below deadlock scenario:
1. dbus thread -> Acquire rw lock on fs_lock. while it trying to unclaim gpfs file system.
It makes ioctl call to gpfs to stop upcall thread and wait for upcall thread to exit using pthread_join.
2. In upcall thread, gpfs_ganesha(OPENHANDLE_INODE_UPDATE, &callback) returns with THREAD_STOP and
this thread also tries to acquire fs_lock in order get fsal_export reference.
Since it is already acquired by dbus thread which is waiting for upcall thread to exit,
this scenario resulting in deadlock
fsal_export is not required in case of THREAD_STOP, as op_context not required.
So thread can be stopped without acquiring the fs_lock.
Change-Id: I57e02d902cbf703137122fa3653e45731c3e92a8
Signed-off-by: Yogendra Charya Tangalapally <Yogendra.Tangalapally(a)ibm.com>
---
M src/FSAL/FSAL_GPFS/fsal_up.c
1 file changed, 8 insertions(+), 7 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/1235302/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235302?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I57e02d902cbf703137122fa3653e45731c3e92a8
Gerrit-Change-Number: 1235302
Gerrit-PatchSet: 1
Gerrit-Owner: Yogendra.Tangalapally(a)ibm.com
1 month, 3 weeks
[XS] Change in ...nfs-ganesha[next]: IBMCEPH-13841: Fix nfs4_op_getattr() crash when op_ctx->clientid is NULL
by Suhas Athani (GerritHub)
Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235214?usp=email )
Change subject: IBMCEPH-13841: Fix nfs4_op_getattr() crash when op_ctx->clientid is NULL
......................................................................
IBMCEPH-13841:
Fix nfs4_op_getattr() crash when op_ctx->clientid is NULL
Fix a NULL-pointer dereference in nfs4_op_getattr() when
evaluating the WRITE-delegation “different client” check.
op_ctx->clientid can be NULL (e.g., NFSv4.0 compound where
op_ctx->nfs_minorvers == 0), and the prior code dereferenced
*op_ctx->clientid, crashing ganesha under delegation stress
(recall16).
Change-Id: I51703b9ba671e85af7887d13b2130473f73f0314
Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com>
---
M src/Protocols/NFS/nfs4_op_getattr.c
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/14/1235214/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235214?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I51703b9ba671e85af7887d13b2130473f73f0314
Gerrit-Change-Number: 1235214
Gerrit-PatchSet: 1
Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>
1 month, 3 weeks