June 2026 - Devel - Nfs Ganesha List Archives

by Frank Filz

Branch next Tag:V9.16 NOTE: This merge includes and ntirpc pullup - please update your submodule. Merge Highlights * Fix buffer overflow and missing null-termination in name2id * Optimisation to avoid same-client lock-path delegation recall in FSAL_UP * Add xattr support to FSAL-GPFS * Replace assert with a check for empty client record value. * Replace assert with a check for memory availability in readdir. * Fix: Improve type safety and resolve missing header dependency * Fix for NLM CLOSE_WAIT Socket Leak * Enable callback channel setup for RDMA (with ntirpc pullup) Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 6513f2631 Frank S. Filz V9.16 ebab1ec2e Rajesh Prasad Enable callback channel setup for RDMA 4a7cdbb27 Rajesh Prasad Fix for NLM CLOSE_WAIT Socket Leak fbff8385a Sreedhar Agraharam Fix: Improve type safety and resolve missing header dependency 20de4beb3 Ofir Vainshtein Replace assert with a check for memory availability in readdir. 654446681 Ofir Vainshtein Replace assert with a check for empty client record value. a89089c7f marc eshel Add xattr support to FSAL-GPFS 5c0c32e0d Suhas Athani Optimisation to avoid same-client lock-path delegation recall in FSAL_UP 6c076b4ea Lior Suliman Fix buffer overflow and missing null-termination in name2id

1 week, 1 day

1
0
0 / 0

[XL] Change in ...nfs-ganesha[next]: Monitoring: Update in Grafana dashboard JSON usage file

by Name of user not set (GerritHub)

sragraha(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238868?usp=email ) Change subject: Monitoring: Update in Grafana dashboard JSON usage file ...................................................................... Monitoring: Update in Grafana dashboard JSON usage file Change-Id: Ia67e22cf732e07c48718e08cf01809695af27a5e Signed-off-by: Sreedhar Agraharam <sragraha(a)redhat.com> --- M src/config_samples/grafana.dashboard.json 1 file changed, 2,116 insertions(+), 2,522 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/68/1238868/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238868?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia67e22cf732e07c48718e08cf01809695af27a5e Gerrit-Change-Number: 1238868 Gerrit-PatchSet: 1 Gerrit-Owner: sragraha(a)redhat.com

1 week, 2 days

1
0
0 / 0

[L] Change in ...nfs-ganesha[next]: ganeshactl/log: add composite conditional logging management commands

by Nishant Puri (GerritHub)

Nishant Puri has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238847?usp=email ) Change subject: ganeshactl/log: add composite conditional logging management commands ...................................................................... ganeshactl/log: add composite conditional logging management commands Add three new commands to ganesha_mgr for managing conditional logging configuration in a single operation: ganesha_mgr set log conditional_config [OPTIONS] Configure multiple aspects of conditional logging in one call. Supports repeatable --components/--level pairs to set different log levels per component group, --clients (IP/CIDR), --export-ids, and --policy (ANY|ALL|MATCH_ANY|MATCH_ALL). All flags are optional but at least one must be provided. Processing order is fixed regardless of flag order on the command line: component levels, then clients, then exports, then policy. Errors are collected and reported at the end (continue-and-collect semantics). ganesha_mgr show log conditional_config Display the full conditional logging configuration in a single view: client list, export list, match policy, and all component log levels. ganesha_mgr reset log conditional_config [OPTIONS] With no options, atomically resets all conditional logging state to defaults via a new ResetConditionalLogging D-Bus method: client and export lists are cleared, all component log levels are reset to NIV_FULL_DEBUG, and the match policy is reset to MATCH_ANY. With options (--clients, --export-ids, --components, --policy), selectively removes or resets only the specified items using the existing individual D-Bus methods. Add ResetConditionalLogging D-Bus method to log_conditional_interface to support the atomic full-reset path. Add validation to ChangeMatchPolicy: setting MATCH_ALL is rejected when either the client list or the export list is empty, since the AND condition can never be satisfied in that state and conditional logging would silently never fire. The rejection is reported back to the caller via the reply status and logged at EVENT level. All existing commands are preserved unchanged. Fix cond_log_props[] and HANDLE_COND_LOG_PROP to include COMPONENT_QOS, COMPONENT_RECOVERY, and COMPONENT_RDMA, which were missing from the conditional logging property table while present in the normal log component table. Change-Id: Ie8ccda20d85fa58dfe41ab835e8c66579cf71be5 Signed-off-by: Nishant Puri <npuri(a)redhat.com> --- M src/log/log_functions.c M src/scripts/ganeshactl/Ganesha/ganesha_mgr_utils.py M src/scripts/ganeshactl/ganesha_mgr.py 3 files changed, 484 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/47/1238847/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238847?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie8ccda20d85fa58dfe41ab835e8c66579cf71be5 Gerrit-Change-Number: 1238847 Gerrit-PatchSet: 1 Gerrit-Owner: Nishant Puri <npuri(a)redhat.com>

1 week, 3 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Enable callback channel setup for RDMA

by Rajesh Prasad (GerritHub)

Rajesh Prasad has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238808?usp=email ) Change subject: Enable callback channel setup for RDMA ...................................................................... Enable callback channel setup for RDMA Incoporated the review comments of PR - https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222344 Addressed the conditional compilation issues for the RDMA. Tirpc PR - https://github.com/nfs-ganesha/ntirpc/pull/396 Change-Id: Iedb96b960b9bb0050f714637ef6e12ec6f2b965d Signed-off-by: Rajesh Prasad <raprasad(a)redhat.com> --- M src/MainNFSD/nfs_rpc_callback.c 1 file changed, 18 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/08/1238808/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238808?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iedb96b960b9bb0050f714637ef6e12ec6f2b965d Gerrit-Change-Number: 1238808 Gerrit-PatchSet: 1 Gerrit-Owner: Rajesh Prasad <raprasad(a)redhat.com>

1 week, 4 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Fix: Improve type safety and resolve missing header dependency

by Name of user not set (GerritHub)

sragraha(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238798?usp=email ) Change subject: Fix: Improve type safety and resolve missing header dependency ...................................................................... Fix: Improve type safety and resolve missing header dependency Change-Id: I2fb00a675f44a2ef83ebd07ccb8bb5bf4ed87c65 Signed-off-by: Sreedhar Agraharam <sragraha(a)redhat.com> --- M src/include/common_utils.h M src/include/nfsv41.h M src/monitoring/prometheus_exposer.cc 3 files changed, 10 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/98/1238798/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238798?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2fb00a675f44a2ef83ebd07ccb8bb5bf4ed87c65 Gerrit-Change-Number: 1238798 Gerrit-PatchSet: 1 Gerrit-Owner: sragraha(a)redhat.com

1 week, 4 days

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: Add xattr support to FSAL_GPFS

by Name of user not set (GerritHub)

eshel(a)us.ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238795?usp=email ) Change subject: Add xattr support to FSAL_GPFS ...................................................................... Add xattr support to FSAL_GPFS Change-Id: I827e9e4289c15576ff7c823516db311c9ab77a77 Signed-off-by: marc eshel <eshel(a)us.ibm.com> --- M src/FSAL/FSAL_GPFS/fsal_internal.h M src/FSAL/FSAL_GPFS/handle.c M src/FSAL/FSAL_GPFS/main.c 3 files changed, 27 insertions(+), 72 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/1238795/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238795?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I827e9e4289c15576ff7c823516db311c9ab77a77 Gerrit-Change-Number: 1238795 Gerrit-PatchSet: 1 Gerrit-Owner: eshel(a)us.ibm.com

1 week, 4 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: RPC Callback - do not destroy AUTH_NONE

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238793?usp=email ) Change subject: RPC Callback - do not destroy AUTH_NONE ...................................................................... RPC Callback - do not destroy AUTH_NONE authnone_ncreate returns a shared auth. Destroying it results in use after free and negative refcount. Change-Id: If5dacc42ed8e8663adf9312f014a586e7a6476fd Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/MainNFSD/nfs_rpc_callback.c M src/include/nfs_proto_data.h 2 files changed, 11 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/93/1238793/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238793?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If5dacc42ed8e8663adf9312f014a586e7a6476fd Gerrit-Change-Number: 1238793 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 week, 4 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Fix for NLM CLOSE_WAIT Socket Leak & negative AUTH refcount in NSM op...

by Rajesh Prasad (GerritHub)

Rajesh Prasad has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238734?usp=email ) Change subject: Fix for NLM CLOSE_WAIT Socket Leak & negative AUTH refcount in NSM operations ...................................................................... Fix for NLM CLOSE_WAIT Socket Leak & negative AUTH refcount in NSM operations NLM CLOSE_WAIT Issue - Fix in nlm_owner.c file When using NFSv3 with NLM (Network Lock Manager), TCP callback connections from NFS Ganesha to clients get stuck in CLOSE_WAIT state and are never properly closed. This leads to socket exhaustion over time. netstat command shows multiple CLOSE_WAIT connections The remote peer (NLM client) sent FIN to close the connection. NFS Ganesha received the FIN and ACKed it but Ganesha never close socket FD. The socket remains in CLOSE_WAIT indefinitely until Ganesha restart. Negative AUTH refcount Issue - Fix in nsm.c file This change fixes a critical bug where AUTH_DESTROY() causes negative reference counts (ah_refcnt) when called on authnone auth structures. ROOT CAUSE: 1. authnone_ncreate() returns a shared singleton but does NOT initialize ah_refcnt (it remains 0 from static storage initialization) 2. AUTH_DESTROY() calls auth_put() which decrements: 0 - 1 = -1 3. Multiple AUTH_DESTROY() calls lead to: -1, -2, -3, ..., -120, .. The fix removes all AUTH_DESTROY() calls for nsm_auth since it's a shared singleton that should persist for the process lifetime. Change-Id: I45ec10b59e0728bdc387eff555121d208600c885 Signed-off-by: Rajesh Prasad <raprasad(a)redhat.com> --- M src/Protocols/NLM/nsm.c M src/SAL/nlm_owner.c 2 files changed, 17 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/1238734/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238734?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I45ec10b59e0728bdc387eff555121d208600c885 Gerrit-Change-Number: 1238734 Gerrit-PatchSet: 1 Gerrit-Owner: Rajesh Prasad <raprasad(a)redhat.com>

1 week, 4 days

1
0
0 / 0

Announce Push of V9.15

by Frank Filz

Branch next Tag:V9.15 NOTE: This merge includes and ntirpc pullup - please update your submodule. NOTE: This is a huge merge, instead of the usual detailed list of highlights, a much abbreviated set is given. Merge Highlights * ntirpc pullup * foundation patches for upcomming integrated NSM patch set * added Cluster_Members config (other features may use this also) * some refinement of rpc_tools and ip_uitls, reduce number of includes of gsh_rpc.h * numerous bug fixes including: * several refcount leaks and use after free * Fix TOCTOU races in NFSv4 OPEN, OPEN_DOWNGRADE, CLOSE, LOCK and LOCKU operations. * NFSv4: fix OPEN_DOWNGRADE validation for BOTH after separate opens * Added bounds checks * NFSv4: fix OPEN_DOWNGRADE validation for BOTH after separate opens * Validate CLAIM_DELEGATE* stateids in open4_claim_deleg() * Added new metrics support QOS feature * main: Add progress logging for initialization steps Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: adb062bb3 Frank S. Filz V9.15 90ba38388 Sreedhar Agraharam Added new metrics support QOS feature baa956ab2 Nishant Puri SAL: recover gracefully from zombie lock-owner so_related_owner mismatch 3735f868a Christoph Martin Fix python install problem, see https://github.com/nfs-ganesha/nfs-ganesha/pull/1393 77d965248 Jagnya Tripathy NFSv4: fix OPEN_DOWNGRADE validation for BOTH after separate opens 2dbfd4f4c Lior Suliman main: Add progress logging for initialization steps 4357cecdd Shahar Hochma Fix dir chunk ref count leak 5a38655d3 Yoni Couriel nfs4_owner: Fixed refcount leak. a42eeefa9 Yoni Couriel state_lock: Fixed refcount leak. fda79a3de Ofir Vainshtein Refactor: Add bounds-checked fattr comparison in nfs4_Fattr_cmp a7fdf6962 Ofir Vainshtein Fix: Prevent releasing uninitialized op_context in LAYOUTRETURN 9f74a3483 Ofir Vainshtein Add bounds check for NFSv4 attribute index. 75b713eb1 Matt Benjamin FSAL_RGW: fix a buffer overrun in module options parsing 1a6dd2640 Suhas Athani Validate CLAIM_DELEGATE* stateids in open4_claim_deleg() 63a0710e5 Inna Batenkov Fix TOCTOU races in NFSv4 OPEN, OPEN_DOWNGRADE, CLOSE, LOCK and LOCKU operations. 6bd2cb238 Inna Batenkov Remove call to mdcache_get_parent when the parent object cache is disabled. 20a130ba5 Inna Batenkov Conditionally retrieve ACLs in access check 7f7431886 Sachin Punadikar GPFS: Fix pynfs failure for RDLK1 58563fbb1 Oscar Ou Fix use-after-free in rados_kv_connect error paths a3c0e4d0d Frank S. Filz ntirpc pullup c772f5ade Frank S. Filz Client list normalization - all have str d83d30c06 Frank S. Filz NLM: Add config to not unmonitor on clean shutdown 8283bcd1f Frank S. Filz Add cluster_members config parameter 062d50f5d Frank S. Filz Better document use of add_client and use correct field for HAProxy_Hosts 64a037423 Frank S. Filz Explicitly include uid2grp.h ca0b05aaa Frank S. Filz Trim gsh_rpc.h from many places, also a few other redundant includes 2d67c3428 Frank S. Filz ip_utils: add is_af_local and is_inaddrany 957ea36a3 Frank S. Filz Move a few more bits from gsh_rpc.h to ip_utils.h dae6359a8 Frank S. Filz rpc_tools: use sockaddr_t instead of netbuf for copy_xprt_addr fae5f8f9d Frank S. Filz Make netconfig available earlier 85c1733fa Frank S. Filz Move definitions of NFS_options and NFS_program to gsh_config.h 1934b060e Frank S. Filz display.h - more documentation in header file 5c44a9ed2 Frank S. Filz enhance display_opaque_value_max with flags and additional set of non-printable dd00d814b Frank S. Filz SAL: move obj_is_junction function to more sensible place 348f17c5b Frank S. Filz Additional Debug 3cefd170e Frank S. Filz Add libganesha_monitoring.so to .gitignore

2 weeks, 1 day

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: Optimisation to avoid same-client lock-path delegation recall in FSAL_UP

by Suhas Athani (GerritHub)

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238566?usp=email ) Change subject: Optimisation to avoid same-client lock-path delegation recall in FSAL_UP ...................................................................... Optimisation to avoid same-client lock-path delegation recall in FSAL_UP This patch is proposed as an optimised solution for patch - https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235527 This change fixes recall24 by preventing spurious NFS delegation recall when a backend upcall arrives during same-client lock/open-mode transitions. With Ceph delegation callbacks, lock-driven reopen activity could trigger up_async_delegrecall, leading to delegrecall_one / CB_RECALL even when all active locks belong to the same client that owns the delegation. Added a guard in FSAL_UP (delegrecall_impl_per_state) to skip recall when all tracked active NFSv4 locks on the file belong to the same clientid as the delegation owner. In that case, delegation state is restored to DELEG_GRANTED and CB_RECALL is not issued. Optimization: - Add lock_clientid_hint on struct state_file, maintained in state_lock.c when locks are added, removed, or wiped. - First lock records that client’s clientid; a lock from a different client sets the hint to UINT64_MAX , clearing the last lock resets the hint to 0. - delegrecall_skip_for_same_client_locks() uses this hint to check instead of iterating file.lock_list. This test case is from nfstest delegation suite - https://github.com/kofemann/nfstest/blob/master/test/nfstest_delegation Change-Id: I1e33457561db047b311d310e5e1238d4d6f69065 Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com> --- M src/FSAL_UP/fsal_up_top.c M src/SAL/state_lock.c M src/include/sal_data.h M src/include/sal_functions.h 4 files changed, 129 insertions(+), 37 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/66/1238566/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238566?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1e33457561db047b311d310e5e1238d4d6f69065 Gerrit-Change-Number: 1238566 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

2 weeks, 2 days

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

Devel June 2026